Aliza reports: can't rename the mob kitten by ... #5837
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
source/testserver
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#5837
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Aliza reports a bug:
Player position:
Player look:
Player information:
Player meta:
Log identifier
Profiler save:
Status:
Teleport command:
Compass command:
tried this, the nametag gets used up but the name you assigned the mob doesn't appear over its head
Apparently that affects ALL mobs and could also explain the missing "Focus" nametag.
I wouldn't be so sure about ALL mobs - Scouts have their nametags on at all times
It seems like mobs_redo renamed the value the nametag is stored in from
nametag
to_nametag
.So everything which spawns mobs with nametags needs to change it. (quite sure this is wrong now.
if I understand this correctly, the first call to update_nametag will overwrite the
newname
in case the mob is "old" and still has theself.nametag
value set. (the whole compat code looks weird)be7b6bc5fe/api.lua (L658)
i wonder if this is related to the smalls that only had 65 max HP... hm.
@AliasAlreadyTaken what commit of mobs_redo are we actually using? i've verified that scouts have a
nametag
attribute and not a_nametag
attribute. foci have neither.actually probably should make a separate issue about the foci/smalls, forgot this was about nametag items
upstream issue https://codeberg.org/tenplus1/mobs_redo/issues/8
actually this appears to have already been fixed upstream
QA
I can't name any mobs_animal via nametag.
Using latest upstream I cannot reproduce the issue.
mobs_redo:
97771f8e65
mobs_animal:
bf12043fdc
We mirrored them and branched them off. Using the branches without the other YL mods, I can name animals. Using the branches WITH the other YL mods, I cannot name animals.
it's an issue with yl_speak_up that wraps
mobs.mob_class.update_tag
without passing the argument properlywith this fix it works
2024-01-29 12:29:18: ACTION[Server]: [yl_commons] formspec "mobs_nametag": Administrator submitted {"mob_rename":"Umbenennen","name":"ASD","quit":"true"}
For some reason, EVERY mob calls update_tag once a second? Why?
Because yl_speak_up overwrites that function in interface_mobs_api.lua, line 137
Sorry for spam, too many branches with inconsistent names 💁
This monkey-patching/wrapping is an antipattern and should be avoided...
97771f8e65/api.lua (L3480)
because environmental damage updates it even when nothing is changed.
this also causes per-second ticking of network packets for every mob...
are you sure it does if the mob doesn't have any nametag? and does it still do that if the nametag doesn't actually change?
I tried commenting both
set_properties
lines out (didn't notice second one at first):So, I'm pretty sure.
Feels like this should be fixed ASAP X)
With this patch tick is gone:
this issue is about naming things with a nametag - we should split the "only set_properties if things change" into a separate issue.
That parameter to update_tag seems new to me. It'll now be passed on to the mobs mod for other mobs than those covered by yl_speak_up.
The reason I had to change this function for the NPC is that all those NPC standing around gave lots of us half of a heart attack :-) It looked like Voice came visiting. There needs to be a visual distinction (=diffrent color tag) between hostile mobs and NPC.
As the NPC are immune to environtment dammage, the current version of them doesn't call the do_env_damage() function from mobs_redo and thus saves a bit of traffic.
QA
With whosit's fix the animals can now be named again. Yay!
QA
Only that the fix never made it into upstream : Sokomine/yl_speak_up#22
This is not solved, only by virtue of quickly editing the file :P
Oh. 😕
nametags work (on kittens specifically)