your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

mobs_redo is generating unnecessary network traffic by by calling object:set_properties without need #6150

New Issue
Closed
opened 2024-01-31 07:56:06 +00:00 by whosit · 8 comments
whosit commented 2024-01-31 07:56:06 +00:00
Member
Copy Link

Here's some previous discussion:
#5837 (comment)

Patch provided there also:
#5837 (comment)

Should I just push this fix to your-land? It should benefit when there are lots of mobs...

Here's some previous discussion: https://gitea.your-land.de/your-land/bugtracker/issues/5837#issuecomment-73115 Patch provided there also: https://gitea.your-land.de/your-land/bugtracker/issues/5837#issuecomment-73120 ~~Should I just push this fix to `your-land`? It should benefit when there are lots of mobs...~~
whosit commented 2024-01-31 08:30:57 +00:00
Author
Member
Copy Link

upstream pr:
https://codeberg.org/tenplus1/mobs_redo/pulls/11

upstream pr: https://codeberg.org/tenplus1/mobs_redo/pulls/11
whosit commented 2024-01-31 11:41:55 +00:00
Author
Member
Copy Link

Fixed upstream here:
70118fc8da

Fixed upstream here: https://codeberg.org/tenplus1/mobs_redo/commit/70118fc8da0ae5029f16af255858426cda730daa
👍 2 🎉 2
whosit added the
1. kind/bug
3. source/mod upstream
4. step/ready to QA test
 labels 2024-01-31 11:43:24 +00:00
Sokomine commented 2024-01-31 18:11:16 +00:00
Member
Copy Link

Great! Thank you for the PR and getting it merged! That'll help in Voice battles as well. It is most likely not the only issue that made such fights more...packeet-intensive in the past, but it will certainly reduce traffic. And that's very good.

Great! Thank you for the PR and getting it merged! That'll help in Voice battles as well. It is most likely not the only issue that made such fights more...packeet-intensive in the past, but it will certainly reduce traffic. And that's very good.
AliasAlreadyTaken added this to the 1.1.123 milestone 2024-01-31 18:12:58 +00:00
AliasAlreadyTaken commented 2024-01-31 18:13:29 +00:00
Owner
Copy Link

The fix is already on the testserver :)

The fix is already on the testserver :)
whosit commented 2024-02-05 15:08:32 +00:00
Author
Member
Copy Link

Checked with wireshark again: don't see mesh and texture names spam anymore... What's left is I assume just set_rotation for "looking around" effect, but those messages are much smaller and can fit 6 into one network packet at least...
(and nametag color change that depends on HP seems to still work too)

Checked with wireshark again: don't see mesh and texture names spam anymore... What's left is I assume just `set_rotation` for "looking around" effect, but those messages are much smaller and can fit 6 into one network packet at least... (and nametag color change that depends on HP seems to still work too)
👍 1
AliasAlreadyTaken commented 2024-02-05 15:15:38 +00:00
Owner
Copy Link

Sounds like QA/OK?

Sounds like QA/OK?
whosit added the
ugh/QA OK
 label 2024-02-05 15:17:46 +00:00
whosit commented 2024-02-05 15:18:40 +00:00
Author
Member
Copy Link

Ok, label added :p

Ok, label added :p
👍 1
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2024-03-28 21:07:43 +00:00
flux commented 2024-03-28 21:07:50 +00:00
Member
Copy Link

assuming this is live

assuming this is live
flux closed this issue 2024-03-28 21:07:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.123
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6150
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?