your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

Service reports: Implement a Formspec which sta ... #5513

New Issue
Open
opened 2023-11-18 16:33:46 +00:00 by yourland-report · 11 comments
yourland-report commented 2023-11-18 16:33:46 +00:00
Member
Copy Link

Service reports a bug:

Implement a Formspec which staff and bailiffs can send to players. Let the command take two paramenters. The first one is the target playername. If the second parameter has no # in it, then send a formspec with a preset question and answers to the user. If it has a # in it, allow creating a new one on the fly

Player position:

{
	x = 2007.6560058594,
	y = 25,
	z = 1294.3950195313
}

Player look:

{
	x = 0.013873598538339,
	y = -0.56063896417618,
	z = -0.82794409990311
}

Player information:

{
	protocol_version = 42,
	lang_code = "de",
	formspec_version = 6,
	ip_version = 6,
	min_rtt = 0.014999999664724,
	avg_rtt = 0.017000000923872,
	minor = 7,
	max_jitter = 0.55400002002716,
	avg_jitter = 0.0019999984651804,
	connection_uptime = 51320,
	serialization_version = 29,
	patch = 0,
	version_string = "5.7.0",
	max_rtt = 0.71899998188019,
	state = "Active",
	min_jitter = 0,
	major = 5
}

Player meta:

{
	fields = {
		["petz:werewolf_vignette_id"] = "19",
		placed_nodes = "23877",
		died = "119",
		crafted = "142",
		hud_state = "on",
		repellant = "0",
		arenalib_infobox_arenaID = "0",
		szutil_watch = "return {}",
		["arena_lib_editor.spawner_ID"] = "0",
		["arena_lib_editor.players_number"] = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		bitten = "0",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "40.5",
		xp = "0",
		punch_count = "2018",
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		["petz:werewolf_clan_idx"] = "2",
		["ocean_build.last_warning"] = "1695708624",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		["petz:lycanthropy"] = "0",
		inflicted_damage = "1070938",
		yl_commons_player_created = "1610342909",
		["signslib:pos"] = "(1954,-22,1298)",
		["stamina:level"] = "0",
		["arena_lib_editor.team_ID"] = "0",
		lagometer = "1",
		["petz:werewolf"] = "0",
		digged_nodes = "21652",
		yl_commons_thankyou = "32",
		["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"sneak_glitch\"] = false, [\"sneak\"] = true, [\"jump\"] = 1, [\"gravity\"] = 1, [\"new_move\"] = true}",
		yl_commons_player_joined = "1700273946",
		ui_waypoints = "{\"data\":[{\"active\":false,\"name\":\"Waypoint 1\",\"world_pos\":{\"x\":2002.0,\"y\":8.0,\"z\":1154.0}}],\"selected\":1.0}",
		yl_audio_state = "off",
		["ethereal:fly_timer"] = "-99",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = -2009, [\"x\"] = -983, [\"y\"] = 19}, [\"last_death_portal\"] = 1672529932, [\"last_heal\"] = 1676219630}",
		played_time = "74928263"
	}
}

Log identifier


[MOD] yl_report log identifier = SWfEcnL2qKQ1R9AOZMZX0LTwqO2I0klY

Profiler save:

profile-20231118T163346.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 5d 6h 35min 24s | max lag: 0.512s | clients (29/52): ahret, AliasAlreadyTaken, Amelie15, America, Bingo, Boot, chaosKing, CloudZ, daydream, DragonWrangler1, flux, formations52, Heron, Kalek, kona, laira, LucyUnicorn_Queen, Noii, pavlo98, Penelopee, pingu_2, Prismatim, rheo, Service, STEALTH, Tom_Bombadil, Transformers, vavo, XeLNaGa

Teleport command:

/teleport xyz 2008 25 1294

Compass command:

/give_compass Construction SWfEcnL2qKQ1R9AOZMZX0LTwqO2I0klY D2691E 2008 25 1294
Service reports a bug: > Implement a Formspec which staff and bailiffs can send to players. Let the command take two paramenters. The first one is the target playername. If the second parameter has no # in it, then send a formspec with a preset question and answers to the user. If it has a # in it, allow creating a new one on the fly Player position: ``` { x = 2007.6560058594, y = 25, z = 1294.3950195313 } ``` Player look: ``` { x = 0.013873598538339, y = -0.56063896417618, z = -0.82794409990311 } ``` Player information: ``` { protocol_version = 42, lang_code = "de", formspec_version = 6, ip_version = 6, min_rtt = 0.014999999664724, avg_rtt = 0.017000000923872, minor = 7, max_jitter = 0.55400002002716, avg_jitter = 0.0019999984651804, connection_uptime = 51320, serialization_version = 29, patch = 0, version_string = "5.7.0", max_rtt = 0.71899998188019, state = "Active", min_jitter = 0, major = 5 } ``` Player meta: ``` { fields = { ["petz:werewolf_vignette_id"] = "19", placed_nodes = "23877", died = "119", crafted = "142", hud_state = "on", repellant = "0", arenalib_infobox_arenaID = "0", szutil_watch = "return {}", ["arena_lib_editor.spawner_ID"] = "0", ["arena_lib_editor.players_number"] = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", bitten = "0", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "40.5", xp = "0", punch_count = "2018", ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", ["petz:werewolf_clan_idx"] = "2", ["ocean_build.last_warning"] = "1695708624", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", ["petz:lycanthropy"] = "0", inflicted_damage = "1070938", yl_commons_player_created = "1610342909", ["signslib:pos"] = "(1954,-22,1298)", ["stamina:level"] = "0", ["arena_lib_editor.team_ID"] = "0", lagometer = "1", ["petz:werewolf"] = "0", digged_nodes = "21652", yl_commons_thankyou = "32", ["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"sneak_glitch\"] = false, [\"sneak\"] = true, [\"jump\"] = 1, [\"gravity\"] = 1, [\"new_move\"] = true}", yl_commons_player_joined = "1700273946", ui_waypoints = "{\"data\":[{\"active\":false,\"name\":\"Waypoint 1\",\"world_pos\":{\"x\":2002.0,\"y\":8.0,\"z\":1154.0}}],\"selected\":1.0}", yl_audio_state = "off", ["ethereal:fly_timer"] = "-99", yl_church = "return {[\"last_death\"] = {[\"z\"] = -2009, [\"x\"] = -983, [\"y\"] = 19}, [\"last_death_portal\"] = 1672529932, [\"last_heal\"] = 1676219630}", played_time = "74928263" } } ``` Log identifier ``` [MOD] yl_report log identifier = SWfEcnL2qKQ1R9AOZMZX0LTwqO2I0klY ``` Profiler save: ``` profile-20231118T163346.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 5d 6h 35min 24s | max lag: 0.512s | clients (29/52): ahret, AliasAlreadyTaken, Amelie15, America, Bingo, Boot, chaosKing, CloudZ, daydream, DragonWrangler1, flux, formations52, Heron, Kalek, kona, laira, LucyUnicorn_Queen, Noii, pavlo98, Penelopee, pingu_2, Prismatim, rheo, Service, STEALTH, Tom_Bombadil, Transformers, vavo, XeLNaGa ``` Teleport command: ``` /teleport xyz 2008 25 1294 ``` Compass command: ``` /give_compass Construction SWfEcnL2qKQ1R9AOZMZX0LTwqO2I0klY D2691E 2008 25 1294 ```
AliasAlreadyTaken was assigned by yourland-report 2023-11-18 16:33:46 +00:00
AliasAlreadyTaken added the
1. kind/enhancement
2. prio/good first issue
 labels 2023-11-18 17:02:57 +00:00
AliasAlreadyTaken commented 2023-11-19 02:22:05 +00:00
Owner
Copy Link

Currently we try to talk to people, whose chat may be off or they otherwise have no means of receiving messages. They simply may be not aware of the chat.

I'd like to send them a formspec, with buttons so they can answer.

Currently we try to talk to people, whose chat may be off or they otherwise have no means of receiving messages. They simply may be not aware of the chat. I'd like to send them a formspec, with buttons so they can answer.
👍 1
tour commented 2024-01-04 00:48:22 +00:00
Copy Link

Since I've the feeling noone really likes formspecs here, I thought this would be suited for me.
(I've done some formspec mods before, but I never finished them :D)

turned out this is way more complex than I thought (or I added too many features)
https://gitea.your-land.de/tour/chat_formspec

I guess bailiffs should make use of it (ct. #3323 (comment) I guess there was even a more precise issue but I can't find it). If even devs struggle with formspecs, how shall bailiffs do? So I added a gui.
Chatcommands are only used to access this gui. So the feature this mod provides is not exactly what was bugged here. If this is a problem, please let me know!
I'm also not 100% sure what preset answers means (or how that should be handled). If it's just about some buttons which trigger an event (chat message which is sent do the one who invoked the fs) it should be doable quite easily. If it's something else: Then I have coded something useless :D

If this mod is more or less the right direction, I'll try to add more features, such as translations. (check out the issues in the mod :D)

Since I've the feeling noone really likes formspecs here, I thought this would be suited for me. (I've done some formspec mods before, but I never finished them :D) turned out this is way more complex than I thought (or I added too many features) https://gitea.your-land.de/tour/chat_formspec I guess bailiffs should make use of it (ct. https://gitea.your-land.de/your-land/bugtracker/issues/3323#issuecomment-36206 I guess there was even a more precise issue but I can't find it). If even devs struggle with formspecs, how shall bailiffs do? So I added a gui. Chatcommands are only used to access this gui. So the feature this mod provides is not exactly what was bugged here. If this is a problem, please let me know! I'm also not 100% sure what preset answers means (or how that should be handled). If it's just about some buttons which trigger an event (chat message which is sent do the one who invoked the fs) it should be doable quite easily. If it's something else: Then I have coded something useless :D If this mod is more or less the right direction, I'll try to add more features, such as translations. (check out the issues in the mod :D)
flux commented 2024-01-04 01:37:59 +00:00
Member
Copy Link

https://gitea.your-land.de/tour/chat_formspec

i'm done for the night. remind me to review this if i forget about it, i'm interested.

> https://gitea.your-land.de/tour/chat_formspec i'm done for the night. remind me to review this if i forget about it, i'm interested.
flux commented 2024-01-05 00:14:25 +00:00
Member
Copy Link

https://gitea.your-land.de/tour/chat_formspec.git

played around with it a bit, this is actually much better than i was imagining! i didn't do a thorough test, but i think it's probably good.

> https://gitea.your-land.de/tour/chat_formspec.git played around with it a bit, this is actually much better than i was imagining! i didn't do a thorough test, but i think it's probably good.
flux commented 2024-01-05 00:15:48 +00:00
Member
Copy Link

perhaps one thing - the message doesn't indicate who sent it. probably it should, so the player can e.g. /msg the sender.

perhaps one thing - the message doesn't indicate who sent it. probably it should, so the player can e.g. /msg the sender.
👍 1
tour commented 2024-02-13 15:17:38 +00:00
Copy Link

After quite some delay I guess I finally understand what Alias meant here tour/chat_formspec#7 and here

allow creating a new one on the fly

Not creating a new formspec but insert a new question and new answer-options into a template

So I threw out hardcoded preset formspecs alltogether and implemented the #-Synax proposed by Alias.
Since this made things much simpler reused 50% of the code and started anew - see https://gitea.your-land.de/tour/chat_formspec-redo for the updated version.

After quite some delay I guess I finally understand what Alias meant here https://gitea.your-land.de/tour/chat_formspec/issues/7 and here > allow creating a new one on the fly Not creating a new formspec but insert a new question and new answer-options into a template So I threw out hardcoded preset formspecs alltogether and implemented the #-Synax proposed by Alias. Since this made things much simpler reused 50% of the code and started anew - see https://gitea.your-land.de/tour/chat_formspec-redo for the updated version.
👀 2
whosit commented 2024-02-13 18:03:02 +00:00
Member
Copy Link

Yes, this is what Alias meant, but with visual editor addition, nice :)

Only some weirdness I feel is happening when I press buttons in the "preview" area.
Otherwise this is cool, and with translations could work nicely...
Even better if predefined response buttons will work with translations too...

Yes, this is what Alias meant, but with visual editor addition, nice :) Only some weirdness I feel is happening when I press buttons in the "preview" area. Otherwise this is cool, and with translations could work nicely... Even better if predefined response buttons will work with translations too...
AliasAlreadyTaken commented 2024-02-14 04:13:12 +00:00
Owner
Copy Link

Just say when ready for QA :)

Just say when ready for QA :)
👍 2
tour commented 2024-02-14 12:53:22 +00:00
Copy Link

Even better if predefined response buttons will work with translations too...

Had to make sure, but that was/is already possible: formspec_escape does not remove translation markers. updated the documentation (57e2520b35)

Otherwise this is cool, and with translations could work nicely...

Added translation for everything the target can see. Note that the sender will now see the preview based on his locale.
Feedback welcome (both the english texts and german translations)
I did not translate the presets since I suspect them to be changed somewhere else.

Only some weirdness I feel is happening when I press buttons in the "preview" area.

Yes, can't avoid that... I use the same code to render the preview and the target fs. IMO there is no need to catch these events, but if ppl see that different I can implement some stuff 🙂

Unless the last point is a blocker: ready for QA

> Even better if predefined response buttons will work with translations too... Had to make sure, but that was/is already possible: `formspec_escape` does not remove translation markers. updated the documentation (https://gitea.your-land.de/tour/chat_formspec-redo/commit/57e2520b35dd81912db9fe71d9a3fbd27847d351) > Otherwise this is cool, and with translations could work nicely... Added translation for everything the target can see. Note that the sender will now see the preview based on his locale. Feedback welcome (both the english texts and german translations) I did not translate the presets since I suspect them to be changed somewhere else. > Only some weirdness I feel is happening when I press buttons in the "preview" area. Yes, can't avoid that... I use the same code to render the preview and the target fs. IMO there is no need to catch these events, but if ppl see that different I can implement some stuff 🙂 Unless the last point is a blocker: ready for QA
flux added the
4. step/ready to QA test
 label 2024-02-14 19:21:06 +00:00
AliasAlreadyTaken added this to the 1.1.123 milestone 2024-02-14 19:57:10 +00:00
AliasAlreadyTaken commented 2024-02-16 08:48:44 +00:00
Owner
Copy Link

Crash: your-land/bugtracker#6300

Crash: your-land/bugtracker#6300
AliasAlreadyTaken added the
ugh/QA NOK
 label 2024-02-16 08:48:52 +00:00
tour commented 2024-02-16 11:05:12 +00:00
Copy Link

crash is (hopefully) fixed...

Only some weirdness I feel is happening when I press buttons in the "preview" area.

Got an idea for this while working on the crash. You can no longer click there. (Note that you can still trigger the weirdness by using tab)

crash is (hopefully) fixed... > Only some weirdness I feel is happening when I press buttons in the "preview" area. Got an idea for this while working on the crash. You can no longer click there. (Note that you can still trigger the weirdness by using tab)
AliasAlreadyTaken modified the milestone from 1.1.123 to 1.1.124 2024-02-23 14:19:28 +00:00
whosit removed the
ugh/QA NOK
 label 2024-02-29 08:46:03 +00:00
AliasAlreadyTaken modified the milestone from 1.1.124 to Next 2024-04-22 12:33:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Next
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5513
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?