your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

use my moreblocks fork #2915

New Issue
Open
opened 2022-10-25 00:57:16 +00:00 by flux · 10 comments
flux commented 2022-10-25 00:57:16 +00:00
Member
Copy Link

because minetest-mods refuses to accept my PR nor discuss what i'd need to do to get it accepted, i've done a hard fork.

https://github.com/fluxionary/minetest-moreblocks

this is an update that will allow for us to hopefully reduce the # of used node IDs immensely.

because minetest-mods refuses to accept my PR nor discuss what i'd need to do to get it accepted, i've done a hard fork. https://github.com/fluxionary/minetest-moreblocks this is an update that will allow for us to hopefully reduce the # of used node IDs immensely.
flux added the
1. kind/enhancement
1. kind/other
4. step/discussion
 labels 2022-10-25 00:57:16 +00:00
flux changed title from use my moreblocks PR in order to gain more confidence in the update to use my moreblocks fork 2023-02-02 03:56:29 +00:00
flux added
4. step/ready to QA test
 and removed
4. step/discussion
 labels 2023-02-02 03:56:53 +00:00
AliasAlreadyTaken commented 2023-02-02 04:00:44 +00:00
Owner
Copy Link

Let's put it on the testserver again. What do we have to do? Simply clone or put some settings?

Let's put it on the testserver again. What do we have to do? Simply clone or put some settings?
flux commented 2023-02-02 18:01:57 +00:00
Author
Member
Copy Link

Let's put it on the testserver again. What do we have to do? Simply clone or put some settings?

probably the most relevant setting is

stairsplus.in_creative_inventory = false

which changed its name slightly.

we may also want to set

stairsplus.crafting_schemata_enabled = false

which will disable all the craft recipes that people find so obnoxious.

> Let's put it on the testserver again. What do we have to do? Simply clone or put some settings? probably the most relevant setting is ``` stairsplus.in_creative_inventory = false ``` which changed its name slightly. we may also want to set ``` stairsplus.crafting_schemata_enabled = false ``` which will disable all the craft recipes that people find so obnoxious.
flux added this to the 1.1.118 milestone 2023-02-20 01:41:29 +00:00
AliasAlreadyTaken modified the milestone from 1.1.118 to 1.1.119 2023-04-14 05:46:17 +00:00
AliasAlreadyTaken modified the milestone from 1.1.119 to 1.1.120 2023-05-09 11:04:27 +00:00
AliasAlreadyTaken commented 2023-05-10 14:25:43 +00:00
Owner
Copy Link

To get this thing on the road:

  • Add modification date to database scheme
  • WE integration and import of old saved stuff (mts and we)

What else?

To get this thing on the road: * [ ] Add modification date to database scheme * [ ] WE integration and import of old saved stuff (mts and we) What else?
flux added this to the flux's TODO list project 2023-05-11 03:39:40 +00:00
flux commented 2023-05-11 04:01:07 +00:00
Author
Member
Copy Link

To get this thing on the road:

  • Add modification date to database scheme
  • WE integration and import of old saved stuff (mts and we)

What else?

making a note to make this a high-priority issue.

i assume the first issue is part of your backup procedure, and not something i can help with directly? and the second is creating an automated translation system for schemas to allow importing things w/ aliased node IDs?

> To get this thing on the road: > > * [ ] Add modification date to database scheme > * [ ] WE integration and import of old saved stuff (mts and we) > > What else? making a note to make this a high-priority issue. i assume the first issue is part of your backup procedure, and not something i can help with directly? and the second is creating an automated translation system for schemas to allow importing things w/ aliased node IDs?
flux added the
2. prio/elevated
 label 2023-05-11 04:01:22 +00:00
flux added
4. step/at work
 and removed
4. step/ready to QA test
 labels 2023-05-15 23:32:59 +00:00
AliasAlreadyTaken commented 2023-05-25 13:21:47 +00:00
Owner
Copy Link

This is now on the testserver

This is now on the testserver
flux commented 2023-07-08 17:05:00 +00:00
Author
Member
Copy Link

whitelist of stairsplus nodes is attached.

whitelist of stairsplus nodes is attached.
stairsplus.whitelist.txt
192 KiB
AliasAlreadyTaken removed this from the 1.1.120 milestone 2023-08-28 10:37:29 +00:00
flux added a new dependency 2023-11-16 21:14:24 +00:00
#1731 JeCel reports: Stairlights are not placeable. ...
flux commented 2024-03-16 04:34:40 +00:00
Author
Member
Copy Link

note: we don't have to have an a priori list list of whitelisted nodes to make this work. we can install it first and create the whitelist at any point after. my fork has a ton of bugfixes that aren't related to reducing the number of extraneous nodes.

note: we don't have to have an a priori list list of whitelisted nodes to make this work. we can install it first and create the whitelist at any point after. my fork has a ton of bugfixes that aren't related to reducing the number of extraneous nodes.
AliasAlreadyTaken commented 2024-03-16 15:48:39 +00:00
Owner
Copy Link

Let's gather what needs to be done to adopt the fork

  • Database needs to have a modification_date: your-land/bugtracker#4526
  • Deal with Worldedit saves, old backups and anything that might break between versions
  • Upgrade all database blocks to latest version, so we can traverse them with a script
  • Split the fork into smaller parts so that upstream has a chance to review them
  • Tell Alias to stop being a coward! :D

Anything else?

And on top of that: Extensive testing

Let's gather what needs to be done to adopt the fork * [ ] Database needs to have a modification_date: your-land/bugtracker#4526 * [ ] Deal with Worldedit saves, old backups and anything that might break between versions * [ ] Upgrade all database blocks to latest version, so we can traverse them with a script * [ ] Split the fork into smaller parts so that upstream has a chance to review them * [ ] Tell Alias to stop being a coward! :D Anything else? And on top of that: Extensive testing
flux commented 2024-03-16 23:09:42 +00:00
Author
Member
Copy Link

Split the fork into smaller parts so that upstream has a chance to review them

that's probably not happening and shouldn't block this issue.

> Split the fork into smaller parts so that upstream has a chance to review them that's probably not happening and shouldn't block this issue.
👍 1
flux commented 2024-03-16 23:16:23 +00:00
Author
Member
Copy Link

Deal with Worldedit saves, old backups and anything that might break between versions

i converted all the worldedit files at some point in the past (maybe 8 months ago?), though there might be new ones. also i'm not sure where i put that.

> Deal with Worldedit saves, old backups and anything that might break between versions i converted all the worldedit files at some point in the past (maybe 8 months ago?), though there might be new ones. also i'm not sure where i put that.
AliasAlreadyTaken added this to the moreblocks milestone 2024-03-17 12:19:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
moreblocks
Projects
Clear projects
No project
flux's TODO list
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#1731 JeCel reports: Stairlights are not placeable. ...
your-land/bugtracker
Reference: your-land/bugtracker#2915
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?