fix duplicating itemframe entities. #6638

Open
opened 2024-04-10 23:11:31 +00:00 by flux · 6 comments
Member

fix a regression of #2235 due to an upstream change. https://codeberg.org/tenplus1/itemframes/pulls/3

see more discussion in #5234

fix a regression of #2235 due to an upstream change. https://codeberg.org/tenplus1/itemframes/pulls/3 see more discussion in #5234
flux added the
1. kind/bug
3. source/mod upstream
2. prio/elevated
4. step/blocked
labels 2024-04-10 23:11:46 +00:00
flux added this to the flux's TODO list project 2024-04-10 23:11:59 +00:00
flux self-assigned this 2024-04-10 23:12:02 +00:00

Upstream pulled your PR. This is bad enough to warrant another hotfix IMO :P

Upstream pulled your PR. This is bad enough to warrant another hotfix IMO :P
flux added
4. step/ready to QA test
and removed
4. step/blocked
labels 2024-04-12 02:12:48 +00:00
Author
Member

upstream should be fixed, though as usual for Tenplus1, my PR was rejected f4d731f0bd

upstream should be fixed, though as usual for Tenplus1, my PR was rejected https://codeberg.org/tenplus1/itemframes/commit/f4d731f0bd2f80525ac2aa257f1006e523803377
Author
Member

This is bad enough to warrant another hotfix

yeah, that's probably warranted.

> This is bad enough to warrant another hotfix yeah, that's probably warranted.
AliasAlreadyTaken added this to the 1.1.124 milestone 2024-04-19 18:58:21 +00:00

Would this be the source of lag in Haven?
The man behind EVIL?

Would this be the source of lag in Haven? The man behind EVIL?
AliasAlreadyTaken added the
ugh/QA OK
label 2024-04-22 11:35:40 +00:00
Author
Member

is this live? when i run the snippet on main, i now see image

is this live? when i run the snippet on main, i now see ![image](/attachments/36f7fcdc-3771-4e09-a62a-d7bf0c2c7ba5)
4.6 KiB

This is live, but a lot of itemframes now show the wrong item, because the function doesn't make sure that the entity content and the blockmeta content matches - it only deletes all entities except the last. This last may or may not be the one with the right entity.

This is live, but a lot of itemframes now show the wrong item, because the function doesn't make sure that the entity content and the blockmeta content matches - it only deletes all entities except the last. This last may or may not be the one with the right entity.
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6638
No description provided.