your-land/bugtracker
your-land/bugtracker
45
22
Issues 2.7k Projects 2 Wiki

fix duplicating itemframe entities. #6638

New Issue
Closed
opened 2024-04-10 23:11:31 +00:00 by flux · 7 comments
flux commented 2024-04-10 23:11:31 +00:00
Member
Copy Link

fix a regression of #2235 due to an upstream change. https://codeberg.org/tenplus1/itemframes/pulls/3

see more discussion in #5234

fix a regression of #2235 due to an upstream change. https://codeberg.org/tenplus1/itemframes/pulls/3 see more discussion in #5234
flux added the
1. kind/bug
3. source/mod upstream
2. prio/elevated
4. step/blocked
 labels 2024-04-10 23:11:46 +00:00
flux added this to the flux's TODO list project 2024-04-10 23:11:59 +00:00
flux self-assigned this 2024-04-10 23:12:02 +00:00
AliasAlreadyTaken commented 2024-04-11 12:20:23 +00:00
Owner
Copy Link

Upstream pulled your PR. This is bad enough to warrant another hotfix IMO :P

Upstream pulled your PR. This is bad enough to warrant another hotfix IMO :P
flux added
4. step/ready to QA test
 and removed
4. step/blocked
 labels 2024-04-12 02:12:48 +00:00
flux commented 2024-04-12 02:13:49 +00:00
Author
Member
Copy Link

upstream should be fixed, though as usual for Tenplus1, my PR was rejected f4d731f0bd

upstream should be fixed, though as usual for Tenplus1, my PR was rejected https://codeberg.org/tenplus1/itemframes/commit/f4d731f0bd2f80525ac2aa257f1006e523803377
flux commented 2024-04-12 02:14:33 +00:00
Author
Member
Copy Link

This is bad enough to warrant another hotfix

yeah, that's probably warranted.

> This is bad enough to warrant another hotfix yeah, that's probably warranted.
AliasAlreadyTaken added this to the 1.1.124 milestone 2024-04-19 18:58:21 +00:00
Jammy commented 2024-04-22 11:28:28 +00:00
Copy Link

Would this be the source of lag in Haven?
The man behind EVIL?

Would this be the source of lag in Haven? The man behind EVIL?
AliasAlreadyTaken added the
ugh/QA OK
 label 2024-04-22 11:35:40 +00:00
flux commented 2024-05-29 19:05:23 +00:00
Author
Member
Copy Link

is this live? when i run the snippet on main, i now see image

is this live? when i run the snippet on main, i now see ![image](/attachments/36f7fcdc-3771-4e09-a62a-d7bf0c2c7ba5)
image.png
4.6 KiB
AliasAlreadyTaken commented 2024-06-02 14:37:13 +00:00
Owner
Copy Link

This is live, but a lot of itemframes now show the wrong item, because the function doesn't make sure that the entity content and the blockmeta content matches - it only deletes all entities except the last. This last may or may not be the one with the right entity.

This is live, but a lot of itemframes now show the wrong item, because the function doesn't make sure that the entity content and the blockmeta content matches - it only deletes all entities except the last. This last may or may not be the one with the right entity.
AliasAlreadyTaken commented 2024-06-30 04:51:07 +00:00
Owner
Copy Link

No more duplicate items, this issue apears solved on main, but now there is #6664 which displays the WRONG item

No more duplicate items, this issue apears solved on main, but now there is #6664 which displays the WRONG item
AliasAlreadyTaken added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2024-06-30 04:51:19 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
source/testserver

Originates on the testserver, no effect on main yet

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
source/testserver
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.124
Projects
Clear projects
No project
flux's TODO list
Assignees
Clear assignees
No Assignees
flux
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6638
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?