your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

Ethereal replaced ethereal:strawberry #6438

New Issue
Open
opened 2024-03-10 19:48:51 +00:00 by AliasAlreadyTaken · 4 comments
AliasAlreadyTaken commented 2024-03-10 19:48:51 +00:00
Owner
Copy Link

Ethereal seems to have removed its strawberries and "replaced" them by farming strawberries (which we then replace by bushes:strawberry):

2024-03-10 19:23:49: ERROR[Main]: ModError: Failed to load and run script from /home/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:
2024-03-10 19:23:49: ERROR[Main]: ...8.0/Minetest_test/bin/../mods/yl_commons/util/groups.lua:6: attempting to override unknown item ethereal:strawberry
2024-03-10 19:23:49: ERROR[Main]: stack traceback:
2024-03-10 19:23:49: ERROR[Main]: 	[C]: in function 'error'
2024-03-10 19:23:49: ERROR[Main]: 	...8.0/Minetest_test/bin/../mods/yl_commons/util/groups.lua:6: in function 'add_groups'
2024-03-10 19:23:49: ERROR[Main]: 	...Minetest_test/bin/../mods/yl_commons/groups/ethereal.lua:17: in main chunk
2024-03-10 19:23:49: ERROR[Main]: 	[C]: in function 'dofile'
2024-03-10 19:23:49: ERROR[Main]: 	...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:234: in function 'dofile'
2024-03-10 19:23:49: ERROR[Main]: 	...8.0/Minetest_test/bin/../mods/yl_commons/groups/init.lua:14: in main chunk
2024-03-10 19:23:49: ERROR[Main]: 	[C]: in function 'dofile'
2024-03-10 19:23:49: ERROR[Main]: 	...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:234: in function 'dofile'
2024-03-10 19:23:49: ERROR[Main]: 	...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:241: in main chunk

"fixed" by

--[[yl_commons.add_groups("ethereal:strawberry", {
    food_strawberry = 1,
    food_berry = 1,
    seed = 1
})]]--

Second error:

2024-03-10 19:32:21: ERROR[Main]: [yl_commons] attempting to log metadata for unknown node "cottages:anvil"
2024-03-10 19:32:21: ERROR[Main]: [yl_commons] attempting to log metadata for unknown node "cottages:quern"
2024-03-10 19:32:23: ERROR[Main]: ModError: Failed to load and run script from /home/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:
2024-03-10 19:32:23: ERROR[Main]: ...t_test/bin/../mods/yl_commons/features/unified_crops.lua:66: unknown item "ethereal:strawberry"
2024-03-10 19:32:23: ERROR[Main]: stack traceback:
2024-03-10 19:32:23: ERROR[Main]: 	[C]: in function 'error'
2024-03-10 19:32:23: ERROR[Main]: 	...t_test/bin/../mods/yl_commons/features/unified_crops.lua:66: in function 'override_target'
2024-03-10 19:32:23: ERROR[Main]: 	...t_test/bin/../mods/yl_commons/features/unified_crops.lua:453: in main chunk
2024-03-10 19:32:23: ERROR[Main]: 	[C]: in function 'dofile'
2024-03-10 19:32:23: ERROR[Main]: 	...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:234: in function 'dofile'
2024-03-10 19:32:23: ERROR[Main]: 	...0/Minetest_test/bin/../mods/yl_commons/features/init.lua:70: in main chunk
2024-03-10 19:32:23: ERROR[Main]: 	[C]: in function 'dofile'
2024-03-10 19:32:23: ERROR[Main]: 	...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:234: in function 'dofile'
2024-03-10 19:32:23: ERROR[Main]: 	...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:242: in main chunk

"fixed" by

if yl_commons.has.ethereal then
    override_target("items", "banana", "ethereal:banana")
    override_target("items", "coconut", "ethereal:coconut")
    override_target("items", "coconut_bits", "ethereal:coconut_slice")

    add_alternate("items", "onion", "ethereal:wild_onion_plant")
    add_alternate("crops", "onion", {pattern = "ethereal:onion_%i", steps = 5})
    add_alternate("wilds", "onion", "ethereal:onion_5")

    --override_target("items", "strawberry", "ethereal:strawberry")
    --override_target("crops", "strawberry", {pattern = "ethereal:strawberry_%i", steps = 8})
    --override_target("wilds", "strawberry", "ethereal:strawberry_8")

    if yl_commons.has.canned_food then
        add_alternate("items", "canned_onion", "canned_food:canned_wild_onion")
        add_alternate("items", "pickled_onion", "canned_food:canned_wild_onion_plus")
    end
end

This replacement and the fixes lead to the strawberry block not craftable

Ethereal seems to have removed its strawberries and "replaced" them by farming strawberries (which we then replace by bushes:strawberry): ``` 2024-03-10 19:23:49: ERROR[Main]: ModError: Failed to load and run script from /home/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua: 2024-03-10 19:23:49: ERROR[Main]: ...8.0/Minetest_test/bin/../mods/yl_commons/util/groups.lua:6: attempting to override unknown item ethereal:strawberry 2024-03-10 19:23:49: ERROR[Main]: stack traceback: 2024-03-10 19:23:49: ERROR[Main]: [C]: in function 'error' 2024-03-10 19:23:49: ERROR[Main]: ...8.0/Minetest_test/bin/../mods/yl_commons/util/groups.lua:6: in function 'add_groups' 2024-03-10 19:23:49: ERROR[Main]: ...Minetest_test/bin/../mods/yl_commons/groups/ethereal.lua:17: in main chunk 2024-03-10 19:23:49: ERROR[Main]: [C]: in function 'dofile' 2024-03-10 19:23:49: ERROR[Main]: ...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:234: in function 'dofile' 2024-03-10 19:23:49: ERROR[Main]: ...8.0/Minetest_test/bin/../mods/yl_commons/groups/init.lua:14: in main chunk 2024-03-10 19:23:49: ERROR[Main]: [C]: in function 'dofile' 2024-03-10 19:23:49: ERROR[Main]: ...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:234: in function 'dofile' 2024-03-10 19:23:49: ERROR[Main]: ...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:241: in main chunk ``` "fixed" by ```lua --[[yl_commons.add_groups("ethereal:strawberry", { food_strawberry = 1, food_berry = 1, seed = 1 })]]-- ``` Second error: ``` 2024-03-10 19:32:21: ERROR[Main]: [yl_commons] attempting to log metadata for unknown node "cottages:anvil" 2024-03-10 19:32:21: ERROR[Main]: [yl_commons] attempting to log metadata for unknown node "cottages:quern" 2024-03-10 19:32:23: ERROR[Main]: ModError: Failed to load and run script from /home/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua: 2024-03-10 19:32:23: ERROR[Main]: ...t_test/bin/../mods/yl_commons/features/unified_crops.lua:66: unknown item "ethereal:strawberry" 2024-03-10 19:32:23: ERROR[Main]: stack traceback: 2024-03-10 19:32:23: ERROR[Main]: [C]: in function 'error' 2024-03-10 19:32:23: ERROR[Main]: ...t_test/bin/../mods/yl_commons/features/unified_crops.lua:66: in function 'override_target' 2024-03-10 19:32:23: ERROR[Main]: ...t_test/bin/../mods/yl_commons/features/unified_crops.lua:453: in main chunk 2024-03-10 19:32:23: ERROR[Main]: [C]: in function 'dofile' 2024-03-10 19:32:23: ERROR[Main]: ...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:234: in function 'dofile' 2024-03-10 19:32:23: ERROR[Main]: ...0/Minetest_test/bin/../mods/yl_commons/features/init.lua:70: in main chunk 2024-03-10 19:32:23: ERROR[Main]: [C]: in function 'dofile' 2024-03-10 19:32:23: ERROR[Main]: ...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:234: in function 'dofile' 2024-03-10 19:32:23: ERROR[Main]: ...e/mt/5.8.0/Minetest_test/bin/../mods/yl_commons/init.lua:242: in main chunk ``` "fixed" by ```lua if yl_commons.has.ethereal then override_target("items", "banana", "ethereal:banana") override_target("items", "coconut", "ethereal:coconut") override_target("items", "coconut_bits", "ethereal:coconut_slice") add_alternate("items", "onion", "ethereal:wild_onion_plant") add_alternate("crops", "onion", {pattern = "ethereal:onion_%i", steps = 5}) add_alternate("wilds", "onion", "ethereal:onion_5") --override_target("items", "strawberry", "ethereal:strawberry") --override_target("crops", "strawberry", {pattern = "ethereal:strawberry_%i", steps = 8}) --override_target("wilds", "strawberry", "ethereal:strawberry_8") if yl_commons.has.canned_food then add_alternate("items", "canned_onion", "canned_food:canned_wild_onion") add_alternate("items", "pickled_onion", "canned_food:canned_wild_onion_plus") end end ``` This replacement and the fixes lead to the strawberry block not craftable
AliasAlreadyTaken added the
1. kind/bug
3. source/integration
 labels 2024-03-10 19:49:03 +00:00
AliasAlreadyTaken added this to the 1.1.123 milestone 2024-03-10 19:49:06 +00:00
AliasAlreadyTaken commented 2024-03-10 20:55:12 +00:00
Author
Owner
Copy Link

This also leads to placed ethereal:strawberry become unknown blocks.

For the update, maybe we should roll back to the previous commit

This also leads to placed ethereal:strawberry become unknown blocks. For the update, maybe we should roll back to the previous commit
AliasAlreadyTaken modified the milestone from 1.1.123 to 1.1.124 2024-03-10 20:55:17 +00:00
AliasAlreadyTaken commented 2024-03-10 23:22:53 +00:00
Author
Owner
Copy Link

I rest ethereal to 1e67afe05e6911bc00150df95874fe69cf4a111b for this upodate, we'll deal with strawberries in the next

I rest ethereal to 1e67afe05e6911bc00150df95874fe69cf4a111b for this upodate, we'll deal with strawberries in the next
👍 1
flux commented 2024-03-11 20:26:12 +00:00
Member
Copy Link

upstream issue: https://codeberg.org/tenplus1/farming/issues/5

upstream issue: https://codeberg.org/tenplus1/farming/issues/5
flux commented 2024-03-11 20:42:11 +00:00
Member
Copy Link

integration fix: 86ec37da01

strawberry block crafting fix: #6438

these fixes should work w/ the current setup, with the currently broken farming redo/ethereal situation, and hopefully in the future when farming redo gets updated to actually create the strawberries.

integration fix: https://gitea.your-land.de/your-land/yl_commons/commit/86ec37da01e248921952734d9e019ef8dfd746d1 strawberry block crafting fix: https://gitea.your-land.de/your-land/bugtracker/issues/6438 these fixes should work w/ the current setup, with the currently broken farming redo/ethereal situation, and hopefully in the future when farming redo gets updated to actually create the strawberries.
AliasAlreadyTaken added the
4. step/ready to QA test
 label 2024-04-19 20:18:12 +00:00
AliasAlreadyTaken added the
ugh/QA OK
 label 2024-04-22 12:24:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.124
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6438
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?