your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

testserver petz/brains/bh_attack.lua:89: attempt to index a nil value #6336

New Issue
Closed
opened 2024-02-23 15:14:06 +00:00 by AliasAlreadyTaken · 13 comments
AliasAlreadyTaken commented 2024-02-23 15:14:06 +00:00
Owner
Copy Link
2024-02-23 15:13:21: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'petz' in callback luaentity_Step(): ...Minetest_test/bin/../mods/petz/petz/brains/bh_attack.lua:89: attempt to index a nil value
2024-02-23 15:13:21: ERROR[Main]: stack traceback:
2024-02-23 15:13:21: ERROR[Main]: 	...Minetest_test/bin/../mods/petz/petz/brains/bh_attack.lua:89: in function 'func'
2024-02-23 15:13:21: ERROR[Main]: 	.../mt/5.8.0/Minetest_test/bin/../mods/petz/kitz/engine.lua:675: in function 'execute_queues'
2024-02-23 15:13:21: ERROR[Main]: 	.../mt/5.8.0/Minetest_test/bin/../mods/petz/kitz/engine.lua:867: in function 'stepfunc'
2024-02-23 15:13:21: ERROR[Main]: 	...st_test/bin/../mods/petz/petz/petz/polar_bear_mobkit.lua:87: in function 'func'
2024-02-23 15:13:21: ERROR[Main]: 	...inetest_test/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:101>
``` 2024-02-23 15:13:21: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'petz' in callback luaentity_Step(): ...Minetest_test/bin/../mods/petz/petz/brains/bh_attack.lua:89: attempt to index a nil value 2024-02-23 15:13:21: ERROR[Main]: stack traceback: 2024-02-23 15:13:21: ERROR[Main]: ...Minetest_test/bin/../mods/petz/petz/brains/bh_attack.lua:89: in function 'func' 2024-02-23 15:13:21: ERROR[Main]: .../mt/5.8.0/Minetest_test/bin/../mods/petz/kitz/engine.lua:675: in function 'execute_queues' 2024-02-23 15:13:21: ERROR[Main]: .../mt/5.8.0/Minetest_test/bin/../mods/petz/kitz/engine.lua:867: in function 'stepfunc' 2024-02-23 15:13:21: ERROR[Main]: ...st_test/bin/../mods/petz/petz/petz/polar_bear_mobkit.lua:87: in function 'func' 2024-02-23 15:13:21: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:101> ```
AliasAlreadyTaken added this to the 1.1.123 milestone 2024-02-23 15:14:06 +00:00
AliasAlreadyTaken added the
1. kind/bug
2. prio/critical
 labels 2024-02-23 15:14:12 +00:00
whosit commented 2024-02-23 15:22:19 +00:00
Member
Copy Link

a658f52fb7/petz/brains/bh_attack.lua (L89)

related (Alias remembered this):
#3601

also, someone got this crash before (on another server):
#6129

https://gitea.your-land.de/your-land/petz/src/commit/a658f52fb7701d7bd8b94621c39a04b08a767b74/petz/brains/bh_attack.lua#L89 related (Alias remembered this): https://gitea.your-land.de/your-land/bugtracker/issues/3601 also, someone got this crash before (on another server): https://gitea.your-land.de/your-land/bugtracker/issues/6129
flux commented 2024-02-24 00:15:09 +00:00
Member
Copy Link

supposedly already fixed, though i don't know how to trigger it so not tested. https://github.com/runsy/petz/issues/208

supposedly already fixed, though i don't know how to trigger it so not tested. https://github.com/runsy/petz/issues/208
whosit commented 2024-02-24 02:52:37 +00:00
Member
Copy Link

supposedly already fixed, though i don't know how to trigger it so not tested. https://github.com/runsy/petz/issues/208

6d45bbbe0f

so, it will still just crash -_-

> supposedly already fixed, though i don't know how to trigger it so not tested. https://github.com/runsy/petz/issues/208 https://github.com/runsy/petz/commit/6d45bbbe0f5f56f304023e06163f992f50d5ab5a so, it will still just crash -_-
flux commented 2024-02-24 02:58:10 +00:00
Member
Copy Link

supposedly already fixed, though i don't know how to trigger it so not tested. https://github.com/runsy/petz/issues/208

6d45bbbe0f

so, it will still just crash -_-

perhaps i need to formally adopt petz

> > supposedly already fixed, though i don't know how to trigger it so not tested. https://github.com/runsy/petz/issues/208 > > https://github.com/runsy/petz/commit/6d45bbbe0f5f56f304023e06163f992f50d5ab5a > > so, it will still just crash -_- perhaps i need to formally adopt petz
😕 1
AliasAlreadyTaken commented 2024-02-25 06:04:59 +00:00
Author
Owner
Copy Link

Upstream issue: https://github.com/runsy/petz/issues/211

Upstream issue: https://github.com/runsy/petz/issues/211
whosit commented 2024-02-26 10:45:41 +00:00
Member
Copy Link

upstream updated:
45a543d062
hope my code is correct XD

upstream updated: https://github.com/runsy/petz/commit/45a543d062198ae36f38917d9c468689fc764d9e hope my code is correct XD
AliasAlreadyTaken commented 2024-02-26 11:01:21 +00:00
Author
Owner
Copy Link

Fixed upstream

It somehow relates to roosters fighting, but there is no 100% repro

Fixed upstream It somehow relates to roosters fighting, but there is no 100% repro
AliasAlreadyTaken added the
4. step/ready to QA test
 label 2024-02-26 11:01:28 +00:00
whosit commented 2024-02-26 12:40:41 +00:00
Member
Copy Link

the saga continues here:
https://github.com/runsy/petz/pull/213

the saga continues here: https://github.com/runsy/petz/pull/213
whosit added the
ugh/QA NOK
 label 2024-02-27 15:35:46 +00:00
whosit commented 2024-02-27 19:39:15 +00:00
Member
Copy Link

https://github.com/runsy/petz/pull/213#event-11941507265
PR closed....

still not sure why wolves don't hunt stuff though.

https://github.com/runsy/petz/pull/213#event-11941507265 PR closed.... still not sure why wolves don't hunt stuff though.
whosit removed the
ugh/QA NOK
 label 2024-02-27 19:39:31 +00:00
AliasAlreadyTaken commented 2024-02-29 00:37:48 +00:00
Author
Owner
Copy Link

The latest fix is now on the testserver

The latest fix is now on the testserver
whosit commented 2024-02-29 08:21:25 +00:00
Member
Copy Link

Now they attack me, but do it silently...

Now they attack me, but do it silently...
AliasAlreadyTaken commented 2024-02-29 14:47:46 +00:00
Author
Owner
Copy Link

QA

Neither bears nor wolves make an attack sound when they try to bite me. Not on main, not on test. means, it's not worse.

But they do attack me, that works. Also I couldn't reproduce the crash with the rooster fight - that's one we will have to wait for whether it happens again on main. The fix looks like it's pretty much solved now - at this place.

QA Neither bears nor wolves make an attack sound when they try to bite me. Not on main, not on test. means, it's not worse. But they do attack me, that works. Also I couldn't reproduce the crash with the rooster fight - that's one we will have to wait for whether it happens again on main. The fix looks like it's pretty much solved now - at this place.
AliasAlreadyTaken added the
ugh/QA OK
ugh/QA main
 labels 2024-02-29 14:47:53 +00:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2024-03-28 22:44:46 +00:00
flux commented 2024-03-28 22:45:18 +00:00
Member
Copy Link

live

live
flux closed this issue 2024-03-28 22:45:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.123
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6336
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?