your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

mail_mod/util/normalize.lua:54: attempt to call method 'gmatch' (a nil value) #6198

New Issue
Closed
opened 2024-02-03 18:27:30 +00:00 by AliasAlreadyTaken · 9 comments
AliasAlreadyTaken commented 2024-02-03 18:27:30 +00:00
Owner
Copy Link
2024-02-03 18:26:10: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'yl_report' in callback environment_Step(): ....0/Minetest_test/bin/../mods/mail_mod/util/normalize.lua:54: attempt to call method 'gmatch' (a nil value)
2024-02-03 18:26:10: ERROR[Main]: stack traceback:
2024-02-03 18:26:10: ERROR[Main]: 	....0/Minetest_test/bin/../mods/mail_mod/util/normalize.lua:54: in function 'parse_player_list'
2024-02-03 18:26:10: ERROR[Main]: 	....0/Minetest_test/bin/../mods/mail_mod/util/normalize.lua:39: in function 'normalize_players_and_add_recipients'
2024-02-03 18:26:10: ERROR[Main]: 	...test_test/bin/../mods/yl_commons/chatcommands/ignore.lua:305: in function 'send'
2024-02-03 18:26:10: ERROR[Main]: 	.../5.8.0/Minetest_test/bin/../mods/yl_report/functions.lua:12: in function 'mail_send'
2024-02-03 18:26:10: ERROR[Main]: 	.../5.8.0/Minetest_test/bin/../mods/yl_report/functions.lua:61: in function 'result_of_gitea'
2024-02-03 18:26:10: ERROR[Main]: 	/home/mt/5.8.0/Minetest_test/bin/../mods/yl_report/init.lua:59: in function 'callback'
2024-02-03 18:26:10: ERROR[Main]: 	/home/mt/5.8.0/Minetest_test/bin/../builtin/game/misc.lua:213: in function 'func'
2024-02-03 18:26:10: ERROR[Main]: 	...e/mt/5.8.0/Minetest_test/bin/../builtin/common/after.lua:27: in function <...e/mt/5.8.0/Minetest_test/bin/../builtin/common/after.lua:11>
2024-02-03 18:26:10: ERROR[Main]: 	...t/5.8.0/Minetest_test/bin/../builtin/common/register.lua:26: in function <...t/5.8.0/Minetest_test/bin/../builtin/common/register.lua:12>
``` 2024-02-03 18:26:10: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'yl_report' in callback environment_Step(): ....0/Minetest_test/bin/../mods/mail_mod/util/normalize.lua:54: attempt to call method 'gmatch' (a nil value) 2024-02-03 18:26:10: ERROR[Main]: stack traceback: 2024-02-03 18:26:10: ERROR[Main]: ....0/Minetest_test/bin/../mods/mail_mod/util/normalize.lua:54: in function 'parse_player_list' 2024-02-03 18:26:10: ERROR[Main]: ....0/Minetest_test/bin/../mods/mail_mod/util/normalize.lua:39: in function 'normalize_players_and_add_recipients' 2024-02-03 18:26:10: ERROR[Main]: ...test_test/bin/../mods/yl_commons/chatcommands/ignore.lua:305: in function 'send' 2024-02-03 18:26:10: ERROR[Main]: .../5.8.0/Minetest_test/bin/../mods/yl_report/functions.lua:12: in function 'mail_send' 2024-02-03 18:26:10: ERROR[Main]: .../5.8.0/Minetest_test/bin/../mods/yl_report/functions.lua:61: in function 'result_of_gitea' 2024-02-03 18:26:10: ERROR[Main]: /home/mt/5.8.0/Minetest_test/bin/../mods/yl_report/init.lua:59: in function 'callback' 2024-02-03 18:26:10: ERROR[Main]: /home/mt/5.8.0/Minetest_test/bin/../builtin/game/misc.lua:213: in function 'func' 2024-02-03 18:26:10: ERROR[Main]: ...e/mt/5.8.0/Minetest_test/bin/../builtin/common/after.lua:27: in function <...e/mt/5.8.0/Minetest_test/bin/../builtin/common/after.lua:11> 2024-02-03 18:26:10: ERROR[Main]: ...t/5.8.0/Minetest_test/bin/../builtin/common/register.lua:26: in function <...t/5.8.0/Minetest_test/bin/../builtin/common/register.lua:12> ```
AliasAlreadyTaken added the
1. kind/bug
2. prio/critical
3. source/mod upstream
 labels 2024-02-03 18:27:46 +00:00
flux added
3. source/integration
 and removed
3. source/mod upstream
 labels 2024-02-03 20:08:03 +00:00
flux commented 2024-02-03 20:09:52 +00:00
Member
Copy Link

this is an integration issue, not necessarily a mail_mod issue. they changed part of their internal API and the "ignore" code doesn't account for that.

this is an integration issue, not necessarily a mail_mod issue. they changed part of their internal API and the "ignore" code doesn't account for that.
flux commented 2024-02-03 20:11:27 +00:00
Member
Copy Link

this is the commit that broke us: 570cf788ec

this is the commit that broke us: https://github.com/mt-mods/mail/commit/570cf788ecca9f4174f923b07e46b9bb84c419db
flux commented 2024-02-03 20:17:58 +00:00
Member
Copy Link

i remarked in #5480 that our code was brittle, i guess this demonstrates that. i'm no longer sure what part of the code i need to modify to ensure things are ignored properly.

i remarked in #5480 that our code was brittle, i guess this demonstrates that. i'm no longer sure what part of the code i need to modify to ensure things are ignored properly.
flux commented 2024-02-03 22:18:50 +00:00
Member
Copy Link

i've removed the broken code while i try to figure out how to achieve the same effect again c9c06b3db0

i've removed the broken code while i try to figure out how to achieve the same effect again https://gitea.your-land.de/your-land/yl_commons/commit/c9c06b3db074dd5ad12ff86304f563b53ebbfaed
flux commented 2024-02-03 22:35:01 +00:00
Member
Copy Link

this seems to work: 0e53886a8d

this seems to work: https://gitea.your-land.de/your-land/yl_commons/commit/0e53886a8d68001b0edc8b03022878e2a2f61ee6
👍 1
AliasAlreadyTaken added this to the 1.1.123 milestone 2024-02-04 18:01:50 +00:00
AliasAlreadyTaken commented 2024-02-04 18:06:53 +00:00
Author
Owner
Copy Link

You think it's ready for QA?

You think it's ready for QA?
flux added the
4. step/ready to QA test
 label 2024-02-04 20:11:05 +00:00
flux commented 2024-02-04 20:11:08 +00:00
Member
Copy Link

yes

yes
👍 1
whosit commented 2024-02-05 16:05:56 +00:00
Member
Copy Link

Tried ignoring my one of my alts and sending mails to both, ignore/unignore works as expected.

Tried ignoring my one of my alts and sending mails to both, ignore/unignore works as expected.
👍 1
whosit added the
ugh/QA OK
 label 2024-02-05 16:06:12 +00:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2024-03-28 21:20:28 +00:00
flux commented 2024-03-28 21:20:33 +00:00
Member
Copy Link

live

live
flux closed this issue 2024-03-28 21:20:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.123
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6198
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?