Ravise reports: one can still receive /mail fr ... #5480

New Issue

yourland-report · 2023-11-12T10:47:46Z

yourland-report commented

2023-11-12 10:47:46 +00:00

Ravise reports a bug:

one can still receive /mail from players in /ignore

Player position:

{
	z = 937.05401611328,
	x = 3521.0109863281,
	y = 36.5
}

Player look:

{
	z = -0.85714733600616,
	x = 0.039672888815403,
	y = -0.51354122161865
}

Player information:

{
	serialization_version = 29,
	patch = 0,
	lang_code = "cs",
	max_rtt = 2.7960000038147,
	major = 5,
	version_string = "5.8.0-dev-ddce858c3-dirty",
	state = "Active",
	connection_uptime = 948,
	protocol_version = 42,
	formspec_version = 7,
	ip_version = 6,
	min_rtt = 0.018999999389052,
	avg_rtt = 0.020999999716878,
	min_jitter = 0,
	max_jitter = 2.7279999256134,
	avg_jitter = 0,
	minor = 8
}

Player meta:

{
	fields = {
		["ocean_build.last_warning"] = "1.65212e+09",
		["ocean_build.ocean_built"] = "11",
		yl_commons_player_created = "1612098151",
		yl_commons_player_joined = "1699785121",
		xp = "860365",
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_rainbow 1 16792\", \"3d_armor:leggings_rainbow 1 16792\", \"3d_armor:helmet_rainbow 1 16792\", \"3d_armor:boots_crystal 1 5040\", \"shields:shield_rainbow 1 16792\", \"\"}",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 4322, [\"x\"] = 4968, [\"y\"] = 29}, [\"last_death_portal\"] = 1691936469}",
		["stamina:exhaustion"] = "91.5",
		jointime = "1612098151",
		arenalib_infobox_arenaID = "0",
		played_time = "9150205",
		digged_nodes = "1333080",
		placed_nodes = "269148",
		died = "90",
		crafted = "129455",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["signslib:pos"] = "(10040,17,14308)",
		inflicted_damage = "2377522",
		yl_commons_thankyou = "161",
		partychat = "party",
		repellant = "0",
		hotbar_size = "16",
		["stamina:level"] = "5",
		partynoinvite = "true",
		["stamina:poisoned"] = "no",
		punch_count = "121800",
		bitten = "0",
		hud_state = "off"
	}
}

Log identifier


[MOD] yl_report log identifier = d0ySs8vUOUGUNFT3e4uw30NZ8F7Y7Mln

Profiler save:

profile-20231112T104746.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 7d 20h 55min 9s | max lag: 0.407s | clients (13/52): ait0r7, AliasAlreadyTaken, Aliza, BeXxity, Bingo, bizon, Boot, Dweller, flux, NULLgamer, Ravise, Service, Sugar0

Teleport command:

/teleport xyz 3521 37 937

Compass command:

/give_compass Construction d0ySs8vUOUGUNFT3e4uw30NZ8F7Y7Mln D2691E 3521 37 937

Ravise reports a bug: > one can still receive /mail from players in /ignore Player position: ``` { z = 937.05401611328, x = 3521.0109863281, y = 36.5 } ``` Player look: ``` { z = -0.85714733600616, x = 0.039672888815403, y = -0.51354122161865 } ``` Player information: ``` { serialization_version = 29, patch = 0, lang_code = "cs", max_rtt = 2.7960000038147, major = 5, version_string = "5.8.0-dev-ddce858c3-dirty", state = "Active", connection_uptime = 948, protocol_version = 42, formspec_version = 7, ip_version = 6, min_rtt = 0.018999999389052, avg_rtt = 0.020999999716878, min_jitter = 0, max_jitter = 2.7279999256134, avg_jitter = 0, minor = 8 } ``` Player meta: ``` { fields = { ["ocean_build.last_warning"] = "1.65212e+09", ["ocean_build.ocean_built"] = "11", yl_commons_player_created = "1612098151", yl_commons_player_joined = "1699785121", xp = "860365", ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_rainbow 1 16792\", \"3d_armor:leggings_rainbow 1 16792\", \"3d_armor:helmet_rainbow 1 16792\", \"3d_armor:boots_crystal 1 5040\", \"shields:shield_rainbow 1 16792\", \"\"}", yl_church = "return {[\"last_death\"] = {[\"z\"] = 4322, [\"x\"] = 4968, [\"y\"] = 29}, [\"last_death_portal\"] = 1691936469}", ["stamina:exhaustion"] = "91.5", jointime = "1612098151", arenalib_infobox_arenaID = "0", played_time = "9150205", digged_nodes = "1333080", placed_nodes = "269148", died = "90", crafted = "129455", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["signslib:pos"] = "(10040,17,14308)", inflicted_damage = "2377522", yl_commons_thankyou = "161", partychat = "party", repellant = "0", hotbar_size = "16", ["stamina:level"] = "5", partynoinvite = "true", ["stamina:poisoned"] = "no", punch_count = "121800", bitten = "0", hud_state = "off" } } ``` Log identifier ``` [MOD] yl_report log identifier = d0ySs8vUOUGUNFT3e4uw30NZ8F7Y7Mln ``` Profiler save: ``` profile-20231112T104746.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 7d 20h 55min 9s | max lag: 0.407s | clients (13/52): ait0r7, AliasAlreadyTaken, Aliza, BeXxity, Bingo, bizon, Boot, Dweller, flux, NULLgamer, Ravise, Service, Sugar0 ``` Teleport command: ``` /teleport xyz 3521 37 937 ``` Compass command: ``` /give_compass Construction d0ySs8vUOUGUNFT3e4uw30NZ8F7Y7Mln D2691E 3521 37 937 ```

AliasAlreadyTaken was assigned by yourland-report

2023-11-12 10:47:46 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2023-11-12 13:37:05 +00:00

flux referenced this issue from a commit

2023-11-13 00:02:27 +00:00

your-land/bugtracker#5480 also ignore email

flux added the

3. source/integration

4. step/ready to QA test

labels 2023-11-13 00:02:53 +00:00

flux commented

2023-11-13 00:03:38 +00:00

implemented 33d3dfe175

note that the sender can tell that their message was ignored because the recipient's name will be removed in the copy of the message in their outbox.

implemented https://gitea.your-land.de/your-land/yl_commons/commit/33d3dfe17532f2cc810a61d03c0482ed0af6d85d note that the sender can tell that their message was ignored because the recipient's name will be removed in the copy of the message in their outbox.

AliasAlreadyTaken added this to the 1.1.122 milestone 2023-11-13 00:54:03 +00:00

AliasAlreadyTaken commented

2023-11-30 13:39:57 +00:00

QA

note that the sender can tell that their message was ignored because the recipient's name will be removed in the copy of the message in their outbox.

This may be used to determine whether someone ignores me or not. Any way we can prevent that?

QA > note that the sender can tell that their message was ignored because the recipient's name will be removed in the copy of the message in their outbox. This may be used to determine whether someone ignores me or not. Any way we can prevent that?

DragonWrangler commented

2023-11-30 14:27:25 +00:00

AliasAlreadyTaken: wouldn't it be better for someone to know they have been ignored and stop trying to contact the person that ignored them, rather than wonder if they are ignored and keep trying to contact the person ?

AliasAlreadyTaken commented

2023-11-30 16:04:50 +00:00

AliasAlreadyTaken: wouldn't it be better for someone to know they have been ignored and stop trying to contact the person that ignored them, rather than wonder if they are ignored and keep trying to contact the person ?

No. If one person ignores another, then there must be no way to tell that they were ignored and no way for them to contact their target. Ignoring someone is not something you do out of spite or because a person made a joke you didn't like. Ignoring is ultima ratio when you do not want anything to do with someone and all other ways of resolving have failed.

They should have no way to tell - else they could simply make themselves a new account to go around the ignore and pester their target again. Imagine someone feels really uncomfortable with someone else, but it's not enough to report them.

> AliasAlreadyTaken: wouldn't it be better for someone to know they have been ignored and stop trying to contact the person that ignored them, rather than wonder if they are ignored and keep trying to contact the person ? No. If one person ignores another, then there must be no way to tell that they were ignored and no way for them to contact their target. Ignoring someone is not something you do out of spite or because a person made a joke you didn't like. Ignoring is ultima ratio when you do not want anything to do with someone and all other ways of resolving have failed. They should have no way to tell - else they could simply make themselves a new account to go around the ignore and pester their target again. Imagine someone feels really uncomfortable with someone else, but it's not enough to report them.

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-11-30 19:28:56 +00:00

flux referenced this issue from a commit

2023-12-01 17:46:48 +00:00

your-land/bugtracker#5480 ensure that mail sender can't detect that message was ignored

flux commented

2023-12-01 17:49:16 +00:00

They should have no way to tell - else they could simply make themselves a new account to go around the ignore and pester their target again. Imagine someone feels really uncomfortable with someone else, but it's not enough to report them.

i've re-implemented this so that the sender cannot tell that the other party didn't receive the message: 4d6bf79ced

note that this is very brittle, as it has to copy a large chunk of code from the mail mod, and the internals of that mod seem to change regularly...

> They should have no way to tell - else they could simply make themselves a new account to go around the ignore and pester their target again. Imagine someone feels really uncomfortable with someone else, but it's not enough to report them. i've re-implemented this so that the sender cannot tell that the other party didn't receive the message: https://gitea.your-land.de/your-land/yl_commons/commit/4d6bf79ced3977fb383184a2517be3eb5bc5be04 note that this is very brittle, as it has to copy a large chunk of code from the mail mod, and the internals of that mod seem to change regularly...

AliasAlreadyTaken commented

2023-12-04 23:31:54 +00:00

Should we probably ask upstream to expose a way to intercept mails? Should be the same place like #5162

QA

feature works (and doesn't appear to be brittle)

Should we probably ask upstream to expose a way to intercept mails? Should be the same place like #5162 QA feature works (and doesn't appear to be brittle)

AliasAlreadyTaken added

ugh/QA OK

and removed

ugh/QA NOK

labels 2023-12-04 23:32:06 +00:00

flux commented

2023-12-05 05:59:17 +00:00

Should we probably ask upstream to expose a way to intercept mails?

i don't want to propose a solution to this, or other mail mod issues, because i feel like the current architecture of the mail mod is infeasible. and, i don't want to commit my time to fixing it. i don't even want to commit my time to teaching the current maintainers how to fix it, but perhaps i should at least open an issue w/ suggestions....

basically, i think the mail mod maintainers need to study the development of email

> Should we probably ask upstream to expose a way to intercept mails? i don't want to propose a solution to this, or other mail mod issues, because i feel like the current architecture of the mail mod is infeasible. and, i don't want to commit my time to fixing it. i don't even want to commit my time to teaching the current maintainers how to fix it, but perhaps i should at least open an issue w/ suggestions.... basically, i think the mail mod maintainers need to study the development of email

AliasAlreadyTaken referenced this issue

2023-12-05 17:26:28 +00:00

allow blocking in-game mail from players #2084

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-12-18 02:09:56 +00:00

flux commented

2023-12-18 02:10:13 +00:00

this is live

flux closed this issue