your-land/bugtracker
your-land/bugtracker
40
21
Issues 3.6k Projects 4 Wiki

chest duplication glitch #5085

New Issue
Closed
opened 2023-08-09 05:58:50 +02:00 by copper248 · 16 comments
copper248 commented 2023-08-09 05:58:50 +02:00
Copy Link

This chest duplication glitch works by attempting to destroy a open chest. This has parallels to #5068, the open chest instead of being moved is blown up and when it is closed a blank (no slot chest) appears and a chest is thrown to the floor by the explosion. The blank chest can then be mined for a second chest

This chest duplication glitch works by attempting to destroy a open chest. This has parallels to [#5068](https://gitea.your-land.de/your-land/bugtracker/issues/5068), the open chest instead of being moved is blown up and when it is closed a blank (no slot chest) appears and a chest is thrown to the floor by the explosion. The blank chest can then be mined for a second chest
flux added the
1. kind/bug
 label 2023-08-09 20:47:44 +02:00
flux commented 2023-08-09 20:49:39 +02:00
Member
Copy Link

ugh.

ugh.
copper248 commented 2023-08-09 22:56:59 +02:00
Author
Copy Link

It is another open chest problem, lets just get rid of them

It is another open chest problem, lets just get rid of them
👍 1
tour commented 2023-08-10 19:22:27 +02:00
Member
Copy Link

Chest duplication works with all chests registerd by default.chest.register_chest. So mesechests should be affected too.

I was curious how chests and their fs are handled...
(50% of the code are needed to open/close chests :P)

They store a table with all open chests. Everytime a player submits a fs they look in this table if the player has an open chest which can be closed. They forgot to check whether there is still a chest at this position... (not to mention that this will delete any other node which might result again in chests with wrong meta)
960aff2f63/mods/default/chests.lua (L46)

NOTE: I somehow rememberd #1979
petz does NOT use the default chest registration but instead copy/pasted it, made some minor changes and copied the bug too. It would need the same fix here...
5df53174ae/petz/misc/chests.lua (L40)

Chest duplication works with all chests registerd by `default.chest.register_chest`. So mesechests should be affected too. I was curious how chests and their fs are handled... (50% of the code are needed to open/close chests :P) They store a table with all open chests. Everytime a player submits a fs they look in this table if the player has an open chest which can be closed. They forgot to check whether there is still a chest at this position... (not to mention that this will delete any other node which might result again in chests with wrong meta) https://github.com/minetest/minetest_game/blob/960aff2f6366c2de864bdd9d4fd4f5eafa956bf3/mods/default/chests.lua#L46 NOTE: I somehow rememberd #1979 petz does NOT use the default chest registration but instead copy/pasted it, made some minor changes and copied the bug too. It would need the same fix here... https://github.com/runsy/petz/blob/5df53174ae9a35f5a945dc88c5dc85b421e428ce/petz/misc/chests.lua#L40
flux commented 2023-08-10 22:13:35 +02:00
Member
Copy Link

i got rid of open chests 34fe76ee92

i guess i need to fix petz too though, i forgot about that.

i got rid of open chests https://gitea.your-land.de/your-land/yl_commons/commit/34fe76ee925571df70424b7813291957aee0ebd5 i guess i need to fix petz too though, i forgot about that.
flux commented 2023-08-10 22:15:23 +02:00
Member
Copy Link

fixed the petz chest as well (i think) c0f98b5cca

fixed the petz chest as well (i think) https://gitea.your-land.de/your-land/yl_commons/commit/c0f98b5ccad60036585d7cfc70143047ebd58e05
flux added the
4. step/ready to QA test
 label 2023-08-10 22:15:53 +02:00
AliasAlreadyTaken added this to the 1.1.120 milestone 2023-08-11 00:17:50 +02:00
AliasAlreadyTaken commented 2023-08-11 00:18:31 +02:00
Owner
Copy Link

I liked the "open chest" thingy, but if it gives us only headaches, there's no point keeping it.

I liked the "open chest" thingy, but if it gives us only headaches, there's no point keeping it.
flux commented 2023-08-11 00:28:22 +02:00
Member
Copy Link

i suppose another option instead of getting rid of the open chests would be to make the "close" action verify that there's actually still an open chest in that location before swapping out the node.

i suppose another option instead of getting rid of the open chests would be to make the "close" action verify that there's actually still an open chest in that location before swapping out the node.
flux commented 2023-08-11 01:54:03 +02:00
Member
Copy Link

i suppose if i add a check to the close lid code, i could possibly even get this updated upstream. i'll try that. in the meantime, chests won't open.

i suppose if i add a check to the close lid code, i could possibly even get this updated upstream. i'll try that. in the meantime, chests won't open.
flux commented 2023-08-11 02:30:31 +02:00
Member
Copy Link

mtg PR: https://github.com/minetest/minetest_game/pull/3046

mtg PR: https://github.com/minetest/minetest_game/pull/3046
flux added the
4. step/blocked
3. source/mod upstream
 labels 2023-08-11 02:30:49 +02:00
flux removed the
4. step/blocked
 label 2023-08-11 21:51:21 +02:00
flux commented 2023-08-11 21:52:00 +02:00
Member
Copy Link

mtg PR got merged

mtg PR got merged
flux commented 2023-08-11 21:54:46 +02:00
Member
Copy Link

i've removed the code to get rid of the open chests: 50ccd70c66

i guess i still need to PR petz to prevent problems there.

i've removed the code to get rid of the open chests: https://gitea.your-land.de/your-land/yl_commons/commit/50ccd70c6656499e69376f203bdbadf03c32ea19 i guess i still need to PR petz to prevent problems there.
flux commented 2023-08-11 22:03:40 +02:00
Member
Copy Link

petz PR https://github.com/runsy/petz/pull/192

petz PR https://github.com/runsy/petz/pull/192
flux commented 2023-08-15 00:08:28 +02:00
Member
Copy Link

petz PR was merged

petz PR was merged
AliasAlreadyTaken commented 2023-09-04 18:38:00 +02:00
Owner
Copy Link

This is blocked until the new MTG is delivered, right? We usually only update MTG with a new MT version, next would be 5.8.0, which is due sometime soonish.

Also, what business has petz to change chests??

This is blocked until the new MTG is delivered, right? We usually only update MTG with a new MT version, next would be 5.8.0, which is due sometime soonish. Also, what business has petz to change chests??
AliasAlreadyTaken added the
4. step/QA OK
 label 2023-09-21 05:42:43 +02:00
AliasAlreadyTaken commented 2023-09-21 05:45:06 +02:00
Owner
Copy Link

QA

I cannot reproduce the issue with the fixese, even without latest MTG

QA I cannot reproduce the issue with the fixese, even without latest MTG
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-11-17 01:12:30 +01:00
flux commented 2023-11-17 01:12:53 +01:00
Member
Copy Link

this is live

this is live
flux closed this issue 2023-11-17 01:12:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
Milestone
Clear milestone
No items
No Milestone
1.1.120
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5085
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?