your-land/bugtracker
your-land/bugtracker
40
21
Issues 3.6k Projects 4 Wiki

rheo reports: default chest duplication glit ... #5068

New Issue
Closed
opened 2023-08-07 02:29:17 +02:00 by yourland-report · 12 comments
yourland-report commented 2023-08-07 02:29:17 +02:00
Member
Copy Link

rheo reports a bug:

default chest duplication glitch via sticky piston

Player position:

{
	z = 19934.03125,
	x = 19996.345703125,
	y = 20030.55078125
}

Player look:

{
	z = 0.023110132664442,
	x = 0.82221657037735,
	y = -0.56870543956757
}

Player information:

{
	protocol_version = 42,
	formspec_version = 6,
	min_rtt = 0.16799999773502,
	avg_rtt = 0.17599999904633,
	min_jitter = 0,
	max_rtt = 5.183000087738,
	avg_jitter = 0.0030000060796738,
	connection_uptime = 10674,
	serialization_version = 29,
	patch = 0,
	ip_version = 6,
	lang_code = "",
	state = "Active",
	max_jitter = 5.0090003013611,
	minor = 8,
	major = 5,
	version_string = "5.8.0-dev-7388c87ad"
}

Player meta:

{
	fields = {
		yl_commons_thankyou = "58",
		["petz:werewolf"] = "0",
		yl_commons_player_created = "1644205752",
		yl_commons_player_joined = "1691357509",
		partychat = "party",
		["petz:werewolf_vignette_id"] = "16",
		["ethereal:fly_timer"] = "-99",
		xp = "0",
		["signslib:pos"] = "(6758,58,6221)",
		digged_nodes = "14969",
		placed_nodes = "18784",
		died = "2",
		["petz:old_override_table"] = "return {[\"sneak\"] = true, [\"speed\"] = 2, [\"new_move\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false}",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		jointime = "1644205752",
		bitten = "0",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}",
		["ocean_build.last_warning"] = "1.66814e+09",
		repellant = "0",
		["ocean_build.ocean_built"] = "6",
		punch_count = "1075",
		arenalib_infobox_arenaID = "0",
		["petz:lycanthropy"] = "0",
		inflicted_damage = "244734",
		hud_state = "off",
		["petz:werewolf_clan_idx"] = "2",
		played_time = "5574398",
		["stamina:level"] = "0",
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots\", \"\", \"\", \"\", \"\", \"\"}",
		["stamina:poisoned"] = "no",
		crafted = "2175",
		["stamina:exhaustion"] = "116"
	}
}

Log identifier


[MOD] yl_report log identifier = GReqcCC66fJT6tQHgEuFnOIE6NAkmXcw

Profiler save:

profile-20230807T002917.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3h 13min 2s | max lag: 0.14s | clients (9/52): copper144, copper248, flux, jackofthebean000, Kenneth, mindfrost, mrminer, Oakenshield, rheo

Teleport command:

/teleport xyz 19996 20031 19934

Compass command:

/give_compass Construction GReqcCC66fJT6tQHgEuFnOIE6NAkmXcw D2691E 19996 20031 19934
rheo reports a bug: > default chest duplication glitch via sticky piston Player position: ``` { z = 19934.03125, x = 19996.345703125, y = 20030.55078125 } ``` Player look: ``` { z = 0.023110132664442, x = 0.82221657037735, y = -0.56870543956757 } ``` Player information: ``` { protocol_version = 42, formspec_version = 6, min_rtt = 0.16799999773502, avg_rtt = 0.17599999904633, min_jitter = 0, max_rtt = 5.183000087738, avg_jitter = 0.0030000060796738, connection_uptime = 10674, serialization_version = 29, patch = 0, ip_version = 6, lang_code = "", state = "Active", max_jitter = 5.0090003013611, minor = 8, major = 5, version_string = "5.8.0-dev-7388c87ad" } ``` Player meta: ``` { fields = { yl_commons_thankyou = "58", ["petz:werewolf"] = "0", yl_commons_player_created = "1644205752", yl_commons_player_joined = "1691357509", partychat = "party", ["petz:werewolf_vignette_id"] = "16", ["ethereal:fly_timer"] = "-99", xp = "0", ["signslib:pos"] = "(6758,58,6221)", digged_nodes = "14969", placed_nodes = "18784", died = "2", ["petz:old_override_table"] = "return {[\"sneak\"] = true, [\"speed\"] = 2, [\"new_move\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false}", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", jointime = "1644205752", bitten = "0", yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}", ["ocean_build.last_warning"] = "1.66814e+09", repellant = "0", ["ocean_build.ocean_built"] = "6", punch_count = "1075", arenalib_infobox_arenaID = "0", ["petz:lycanthropy"] = "0", inflicted_damage = "244734", hud_state = "off", ["petz:werewolf_clan_idx"] = "2", played_time = "5574398", ["stamina:level"] = "0", ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots\", \"\", \"\", \"\", \"\", \"\"}", ["stamina:poisoned"] = "no", crafted = "2175", ["stamina:exhaustion"] = "116" } } ``` Log identifier ``` [MOD] yl_report log identifier = GReqcCC66fJT6tQHgEuFnOIE6NAkmXcw ``` Profiler save: ``` profile-20230807T002917.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3h 13min 2s | max lag: 0.14s | clients (9/52): copper144, copper248, flux, jackofthebean000, Kenneth, mindfrost, mrminer, Oakenshield, rheo ``` Teleport command: ``` /teleport xyz 19996 20031 19934 ``` Compass command: ``` /give_compass Construction GReqcCC66fJT6tQHgEuFnOIE6NAkmXcw D2691E 19996 20031 19934 ```
AliasAlreadyTaken was assigned by yourland-report 2023-08-07 02:29:17 +02:00
flux added the
1. kind/bug
3. source/integration
2. prio/critical
 labels 2023-08-07 02:31:34 +02:00
flux commented 2023-08-07 02:34:53 +02:00
Member
Copy Link

this is much easier in a "vanilla" world, because we've made open chests MVPS stoppers.

image

however i can still trigger it on YL, by opening and closing the chest rapidly when the piston is extended:

image

at least the new chests don't have duplicated contents - their node metadata doesn't get initialized.

proposed solution: any chest w/ an "open" variant should be an MVPS stopper.

this is much easier in a "vanilla" world, because we've made open chests MVPS stoppers. ![image](/attachments/263435fc-acae-47c6-93c8-4439a5fba650) however i can still trigger it on YL, by opening and closing the chest rapidly when the piston is extended: ![image](/attachments/d81aeb3b-12ce-438f-8b17-71a0b2988698) at least the new chests don't have duplicated contents - their node metadata doesn't get initialized. proposed solution: any chest w/ an "open" variant should be an MVPS stopper.
image.png
225 KiB
image.png
541 KiB
image.png
758 KiB
image.png
flux commented 2023-08-07 02:37:54 +02:00
Member
Copy Link

oh right, the reason the open chests are already MVPS stoppers: #1905

but the problem persists w/ closed chests too, in some edge case

fixing this via something other than MVPS stoppers would be very tricky.

oh right, the reason the open chests are already MVPS stoppers: #1905 but the problem persists w/ closed chests too, in some edge case fixing this via something other than MVPS stoppers would be very tricky.
AliasAlreadyTaken commented 2023-08-07 11:15:16 +02:00
Owner
Copy Link

How about we add everything that has meta to mvps stoppers and replacer blacklist?

How about we add everything that has meta to mvps stoppers and replacer blacklist?
copper248 commented 2023-08-08 04:55:36 +02:00
Copy Link

How about we add everything that has meta to mvps stoppers and replacer blacklist?

There is no way that this doesn't mess with some sort of mesecons build, I am all for replacer blacklisting them but making everything that has meta a mvps stopper is taking away one of the nicer features of mesecons, couldn't you just remove chest open entirely? I don't think many would care if a random animation disappeared, I haven't seen anyone complain about shared chests not opening. Honestly I think open chests are more trouble than they are worth.

Anyway that is my 2 cents

> How about we add everything that has meta to mvps stoppers and replacer blacklist? There is no way that this doesn't mess with some sort of mesecons build, I am all for replacer blacklisting them but making everything that has meta a mvps stopper is taking away one of the nicer features of mesecons, couldn't you just remove chest open entirely? I don't think many would care if a random animation disappeared, I haven't seen anyone complain about shared chests not opening. Honestly I think open chests are more trouble than they are worth. Anyway that is my 2 cents
👍 1
flux commented 2023-08-09 06:29:46 +02:00
Member
Copy Link

How about we add everything that has meta to mvps stoppers and replacer blacklist?

this is probably a good first step - this will prevent exploits.

There is no way that this doesn't mess with some sort of mesecons build

true. this will 100% break things. but probably these mechanics need to be whitelisted and possibly have special logic to handle the interactions, which we intentionally add when requested.

> How about we add everything that has meta to mvps stoppers and replacer blacklist? this is probably a good first step - this will prevent exploits. > There is no way that this doesn't mess with some sort of mesecons build true. this will 100% break things. but probably these mechanics need to be whitelisted and possibly have special logic to handle the interactions, which we intentionally add when requested.
👍 1
flux commented 2023-08-09 20:49:32 +02:00
Member
Copy Link

another option: get rid of the "open" chest variants, and have these chests work like e.g. the shared chest.

another option: get rid of the "open" chest variants, and have these chests work like e.g. the shared chest.
❤️ 1
AliasAlreadyTaken commented 2023-08-10 01:41:49 +02:00
Owner
Copy Link

I'm not that big into machines, sorry. What examples or usecases would break by adding add blocks with inv to mvps stoppers?

If for some reason we cannot "tame" open chests, we can remove them. Especially since not all chests display the same behaviour.

We can add back that mechanic when we unify chests and we found a generic solution.

I'm not that big into machines, sorry. What examples or usecases would break by adding add blocks with inv to mvps stoppers? If for some reason we cannot "tame" open chests, we can remove them. Especially since not all chests display the same behaviour. We can add back that mechanic when we unify chests and we found a generic solution.
copper248 commented 2023-08-10 07:52:44 +02:00
Copy Link

I'm not that big into machines, sorry. What examples or usecases would break by adding add blocks with inv to mvps stoppers?

If for some reason we cannot "tame" open chests, we can remove them. Especially since not all chests display the same behaviour.

We can add back that mechanic when we unify chests and we found a generic solution.

the problem is not items with metadata being mvps stoppers it is with open chests, see #5085 just kill 2 birds with 1 stone and get rid of them now before there is another way to destroy open chests

> I'm not that big into machines, sorry. What examples or usecases would break by adding add blocks with inv to mvps stoppers? > > If for some reason we cannot "tame" open chests, we can remove them. Especially since not all chests display the same behaviour. > > We can add back that mechanic when we unify chests and we found a generic solution. the problem is not items with metadata being mvps stoppers it is with open chests, see [#5085](https://gitea.your-land.de/your-land/bugtracker/issues/5085) just kill 2 birds with 1 stone and get rid of them now before there is another way to destroy open chests
flux commented 2023-08-10 21:18:33 +02:00
Member
Copy Link

all nodes w/ mutable metadata or special construction actions are now MVPS stoppers: fbcc8cfe51

all nodes w/ mutable metadata or special construction actions are now MVPS stoppers: https://gitea.your-land.de/your-land/yl_commons/commit/fbcc8cfe51c12563e85583ba402b94a13cd460f6
flux commented 2023-08-10 22:12:01 +02:00
Member
Copy Link

i got rid of open chests: 34fe76ee92

i got rid of open chests: https://gitea.your-land.de/your-land/yl_commons/commit/34fe76ee925571df70424b7813291957aee0ebd5
flux added the
4. step/ready to QA test
 label 2023-08-10 22:12:11 +02:00
AliasAlreadyTaken added this to the 1.1.120 milestone 2023-08-11 00:42:14 +02:00
AliasAlreadyTaken commented 2023-09-05 05:28:22 +02:00
Owner
Copy Link

QA:

Open chests are still in due to #5085 (comment)

However, the issue was solved, I can't reproduce it.

QA: Open chests are still in due to https://gitea.your-land.de/your-land/bugtracker/issues/5085#issuecomment-59431 However, the issue was solved, I can't reproduce it.
AliasAlreadyTaken added the
4. step/QA OK
 label 2023-09-05 05:28:28 +02:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-11-17 01:09:04 +01:00
AliasAlreadyTaken was unassigned by flux 2023-11-17 01:09:07 +01:00
flux commented 2023-11-17 01:09:40 +01:00
Member
Copy Link

this is live

this is live
flux closed this issue 2023-11-17 01:09:41 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
Milestone
Clear milestone
No items
No Milestone
1.1.120
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5068
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?