your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

flux reports: free chests @ haven are stuck ... #2149

New Issue
Open
opened 2022-06-30 23:04:58 +00:00 by yourland-report · 19 comments
yourland-report commented 2022-06-30 23:04:58 +00:00
Member
Copy Link

flux reports a bug:

free chests @ haven are stuck open. i WE'ed them close again, and they're open again O_O

Player position:

{
	y = 14.5,
	x = 1954.123046875,
	z = 1159.2120361328
}

Player look:

{
	y = -0.56583070755005,
	x = 0.1090484187007,
	z = 0.817278444767
}

Player information:

{
	min_rtt = 0.15500000119209,
	max_rtt = 12.59700012207,
	connection_uptime = 199601,
	max_jitter = 12.422999382019,
	minor = 6,
	major = 5,
	ip_version = 6,
	formspec_version = 5,
	patch = 0,
	protocol_version = 40,
	serialization_version = 29,
	lang_code = "",
	version_string = "5.6.0-dev-d208be276-dirty",
	avg_rtt = 0.17000000178814,
	state = "Active",
	avg_jitter = 0.0020000040531158,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_nether 1 1440\", \"nether_mobs:dragon_shield 1 720\", \"3d_armor:helmet_nether 1 720\", \"nether_mobs:dragon_boots 1 720\", \"3d_armor:leggings_nether 1 1440\", \"\"}",
		["petz:werewolf_vignette_id"] = "5",
		["petz:werewolf"] = "0",
		jointime = "1615351173",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "145",
		["signslib:pos"] = "(1290,63,550)",
		digged_nodes = "1060285",
		yl_commons_thankyou = "125",
		played_time = "18594123",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 29400, [\"x\"] = 2338, [\"z\"] = 1226}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}",
		xp = "1242401",
		["stamina:level"] = "9",
		punch_count = "79753",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "1287112",
		crafted = "38406",
		["petz:werewolf_clan_idx"] = "1",
		yl_commons_player_joined = "1656430717",
		placed_nodes = "346978",
		died = "65",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1615351173"
	}
}

Log identifier


[MOD] yl_report log identifier = xcI7LmP9TgjDXSJgEpAoWnCMYt2V65VL

Profiler save:

profile-20220701T010458.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 7d 8h 26min 51s | max lag: 4.5s | clients: Therottenpotato, CorranEveryone, Ivanhoe, Combie, rheo, Xonon, Anaconda, Grey, Ineva, KittyCatFan, Lucien, Chache, Service, AliasAlreadyTaken, Bailiff, flux

Teleport command:

/teleport xyz 1954 15 1159

Compass command:

/give_compass Construction xcI7LmP9TgjDXSJgEpAoWnCMYt2V65VL D2691E 1954 15 1159
flux reports a bug: > free chests @ haven are stuck open. i WE'ed them close again, and they're open again O_O Player position: ``` { y = 14.5, x = 1954.123046875, z = 1159.2120361328 } ``` Player look: ``` { y = -0.56583070755005, x = 0.1090484187007, z = 0.817278444767 } ``` Player information: ``` { min_rtt = 0.15500000119209, max_rtt = 12.59700012207, connection_uptime = 199601, max_jitter = 12.422999382019, minor = 6, major = 5, ip_version = 6, formspec_version = 5, patch = 0, protocol_version = 40, serialization_version = 29, lang_code = "", version_string = "5.6.0-dev-d208be276-dirty", avg_rtt = 0.17000000178814, state = "Active", avg_jitter = 0.0020000040531158, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_nether 1 1440\", \"nether_mobs:dragon_shield 1 720\", \"3d_armor:helmet_nether 1 720\", \"nether_mobs:dragon_boots 1 720\", \"3d_armor:leggings_nether 1 1440\", \"\"}", ["petz:werewolf_vignette_id"] = "5", ["petz:werewolf"] = "0", jointime = "1615351173", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "145", ["signslib:pos"] = "(1290,63,550)", digged_nodes = "1060285", yl_commons_thankyou = "125", played_time = "18594123", bitten = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 29400, [\"x\"] = 2338, [\"z\"] = 1226}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}", xp = "1242401", ["stamina:level"] = "9", punch_count = "79753", arenalib_infobox_arenaID = "0", inflicted_damage = "1287112", crafted = "38406", ["petz:werewolf_clan_idx"] = "1", yl_commons_player_joined = "1656430717", placed_nodes = "346978", died = "65", hud_state = "on", repellant = "0", yl_commons_player_created = "1615351173" } } ``` Log identifier ``` [MOD] yl_report log identifier = xcI7LmP9TgjDXSJgEpAoWnCMYt2V65VL ``` Profiler save: ``` profile-20220701T010458.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 7d 8h 26min 51s | max lag: 4.5s | clients: Therottenpotato, CorranEveryone, Ivanhoe, Combie, rheo, Xonon, Anaconda, Grey, Ineva, KittyCatFan, Lucien, Chache, Service, AliasAlreadyTaken, Bailiff, flux ``` Teleport command: ``` /teleport xyz 1954 15 1159 ``` Compass command: ``` /give_compass Construction xcI7LmP9TgjDXSJgEpAoWnCMYt2V65VL D2691E 1954 15 1159 ```
AliasAlreadyTaken was assigned by yourland-report 2022-06-30 23:04:58 +00:00
flux commented 2022-07-01 02:27:51 +00:00
Member
Copy Link

i broke them and re-placed them and they're still broken O_O

i broke them and re-placed them and they're still broken O_O
flux commented 2022-07-01 15:31:26 +00:00
Member
Copy Link

https://github.com/minetest/minetest_game/issues/2031

https://github.com/minetest/minetest_game/issues/2031
flux added the
1. kind/bug
3. source/mod upstream
 labels 2022-07-01 15:31:44 +00:00
flux commented 2022-07-01 16:14:45 +00:00
Member
Copy Link

upstream PR https://github.com/minetest/minetest_game/pull/2965

upstream PR https://github.com/minetest/minetest_game/pull/2965
flux added this to the flux's TODO list project 2022-07-02 22:37:23 +00:00
flux added the
4. step/blocked
 label 2022-10-29 18:46:22 +00:00
flux self-assigned this 2022-10-29 18:46:28 +00:00
flux added
4. step/ready to QA test
 and removed
4. step/blocked
 labels 2023-01-25 19:40:16 +00:00
flux commented 2023-01-25 19:40:30 +00:00
Member
Copy Link

upstream MTG fix was merged

upstream MTG fix was merged
AliasAlreadyTaken commented 2023-01-26 06:09:56 +00:00
Owner
Copy Link

We'll most likely update to this fix with the release of 5.7.0

We'll most likely update to this fix with the release of 5.7.0
whosit commented 2023-06-28 12:46:19 +00:00
Member
Copy Link

Chests are still stuck, should this be added to next milestone? (since server is now 5.7.0?)

Chests are still stuck, should this be added to next milestone? (since server is now 5.7.0?)
flux commented 2023-06-28 19:08:55 +00:00
Member
Copy Link

note that the fix is in minetest_game, not the engine. i'm not sure which version of minetest_game we're running.

note that the fix is in minetest_game, not the engine. i'm not sure which version of minetest_game we're running.
AliasAlreadyTaken commented 2023-06-28 21:14:07 +00:00
Owner
Copy Link

We're on MTG stable-5: 08057e8e0f01b443515ff81423215e4367f84872

This is the repo: https://gitea.your-land.de/your-land/minetest_game/src/branch/stable-5

Since there are no changes towards upstream, I didn't make a yl_stable branch yet

We're on MTG stable-5: 08057e8e0f01b443515ff81423215e4367f84872 This is the repo: https://gitea.your-land.de/your-land/minetest_game/src/branch/stable-5 Since there are no changes towards upstream, I didn't make a yl_stable branch yet
flux commented 2023-06-29 17:31:41 +00:00
Member
Copy Link

i guess the update hasn't made it into stable yet. this is the commit which fixed the chests: ec2f57db0e

i guess the update hasn't made it into stable yet. this is the commit which fixed the chests: https://github.com/minetest/minetest_game/commit/ec2f57db0e12f7bf5dfe409c6815491a40c2a499
tour commented 2024-03-18 21:15:33 +00:00
Copy Link

In my plain singleplayer world chests work fine. But... pipeworks kills all of the changes.
1b79084e6b/compat-chests.lua

(regarding how outdated that code is: chests not closing on logout is a problem that got fixed in MTG >6 Years ago...)

In my plain singleplayer world chests work fine. But... pipeworks kills all of the changes. https://github.com/mt-mods/pipeworks/blob/1b79084e6bbbcbc02229f3136b87cca98f14e829/compat-chests.lua (regarding how outdated that code is: chests not closing on logout is a problem that got fixed in MTG >6 Years ago...)
AliasAlreadyTaken commented 2024-03-19 00:26:37 +00:00
Owner
Copy Link

In YL, we're on commit 08057e8e0f01b443515ff81423215e4367f84872

That means the fix is not on the server yet. With the 5.8.0 upgrade we'll also go to a new MTG

In YL, we're on commit 08057e8e0f01b443515ff81423215e4367f84872 That means the fix is not on the server yet. With the 5.8.0 upgrade we'll also go to a new MTG
flux commented 2024-03-29 23:30:21 +00:00
Member
Copy Link

just validated that this is still an issue

image

just validated that this is still an issue ![image](/attachments/11d81b33-b4fb-48f7-b926-6e3c79b250e4)
image.png
163 KiB
AliasAlreadyTaken commented 2024-03-29 23:49:45 +00:00
Owner
Copy Link

The new MTG was planned to be delivered with the upgrade to 5.8.0, but there was a connection issue. So we had to go back to what we had before, 5.7.0 with the previous MTG. Details here: your-land/administration#208

The new MTG was planned to be delivered with the upgrade to 5.8.0, but there was a connection issue. So we had to go back to what we had before, 5.7.0 with the previous MTG. Details here: your-land/administration#208
flux added this to the minetest 5.8.0 milestone 2024-03-30 19:59:27 +00:00
tour commented 2024-04-01 18:23:59 +00:00
Copy Link

Seeing that the discussion here is still only about the MTG update, I realize that my last comment was very imprecise:

The problem here is only partially with MTG. Before 5.8.0 MTG chests were definitely buggy. What I tried to say with my last comment: A MTG update might not be enough for this issue, other mods mess up with chests too :/

Take the repo provided by flux in #6526

  1. open chest
  2. while formspec is open, kill the client.

This issue was solved by MTG in 2017 by adding a register_on_leaveplayer callback (https://github.com/minetest/minetest_game/pull/1884). This should definitely be live.

BUT there is pipeworks: https://github.com/mt-mods/pipeworks/blob/master/compat-chests.lua
It looks like they copied and modified MTG chest code 12 years ago and only cherry-picked commits from mtg chests since then.
This includes the code which is responsible for opened/closed chests.
Long story short: MTG chests got updates/fixes, but most of them never made into the pipeworks code.

If needed, I can elaborate on why most of mtg's fixes (including the one mentioned above) do not affect the pipeworks implementation.
It shouldn't be too hard for me open a pr to pipeworks and get rid of all the duplicated code in there. Let me know if I should do so :-)

Seeing that the discussion here is still only about the MTG update, I realize that my last comment was very imprecise: The problem here is only partially with MTG. Before 5.8.0 MTG chests were definitely buggy. What I tried to say with my last comment: A MTG update might not be enough for this issue, other mods mess up with chests too :/ Take the repo provided by flux in #6526 >1) open chest >2) while formspec is open, kill the client. This issue was solved by MTG in **2017** by adding a `register_on_leaveplayer` callback (https://github.com/minetest/minetest_game/pull/1884). This should definitely be live. BUT there is pipeworks: https://github.com/mt-mods/pipeworks/blob/master/compat-chests.lua It looks like they copied and modified MTG chest code 12 years ago and only cherry-picked commits from mtg chests since then. This includes the code which is responsible for opened/closed chests. Long story short: MTG chests got updates/fixes, but most of them never made into the pipeworks code. If needed, I can elaborate on why most of mtg's fixes (including the one mentioned above) do not affect the pipeworks implementation. It shouldn't be too hard for me open a pr to pipeworks and get rid of all the duplicated code in there. Let me know if I should do so :-)
flux commented 2024-04-01 23:40:39 +00:00
Member
Copy Link

In my plain singleplayer world chests work fine. But... pipeworks kills all of the changes.

oh i missed that before, sorry tour.

> In my plain singleplayer world chests work fine. But... pipeworks kills all of the changes. oh i missed that before, sorry tour.
flux commented 2024-04-01 23:44:11 +00:00
Member
Copy Link

seems that pipeworks has been updated: 1b79084e6b

seems that pipeworks has been updated: https://github.com/mt-mods/pipeworks/commit/1b79084e6bbbcbc02229f3136b87cca98f14e829
flux commented 2024-04-01 23:45:49 +00:00
Member
Copy Link

It shouldn't be too hard for me open a pr to pipeworks and get rid of all the duplicated code in there. Let me know if I should do so :-)

if you want to dig into pipeworks enough to de-dupe the code, feel free :) i try to avoid touching it when i can.

> It shouldn't be too hard for me open a pr to pipeworks and get rid of all the duplicated code in there. Let me know if I should do so :-) if you want to dig into pipeworks enough to de-dupe the code, feel free :) i try to avoid touching it when i can.
👍 2
tour commented 2024-04-05 17:42:49 +00:00
Copy Link

seems that pipeworks has been updated: 1b79084e6b

That only affects the fix from #5085 while this issue deals with chests stuck open. None of the pr's from here made it into the pipeworks version so far...

I tried my best, I hope I don't have to rewrite large parts after feedback from the maintainers:
https://github.com/mt-mods/pipeworks/pull/123

oh i missed that before

Well, from what I can see and hear here, you have already more than enough to do. One of the reasons why I am a bit more active here now.
Hope I help more than I create extra work...

> seems that pipeworks has been updated: 1b79084e6b That only affects the fix from #5085 while this issue deals with chests stuck open. None of the pr's from here made it into the pipeworks version so far... I tried my best, I hope I don't have to rewrite large parts after feedback from the maintainers: https://github.com/mt-mods/pipeworks/pull/123 --- > oh i missed that before Well, from what I can see and hear here, you have already more than enough to do. One of the reasons why I am a bit more active here now. Hope I help more than I create extra work...
👍 1
flux added
4. step/blocked
 and removed
4. step/ready to QA test
 labels 2024-04-05 20:16:46 +00:00
tour commented 2024-04-11 11:37:09 +00:00
Copy Link

pr got merged. This should now be fixed with latest mtg+pipeworks.

Just for completeness, some special chests might not have this fix...

  • moremesecons:mesechest(\_protected) is registered in a very weird way, the lbm to close open chests on load will not run for these. they need a rewrite anyway #4809
  • The petz repo is gone, I remember they duplicated chest code too. I sadly can't look that up, but I think Christmas presents stuck open are not a big problem atm 😆
pr got merged. This should now be fixed with latest mtg+pipeworks. Just for completeness, some special chests might not have this fix... - `moremesecons:mesechest(\_protected)` is registered in a very weird way, the lbm to close open chests on load will not run for these. they need a rewrite anyway #4809 - The petz repo is gone, I remember they duplicated chest code too. I sadly can't look that up, but I think Christmas presents stuck open are not a big problem atm 😆
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
minetest 5.8.0
Projects
Clear projects
No project
flux's TODO list
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
flux
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2149
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?