your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

MineWorlds reports: compass dupe bug. how it works ... #4591

New Issue
Open
opened 2023-05-24 16:12:49 +00:00 by yourland-report · 6 comments
yourland-report commented 2023-05-24 16:12:49 +00:00
Member
Copy Link

MineWorlds reports a bug:

compass dupe bug. how it works?: get 2 miocene compasses for free by buttercup. place an autocraft. set the crafting recipe for 2 compasses to make 1 compass, then place the 2 free miocene compasses and boom. you get an default compass. allowing you to add your own coords to it and save on ores.

Player position:

{
	z = 522.19903564453,
	x = 1296.1989746094,
	y = 41.5
}

Player look:

{
	z = 0.60781288146973,
	x = 0.76357799768448,
	y = 0.21797290444374
}

Player information:

{
	major = 5,
	ip_version = 6,
	min_rtt = 0.16099999845028,
	minor = 3,
	min_jitter = 0,
	max_jitter = 2.1470000743866,
	avg_jitter = 0.0069999992847443,
	connection_uptime = 4165,
	serialization_version = 28,
	patch = 0,
	lang_code = "",
	version_string = "5.3.0",
	formspec_version = 3,
	max_rtt = 2.3129999637604,
	state = "Active",
	avg_rtt = 0.17700000107288,
	protocol_version = 39
}

Player meta:

{
	fields = {
		["petz:werewolf_clan_idx"] = "2",
		played_time = "4029627",
		digged_nodes = "1125966",
		placed_nodes = "102137",
		died = "102",
		crafted = "46470",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		yl_commons_thankyou = "175",
		jointime = "1614030326",
		bitten = "0",
		punch_count = "253640",
		inflicted_damage = "5447198",
		yl_church = "return {[\"last_death_portal\"] = 1684687269, [\"last_death\"] = {[\"z\"] = 1179, [\"x\"] = 2006, [\"y\"] = 15}, [\"last_heal\"] = 1684019804}",
		["stamina:level"] = "18",
		repellant = "0",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "144.5",
		["signslib:pos"] = "(1974,14,1673)",
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 520\", \"shields:shield_nether 1 1040\", \"3d_armor:leggings_nether 1 1040\", \"3d_armor:helmet_nether 1 520\", \"3d_armor:chestplate_nether 1 1040\", \"\"}",
		["ocean_build.last_warning"] = "1.679e+09",
		["petz:werewolf"] = "0",
		["ocean_build.ocean_built"] = "12",
		["petz:lycanthropy"] = "0",
		["petz:werewolf_vignette_id"] = "19",
		["hud_manager:choppy:waypoint_enabled"] = "y",
		hud_state = "on",
		arenalib_infobox_arenaID = "0",
		xp = "920059",
		["petz:old_override_table"] = "return {[\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak\"] = true, [\"speed\"] = 2, [\"new_move\"] = true, [\"sneak_glitch\"] = false}",
		yl_commons_player_joined = "1684940674",
		partychat = "party",
		yl_commons_player_created = "1614030326",
		["ocean_build.forbidden"] = "true"
	}
}

Log identifier


[MOD] yl_report log identifier = 7kwX5ezc6vP6wpkhBtBAM8g7MPWV2KRj

Profiler save:

profile-20230524T161249.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 1d 21h 9min 49s | max lag: 0.94s | clients (26/52): AliasAlreadyTaken, Bailiff, BibaBoba, carag, daydream, Dirac, Dovakhiin, flux, Grzegorz, JeCel, lolshsh, lucas123s, mahou, melone, MineWorlds, Murmel, niceride, poppyasdan, Qualia, Ravise, Service, shanish, Sysmatic, tagtraum, whymebob, Yumpy

Teleport command:

/teleport xyz 1296 42 522

Compass command:

/give_compass Construction 7kwX5ezc6vP6wpkhBtBAM8g7MPWV2KRj D2691E 1296 42 522
MineWorlds reports a bug: > compass dupe bug. how it works?: get 2 miocene compasses for free by buttercup. place an autocraft. set the crafting recipe for 2 compasses to make 1 compass, then place the 2 free miocene compasses and boom. you get an default compass. allowing you to add your own coords to it and save on ores. Player position: ``` { z = 522.19903564453, x = 1296.1989746094, y = 41.5 } ``` Player look: ``` { z = 0.60781288146973, x = 0.76357799768448, y = 0.21797290444374 } ``` Player information: ``` { major = 5, ip_version = 6, min_rtt = 0.16099999845028, minor = 3, min_jitter = 0, max_jitter = 2.1470000743866, avg_jitter = 0.0069999992847443, connection_uptime = 4165, serialization_version = 28, patch = 0, lang_code = "", version_string = "5.3.0", formspec_version = 3, max_rtt = 2.3129999637604, state = "Active", avg_rtt = 0.17700000107288, protocol_version = 39 } ``` Player meta: ``` { fields = { ["petz:werewolf_clan_idx"] = "2", played_time = "4029627", digged_nodes = "1125966", placed_nodes = "102137", died = "102", crafted = "46470", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", yl_commons_thankyou = "175", jointime = "1614030326", bitten = "0", punch_count = "253640", inflicted_damage = "5447198", yl_church = "return {[\"last_death_portal\"] = 1684687269, [\"last_death\"] = {[\"z\"] = 1179, [\"x\"] = 2006, [\"y\"] = 15}, [\"last_heal\"] = 1684019804}", ["stamina:level"] = "18", repellant = "0", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "144.5", ["signslib:pos"] = "(1974,14,1673)", ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 520\", \"shields:shield_nether 1 1040\", \"3d_armor:leggings_nether 1 1040\", \"3d_armor:helmet_nether 1 520\", \"3d_armor:chestplate_nether 1 1040\", \"\"}", ["ocean_build.last_warning"] = "1.679e+09", ["petz:werewolf"] = "0", ["ocean_build.ocean_built"] = "12", ["petz:lycanthropy"] = "0", ["petz:werewolf_vignette_id"] = "19", ["hud_manager:choppy:waypoint_enabled"] = "y", hud_state = "on", arenalib_infobox_arenaID = "0", xp = "920059", ["petz:old_override_table"] = "return {[\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak\"] = true, [\"speed\"] = 2, [\"new_move\"] = true, [\"sneak_glitch\"] = false}", yl_commons_player_joined = "1684940674", partychat = "party", yl_commons_player_created = "1614030326", ["ocean_build.forbidden"] = "true" } } ``` Log identifier ``` [MOD] yl_report log identifier = 7kwX5ezc6vP6wpkhBtBAM8g7MPWV2KRj ``` Profiler save: ``` profile-20230524T161249.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 1d 21h 9min 49s | max lag: 0.94s | clients (26/52): AliasAlreadyTaken, Bailiff, BibaBoba, carag, daydream, Dirac, Dovakhiin, flux, Grzegorz, JeCel, lolshsh, lucas123s, mahou, melone, MineWorlds, Murmel, niceride, poppyasdan, Qualia, Ravise, Service, shanish, Sysmatic, tagtraum, whymebob, Yumpy ``` Teleport command: ``` /teleport xyz 1296 42 522 ``` Compass command: ``` /give_compass Construction 7kwX5ezc6vP6wpkhBtBAM8g7MPWV2KRj D2691E 1296 42 522 ```
AliasAlreadyTaken was assigned by yourland-report 2023-05-24 16:12:49 +00:00
flux added the
1. kind/bug
 label 2023-05-24 17:02:26 +00:00
whosit commented 2023-05-24 17:28:19 +00:00
Member
Copy Link

I can't reproduce this in the player's crafting grid, so I will blame the autocrafter :P

Seems like autocrafter is not calling on_craft or craft_predict that should update the item's meta or prevent the crafting a new compass from two "set" compasses.

bd5a42356b/autocrafter.lua (L36)

Probably can be prevented by making "unset" compass a separate item?
#2186

I can't reproduce this in the player's crafting grid, so I will blame the autocrafter :P Seems like autocrafter is not calling `on_craft` or `craft_predict` that should update the item's meta or prevent the crafting a new compass from two "set" compasses. https://gitea.your-land.de/your-land/pipeworks/src/commit/bd5a42356bc20a71dac5d11ea04deb4fa6246d0e/autocrafter.lua#L36 Probably can be prevented by making "unset" compass a separate item? https://gitea.your-land.de/your-land/bugtracker/issues/2186
flux commented 2023-05-24 21:47:26 +00:00
Member
Copy Link

just to be clear - the goal of the "2 compass" crafting recipe is to copy the recipe from a programmed compass to an empty compass, this isn't a weird remnant of the "craft 2 worn tools to create a single less-worn tool" mechanic, right?

Probably can be prevented by making "unset" compass a separate item?

i'm in favor of this in general - unlike nodes, there's no real limit on the # of other items. more importantly, it'd allow making the unset compasses into "craftitems" instead of "tools", so that they could stack #2186.

I will blame the autocrafter

crafting is hard. i'm pretty sure i (finally) got it right for the "craft all" button, so i guess i should apply that work to the autocrafter. but, ugh, i hate pipeworks...

just to be clear - the goal of the "2 compass" crafting recipe is to copy the recipe from a programmed compass to an empty compass, this isn't a weird remnant of the "craft 2 worn tools to create a single less-worn tool" mechanic, right? > Probably can be prevented by making "unset" compass a separate item? i'm in favor of this in general - unlike nodes, there's no real limit on the # of other items. more importantly, it'd allow making the unset compasses into "craftitems" instead of "tools", so that they could stack #2186. > I will blame the autocrafter crafting is hard. i'm pretty sure i (finally) got it right for the ["craft all" button](https://github.com/mt-mods/unified_inventory_plus/blob/master/craft_all.lua), so i guess i should apply that work to the autocrafter. but, ugh, i hate pipeworks...
whosit commented 2023-05-24 23:11:15 +00:00
Member
Copy Link

just to be clear - the goal of the "2 compass" crafting recipe is to copy the recipe from a programmed compass to an empty compass, this isn't a weird remnant of the "craft 2 worn tools to create a single less-worn tool" mechanic, right?

Sorry, I have no idea how repairing works (if it's default behavior for tools, and compass is a tool. Why it's a tool? Probably to prevent stacking, or I was not sure what callbacks were availible for non-tools, I don't remember...). But I did write this:
c01ba435b7/init.lua (L433)
Which then triggers this:
c01ba435b7/init.lua (L439)
And it's supposed to find one "set" compass and one "unset", then copy meta.

Probably can be prevented by making "unset" compass a separate item?

i'm in favor of this in general - unlike nodes, there's no real limit on the # of other items. more importantly, it'd allow making the unset compasses into "craftitems" instead of "tools", so that they could stack #2186.

Well, maybe one day I'll finally do that, having a separate item seemed error prone to me back then, but maybe it's not too bad...

I will blame the autocrafter

crafting is hard. i'm pretty sure i (finally) got it right for the "craft all" button, so i guess i should apply that work to the autocrafter. but, ugh, i hate pipeworks...

Sucks that all of this depends on undocumented features.
I seem to remember there was a bug about autocrafter eating a bucket instead of empying it or something? Probably related problem...

> just to be clear - the goal of the "2 compass" crafting recipe is to copy the recipe from a programmed compass to an empty compass, this isn't a weird remnant of the "craft 2 worn tools to create a single less-worn tool" mechanic, right? Sorry, I have no idea how repairing works (if it's default behavior for tools, and compass _is_ a tool. Why it's a tool? Probably to prevent stacking, or I was not sure what callbacks were availible for non-tools, I don't remember...). But I did write this: https://gitea.your-land.de/whosit/waypoint_compass/src/commit/c01ba435b7573551f3bf69c467525f3ae51ad931/init.lua#L433 Which then triggers this: https://gitea.your-land.de/whosit/waypoint_compass/src/commit/c01ba435b7573551f3bf69c467525f3ae51ad931/init.lua#L439 And it's supposed to find one "set" compass and one "unset", then copy meta. > > Probably can be prevented by making "unset" compass a separate item? > > i'm in favor of this in general - unlike nodes, there's no real limit on the # of other items. more importantly, it'd allow making the unset compasses into "craftitems" instead of "tools", so that they could stack #2186. Well, maybe one day I'll finally do that, having a separate item seemed error prone to me back then, but maybe it's not too bad... > > > I will blame the autocrafter > > crafting is hard. i'm pretty sure i (finally) got it right for the ["craft all" button](https://github.com/mt-mods/unified_inventory_plus/blob/master/craft_all.lua), so i guess i should apply that work to the autocrafter. but, ugh, i hate pipeworks... Sucks that all of this depends on undocumented features. I seem to remember there was a bug about autocrafter eating a bucket instead of empying it or something? Probably related problem...
flux commented 2023-05-25 00:17:03 +00:00
Member
Copy Link

just to be clear - the goal of the "2 compass" crafting recipe is to copy the recipe from a programmed compass to an empty compass, this isn't a weird remnant of the "craft 2 worn tools to create a single less-worn tool" mechanic, right?

verified the autocrafter has a similar problem w/ written books

> just to be clear - the goal of the "2 compass" crafting recipe is to copy the recipe from a programmed compass to an empty compass, this isn't a weird remnant of the "craft 2 worn tools to create a single less-worn tool" mechanic, right? verified the autocrafter has a similar problem w/ written books
flux commented 2023-05-25 14:23:23 +00:00
Member
Copy Link

to be absolutely clear, this is a bug w/ pipeworks, not w/ the compass.

Sorry, I have no idea how repairing works

how tool repair works. we have it disabled intentionally (#118, #1787), though i no longer remember why i did so in a convoluted way.

I seem to remember there was a bug about autocrafter eating a bucket instead of empying it or something?

that's a separate but related problem https://github.com/mt-mods/pipeworks/issues/61.

to be absolutely clear, this is a bug w/ pipeworks, not w/ the compass. > Sorry, I have no idea how repairing works [how tool repair works](https://github.com/minetest/minetest/blob/master/doc/lua_api.md#tool-repair). we have it disabled intentionally (#118, #1787), though i no longer remember why i did so in a convoluted way. > I seem to remember there was a bug about autocrafter eating a bucket instead of empying it or something? that's a separate but related problem https://github.com/mt-mods/pipeworks/issues/61.
👀 1
flux commented 2023-05-25 14:40:25 +00:00
Member
Copy Link

upstream issue: https://github.com/mt-mods/pipeworks/issues/67

upstream issue: https://github.com/mt-mods/pipeworks/issues/67
flux added the
3. source/mod upstream
 label 2023-05-25 14:40:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#4591
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?