Freebie reports: If you put two new swords in t ... #1787

New Issue

yourland-report · 2022-04-18T10:29:11Z

yourland-report commented

2022-04-18 10:29:11 +00:00

Freebie reports a bug:

If you put two new swords in the grid it will craft just one sword, one lost.

Player position:

{
	y = -12.5,
	x = 5979.8500976563,
	z = 2975.7199707031
}

Player look:

{
	y = -0.29737484455109,
	x = 0.59825658798218,
	z = 0.74408143758774
}

Player information:

{
	min_rtt = 0.014000000432134,
	max_rtt = 0.39700001478195,
	connection_uptime = 94,
	max_jitter = 0.30099999904633,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 5,
	patch = 0,
	protocol_version = 40,
	serialization_version = 29,
	lang_code = "de",
	version_string = "5.5.0",
	avg_rtt = 0.018999999389052,
	state = "Active",
	avg_jitter = 0.0010000001639128,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 13620\", \"3d_armor:boots_crystal 1 13620\", \"shields:shield_crystal 1 13620\", \"3d_armor:leggings_crystal 1 13620\", \"3d_armor:chestplate_crystal 1 13620\", \"\"}",
		played_time = "29021",
		jointime = "1649959597",
		yl_commons_player_joined = "1650277666",
		["stamina:exhaustion"] = "59",
		digged_nodes = "1",
		bitten = "0",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -12, [\"x\"] = 5984, [\"z\"] = 2968}, [\"last_death_portal\"] = 1649963868}",
		["stamina:level"] = "10",
		xp = "5",
		arenalib_infobox_arenaID = "0",
		crafted = "3",
		died = "1",
		["stamina:poisoned"] = "no",
		placed_nodes = "2",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1649959597"
	}
}

Log identifier


[MOD] yl_report log identifier = VFtNZHBrMscKDke0WHWboonEOcuxLbcK

Profiler save:

profile-20220418T122910.json_prettyEE

Status:

# Server: version: 5.5.0-yl | game: Minetest Game | uptime: 1h 21min 50s | max lag: 3.84s | clients: Papi, alvin, rohit, JeCel, upie, Segmentation_Fault, pitman, Bailiff, GrimPixel, Chache, Aero, acen2006, ramneeiu, AliasAlreadyTaken, Freebie, Service, brok, Boris, ipse, Arc999

Teleport command:

/teleport xyz 5980 -13 2976

Compass command:

/give_compass Construction VFtNZHBrMscKDke0WHWboonEOcuxLbcK D2691E 5980 -13 2976

Freebie reports a bug: > If you put two new swords in the grid it will craft just one sword, one lost. Player position: ``` { y = -12.5, x = 5979.8500976563, z = 2975.7199707031 } ``` Player look: ``` { y = -0.29737484455109, x = 0.59825658798218, z = 0.74408143758774 } ``` Player information: ``` { min_rtt = 0.014000000432134, max_rtt = 0.39700001478195, connection_uptime = 94, max_jitter = 0.30099999904633, minor = 5, major = 5, ip_version = 6, formspec_version = 5, patch = 0, protocol_version = 40, serialization_version = 29, lang_code = "de", version_string = "5.5.0", avg_rtt = 0.018999999389052, state = "Active", avg_jitter = 0.0010000001639128, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 13620\", \"3d_armor:boots_crystal 1 13620\", \"shields:shield_crystal 1 13620\", \"3d_armor:leggings_crystal 1 13620\", \"3d_armor:chestplate_crystal 1 13620\", \"\"}", played_time = "29021", jointime = "1649959597", yl_commons_player_joined = "1650277666", ["stamina:exhaustion"] = "59", digged_nodes = "1", bitten = "0", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = -12, [\"x\"] = 5984, [\"z\"] = 2968}, [\"last_death_portal\"] = 1649963868}", ["stamina:level"] = "10", xp = "5", arenalib_infobox_arenaID = "0", crafted = "3", died = "1", ["stamina:poisoned"] = "no", placed_nodes = "2", hud_state = "on", repellant = "0", yl_commons_player_created = "1649959597" } } ``` Log identifier ``` [MOD] yl_report log identifier = VFtNZHBrMscKDke0WHWboonEOcuxLbcK ``` Profiler save: ``` profile-20220418T122910.json_prettyEE ``` Status: ``` # Server: version: 5.5.0-yl | game: Minetest Game | uptime: 1h 21min 50s | max lag: 3.84s | clients: Papi, alvin, rohit, JeCel, upie, Segmentation_Fault, pitman, Bailiff, GrimPixel, Chache, Aero, acen2006, ramneeiu, AliasAlreadyTaken, Freebie, Service, brok, Boris, ipse, Arc999 ``` Teleport command: ``` /teleport xyz 5980 -13 2976 ``` Compass command: ``` /give_compass Construction VFtNZHBrMscKDke0WHWboonEOcuxLbcK D2691E 5980 -13 2976 ```

AliasAlreadyTaken was assigned by yourland-report

2022-04-18 10:29:11 +00:00

flux commented

2022-04-18 15:36:20 +00:00

that's the intended behavior, though i agree that it's stupid.

flux added the

1. kind/documentation

label 2022-04-18 15:36:35 +00:00

flux commented

2022-04-18 15:38:36 +00:00

cf #118

AliasAlreadyTaken commented

2022-04-19 00:25:05 +00:00

Most likely it's meant to be a repair mechanic. Let's find where this comes from and disable it.

Affects your-land/administration#111

Most likely it's meant to be a repair mechanic. Let's find where this comes from and disable it. Affects https://gitea.your-land.de/your-land/administration/issues/111

AliasAlreadyTaken commented

2022-04-19 00:27:08 +00:00

Aloha,

most likely it's meant to be a repair mechanic for games that don't have the anvil. At least it is default behaviour for minetest game. Still, its confusing and potentially dangerous, we'll disable it.

We will overhaul repair mechanics and the anvil anyways.

Greetings, Alias

Aloha, most likely it's meant to be a repair mechanic for games that don't have the anvil. At least it is default behaviour for minetest game. Still, its confusing and potentially dangerous, we'll disable it. We will overhaul repair mechanics and the anvil anyways. Greetings, Alias

AliasAlreadyTaken closed this issue

2022-04-19 00:27:09 +00:00

AliasAlreadyTaken reopened this issue

2022-04-19 00:27:21 +00:00

AliasAlreadyTaken commented

2022-04-19 00:28:09 +00:00

I closed it because I delivered the explanation, but I reopened. We should close this when this wayward repair mechanis is disabled.

flux commented

2022-08-29 20:41:02 +00:00

@Alias this can be disabled entirely by removing a certain recipe, or per-tool by setting a certain group. see 75d88dcae2/doc/lua_api.txt (L8445-L8464)

i've never liked that repair mechanic, i could disable this quickly if we want.

i think there might be at least one other ticket pertaining to this mechanic. compasses? i can't find it though.

@Alias this can be disabled entirely by removing a certain recipe, or per-tool by setting a certain group. see https://github.com/minetest/minetest/blob/75d88dcae233757d9567c971227b33b0168b5254/doc/lua_api.txt#L8445-L8464 i've never liked that repair mechanic, i could disable this quickly if we want. i think there might be at least one other ticket pertaining to this mechanic. compasses? i can't find it though.

👍 2

flux added the

1. kind/enhancement

4. step/want approval

2. prio/interesting

labels 2022-08-29 20:41:18 +00:00

flux added this to the flux's TODO list project 2022-08-29 20:41:20 +00:00

flux self-assigned this 2022-08-29 20:41:27 +00:00

AliasAlreadyTaken added the

4. step/approved

label 2022-08-29 21:09:34 +00:00

AliasAlreadyTaken commented

2022-08-29 21:12:39 +00:00

I see no point in keeping them, since we aim for a different repair mechanic

flux removed the

4. step/want approval

label 2022-08-30 01:42:50 +00:00

flux commented

2022-08-30 02:10:50 +00:00

implemented via fb329b9611

not the most straightforward way of disabling it, but it works.

implemented via https://gitea.your-land.de/your-land/yl_commons/commit/fb329b96119b1326396ae2c457cd4b0448ed73a3 not the most straightforward way of disabling it, but it works.

flux added the

4. step/ready to QA test

label 2022-08-30 02:10:59 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2022-08-31 00:37:58 +00:00

flux removed this from the flux's TODO list project 2022-08-31 00:38:00 +00:00

AliasAlreadyTaken was unassigned by flux

2022-08-31 00:38:02 +00:00

flux removed their assignment 2022-08-31 00:38:02 +00:00