Sokomine reports: now that the trash slot is gon ... #4155

New Issue

yourland-report · 2023-04-10T17:30:42Z

yourland-report commented

2023-04-10 17:30:42 +00:00

Sokomine reports a bug:

now that the trash slot is gone (even though hopefully temporally only), we ought to have a way to give books back that we've read

Player position:

{
	x = 1996.3410644531,
	z = 1154.0539550781,
	y = 14.5
}

Player look:

{
	x = 0.82424801588058,
	z = 0.3004906475544,
	y = -0.47991725802422
}

Player information:

{
	lang_code = "",
	formspec_version = 6,
	protocol_version = 41,
	state = "Active",
	minor = 8,
	min_rtt = 0.01799999922514,
	avg_rtt = 0.018999999389052,
	max_rtt = 13.77799987793,
	max_jitter = 13.727000236511,
	avg_jitter = 0,
	connection_uptime = 9417,
	serialization_version = 29,
	patch = 0,
	version_string = "5.8.0-dev-4a742be73-dirty",
	ip_version = 6,
	min_jitter = 0,
	major = 5
}

Player meta:

{
	fields = {
		inflicted_damage = "4625078",
		hud_state = "on",
		bitten = "0",
		["stamina:poisoned"] = "no",
		repellant = "0",
		["ocean_build.last_warning"] = "1.65032e+09",
		["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 400\", \"shields:shield_rainbow 1 232\", \"3d_armor:chestplate_crystal 1 400\", \"3d_armor:boots_crystal 1 580\", \"3d_armor:leggings_crystal 1 400\"}",
		["ocean_build.ocean_built"] = "5",
		yl_commons_thankyou = "371",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}",
		["ethereal:fly_timer"] = "-99",
		crafted = "536464",
		["stamina:level"] = "12",
		partychat = "main",
		arenalib_infobox_arenaID = "0",
		played_time = "12798370",
		digged_nodes = "1781345",
		placed_nodes = "300818",
		yl_commons_player_created = "1617905120",
		yl_commons_player_joined = "1681138449",
		["signslib:pos"] = "(2247,-164,1417)",
		["stamina:exhaustion"] = "83.5",
		yl_church = "return {[\"last_death_portal\"] = 1680366715, [\"last_death\"] = {[\"x\"] = 2943, [\"z\"] = 498, [\"y\"] = 78}, [\"last_heal\"] = 1673909657}",
		xp = "2006483",
		died = "41",
		punch_count = "222941",
		jointime = "1617905120"
	}
}

Log identifier


[MOD] yl_report log identifier = FNhuF0qlSmiDQPPk6EN4Et9gwYyZlBZx

Profiler save:

profile-20230410T173042.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10d 14h 23min 35s | max lag: 1.46s | clients (32/52): AliasAlreadyTaken, Amanda, AriellesWish, arual, Bailiff, bizon, BobaCat, Boot, copper248, darealbang, daydream, drgn, Ente, flux, FullmetalBOI, JeCel, johanlegend, labrat, Lupercus, MineWorlds, Murmel, niceride, pedro_natalandia1, PikaPika21, rewired_X, Service, shanish3, Sokomine, Syslog, Sysmatic, tour, Traube

Teleport command:

/teleport xyz 1996 15 1154

Compass command:

/give_compass Construction FNhuF0qlSmiDQPPk6EN4Et9gwYyZlBZx D2691E 1996 15 1154

Sokomine reports a bug: > now that the trash slot is gone (even though hopefully temporally only), we ought to have a way to give books back that we've read Player position: ``` { x = 1996.3410644531, z = 1154.0539550781, y = 14.5 } ``` Player look: ``` { x = 0.82424801588058, z = 0.3004906475544, y = -0.47991725802422 } ``` Player information: ``` { lang_code = "", formspec_version = 6, protocol_version = 41, state = "Active", minor = 8, min_rtt = 0.01799999922514, avg_rtt = 0.018999999389052, max_rtt = 13.77799987793, max_jitter = 13.727000236511, avg_jitter = 0, connection_uptime = 9417, serialization_version = 29, patch = 0, version_string = "5.8.0-dev-4a742be73-dirty", ip_version = 6, min_jitter = 0, major = 5 } ``` Player meta: ``` { fields = { inflicted_damage = "4625078", hud_state = "on", bitten = "0", ["stamina:poisoned"] = "no", repellant = "0", ["ocean_build.last_warning"] = "1.65032e+09", ["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 400\", \"shields:shield_rainbow 1 232\", \"3d_armor:chestplate_crystal 1 400\", \"3d_armor:boots_crystal 1 580\", \"3d_armor:leggings_crystal 1 400\"}", ["ocean_build.ocean_built"] = "5", yl_commons_thankyou = "371", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}", ["ethereal:fly_timer"] = "-99", crafted = "536464", ["stamina:level"] = "12", partychat = "main", arenalib_infobox_arenaID = "0", played_time = "12798370", digged_nodes = "1781345", placed_nodes = "300818", yl_commons_player_created = "1617905120", yl_commons_player_joined = "1681138449", ["signslib:pos"] = "(2247,-164,1417)", ["stamina:exhaustion"] = "83.5", yl_church = "return {[\"last_death_portal\"] = 1680366715, [\"last_death\"] = {[\"x\"] = 2943, [\"z\"] = 498, [\"y\"] = 78}, [\"last_heal\"] = 1673909657}", xp = "2006483", died = "41", punch_count = "222941", jointime = "1617905120" } } ``` Log identifier ``` [MOD] yl_report log identifier = FNhuF0qlSmiDQPPk6EN4Et9gwYyZlBZx ``` Profiler save: ``` profile-20230410T173042.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10d 14h 23min 35s | max lag: 1.46s | clients (32/52): AliasAlreadyTaken, Amanda, AriellesWish, arual, Bailiff, bizon, BobaCat, Boot, copper248, darealbang, daydream, drgn, Ente, flux, FullmetalBOI, JeCel, johanlegend, labrat, Lupercus, MineWorlds, Murmel, niceride, pedro_natalandia1, PikaPika21, rewired_X, Service, shanish3, Sokomine, Syslog, Sysmatic, tour, Traube ``` Teleport command: ``` /teleport xyz 1996 15 1154 ``` Compass command: ``` /give_compass Construction FNhuF0qlSmiDQPPk6EN4Et9gwYyZlBZx D2691E 1996 15 1154 ```

👍 1

AliasAlreadyTaken was assigned by yourland-report

2023-04-10 17:30:42 +00:00

daydream commented

2023-04-10 17:40:34 +00:00

I have to review each and every book turned in to the library to make sure I don't have it already because there's no 'new' flag and even if there was - why should I have to delete all the books for the players just to roleplay returning a library book?

We could try 'new books only' and 'returned books' could be a camouflaged trash can... but if someone is turning in a book and does the wrong one - we'll never hear the end of it.

Maybe a red X on the book somewhere to 'go to book heaven' or something lol IDK but returning has issues. We'll have to think pretty far outside the box on this one.

I have to review each and every book turned in to the library to make sure I don't have it already because there's no 'new' flag and even if there was - why should I have to delete all the books for the players just to roleplay returning a library book? We could try 'new books only' and 'returned books' could be a camouflaged trash can... but if someone is turning in a book and does the wrong one - we'll never hear the end of it. Maybe a red X on the book somewhere to 'go to book heaven' or something lol IDK but returning has issues. We'll have to think pretty far outside the box on this one.

Sokomine commented

2023-04-10 19:04:48 +00:00

Daydream has a very valid point. The idea was to have a special trash can disguised as a bookshelf so that players could "return" the books so that they'd automaticly get trashed.

Players putting new books in there and believing that's the right way to forward them to the library like daydream mentionned could be a big problem. My idea seems too risky then.

Daydream has a very valid point. The idea was to have a special trash can disguised as a bookshelf so that players could "return" the books so that they'd automaticly get trashed. Players putting new books in there and believing that's the right way to forward them to the library like daydream mentionned could be a big problem. My idea seems too risky then.

AliasAlreadyTaken commented

2023-04-10 20:03:43 +00:00

We'll bring back the old trashcan with the next server restart, until we have a replacement.

🎉 2

AliasAlreadyTaken added the

3. source/ingame

1. kind/enhancement

labels 2023-04-10 20:04:00 +00:00

flux commented

2023-04-12 03:04:37 +00:00

the accidental trash button removal seems to have gotten reset before i even noticed. i'd still like it if there was a dedicated trash "tab" in unified inventory, which had a limited undo functionality. cf. #2323

EDIT: this is the sort of thing i could write up in a day, perhaps i need to get my priorities straight.

the accidental trash button removal seems to have gotten reset before i even noticed. i'd still like it if there was a dedicated trash "tab" in unified inventory, which had a limited undo functionality. cf. #2323 EDIT: this is the sort of thing i could write up in a day, perhaps i need to get my priorities straight.

AliasAlreadyTaken commented

2023-04-12 18:52:56 +00:00

This is a good issue for a new developer. In fact, TheTrueBeginner started on this one already.

Issue here: #4077

Repo here: https://gitea.your-land.de/your-land/yl_unified_trash

This is a good issue for a new developer. In fact, TheTrueBeginner started on this one already. Issue here: #4077 Repo here: https://gitea.your-land.de/your-land/yl_unified_trash

👍 1

AliasAlreadyTaken commented

2023-04-25 14:28:12 +00:00

yl_unified_trash was implemented by yo_hi and delivered with 1.1.118

Giving books back would soon result in more copies than we can ever check. Closing this in favour of the new trashcan.

yl_unified_trash was implemented by yo_hi and delivered with 1.1.118 Giving books back would soon result in more copies than we can ever check. Closing this in favour of the new trashcan.

AliasAlreadyTaken closed this issue

2023-04-25 14:28:12 +00:00

AliasAlreadyTaken added the

5. result/fixed

label 2023-04-25 14:28:20 +00:00

flux commented

2023-04-27 19:08:22 +00:00

Giving books back would soon result in more copies than we can ever check. Closing this in favour of the new trashcan.

we can just use a tubelib trashcan and put a sign on it that says "book return"

> Giving books back would soon result in more copies than we can ever check. Closing this in favour of the new trashcan. we can just use a tubelib trashcan and put a sign on it that says "book return"

Sign in to join this conversation.