Replace trash of unified inventory #4077

New Issue

AliasAlreadyTaken · 2023-03-28T04:54:30Z

AliasAlreadyTaken commented

2023-03-28 04:54:30 +00:00

There are multiple incidents where a player would trash items by accident due to a client bug.

Affected issues:

#3954 #3373 #2323 and a couple of not reported incidents where players trashed valuables. Lucky there seems not to have been an incident where someone would have trashed a unique item, but its only a matter of time (or even attention).

Short term solution is to disable the trashcan of unified inventory.

Medium term solution is to create a trashcan page in unified inventory of sorts.

Long term solution is only additional to the medium term solution: Fix that darn upstream issue.

There are multiple incidents where a player would trash items by accident due to a client bug. Affected issues: #3954 #3373 #2323 and a couple of not reported incidents where players trashed valuables. Lucky there seems not to have been an incident where someone would have trashed a unique item, but its only a matter of time (or even attention). Short term solution is to disable the trashcan of unified inventory. Medium term solution is to create a trashcan page in unified inventory of sorts. Long term solution is only additional to the medium term solution: Fix that darn upstream issue.

AliasAlreadyTaken added the

1. kind/enhancement

2. prio/elevated

2. prio/good first issue

labels 2023-03-28 04:54:45 +00:00

niceride commented

2023-03-28 04:57:17 +00:00

I would like trashcan to become a 1-item storage area where if you drag something into it, the previous item that was in the trashcan storage slot is trashed; If you take something out of the trashcan, then the trashcan is empty and you get your thing back from the trash. I would want this even if the upstream bug gets fixed.

AliasAlreadyTaken commented

2023-03-28 05:00:07 +00:00

My preferred solution would be this:

Remove the trashcan slot.
Add a button where the trashcan slot is now.
Let this button open a new unified inventory page called trashcan.
Let this trashcan page have four itemslots and a flush button.
Allow users to move items between their main inventory back and forth between the trashcan and the inventory.
Let the flush button remove all items in the itemslots premanently.
Add the trashcan items to the bones.
Log all items trashed in this way.

Bonus points if the previous trashcan slot remains and causes the items dragged into it not get removed permanently, but sent to the trashcan inventory to be flushed after review.

My preferred solution would be this: Remove the trashcan slot. Add a button where the trashcan slot is now. Let this button open a new unified inventory page called trashcan. Let this trashcan page have four itemslots and a flush button. Allow users to move items between their main inventory back and forth between the trashcan and the inventory. Let the flush button remove all items in the itemslots premanently. Add the trashcan items to the bones. Log all items trashed in this way. Bonus points if the previous trashcan slot remains and causes the items dragged into it not get removed permanently, but sent to the trashcan inventory to be flushed after review.

flux commented

2023-03-28 16:25:01 +00:00

config setting to disable the trashcan:
b2cc3d1532/settingtypes.txt (L9-L11)

config setting to disable the trashcan: https://github.com/minetest-mods/unified_inventory/blob/b2cc3d15320aabc9df0d6d90e22e7661099dbb8a/settingtypes.txt#L9-L11

👍 1

daydream commented

2023-03-31 09:59:42 +00:00

Disabling trash is a bit of an overreaction - which we'll be explaining every 5 minutes 24/7 for how long? Meanwhile IF and WHEN someone did accidentally delete something it was a matter of checking log and giving it back... we really couldn't have just kept doing that until the update was coded?

Q-dropping trash is pretty hard for anyone with OCD

Disabling trash is a bit of an overreaction - which we'll be explaining every 5 minutes 24/7 for how long? Meanwhile IF and WHEN someone did accidentally delete something it was a matter of checking log and giving it back... we really couldn't have just kept doing that until the update was coded? Q-dropping trash is pretty hard for anyone with OCD

daydream commented

2023-04-12 17:33:07 +00:00

What I'd love to see is you can delete whatever and if you click the trash can you see a window with 4 slots containing the last 4 things you threw away. At this point you can drag any of the last 4 things back into inventory from the trash. So it's a review of your last 4 trash items by icon and stack number.

This is true 'review' and undo after the fact, not just extra clicks.

I want to throw things out just like old trash... drag the trash and it's over. I want to review the trash by clicking on it instead of dragging on it. At that point you have review and retrieval options to drag something back out with the last 4 icons including stack number displayed.

Otherwise it's just double-throwing out instead of review/retrieval and sometimes you just need to throw something out very quickly, for sure. I don't see a need for another click in a different part of the screen at all. If it's just for review and retrieval, no extra click is needed, if that makes sense.

What I'd love to see is you can delete whatever and if you click the trash can you see a window with 4 slots containing the last 4 things you threw away. At this point you can drag any of the last 4 things back into inventory from the trash. So it's a review of your last 4 trash items by icon and stack number. This is true 'review' and undo after the fact, not just extra clicks. I want to throw things out just like old trash... drag the trash and it's over. I want to review the trash by clicking on it instead of dragging on it. At that point you have review and retrieval options to drag something back out with the last 4 icons including stack number displayed. Otherwise it's just double-throwing out instead of review/retrieval and sometimes you just need to throw something out very quickly, for sure. I don't see a need for another click in a different part of the screen at all. If it's just for review and retrieval, no extra click is needed, if that makes sense.

👍 2

AliasAlreadyTaken referenced this issue

2023-04-12 18:52:56 +00:00

Sokomine reports: now that the trash slot is gon ... #4155

AliasAlreadyTaken referenced this issue

2023-04-13 01:15:05 +00:00

1.1.118 #3401

flux commented

2023-04-14 01:32:02 +00:00

i like daydream's proposal at least as much as what i discussed in #2323, i'll get around to this someday, but probably not soon.

👍 2

AliasAlreadyTaken commented

2023-04-14 02:00:35 +00:00

This is the result so far: https://gitea.your-land.de/your-land/yl_unified_trash

It's on the testserver and if there are no terrible errors, we'll roll it out together with 1.1.118

This is the result so far: https://gitea.your-land.de/your-land/yl_unified_trash It's on the testserver and if there are no terrible errors, we'll roll it out together with 1.1.118

👍 1

AliasAlreadyTaken referenced this issue

2023-04-14 02:07:29 +00:00

JeCel reports: Maybe add a button with which ... #2323

AliasAlreadyTaken added this to the 1.1.118 milestone 2023-04-14 02:07:44 +00:00

daydream commented

2023-04-14 10:19:58 +00:00

new trash is wonderful, yo_hi did a great job - everyone go test!

niceride commented

2023-04-14 18:55:13 +00:00

I tried some things to break it, seems stable. Not being able to drag things into the new trash icon is not-intuitive. I would say for consistency that there should be a way to click on trash and have the trash action be an option as well as rummaging through it. Also having a 2x2 grid does not make it clear what the stacking order is of items in the queue for trash. I think it should be limited to 1-3 items no more than three; if there's a way to make the trash visible from crafting, bags, and armor views (anywhere there would be an inventory on view) then the need for a trash button is removed, it can just exist anywhere. That button space is extremely valuable and will be needed in future updates to Your Land.

👍 1

AliasAlreadyTaken commented

2023-04-16 11:31:52 +00:00

Add logging. Each removed item must go to the log. Each time an item switches inventory, there needs to be logging.
Configure to 1x4, so that it is clear which item gets tossed first
Add the trashcan to the bags, so that it is available from every page where there's inventory.
Allow dragdrop from main inv to trashcan. Optional: Use listrings for shift+click

* [x] Add logging. Each removed item must go to the log. Each time an item switches inventory, there needs to be logging. * [x] Configure to 1x4, so that it is clear which item gets tossed first * [x] Add the trashcan to the bags, so that it is available from every page where there's inventory. * [x] Allow dragdrop from main inv to trashcan. Optional: Use listrings for shift+click

👍 2

AliasAlreadyTaken added the

ugh/QA OK

label 2023-04-17 14:43:52 +00:00

flux added the

5. result/fixed

label 2023-04-26 00:28:58 +00:00

flux commented

2023-04-26 00:32:53 +00:00

this is live. i'm quite happy w/ how it works.

flux closed this issue

2023-04-26 00:32:53 +00:00