JeCel reports: Maybe add a button with which ... #2323

Closed
opened 2022-07-26 18:03:50 +00:00 by yourland-report · 8 comments

JeCel reports a bug:

Maybe add an potion a button with which you can get back the last item you threw away? Because I (and others probably too) often happen to accidently throw away the wron item, when throwing away things fast, or because lag causes an item mix up. I jsut lost my mithril axe this way :(

Player position:

{
	y = 40.5,
	z = 10412.970703125,
	x = 6772.0185546875
}

Player look:

{
	y = -0.25021103024483,
	z = -0.8394912481308,
	x = -0.48233690857887
}

Player information:

{
	avg_jitter = 0.012000001966953,
	connection_uptime = 11574,
	serialization_version = 28,
	patch = 1,
	lang_code = "",
	formspec_version = 4,
	protocol_version = 39,
	major = 5,
	minor = 4,
	version_string = "5.4.1",
	state = "Active",
	ip_version = 6,
	min_rtt = 0.028000000864267,
	max_rtt = 1.2150000333786,
	avg_rtt = 0.045000001788139,
	min_jitter = 0,
	max_jitter = 1.1660000085831
}

Player meta:

{
	fields = {
		["stamina:level"] = "17",
		["stamina:poisoned"] = "no",
		["ocean_build.ocean_built"] = "6",
		repellant = "0",
		yl_commons_thankyou = "27",
		jointime = "1621787993",
		bitten = "0",
		arenalib_infobox_arenaID = "0",
		punch_count = "17990",
		inflicted_damage = "349076",
		xp = "1140263",
		placed_nodes = "154616",
		yl_commons_player_joined = "1658847075",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 1300\", \"3d_armor:chestplate_crystal 1 1300\", \"3d_armor:leggings_crystal 1 1300\", \"3d_armor:boots_crystal 1 2480\", \"shields:shield_crystal 1 1300\", \"\"}",
		["signslib:pos"] = "(6682,-33,10397)",
		partychat = "main",
		["stamina:exhaustion"] = "58",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		played_time = "1637357",
		digged_nodes = "817239",
		xp_redo_hud_color = "0x99ffff",
		yl_commons_player_created = "1621787993",
		crafted = "270803",
		hud_state = "on",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 110, [\"x\"] = 1388, [\"z\"] = 521}, [\"last_death_portal\"] = 1655937668}",
		died = "18",
		["ocean_build.last_warning"] = "1.65313e+09"
	}
}

Log identifier


[MOD] yl_report log identifier = PKoV2KgS2MGMsrL42HZvfmLkwSxBVyU5

Profiler save:

profile-20220726T180349.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 13h 11min 33s | max lag: 0.977s | clients: jrk, shanish, NikolaiGamer, Giuseppe, Mielle, Worstest, tmfdw, BTS-, flux, JeCel, Bailiff, AliasAlreadyTaken, Service

Teleport command:

/teleport xyz 6772 41 10413

Compass command:

/give_compass Construction PKoV2KgS2MGMsrL42HZvfmLkwSxBVyU5 D2691E 6772 41 10413
JeCel reports a bug: > Maybe add ~~an potion~~ a button with which you can get back the last item you threw away? Because I (and others probably too) often happen to accidently throw away the wron item, when throwing away things fast, or because lag causes an item mix up. I jsut lost my mithril axe this way :( Player position: ``` { y = 40.5, z = 10412.970703125, x = 6772.0185546875 } ``` Player look: ``` { y = -0.25021103024483, z = -0.8394912481308, x = -0.48233690857887 } ``` Player information: ``` { avg_jitter = 0.012000001966953, connection_uptime = 11574, serialization_version = 28, patch = 1, lang_code = "", formspec_version = 4, protocol_version = 39, major = 5, minor = 4, version_string = "5.4.1", state = "Active", ip_version = 6, min_rtt = 0.028000000864267, max_rtt = 1.2150000333786, avg_rtt = 0.045000001788139, min_jitter = 0, max_jitter = 1.1660000085831 } ``` Player meta: ``` { fields = { ["stamina:level"] = "17", ["stamina:poisoned"] = "no", ["ocean_build.ocean_built"] = "6", repellant = "0", yl_commons_thankyou = "27", jointime = "1621787993", bitten = "0", arenalib_infobox_arenaID = "0", punch_count = "17990", inflicted_damage = "349076", xp = "1140263", placed_nodes = "154616", yl_commons_player_joined = "1658847075", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 1300\", \"3d_armor:chestplate_crystal 1 1300\", \"3d_armor:leggings_crystal 1 1300\", \"3d_armor:boots_crystal 1 2480\", \"shields:shield_crystal 1 1300\", \"\"}", ["signslib:pos"] = "(6682,-33,10397)", partychat = "main", ["stamina:exhaustion"] = "58", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", played_time = "1637357", digged_nodes = "817239", xp_redo_hud_color = "0x99ffff", yl_commons_player_created = "1621787993", crafted = "270803", hud_state = "on", yl_church = "return {[\"last_death\"] = {[\"y\"] = 110, [\"x\"] = 1388, [\"z\"] = 521}, [\"last_death_portal\"] = 1655937668}", died = "18", ["ocean_build.last_warning"] = "1.65313e+09" } } ``` Log identifier ``` [MOD] yl_report log identifier = PKoV2KgS2MGMsrL42HZvfmLkwSxBVyU5 ``` Profiler save: ``` profile-20220726T180349.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 13h 11min 33s | max lag: 0.977s | clients: jrk, shanish, NikolaiGamer, Giuseppe, Mielle, Worstest, tmfdw, BTS-, flux, JeCel, Bailiff, AliasAlreadyTaken, Service ``` Teleport command: ``` /teleport xyz 6772 41 10413 ``` Compass command: ``` /give_compass Construction PKoV2KgS2MGMsrL42HZvfmLkwSxBVyU5 D2691E 6772 41 10413 ```
AliasAlreadyTaken was assigned by yourland-report 2022-07-26 18:03:50 +00:00

Would it be possible to get a refund? :(

Would it be possible to get a refund? :(
flux added the
1. kind/bug
1. kind/enhancement
3. source/client
labels 2022-07-26 18:59:37 +00:00
Member

@JeCel the issue w/ dragging wrong items into the trash is due to the fact that minetest registers a click event both when you press the mouse button and when you release it. if you're moving the cursor while clicking on something, it can end up clicking once on one item, and then clicking a second time on another.

i created an upstream issue, because while i've known about this for years, apparently no-one else ever thought about reporting it.

https://github.com/minetest/minetest/issues/12596

adding an "undo" feature to the inventory trashcan has been on my todo list for years, that might be easier...

@JeCel the issue w/ dragging wrong items into the trash is due to the fact that minetest registers a click event both when you press the mouse button and when you release it. if you're moving the cursor while clicking on something, it can end up clicking once on one item, and then clicking a second time on another. i created an upstream issue, because while i've known about this for years, apparently no-one else ever thought about reporting it. https://github.com/minetest/minetest/issues/12596 adding an "undo" feature to the inventory trashcan has been on my todo list for years, that might be easier...
flux added this to the flux's TODO list project 2022-07-26 21:38:05 +00:00
AliasAlreadyTaken was unassigned by flux 2022-07-26 21:38:13 +00:00
flux self-assigned this 2022-07-26 21:38:13 +00:00

Maybe add an potion with which you can get back the last item you threw away? Because I

I just realized that I wrote potion. Of course I meant button...

@flux Ah, that definitely explains that behavior. It's really frustrating

> > Maybe add an potion with which you can get back the last item you threw away? Because I I just realized that I wrote potion. Of course I meant button... @flux Ah, that definitely explains that behavior. It's really frustrating
Member
upstream issue: https://github.com/minetest-mods/unified_inventory/issues/186

Now I want to implement a wayback-potion :D

Maybe we should throw out the trashcan. So far it lead to more trouble than good. If people really want to throw away things, they can simply drag them out of their inventory and wait for them to despawn.

This kind of includes a way back: You can anytime pick up what you threw out again.

Another benefit: There's already a setting to disable the trashcan.

unified_inventory_trash (Enable trash) bool true

Now I want to implement a wayback-potion :D Maybe we should throw out the trashcan. So far it lead to more trouble than good. If people really want to throw away things, they can simply drag them out of their inventory and wait for them to despawn. This kind of includes a way back: You can anytime pick up what you threw out again. Another benefit: There's already a setting to disable the trashcan. unified_inventory_trash (Enable trash) bool true
Member

unified_inventory_trash (Enable trash) bool true

worth trying. i guarantee that players will complain about that too, but if they're really upset, we can just re-enable it.

we could also create a trash-can node. there seems to be one in this mod https://content.minetest.net/packages/Evergreen/trash_can/ but we'd have to disable the dumpster.

> unified_inventory_trash (Enable trash) bool true worth trying. i guarantee that players will complain about *that* too, but if they're really upset, we can just re-enable it. we could also create a trash-can node. there seems to be one in this mod https://content.minetest.net/packages/Evergreen/trash_can/ but we'd have to disable the dumpster.
flux changed title from JeCel reports: Maybe add an potion with which ... to JeCel reports: Maybe add a button with which ... 2023-04-12 03:03:50 +00:00

We disabled it, way more players than I could have imagined complained, so we reenabled it until #4077 is ready.

The suggested trashcan mod looks funny, but has the same missclick opportunity.

Let's have this issue deal with the client missclick and explore the trashcan in #4077

We disabled it, way more players than I could have imagined complained, so we reenabled it until #4077 is ready. The suggested trashcan mod looks funny, but has the same missclick opportunity. Let's have this issue deal with the client missclick and explore the trashcan in #4077
Member

closing this as resolved, since we have #4077 now. for reference, the usptream client/engine issue is resolved and should be part of 5.8

closing this as resolved, since we have #4077 now. for reference, the usptream client/engine issue is resolved and should be part of 5.8
flux closed this issue 2023-06-05 19:17:28 +00:00
flux removed this from the flux's TODO list project 2023-06-05 19:17:35 +00:00
flux removed their assignment 2023-06-05 19:17:38 +00:00
flux added the
5. result/fixed
label 2023-06-05 19:17:44 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2323
No description provided.