flux reports: quicksand (from ethereal) shou ... #2163

New Issue

yourland-report · 2022-07-05T01:50:50Z

yourland-report commented

2022-07-05 01:50:50 +00:00

flux reports a bug:

quicksand (from ethereal) should fall, i think

Player position:

{
	y = -7840.6650390625,
	x = 1550.3139648438,
	z = 749.83599853516
}

Player look:

{
	y = 0.78618061542511,
	x = 0.37587031722069,
	z = -0.49055230617523
}

Player information:

{
	min_rtt = 0.15800000727177,
	max_rtt = 10.46399974823,
	connection_uptime = 111239,
	max_jitter = 10.297999382019,
	minor = 6,
	major = 5,
	ip_version = 6,
	formspec_version = 5,
	patch = 0,
	protocol_version = 40,
	serialization_version = 29,
	lang_code = "",
	version_string = "5.6.0-dev-874bb40be-dirty",
	avg_rtt = 0.17200000584126,
	state = "Active",
	avg_jitter = 0.0010000020265579,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_nether 1 6400\", \"nether_mobs:dragon_shield 1 3200\", \"3d_armor:helmet_nether 1 3200\", \"nether_mobs:dragon_boots 1 3200\", \"3d_armor:leggings_nether 1 6400\", \"\"}",
		["petz:werewolf_vignette_id"] = "20",
		yl_commons_thankyou = "126",
		jointime = "1615351173",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "26",
		["signslib:pos"] = "(1290,63,550)",
		digged_nodes = "1060778",
		placed_nodes = "347038",
		yl_commons_player_joined = "1656874633",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		xp = "1235816",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 48, [\"x\"] = 1289, [\"z\"] = 624}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}",
		played_time = "18950551",
		["stamina:level"] = "15",
		punch_count = "79878",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "1289862",
		crafted = "38423",
		["petz:werewolf_clan_idx"] = "1",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:werewolf"] = "0",
		died = "66",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1615351173"
	}
}

Log identifier


[MOD] yl_report log identifier = ElMs3vrxsnIAFySRF8K3oX7qNAxHUATa

Profiler save:

profile-20220705T035050.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 11d 12h 54min 2s | max lag: 2.38s | clients: evil123, digdeep, AspireMint, Service, AliasAlreadyTaken, jackofthebean000, Queenfire234312, Bailiff, pitman, set, LeetPeet, flux

Teleport command:

/teleport xyz 1550 -7841 750

Compass command:

/give_compass Construction ElMs3vrxsnIAFySRF8K3oX7qNAxHUATa D2691E 1550 -7841 750

flux reports a bug: > quicksand (from ethereal) should fall, i think Player position: ``` { y = -7840.6650390625, x = 1550.3139648438, z = 749.83599853516 } ``` Player look: ``` { y = 0.78618061542511, x = 0.37587031722069, z = -0.49055230617523 } ``` Player information: ``` { min_rtt = 0.15800000727177, max_rtt = 10.46399974823, connection_uptime = 111239, max_jitter = 10.297999382019, minor = 6, major = 5, ip_version = 6, formspec_version = 5, patch = 0, protocol_version = 40, serialization_version = 29, lang_code = "", version_string = "5.6.0-dev-874bb40be-dirty", avg_rtt = 0.17200000584126, state = "Active", avg_jitter = 0.0010000020265579, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_nether 1 6400\", \"nether_mobs:dragon_shield 1 3200\", \"3d_armor:helmet_nether 1 3200\", \"nether_mobs:dragon_boots 1 3200\", \"3d_armor:leggings_nether 1 6400\", \"\"}", ["petz:werewolf_vignette_id"] = "20", yl_commons_thankyou = "126", jointime = "1615351173", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "26", ["signslib:pos"] = "(1290,63,550)", digged_nodes = "1060778", placed_nodes = "347038", yl_commons_player_joined = "1656874633", bitten = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", xp = "1235816", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 48, [\"x\"] = 1289, [\"z\"] = 624}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}", played_time = "18950551", ["stamina:level"] = "15", punch_count = "79878", arenalib_infobox_arenaID = "0", inflicted_damage = "1289862", crafted = "38423", ["petz:werewolf_clan_idx"] = "1", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:werewolf"] = "0", died = "66", hud_state = "on", repellant = "0", yl_commons_player_created = "1615351173" } } ``` Log identifier ``` [MOD] yl_report log identifier = ElMs3vrxsnIAFySRF8K3oX7qNAxHUATa ``` Profiler save: ``` profile-20220705T035050.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 11d 12h 54min 2s | max lag: 2.38s | clients: evil123, digdeep, AspireMint, Service, AliasAlreadyTaken, jackofthebean000, Queenfire234312, Bailiff, pitman, set, LeetPeet, flux ``` Teleport command: ``` /teleport xyz 1550 -7841 750 ``` Compass command: ``` /give_compass Construction ElMs3vrxsnIAFySRF8K3oX7qNAxHUATa D2691E 1550 -7841 750 ```

AliasAlreadyTaken was assigned by yourland-report

2022-07-05 01:50:50 +00:00

flux added the

1. kind/balancing

label 2022-07-05 02:51:46 +00:00

flux added this to the flux's TODO list project 2022-07-05 02:51:59 +00:00

AliasAlreadyTaken commented

2022-08-07 09:01:46 +00:00

It does not?!

flux commented

2022-08-07 23:38:14 +00:00

trivial to fix, however when i was testing the fix, i realized that part of the buggy nature minetest's falling nodes creates a new bug. falling nodes will fall into things which aren't solid and replace them, often times without even leaving a drop (and see #1820). i'm honestly unsure what triggers some things to leave a drop and others not to - quicksand doesn't leave a drop, but e.g. flowers and sleeping mats do.

however you can still create a pillar of quicksand, just be careful not to mix the 2 kinds (why are there 2 kinds? i remember there being "one natural" and "one craftable", it seems the natural one is the craftable one here and the other is unused?)

trivial to fix, however when i was testing the fix, i realized that part of the buggy nature minetest's falling nodes creates a new bug. falling nodes will fall *into* things which aren't solid and replace them, often times without even leaving a drop (and see #1820). i'm honestly unsure what triggers some things to leave a drop and others not to - quicksand doesn't leave a drop, but e.g. flowers and sleeping mats do. however you *can* still create a pillar of quicksand, just be careful not to mix the 2 kinds (why are there 2 kinds? i remember there being "one natural" and "one craftable", it seems the natural one is the craftable one here and the other is unused?)

AliasAlreadyTaken commented

2022-08-08 05:21:48 +00:00

Just pretend I commented each of your findings with "wtf? What a mess!"

Question is, what do we do with it? This sounds like yet another rabbithole a certain flux would be very eager to fix, once we came to a "this is how it should be".

In such weird "do not touch code" cases I'd go to the developer, if available, and ask what this was about and if it is necessary still.

The solution looks like and attempt we discussed with the treetrunks: One mapgen and one to be placed. But in the case of quicksand: Done wrong. Or quicksand (in contrast to quicksand2) is some legacy block, not to be used anymore?

The engine bug is yet another problem, let's deal with it in the issue you referred to.

So, what do we do here?

Quicksand should fall, like the other sand. Making it fall does not create a new bug, but adds yet another member to an already buggy mechanic.
The replacement problem exists, independent of whether we fix the quicksand problem or not. We shall deal with it in a general upstream fix.
quicksand2 is craftable, while also used in mapgen. That's something only Tenplus1 can reveal to us. He's hard to catch, but I'll try to ask him.

"Did I forget somthing?", asked the Alias while swimming in a floating quicksand bridge. Maybe we need a "WTF?!" label ...

Just pretend I commented each of your findings with "wtf? What a mess!" Question is, what do we do with it? This sounds like yet another rabbithole a certain flux would be very eager to fix, once we came to a "this is how it should be". In such weird "do not touch code" cases I'd go to the developer, if available, and ask what this was about and if it is necessary still. The solution looks like and attempt we discussed with the treetrunks: One mapgen and one to be placed. But in the case of quicksand: Done wrong. Or quicksand (in contrast to quicksand2) is some legacy block, not to be used anymore? The engine bug is yet another problem, let's deal with it in the issue you referred to. So, what do we do here? 1. Quicksand should fall, like the other sand. Making it fall does not create a new bug, but adds yet another member to an already buggy mechanic. 2. The replacement problem exists, independent of whether we fix the quicksand problem or not. We shall deal with it in a general upstream fix. 3. quicksand2 is craftable, while also used in mapgen. That's something only Tenplus1 can reveal to us. He's hard to catch, but I'll try to ask him. "Did I forget somthing?", asked the Alias while swimming in a floating quicksand bridge. Maybe we need a "WTF?!" label ...

flux commented

2022-08-08 18:29:56 +00:00

added quicksand to the falling_node group in yl_commons 4537e58ec0
the logic of it disappearing actually seems to be because quicksand is a liquid, and was actually already a problem before it became a falling node. i'm going to do some tests, but i think it might have to remain a liquid in order to preserve the "player slowly sinks into the node" effect. however, spiderwebs exist too...
i looked at the source code, which has the following comments:

-- Quicksand (old style, sinking inside shows black instead of yellow effect,
-- works ok with noclip enabled though)
minetest.register_node("ethereal:quicksand", {
...
})

-- Quicksand (new style, sinking inside shows yellow effect with or without noclip,
-- but old quicksand is shown as black until block placed nearby to update light)
minetest.register_node("ethereal:quicksand2", {
...
})

so Tenplus1 has a reason, though i don't know if we have a reason. i could force-alias one to the other.

1. added quicksand to the `falling_node` group in `yl_commons` https://gitea.your-land.de/your-land/yl_commons/commit/4537e58ec0186a872b98713156911070481ecffc 2. the logic of it disappearing actually seems to be because quicksand is a *liquid*, and was actually already a problem before it became a falling node. i'm going to do some tests, but i think it might have to remain a liquid in order to preserve the "player slowly sinks into the node" effect. however, spiderwebs exist too... 3. i looked at the source code, which has the following comments: ```lua -- Quicksand (old style, sinking inside shows black instead of yellow effect, -- works ok with noclip enabled though) minetest.register_node("ethereal:quicksand", { ... }) -- Quicksand (new style, sinking inside shows yellow effect with or without noclip, -- but old quicksand is shown as black until block placed nearby to update light) minetest.register_node("ethereal:quicksand2", { ... }) ``` so Tenplus1 has a reason, though i don't know if *we* have a reason. i could force-alias one to the other.

flux commented

2022-08-08 19:08:22 +00:00

spiderwebs (both petz and mobs_monster, as well as homedecor) are also liquids O_O
quicksand works absolutely fine as a non-liquid if move_resistance is set instead of viscosity. perhaps it even works better - you don't just sink to your waist, you keep sinking forever, you can't swim down. however, the "pitch move to get out" trick no-longer works.
falling nodes still fall into quicksand (and dropping a quicksand into a stack of quicksand destroys the entire stack), but at least the nodes drop as items.

* spiderwebs (both petz and mobs_monster, as well as homedecor) are also liquids O_O * quicksand works absolutely fine as a non-liquid if `move_resistance` is set instead of `viscosity`. perhaps it even works better - you don't just sink to your waist, you keep sinking forever, you can't swim down. however, the "pitch move to get out" trick no-longer works. * falling nodes still fall *into* quicksand (and dropping a quicksand into a stack of quicksand destroys the *entire stack*), but at least the nodes drop as items.

flux commented

2022-08-08 19:38:19 +00:00

got distracted setting move_resistance to values much larger than it's supposed to be, and watching things get weird

got distracted setting `move_resistance` to values much larger than it's supposed to be, and watching things get *weird*

flux added the

4. step/ready to QA test

label 2022-08-08 21:26:04 +00:00

flux commented

2022-08-08 21:27:53 +00:00

let's have this issue just track the "quicksand as a falling node" issue, i'll make other issues for the other things

flux self-assigned this 2022-08-08 22:02:20 +00:00

AliasAlreadyTaken commented