Flatulenator reports: If sand falls on your bones ju ... #1820

New Issue

yourland-report · 2022-04-24T05:40:53Z

yourland-report commented

2022-04-24 05:40:53 +00:00

Flatulenator reports a bug:

If sand falls on your bones just as you die, your bones disappear

Player position:

{
	y = -25123.5,
	x = -30000.09765625,
	z = -29999.84375
}

Player look:

{
	y = -0.93035358190536,
	x = -0.059506636112928,
	z = 0.36180272698402
}

Player information:

{
	min_rtt = 0.14399999380112,
	max_rtt = 2.5030000209808,
	connection_uptime = 14876,
	max_jitter = 2.3340001106262,
	minor = 1,
	major = 5,
	ip_version = 6,
	formspec_version = 2,
	patch = 1,
	protocol_version = 38,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.1.1",
	avg_rtt = 0.15700000524521,
	state = "Active",
	avg_jitter = 0.0059999972581863,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		played_time = "499558",
		["ocean_build.ocean_built"] = "3",
		jointime = "1648785584",
		yl_commons_player_joined = "1650764022",
		["stamina:exhaustion"] = "27",
		["signslib:pos"] = "(2,2,-30911)",
		digged_nodes = "85805",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_commons_thankyou = "9",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -25140, [\"x\"] = -30000, [\"z\"] = -30000}, [\"last_heal\"] = 1648878609, [\"last_death_portal\"] = 1650778499}",
		died = "135",
		["stamina:level"] = "11",
		punch_count = "15594",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "283596",
		crafted = "751",
		["stamina:poisoned"] = "no",
		["ocean_build.last_warning"] = "1.65061e+09",
		xp = "58795",
		placed_nodes = "6698",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1648785584"
	}
}

Log identifier


[MOD] yl_report log identifier = jjrsD2VMvDXkaHGN7FGIRYsvgTHdQDpB

Profiler save:

profile-20220424T074052.json_prettyEE

Status:

# Server: version: 5.5.0-yl | game: Minetest Game | uptime: 20h 31min 51s | max lag: 5.01s | clients: meow132, ltr, rohit, tog2, Giuseppe, Kilarin, jackofthebean000, DreamNotFound, Coolstorms, TheSingingBee, Flatulenator, slayer, AliasAlreadyTaken, bluattire, Oakenshield, Futureismine, Ryanthegirl, Service, pitman, flux, Aleks555, Bailiff

Teleport command:

/teleport xyz -30000 -25124 -30000

Compass command:

/give_compass Construction jjrsD2VMvDXkaHGN7FGIRYsvgTHdQDpB D2691E -30000 -25124 -30000

Flatulenator reports a bug: > If sand falls on your bones just as you die, your bones disappear Player position: ``` { y = -25123.5, x = -30000.09765625, z = -29999.84375 } ``` Player look: ``` { y = -0.93035358190536, x = -0.059506636112928, z = 0.36180272698402 } ``` Player information: ``` { min_rtt = 0.14399999380112, max_rtt = 2.5030000209808, connection_uptime = 14876, max_jitter = 2.3340001106262, minor = 1, major = 5, ip_version = 6, formspec_version = 2, patch = 1, protocol_version = 38, serialization_version = 28, lang_code = "", version_string = "5.1.1", avg_rtt = 0.15700000524521, state = "Active", avg_jitter = 0.0059999972581863, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", played_time = "499558", ["ocean_build.ocean_built"] = "3", jointime = "1648785584", yl_commons_player_joined = "1650764022", ["stamina:exhaustion"] = "27", ["signslib:pos"] = "(2,2,-30911)", digged_nodes = "85805", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_commons_thankyou = "9", yl_church = "return {[\"last_death\"] = {[\"y\"] = -25140, [\"x\"] = -30000, [\"z\"] = -30000}, [\"last_heal\"] = 1648878609, [\"last_death_portal\"] = 1650778499}", died = "135", ["stamina:level"] = "11", punch_count = "15594", arenalib_infobox_arenaID = "0", inflicted_damage = "283596", crafted = "751", ["stamina:poisoned"] = "no", ["ocean_build.last_warning"] = "1.65061e+09", xp = "58795", placed_nodes = "6698", hud_state = "on", repellant = "0", yl_commons_player_created = "1648785584" } } ``` Log identifier ``` [MOD] yl_report log identifier = jjrsD2VMvDXkaHGN7FGIRYsvgTHdQDpB ``` Profiler save: ``` profile-20220424T074052.json_prettyEE ``` Status: ``` # Server: version: 5.5.0-yl | game: Minetest Game | uptime: 20h 31min 51s | max lag: 5.01s | clients: meow132, ltr, rohit, tog2, Giuseppe, Kilarin, jackofthebean000, DreamNotFound, Coolstorms, TheSingingBee, Flatulenator, slayer, AliasAlreadyTaken, bluattire, Oakenshield, Futureismine, Ryanthegirl, Service, pitman, flux, Aleks555, Bailiff ``` Teleport command: ``` /teleport xyz -30000 -25124 -30000 ``` Compass command: ``` /give_compass Construction jjrsD2VMvDXkaHGN7FGIRYsvgTHdQDpB D2691E -30000 -25124 -30000 ```

AliasAlreadyTaken was assigned by yourland-report

2022-04-24 05:40:53 +00:00

flux added the

1. kind/bug

3. source/mod upstream

labels 2022-04-24 15:50:48 +00:00

AliasAlreadyTaken commented

2022-05-03 15:03:24 +00:00

Not only the bones disappear, the whole content with them!

Lucky we have loggin of items that go to the bones ... but wth?

Can we tell which mechanic is resonsible and fix that? I wouldn't know where to start on this one tbh.

Not only the bones disappear, the whole content with them! Lucky we have loggin of items that go to the bones ... but wth? Can we tell which mechanic is resonsible and fix that? I wouldn't know where to start on this one tbh.

AliasAlreadyTaken added the

2. prio/critical

label 2022-05-03 15:03:31 +00:00

flux commented

2022-05-03 20:08:08 +00:00

this isn't super easy to replicate, but i'd blame https://github.com/minetest/minetest/blob/master/builtin/game/falling.lua

flux added this to the flux's TODO list project 2022-07-02 21:05:08 +00:00

flux added

2. prio/elevated

and removed

2. prio/critical

labels 2022-07-23 00:45:11 +00:00

flux commented

2022-07-23 04:16:04 +00:00

it'd be easy to turn falling stuff into "dropped items" if the target node isn't air (or isn't "buildable_to", but that doesn't solve the issue of replacing fluid source nodes).

i have some ideas, but no perfect solution in mind.

this should be done as a PR against the "builtin" lua code of the engine

it'd be easy to turn falling stuff into "dropped items" if the target node isn't air (or isn't "buildable_to", but that doesn't solve the issue of replacing fluid source nodes). i have some ideas, but no perfect solution in mind. this should be done as a PR against the "builtin" lua code of the engine

AliasAlreadyTaken commented

2022-07-23 05:37:27 +00:00

I reproduced it by building a small tower with a ghoststone "nose" in one direction. I placed sand atop the ghosttone. I died below and caused the sand to fall by removing the ghoststone. Sometimes the sand wouldn't fall even with the ghoststone removed, then I would die and pummel the "floating" sand. Seems like lag is not the issue, it worked on the testserver.

flux commented

2022-07-23 14:16:22 +00:00

related: the river destruction in #2141

flux referenced this issue

2022-08-07 23:38:14 +00:00

flux reports: quicksand (from ethereal) shou ... #2163

flux commented

2023-05-13 21:38:47 +00:00

@AliasAlreadyTaken do you remember how you replicated this exactly? i can't seem to manage it, though my setup isn't identical (i'm using a script to place and drop the blocks and kill a test subject, instead of ghoststone and manual commands). relevant because of https://github.com/minetest/minetest/issues/13485

flux added

3. source/engine

and removed

3. source/mod upstream

labels 2023-05-13 21:48:00 +00:00

AliasAlreadyTaken commented

2023-05-14 15:27:16 +00:00

I didn't have 100% success rate, but the setup worked:

I reproduced it by building a small tower with a ghoststone "nose" in one direction. I placed sand atop the ghosttone. I died below and caused the sand to fall by removing the ghoststone. Sometimes the sand wouldn't fall even with the ghoststone removed, then I would die and pummel the "floating" sand. Seems like lag is not the issue, it worked on the testserver.

I didn't have 100% success rate, but the setup worked: > I reproduced it by building a small tower with a ghoststone "nose" in one direction. I placed sand atop the ghosttone. I died below and caused the sand to fall by removing the ghoststone. Sometimes the sand wouldn't fall even with the ghoststone removed, then I would die and pummel the "floating" sand. Seems like lag is not the issue, it worked on the testserver.

flux referenced this issue from a commit

2023-11-28 00:15:37 +00:00

your-land/bugtracker#1820 prevent falling nodes from digging nodes if they end up inside them

flux added the

4. step/ready to QA test

label 2023-11-28 00:15:51 +00:00

flux commented

2023-11-28 00:21:29 +00:00

implemented something as the engine people dithered: 8fd4876cf2

not sure how to best QA this, as i never was able to automate a reliable replication, though just spawning a falling node in a solid block should work.

note that the fix results in nodes falling non-phyiscal but non-buildable_to nodes like torches turning into dropped items. perhaps i need to add additional checks for walkable and diggable...

implemented something as the engine people dithered: https://gitea.your-land.de/your-land/yl_commons/commit/8fd4876cf22edff49d1419694d144c43226502a1 not sure how to best QA this, as i never was able to automate a reliable replication, though just spawning a falling node in a solid block should work. note that the fix results in nodes falling non-phyiscal but non-buildable_to nodes like torches turning into dropped items. perhaps i need to add additional checks for walkable and diggable...

AliasAlreadyTaken commented

2023-12-06 16:46:27 +00:00

QA

This works astonishingly well, I tried a lot to destroy my bones, but they were always generated properly, sometimes even last moment.

QA This works astonishingly well, I tried a lot to destroy my bones, but they were always generated properly, sometimes even last moment.

AliasAlreadyTaken added the

ugh/QA OK

label 2023-12-06 16:46:34 +00:00

AliasAlreadyTaken added this to the 1.1.122 milestone 2023-12-06 16:46:37 +00:00

flux added

5. result/fixed

and removed