various fruit are in group:leafdecay, and thus can be crafted into trunks:twig_1 #1992

Closed
opened 2022-05-27 19:07:03 +00:00 by flux · 7 comments
Member

which is weird.

  1. fruit should fall when the tree is cut down
  2. fruit should not be craftable into twigs, as that can conflict w/ existing or plausible recipes, e.g. ethereal:banana_bunch

affected fruit:

  • default:apple
  • ethereal:banana
  • ethereal:banana_bunch
  • ethereal:coconut
  • ethereal:golden_apple
  • ethereal:lemon
  • ethereal:olive
  • ethereal:orange
  • moretrees:acorn
  • moretrees:cedar_cone
  • moretrees:fir_cone
  • moretrees:spruce_cone

I think the solution to this should just be to remove that crafting recipe? There's other ways to craft that twig.

which is weird. 1. fruit should fall when the tree is cut down 2. fruit should not be craftable into twigs, as that can conflict w/ existing or plausible recipes, e.g. `ethereal:banana_bunch` affected fruit: * `default:apple` * `ethereal:banana` * `ethereal:banana_bunch` * `ethereal:coconut` * `ethereal:golden_apple` * `ethereal:lemon` * `ethereal:olive` * `ethereal:orange` * `moretrees:acorn` * `moretrees:cedar_cone` * `moretrees:fir_cone` * `moretrees:spruce_cone` I think the solution to this should just be to remove that crafting recipe? There's other ways to craft that twig.
flux added the
1. kind/bug
3. source/integration
4. step/want approval
labels 2022-05-27 19:07:03 +00:00
Author
Member

Or possibly, fruit should be put in "group:falling" and removed from leafdecay?

Or possibly, fruit should be put in "group:falling" and removed from leafdecay?
Author
Member

per #2066, fruit doesn't even fall currently when the tree is cut down via treecutting...

per #2066, fruit doesn't even fall currently when the tree is cut down via treecutting...

group:falling sounds more reasonable. leafdecay is yet another special mechanic from plantlife (or moretrees??), which noone else uses (and thus is not expected).

group:falling sounds more reasonable. leafdecay is yet another special mechanic from plantlife (or moretrees??), which noone else uses (and thus is not expected).
AliasAlreadyTaken added the
4. step/approved
label 2022-06-16 01:35:12 +00:00
flux self-assigned this 2022-06-16 02:18:16 +00:00
Author
Member

hm. i still like the group:falling_node idea, but it doesn't resolve the issue in #2066 when using the electrumese axe.

also, because the various fruits are not walkable, when they fall on the ground, they don't stack, so you lose a lot of your crop.

hm. i still like the `group:falling_node` idea, but it doesn't resolve the issue in #2066 when using the electrumese axe. also, because the various fruits are not `walkable`, when they fall on the ground, they don't stack, so you lose a lot of your crop. ![](https://gitea.your-land.de/attachments/a8cfaf32-13b3-4361-a8bb-a1e4f172ea14)
flux added
4. step/at work
and removed
4. step/want approval
labels 2022-06-16 16:53:19 +00:00
Author
Member

fixed the electrumese axe via 2ff95735f9

fixed the electrumese axe via https://gitea.your-land.de/your-land/yl_nether/commit/2ff95735f902fb738171148017473adc2368e529
Author
Member

implemented in c8ec25e786

implemented in https://gitea.your-land.de/your-land/yl_commons/commit/c8ec25e786f7df177f70d23534c981cc177d8f88
flux added
4. step/ready to QA test
and removed
4. step/at work
labels 2022-06-16 19:45:12 +00:00
AliasAlreadyTaken added this to the 1.1.113 milestone 2022-06-17 23:05:11 +00:00
flux added
5. result/fixed
and removed
4. step/approved
4. step/ready to QA test
labels 2022-06-22 15:42:20 +00:00
Author
Member

live

live
flux closed this issue 2022-06-22 15:42:26 +00:00
flux removed their assignment 2022-09-21 00:02:26 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#1992
No description provided.