flux reports: you can knock apples (and othe ... #2925

Closed
opened 2022-10-28 16:37:30 +00:00 by yourland-report · 13 comments

flux reports a bug:

you can knock apples (and other fruit) off trees in protected areas, even though you can't pick them up.

Player position:

{
	y = 9.5,
	z = 10431.998046875,
	x = 6499.9350585938
}

Player look:

{
	y = -0.37897169589996,
	z = 0.82505750656128,
	x = -0.41911882162094
}

Player information:

{
	ip_version = 6,
	min_rtt = 0.15999999642372,
	max_rtt = 4.4340000152588,
	avg_rtt = 0.17700000107288,
	min_jitter = 0,
	max_jitter = 4.2639999389648,
	avg_jitter = 0.0030000060796738,
	lang_code = "",
	patch = 1,
	state = "Active",
	formspec_version = 6,
	major = 5,
	minor = 6,
	version_string = "5.6.1",
	serialization_version = 29,
	connection_uptime = 6529,
	protocol_version = 41
}

Player meta:

{
	fields = {
		["petz:werewolf"] = "1",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death_portal\"] = 1665277689, [\"last_heal\"] = 1615504208, [\"last_death\"] = {[\"x\"] = 1276, [\"y\"] = 45, [\"z\"] = 549}}",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		jointime = "1615351173",
		bitten = "0",
		["petz:werewolf_vignette_id"] = "20",
		xp = "1321262",
		digged_nodes = "1120757",
		yl_commons_player_created = "1615351173",
		yl_commons_player_joined = "1666968549",
		["petz:werewolf_clan_idx"] = "1",
		arenalib_infobox_arenaID = "0",
		placed_nodes = "363951",
		["stamina:level"] = "13",
		crafted = "45964",
		["stamina:poisoned"] = "no",
		partychat = "party",
		repellant = "0",
		["stamina:exhaustion"] = "157.5",
		inflicted_damage = "1897512",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		hud_state = "on",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 2176\", \"3d_armor:leggings_rainbow 1 2176\", \"shields:shield_rainbow 1 2176\", \"3d_armor:chestplate_rainbow 1 2176\", \"3d_armor:boots_crystal 1 5040\", \"\"}",
		punch_count = "109414",
		died = "72",
		["signslib:pos"] = "(1036,15,1987)",
		played_time = "26185368",
		yl_commons_thankyou = "177"
	}
}

Log identifier


[MOD] yl_report log identifier = dpyw51Mq7QdRl7mBED6jCGsEJKHKK49x

Profiler save:

profile-20221028T163730.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 11h 30min 24s | max lag: 1.93s | clients: Sense, Queenfire234312, alexandre2005, JeCel, SkyKnife, rabenkind, niceride, flux, Bailiff, shanish, daydream, AliasAlreadyTaken, Chache, Service

Teleport command:

/teleport xyz 6500 10 10432

Compass command:

/give_compass Construction dpyw51Mq7QdRl7mBED6jCGsEJKHKK49x D2691E 6500 10 10432
flux reports a bug: > you can knock apples (and other fruit) off trees in protected areas, even though you can't pick them up. Player position: ``` { y = 9.5, z = 10431.998046875, x = 6499.9350585938 } ``` Player look: ``` { y = -0.37897169589996, z = 0.82505750656128, x = -0.41911882162094 } ``` Player information: ``` { ip_version = 6, min_rtt = 0.15999999642372, max_rtt = 4.4340000152588, avg_rtt = 0.17700000107288, min_jitter = 0, max_jitter = 4.2639999389648, avg_jitter = 0.0030000060796738, lang_code = "", patch = 1, state = "Active", formspec_version = 6, major = 5, minor = 6, version_string = "5.6.1", serialization_version = 29, connection_uptime = 6529, protocol_version = 41 } ``` Player meta: ``` { fields = { ["petz:werewolf"] = "1", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death_portal\"] = 1665277689, [\"last_heal\"] = 1615504208, [\"last_death\"] = {[\"x\"] = 1276, [\"y\"] = 45, [\"z\"] = 549}}", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", jointime = "1615351173", bitten = "0", ["petz:werewolf_vignette_id"] = "20", xp = "1321262", digged_nodes = "1120757", yl_commons_player_created = "1615351173", yl_commons_player_joined = "1666968549", ["petz:werewolf_clan_idx"] = "1", arenalib_infobox_arenaID = "0", placed_nodes = "363951", ["stamina:level"] = "13", crafted = "45964", ["stamina:poisoned"] = "no", partychat = "party", repellant = "0", ["stamina:exhaustion"] = "157.5", inflicted_damage = "1897512", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", hud_state = "on", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 2176\", \"3d_armor:leggings_rainbow 1 2176\", \"shields:shield_rainbow 1 2176\", \"3d_armor:chestplate_rainbow 1 2176\", \"3d_armor:boots_crystal 1 5040\", \"\"}", punch_count = "109414", died = "72", ["signslib:pos"] = "(1036,15,1987)", played_time = "26185368", yl_commons_thankyou = "177" } } ``` Log identifier ``` [MOD] yl_report log identifier = dpyw51Mq7QdRl7mBED6jCGsEJKHKK49x ``` Profiler save: ``` profile-20221028T163730.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 11h 30min 24s | max lag: 1.93s | clients: Sense, Queenfire234312, alexandre2005, JeCel, SkyKnife, rabenkind, niceride, flux, Bailiff, shanish, daydream, AliasAlreadyTaken, Chache, Service ``` Teleport command: ``` /teleport xyz 6500 10 10432 ``` Compass command: ``` /give_compass Construction dpyw51Mq7QdRl7mBED6jCGsEJKHKK49x D2691E 6500 10 10432 ```
AliasAlreadyTaken was assigned by yourland-report 2022-10-28 16:37:31 +00:00
flux added the
1. kind/bug
3. source/integration
labels 2022-10-28 18:30:28 +00:00
Member

probably players shouldn't be able to trigger falling nodes in protected areas that they don't control.

probably players shouldn't be able to trigger falling nodes in protected areas that they don't control.
Member

ugh this will require changes to the builtin lua API. ugh.

ugh this will require changes to the builtin lua API. ugh.
flux added this to the flux's TODO list project 2022-10-28 18:36:44 +00:00
AliasAlreadyTaken was unassigned by flux 2022-10-28 18:36:51 +00:00

Is that the same case as "falling gravel in a protected area" ?

Is that the same case as "falling gravel in a protected area" ?
Member

Is that the same case as "falling gravel in a protected area" ?

the solution in my mind equates these. for a server like your-land, i can't think of a good use case of knocking gravel in someone else's protected area and having it fall.

perhaps when there's a more sophisticated API for managing player interactions in a "volume", but currently, every time i make gravel/sand fall in a protected cave, i feel like i'm abusing the mechanic.

> Is that the same case as "falling gravel in a protected area" ? > the solution in my mind equates these. for a server like your-land, i can't think of a good use case of knocking gravel in someone else's protected area and having it fall. perhaps when there's [a more sophisticated API for managing player interactions in a "volume"](https://gitea.your-land.de/your-land/administration/issues/178), but currently, every time i make gravel/sand fall in a protected cave, i feel like i'm abusing the mechanic.

It's hard to have code guess intention. Sounds like a case of "in one case it should be this way, in the other case it should be another".

It's hard to have code guess intention. Sounds like a case of "in one case it should be this way, in the other case it should be another".
Member

Falling nodes are in general a pain. Perhaps reconsider if fruits really need to fall down. Or was it a change in upstream? Then there's little one can do.

Falling nodes are in general a pain. Perhaps reconsider if fruits really need to fall down. Or was it a change in upstream? Then there's little one can do.
Member

Falling nodes are in general a pain.

this is true, but it doesn't need to be that way

Perhaps reconsider if fruits really need to fall down.

having them fall is preferable to having them float in the sky, but there's currently no way to get them to fall in some sort of "sane" way. at some point, i can rewrite falling nodes as a mod and solve a lot of these problems.

there's also an upstream engine PR, though it's stalled:

> Falling nodes are in general a pain. this is true, but it doesn't need to be that way > Perhaps reconsider if fruits really need to fall down. having them fall is preferable to having them float in the sky, but there's currently no way to get them to fall in some sort of "sane" way. at some point, i can rewrite falling nodes as a mod and solve a lot of these problems. there's also an upstream engine PR, though it's stalled: * https://github.com/minetest/minetest/pull/12966
Member

notes from #3246

it's not possible to fix a tree once an apple decided to "fall".

instead, fruit should regrow on trees every-so-often, and it shouldn't be possible to knock fruit down in protected areas

plus they destroy flowers and grass when falling down

ideally, flowers and grass should regrow over time, at least in unprotected areas. in protected areas, falling nodes should never replace other nodes.

the admin issue for these behaviors is your-land/administration#134, though i know most people can't see that.

notes from #3246 > it's not possible to fix a tree once an apple decided to "fall". instead, fruit should regrow on trees every-so-often, and it shouldn't be possible to knock fruit down in protected areas > plus they destroy flowers and grass when falling down ideally, flowers and grass should regrow over time, at least in unprotected areas. in protected areas, falling nodes should never replace other nodes. the admin issue for these behaviors is https://gitea.your-land.de/your-land/administration/issues/134, though i know most people can't see that.
Member

The current implementation is...problematic. Apples can be knocked from trees unvoluntarily, and the falling apples do kill flowers. It's not a matter of them regrowing or not...or of the mechanism beeing repaird/improved in the far future.

I think the best solution would still be to avoid falling nodes as far as possible. It's not even realistic: Apples can hang on twigs. They don't need to sit on something. And even then...having falling apples but stone structures float happily in the sky remains...strange.

And then there's picking up an apple/fir cone - just to have the apple/fir cone you just tried to pick up start falling and end up on the floor. Seems our hands aren't very good at gripping things.

Or have a fir cone land on a horse passing by and float on top of that.

It's better for gameplay mechanics to switch them from falling nodes back to normal nodes.

The current implementation is...problematic. Apples can be knocked from trees unvoluntarily, and the falling apples *do* kill flowers. It's not a matter of them regrowing or not...or of the mechanism beeing repaird/improved in the far future. I think the best solution would still be to avoid falling nodes as far as possible. It's not even realistic: Apples can hang on twigs. They don't need to sit on something. And even then...having falling apples but stone structures float happily in the sky remains...strange. And then there's picking up an apple/fir cone - just to have the apple/fir cone you just tried to pick up start falling and end up on the floor. Seems our hands aren't very good at gripping things. Or have a fir cone land on a horse passing by and float on top of that. It's better for gameplay mechanics to switch them from falling nodes back to normal nodes.
Member

how we got here:

  • #1992

    tree fruit are in the "leafdecay" group which breaks crafting recipes. solution: tree fruit are removed from the leafdecay group.

  • #2066

    because they were removed from "leafdecay", fruit hovers in the sky. solution: turn them into falling nodes.

how we got here: * #1992 tree fruit are in the "leafdecay" group which breaks crafting recipes. solution: tree fruit are removed from the leafdecay group. * #2066 because they were removed from "leafdecay", fruit hovers in the sky. solution: turn them into falling nodes.

Can we make them fall as entities?

Can we make them fall as entities?
Member

Can we make them fall as entities?

implemented this in 13c1a0e0f9

upsides:

  • doesn't destroy grass/flowers

downsides:

  • fruit has to be picked up as individual items, which is tedious
  • treecapitator leaves some fruit floating

unchanged:

  • you can still knock fruit off trees in protected areas
> Can we make them fall as entities? implemented this in https://gitea.your-land.de/your-land/yl_commons/commit/13c1a0e0f94a8f7427c1244a60ded8f2ced5426a upsides: * doesn't destroy grass/flowers downsides: * fruit has to be picked up as individual items, which is tedious * treecapitator leaves some fruit floating unchanged: * you can still knock fruit off trees in protected areas
flux added the
2. prio/elevated
label 2022-12-24 19:07:19 +00:00
flux added the
5. result/fixed
label 2023-01-26 19:41:23 +00:00
flux removed this from the flux's TODO list project 2023-01-26 19:41:26 +00:00
Member

this is live, though it didn't go through QA and there's still some problems which weren't even listed here.

this is live, though it didn't go through QA and there's still some problems which weren't even listed here.
flux closed this issue 2023-01-26 19:43:41 +00:00
AliasAlreadyTaken added this to the 1.1.117 milestone 2023-01-26 19:57:55 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2925
No description provided.