tour reports: boards:green_board can be put ... #1273

New Issue

yourland-report · 2022-01-05T19:25:14Z

yourland-report commented

2022-01-05 19:25:14 +00:00

tour reports a bug:

boards:green_board can be put in itemframes (both types), but you can't see it in there. I expect (bud didn't test) the same with the black board

Player position:

{
	y = 28.5,
	x = 6625.5717773438,
	z = 3083.4301757813
}

Player look:

{
	y = -0.45538952946663,
	x = -0.87294220924377,
	z = 0.17490656673908
}

Player information:

{
	min_rtt = 0.028000000864267,
	max_rtt = 3.3870000839233,
	connection_uptime = 9842,
	max_jitter = 3.3529999256134,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "de",
	version_string = "5.4.1",
	avg_rtt = 0.029999999329448,
	state = "Active",
	avg_jitter = 0.0030000004917383,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"shields:shield_crystal 1 31940\", \"3d_armor:leggings_crystal 1 31940\", \"3d_armor:chestplate_crystal 1 31940\", \"3d_armor:helmet_crystal 1 31940\", \"3d_armor:boots_crystal 1 31940\", \"\"}",
		yl_commons_thankyou = "42",
		jointime = "1625997613",
		yl_commons_player_joined = "1641400896",
		["signslib:pos"] = "(6580,4,3071)",
		digged_nodes = "225474",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 48, [\"x\"] = 6414, [\"z\"] = 3101}, [\"last_death_portal\"] = 1640118045}",
		["stamina:level"] = "19",
		punch_count = "22208",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "410336",
		crafted = "18701",
		died = "99",
		xp = "212526",
		played_time = "1664908",
		placed_nodes = "107963",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1625997613"
	}
}

Log identifier


[MOD] yl_report log identifier = yRmABhpUejtTUXJtoNMJXWMizNstuYaG

Profiler save:

profile-20220105T202513.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=39363.8, max_lag=4.97533, clients={The_Cameraman, Ashy, Lupercus, jackofthebean000, Lichberry, mad-dog86, _DRAGON_, LeetPeet, shanish, Ernesto, Woldar, Service, debiankaios, tour, Bailiff, AliasAlreadyTaken, Boot, karlbrock, Bla, mindfrost, flux, petarpro, guestxmart, LeniOwO}

Teleport command:

/teleport xyz 6626 29 3083

Compass command:

/give_compass Construction yRmABhpUejtTUXJtoNMJXWMizNstuYaG D2691E 6626 29 3083

tour reports a bug: > boards:green_board can be put in itemframes (both types), but you can't see it in there. I expect (bud didn't test) the same with the black board Player position: ``` { y = 28.5, x = 6625.5717773438, z = 3083.4301757813 } ``` Player look: ``` { y = -0.45538952946663, x = -0.87294220924377, z = 0.17490656673908 } ``` Player information: ``` { min_rtt = 0.028000000864267, max_rtt = 3.3870000839233, connection_uptime = 9842, max_jitter = 3.3529999256134, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "de", version_string = "5.4.1", avg_rtt = 0.029999999329448, state = "Active", avg_jitter = 0.0030000004917383, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"shields:shield_crystal 1 31940\", \"3d_armor:leggings_crystal 1 31940\", \"3d_armor:chestplate_crystal 1 31940\", \"3d_armor:helmet_crystal 1 31940\", \"3d_armor:boots_crystal 1 31940\", \"\"}", yl_commons_thankyou = "42", jointime = "1625997613", yl_commons_player_joined = "1641400896", ["signslib:pos"] = "(6580,4,3071)", digged_nodes = "225474", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 48, [\"x\"] = 6414, [\"z\"] = 3101}, [\"last_death_portal\"] = 1640118045}", ["stamina:level"] = "19", punch_count = "22208", arenalib_infobox_arenaID = "0", inflicted_damage = "410336", crafted = "18701", died = "99", xp = "212526", played_time = "1664908", placed_nodes = "107963", hud_state = "on", repellant = "0", yl_commons_player_created = "1625997613" } } ``` Log identifier ``` [MOD] yl_report log identifier = yRmABhpUejtTUXJtoNMJXWMizNstuYaG ``` Profiler save: ``` profile-20220105T202513.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=39363.8, max_lag=4.97533, clients={The_Cameraman, Ashy, Lupercus, jackofthebean000, Lichberry, mad-dog86, _DRAGON_, LeetPeet, shanish, Ernesto, Woldar, Service, debiankaios, tour, Bailiff, AliasAlreadyTaken, Boot, karlbrock, Bla, mindfrost, flux, petarpro, guestxmart, LeniOwO} ``` Teleport command: ``` /teleport xyz 6626 29 3083 ``` Compass command: ``` /give_compass Construction yRmABhpUejtTUXJtoNMJXWMizNstuYaG D2691E 6626 29 3083 ```

AliasAlreadyTaken was assigned by yourland-report

2022-01-05 19:25:14 +00:00

AliasAlreadyTaken added the

1. kind/bug

3. source/integration

labels 2022-01-06 01:06:20 +00:00

AliasAlreadyTaken commented

2022-01-07 04:19:21 +00:00

![image](/attachments/eeff116e-178f-4765-ad83-287b525f8818)

image.png

293 KiB

AliasAlreadyTaken commented

2022-01-07 04:19:49 +00:00

Seems like the black and green boards are displayed BEHIND the itemframe?!

AliasAlreadyTaken added the

3. source/mod upstream

label 2022-01-07 04:20:17 +00:00

AliasAlreadyTaken commented

2022-01-07 04:26:14 +00:00

![image](/attachments/e5456e89-c124-461b-8aea-fea9ff96af48)

image.png

207 KiB

AliasAlreadyTaken commented

2022-01-07 04:30:00 +00:00

Upstream:

https://github.com/pyrollo/display_modpack/issues/47

https://notabug.org/TenPlus1/itemframes/issues/3

Upstream: https://github.com/pyrollo/display_modpack/issues/47 https://notabug.org/TenPlus1/itemframes/issues/3

flux commented

2022-01-07 05:23:42 +00:00

this isn't an issue w/ itemframes or display_modpack. this is due to how visual = "wielditem" works for entities, as written into the engine. you can see some of my attempts to deal w/ this in my smartshop fork, though i'm still not able to deal with everything

this isn't an issue w/ itemframes or display_modpack. this is due to how `visual = "wielditem"` works for entities, as written into the engine. you can see some of my attempts to deal w/ this in my smartshop fork, though i'm still not able to deal with everything

flux commented

2022-01-07 05:25:14 +00:00

because there's no API to query what is actually being displayed, this issue is fundamentally insoluble outside the engine.

because there's no API to query *what is actually being displayed*, this issue is fundamentally insoluble outside the engine.

AliasAlreadyTaken commented

2022-01-07 09:15:36 +00:00

This is what Tenplus1 said:

This is an issue with the mod itself, itemframes either show the inventory image for an item or if that's missing the actual 3D model which in this case sits flush against a wall so it's behind the itemframe. If an inventory image is added than it will be fixed.

This is what Tenplus1 said: > This is an issue with the mod itself, itemframes either show the inventory image for an item or if that's missing the actual 3D model which in this case sits flush against a wall so it's behind the itemframe. If an inventory image is added than it will be fixed.

AliasAlreadyTaken commented

2022-01-08 10:35:33 +00:00

For whatever reason item override doesn't work.

28e5473a00be3432160ba662985bb0ede4dd5f32

For whatever reason item override doesn't work. 28e5473a00be3432160ba662985bb0ede4dd5f32

flux commented

2022-01-08 17:00:21 +00:00

hm. what if you remove the item from the frame and put it back, after the override?

AliasAlreadyTaken commented

2022-01-08 18:33:25 +00:00

Same game. Even worse:

It kind of worked. When I edit the boards mod and put in an inventory_image, it displays the inv image correctly and also in the itemframe.

But if I retrofit this inventory_image via override_item, it does not. Despite the inventory_image being displayed as inventory image and can be queried as such. But in the itemframe it's still borked.

I told Tenplus1 in the upstream issue, but I fear its an engine problem.

Regardless whether I add directly or as an override, I can query the correct (and same) inventory_image by wielding the item and doing /iinfo

Same game. Even worse: It kind of worked. When I edit the boards mod and put in an inventory_image, it displays the inv image correctly and also in the itemframe. But if I retrofit this inventory_image via override_item, it does not. Despite the inventory_image being displayed as inventory image and can be queried as such. But in the itemframe it's still borked. I told Tenplus1 in the upstream issue, but I fear its an engine problem. Regardless whether I add directly or as an override, I can query the correct (and same) inventory_image by wielding the item and doing /iinfo

flux commented

2022-01-10 00:05:56 +00:00

But if I retrofit this inventory_image via override_item, it does not. Despite the inventory_image being displayed as inventory image and can be queried as such. But in the itemframe it's still borked.

are you sure you have the mod dependencies set up right? your call to "override" might be getting called before the node is defined.

> But if I retrofit this inventory_image via override_item, it does not. Despite the inventory_image being displayed as inventory image and can be queried as such. But in the itemframe it's still borked. are you sure you have the mod dependencies set up right? your call to "override" might be getting called before the node is defined.

flux referenced this issue

2022-04-07 19:49:56 +00:00

LeniOwO reports: lmao when u put a vintage lant ... #1422

flux added this to the flux's TODO list project 2022-07-02 19:18:36 +00:00

flux commented

2022-07-02 19:19:35 +00:00

real solution should be to do an upstream PR that checks if something has a nodebox/mesh drawtype, and if there's no inventory image, place the entity further forward.

flux referenced this issue

2022-08-04 14:20:23 +00:00

jakob reports: If I put a shield (I tried it ... #2404

flux referenced this issue

2023-02-04 00:36:47 +00:00

Laylem reports: you can rotate an itemframe pl ... #3713

flux referenced this issue

2023-04-15 16:22:34 +00:00

daydream reports: if you put a painting in an it ... #4201

flux referenced this issue

2023-05-18 19:17:44 +00:00

display of nodes like cannonballs in itemframes is still very inconsistent #4529