Laylem reports: you can rotate an itemframe pl ... #3713

Closed
opened 2023-02-03 22:53:04 +00:00 by yourland-report · 4 comments

Laylem reports a bug:

you can rotate an itemframe placed on the ground, but rotating an itemframe placed on a wall does not work as expected, it only seems to have 2 orientation even though the param2 changes

Player position:

{
	z = 1627.3000488281,
	x = 2217.0900878906,
	y = 12.5
}

Player look:

{
	z = -0.17070898413658,
	x = 0.81077271699905,
	y = -0.55991613864899
}

Player information:

{
	major = 5,
	version_string = "5.6.1",
	protocol_version = 41,
	ip_version = 6,
	min_rtt = 0.16099999845028,
	avg_rtt = 0.17200000584126,
	min_jitter = 0,
	max_jitter = 1.4500000476837,
	avg_jitter = 0.0020000040531158,
	lang_code = "",
	serialization_version = 29,
	patch = 1,
	max_rtt = 1.6169999837875,
	minor = 6,
	state = "Active",
	formspec_version = 6,
	connection_uptime = 7098
}

Player meta:

{
	fields = {
		jointime = "1659420654",
		bitten = "0",
		["signslib:pos"] = "(2227,13,1625)",
		arenalib_infobox_arenaID = "0",
		yl_church = "return {[\"last_death_portal\"] = 1673847554, [\"last_death\"] = {[\"y\"] = 60, [\"z\"] = 5, [\"x\"] = 2636}, [\"last_heal\"] = 1673778297}",
		yl_commons_thankyou = "69",
		xp = "347132",
		punch_count = "26247",
		played_time = "2210266",
		digged_nodes = "330532",
		placed_nodes = "96623",
		died = "45",
		partychat = "main",
		crafted = "77379",
		["stamina:exhaustion"] = "81",
		["stamina:level"] = "19",
		hud_state = "on",
		["stamina:poisoned"] = "no",
		["ocean_build.last_warning"] = "1.66072e+09",
		inflicted_damage = "546746",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 27185\", \"shields:shield_rainbow 1 19000\", \"3d_armor:chestplate_crystal 1 27185\", \"3d_armor:boots_crystal 1 27185\", \"3d_armor:leggings_crystal 1 27185\", \"\"}",
		["ocean_build.ocean_built"] = "11",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		repellant = "0",
		yl_commons_player_created = "1659420654",
		yl_commons_player_joined = "1675457713"
	}
}

Log identifier


[MOD] yl_report log identifier = aLJo3CBXrIWgGMYGTslOBLeECPqx5HhZ

Profiler save:

profile-20230203T225304.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 5d 1h 3min 29s | max lag: 4.3s | clients (36/52): 9T9, afonsan, AliasAlreadyTaken, Aliza, Anaconda, Arsten, AspireMint, Bailiff, CaramelPlant, Chazz, Curlyfries, daydream, digdeep, drgn, Ecklair, flux, Grey, HorusDamocles, Ivanhoe, Kalek, karlbrock, labrat, Laylem, Limurzik, mindfrost, niceride, Parrish, rewired_X, rheo, RyiBread, Sandra, Service, SkylerHunt, Sokomine, Squawk, Sysmatic

Teleport command:

/teleport xyz 2217 13 1627

Compass command:

/give_compass Construction aLJo3CBXrIWgGMYGTslOBLeECPqx5HhZ D2691E 2217 13 1627
Laylem reports a bug: > you can rotate an itemframe placed on the ground, but rotating an itemframe placed on a wall does not work as expected, it only seems to have 2 orientation even though the param2 changes Player position: ``` { z = 1627.3000488281, x = 2217.0900878906, y = 12.5 } ``` Player look: ``` { z = -0.17070898413658, x = 0.81077271699905, y = -0.55991613864899 } ``` Player information: ``` { major = 5, version_string = "5.6.1", protocol_version = 41, ip_version = 6, min_rtt = 0.16099999845028, avg_rtt = 0.17200000584126, min_jitter = 0, max_jitter = 1.4500000476837, avg_jitter = 0.0020000040531158, lang_code = "", serialization_version = 29, patch = 1, max_rtt = 1.6169999837875, minor = 6, state = "Active", formspec_version = 6, connection_uptime = 7098 } ``` Player meta: ``` { fields = { jointime = "1659420654", bitten = "0", ["signslib:pos"] = "(2227,13,1625)", arenalib_infobox_arenaID = "0", yl_church = "return {[\"last_death_portal\"] = 1673847554, [\"last_death\"] = {[\"y\"] = 60, [\"z\"] = 5, [\"x\"] = 2636}, [\"last_heal\"] = 1673778297}", yl_commons_thankyou = "69", xp = "347132", punch_count = "26247", played_time = "2210266", digged_nodes = "330532", placed_nodes = "96623", died = "45", partychat = "main", crafted = "77379", ["stamina:exhaustion"] = "81", ["stamina:level"] = "19", hud_state = "on", ["stamina:poisoned"] = "no", ["ocean_build.last_warning"] = "1.66072e+09", inflicted_damage = "546746", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 27185\", \"shields:shield_rainbow 1 19000\", \"3d_armor:chestplate_crystal 1 27185\", \"3d_armor:boots_crystal 1 27185\", \"3d_armor:leggings_crystal 1 27185\", \"\"}", ["ocean_build.ocean_built"] = "11", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", repellant = "0", yl_commons_player_created = "1659420654", yl_commons_player_joined = "1675457713" } } ``` Log identifier ``` [MOD] yl_report log identifier = aLJo3CBXrIWgGMYGTslOBLeECPqx5HhZ ``` Profiler save: ``` profile-20230203T225304.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 5d 1h 3min 29s | max lag: 4.3s | clients (36/52): 9T9, afonsan, AliasAlreadyTaken, Aliza, Anaconda, Arsten, AspireMint, Bailiff, CaramelPlant, Chazz, Curlyfries, daydream, digdeep, drgn, Ecklair, flux, Grey, HorusDamocles, Ivanhoe, Kalek, karlbrock, labrat, Laylem, Limurzik, mindfrost, niceride, Parrish, rewired_X, rheo, RyiBread, Sandra, Service, SkylerHunt, Sokomine, Squawk, Sysmatic ``` Teleport command: ``` /teleport xyz 2217 13 1627 ``` Compass command: ``` /give_compass Construction aLJo3CBXrIWgGMYGTslOBLeECPqx5HhZ D2691E 2217 13 1627 ```
AliasAlreadyTaken was assigned by yourland-report 2023-02-03 22:53:04 +00:00
flux added the
1. kind/bug
4. step/needs confirmation
labels 2023-02-04 00:10:47 +00:00
flux added
3. source/mod upstream
and removed
4. step/needs confirmation
labels 2023-02-04 00:28:52 +00:00
Member

there's at least 2 issues here:

image

  • item is bbq:pepperoni
  • this image shows 4 item frames oriented in different ways (param2 = 1, 5, 9, and 23). however, in 3 of them, the item is shown right-side-up, and in 1 of them, it is upside down. notably, there are no orientations where the item is rotated 90 or 270 degrees.

image

  • item is cannons:ball_stone_stack_2
  • this is related to issue #1273, but it highlights an additional issue. the item has a nodebox drawtype and no inventory/wield image, so wieldview draws it as a 3d model. however, the orientation of that model w.r.t. to the orientation of the frame is not consistent - sometimes it appears in front of the frame, sometimes it is mostly behind it.

this would be a great first issue for someone who's got the patience to sit down and work out the 24 correct offset and rotation values and submit that as a PR to itemframes.

there's at least 2 issues here: ![image](/attachments/364fa9cd-396f-4dd7-b6d3-99e99d5210d0) * item is `bbq:pepperoni` * this image shows 4 item frames oriented in different ways (param2 = 1, 5, 9, and 23). however, in 3 of them, the item is shown right-side-up, and in 1 of them, it is upside down. notably, there are no orientations where the item is rotated 90 or 270 degrees. ![image](/attachments/0c8f2b12-4308-4294-b16b-ccf739485209) * item is `cannons:ball_stone_stack_2` * this is related to issue #1273, but it highlights an additional issue. the item has a nodebox drawtype and no inventory/wield image, so wieldview draws it as a 3d model. however, the orientation of that model w.r.t. to the orientation of the frame is not consistent - sometimes it appears in front of the frame, sometimes it is mostly behind it. this would be a great first issue for someone who's got the patience to sit down and work out the 24 correct offset and rotation values and submit that as a PR to itemframes.
flux added the
2. prio/good first issue
label 2023-02-04 00:37:05 +00:00
https://notabug.org/TenPlus1/itemframes/pulls/11

got merged. TenPlus1 added an ability to rotate itemframes and items with sneak+punch

got merged. TenPlus1 added an ability to rotate itemframes and items with sneak+punch
AliasAlreadyTaken added this to the 1.1.119 milestone 2023-05-07 18:47:19 +00:00
AliasAlreadyTaken added the
4. step/ready to QA test
label 2023-05-07 19:25:26 +00:00
AliasAlreadyTaken added the
ugh/QA OK
label 2023-05-09 11:03:27 +00:00
Member

you can now indeed rotate an itemframe by sneak-punching it, but problems remain.

  • rotating the itemframe w/ a screwdriver/rhotator still does not update the entity

  • items in itemframes on the ground show their rear face, not their front face

    image

  • display of nodes like cannonballs is still very inconsistent

    image

these can probably become new issues.

you can now indeed rotate an itemframe by sneak-punching it, but problems remain. * rotating the itemframe w/ a screwdriver/rhotator still does not update the entity * items in itemframes on the ground show their rear face, not their front face ![image](/attachments/dedbad9c-0015-4a42-ad12-c01970b921fe) * display of nodes like cannonballs is still very inconsistent ![image](/attachments/2c444602-fe59-4c1c-acf7-0ebeb0a1156a) these can probably become new issues.
251 KiB
180 KiB
flux closed this issue 2023-05-18 18:44:57 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2023-05-18 19:14:30 +00:00
AliasAlreadyTaken was unassigned by flux 2023-05-18 19:14:34 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#3713
No description provided.