your-land/bugtracker
your-land/bugtracker
41
22
Issues 3.6k Projects 4 Wiki

Lichberry reports: this is more of an oddity - if ... #974

New Issue
Closed
opened 2021-10-30 10:47:56 +02:00 by yourland-report · 10 comments
yourland-report commented 2021-10-30 10:47:56 +02:00
Member
Copy Link

Lichberry reports a bug:

this is more of an oddity - if you create the cucina vegana salad glass bowl dish (it's a salad), you can use any bowl from the bowl group. After you have eaten the salad, any bowl you used gets force converted into a glass bowl and is returned to your inventory as such. I used a wooden bowl and got a glass bowl back.

Player position:

{
	y = 20.5,
	x = 2070.5900878906,
	z = 1163.9490966797
}

Player look:

{
	y = -0.20569179952145,
	x = 0.1307827681303,
	z = 0.96983850002289
}

Player information:

{
	min_rtt = 0.016000000759959,
	max_rtt = 0.22800000011921,
	connection_uptime = 1362,
	max_jitter = 0.20500001311302,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "de",
	version_string = "5.4.1",
	avg_rtt = 0.020999999716878,
	state = "Active",
	avg_jitter = 0.0030000004917383,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 25\", \"\", \"3d_armor:chestplate_crystal 1 25\", \"3d_armor:leggings_crystal 1 25\", \"3d_armor:boots_crystal 1 25\"}",
		yl_commons_thankyou = "7",
		jointime = "1611008087",
		yl_commons_player_joined = "1635582393",
		["signslib:pos"] = "(2070,19,1168)",
		digged_nodes = "24078",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 16, [\"x\"] = 2150, [\"z\"] = 1074}, [\"last_death_portal\"] = 1629802471}",
		["stamina:level"] = "12",
		punch_count = "890",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "13156",
		crafted = "1445",
		placed_nodes = "2700",
		xp = "24519",
		played_time = "236342",
		died = "9",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1611008087"
	}
}

Log identifier


[MOD] yl_report log identifier = EotMZq4e8LdVi5d83e6EomPVgBlyUmvd

Profiler save:

profile-20211030T104755.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=58886.3, max_lag=17.5714, clients={Lichberry, Paso, Bla, Robo, meatball, Service, katiebee, AliasAlreadyTaken, _DRAGON_, Bailiff, Diaeresis, Bond007, Arabella, Flippster, flux}

Teleport command:

/teleport xyz 2071 21 1164

Compass command:

/give_compass Construction EotMZq4e8LdVi5d83e6EomPVgBlyUmvd D2691E 2071 21 1164
Lichberry reports a bug: > this is more of an oddity - if you create the cucina vegana salad glass bowl dish (it's a salad), you can use any bowl from the bowl group. After you have eaten the salad, any bowl you used gets force converted into a glass bowl and is returned to your inventory as such. I used a wooden bowl and got a glass bowl back. Player position: ``` { y = 20.5, x = 2070.5900878906, z = 1163.9490966797 } ``` Player look: ``` { y = -0.20569179952145, x = 0.1307827681303, z = 0.96983850002289 } ``` Player information: ``` { min_rtt = 0.016000000759959, max_rtt = 0.22800000011921, connection_uptime = 1362, max_jitter = 0.20500001311302, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "de", version_string = "5.4.1", avg_rtt = 0.020999999716878, state = "Active", avg_jitter = 0.0030000004917383, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 25\", \"\", \"3d_armor:chestplate_crystal 1 25\", \"3d_armor:leggings_crystal 1 25\", \"3d_armor:boots_crystal 1 25\"}", yl_commons_thankyou = "7", jointime = "1611008087", yl_commons_player_joined = "1635582393", ["signslib:pos"] = "(2070,19,1168)", digged_nodes = "24078", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", yl_church = "return {[\"last_death\"] = {[\"y\"] = 16, [\"x\"] = 2150, [\"z\"] = 1074}, [\"last_death_portal\"] = 1629802471}", ["stamina:level"] = "12", punch_count = "890", arenalib_infobox_arenaID = "0", inflicted_damage = "13156", crafted = "1445", placed_nodes = "2700", xp = "24519", played_time = "236342", died = "9", hud_state = "on", repellant = "0", yl_commons_player_created = "1611008087" } } ``` Log identifier ``` [MOD] yl_report log identifier = EotMZq4e8LdVi5d83e6EomPVgBlyUmvd ``` Profiler save: ``` profile-20211030T104755.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=58886.3, max_lag=17.5714, clients={Lichberry, Paso, Bla, Robo, meatball, Service, katiebee, AliasAlreadyTaken, _DRAGON_, Bailiff, Diaeresis, Bond007, Arabella, Flippster, flux} ``` Teleport command: ``` /teleport xyz 2071 21 1164 ``` Compass command: ``` /give_compass Construction EotMZq4e8LdVi5d83e6EomPVgBlyUmvd D2691E 2071 21 1164 ```
AliasAlreadyTaken was assigned by yourland-report 2021-10-30 10:47:56 +02:00
Styxcolor added the
5. result/duplicate
 label 2021-10-31 02:05:17 +01:00
Styxcolor commented 2021-10-31 02:05:41 +01:00
Owner
Copy Link

Just discovered that this has already been reported as issue #490 . Will fix.

Just discovered that this has already been reported as issue #490 . Will fix.
Styxcolor added the
4. step/at work
 label 2021-10-31 02:06:53 +01:00
Styxcolor removed the
5. result/duplicate
 label 2021-10-31 02:16:32 +01:00
Styxcolor commented 2021-10-31 02:16:51 +01:00
Owner
Copy Link

turns out my issue is similar but not a duplicate, it's different mods.

turns out my issue is similar but not a duplicate, it's different mods.
Styxcolor added the
5. result/duplicate
 label 2021-10-31 03:12:14 +01:00
Styxcolor commented 2021-10-31 03:12:44 +01:00
Owner
Copy Link

upon more research, it is a duplicate. It is an integration issue of at least three mods, farming, ethereal and cucina vegana.

upon more research, it is a duplicate. It is an integration issue of at least three mods, farming, ethereal and cucina vegana.
Styxcolor self-assigned this 2021-10-31 12:44:10 +01:00
Styxcolor commented 2021-11-11 19:43:33 +01:00
Owner
Copy Link

ethereal is out, even ethereal's own code says when farming:bowl is present, ethereal:bowl takes a backseat. Alias forced that one out in:

#954

So we're left with integrating cucina_vegana:bowl and farming:bowl

A first taste how the fixes look is in

#978

A more elegant fix might be possible engine side and is worked on, but as long as no one has an idea when it drops we need something else, something better than we got right now. I've created a separate lua file for all the fixed recipes that are coming.

ethereal is out, even ethereal's own code says when farming:bowl is present, ethereal:bowl takes a backseat. Alias forced that one out in: #954 So we're left with integrating cucina_vegana:bowl and farming:bowl A first taste how the fixes look is in #978 A more elegant fix might be possible engine side and is worked on, but as long as no one has an idea when it drops we need something else, something better than we got right now. I've created a separate lua file for all the fixed recipes that are coming.
Styxcolor commented 2021-11-11 19:55:14 +01:00
Owner
Copy Link

Recipes to fix:

  • farming:spanish_potatoes
  • farming:beetroot_soup
  • farming:porridge
  • farming:bibimbap (2 variations, one veggie)
  • cucina_vegana:sea_salad (change to group:bowl here)
  • farming:cornstarch
  • farming:onion_soup
  • farming:tomato_soup
  • farming:potato_salad
  • cucina_vegana:bowl_rice (2 variations of water)
  • ethereal:mushroom_soup
  • farming:pea_soup
  • ethereal:hearty_stew(2 variations, one with fern)
  • farming:potato_omelet
  • farming:paella
  • cucina_vegana:salad_bowl
  • ethereal:teriyaki_beef
  • farming:chili_bowl
  • cucina_vegana:salad_hollandaise
  • farming:salad
Recipes to fix: - farming:spanish_potatoes - farming:beetroot_soup - farming:porridge - farming:bibimbap (2 variations, one veggie) - cucina_vegana:sea_salad (change to group:bowl here) - farming:cornstarch - farming:onion_soup - farming:tomato_soup - farming:potato_salad - cucina_vegana:bowl_rice (2 variations of water) - ethereal:mushroom_soup - farming:pea_soup - ethereal:hearty_stew(2 variations, one with fern) - farming:potato_omelet - farming:paella - cucina_vegana:salad_bowl - ethereal:teriyaki_beef - farming:chili_bowl - cucina_vegana:salad_hollandaise - farming:salad
Styxcolor commented 2021-11-11 20:33:10 +01:00
Owner
Copy Link

found an issue while testing farming:porridge

it accepts glasses of milk, not the full milk group
it's crucial that it's an item that returns an empty vessels:drinking glass
this is true for cucina_vegana:soy_milk and moretrees:coconut_milk

also I now understand why you can fill the bucket of milk into glasses of milk
that could be a workaround for water recipes with the farming glass of water too

found an issue while testing farming:porridge it accepts glasses of milk, not the full milk group it's crucial that it's an item that returns an empty vessels:drinking glass this is true for cucina_vegana:soy_milk and moretrees:coconut_milk also I now understand why you can fill the bucket of milk into glasses of milk that could be a workaround for water recipes with the farming glass of water too
Styxcolor commented 2021-11-11 21:22:28 +01:00
Owner
Copy Link

a breakthrough was made, I thoroughly understand the replacements mechanic now

more group fixes were made while I'm testing and editing all the affected recipes.

temporary list for recipes affected by cornstarch (must check whether they return an empty farming:bowl)
-ethereal:teriyaki_chicken
-farming:cheese_vegan (2x with and without ethanol)
-farming:turkish_delight
-ethereal:teriyalki_beef

a breakthrough was made, I thoroughly understand the replacements mechanic now more group fixes were made while I'm testing and editing all the affected recipes. temporary list for recipes affected by cornstarch (must check whether they return an empty farming:bowl) -ethereal:teriyaki_chicken -farming:cheese_vegan (2x with and without ethanol) -farming:turkish_delight -ethereal:teriyalki_beef
Styxcolor commented 2021-11-11 23:21:04 +01:00
Owner
Copy Link

temporary list for recipes affected by cucina_vegana:bowl_rice
(checking whether each returns the glass bowl as it should)

  • cucina_vegana:asparagus_rice
  • cucina_vegana:vegan_sushi (2 variations)
  • cooking the rice (that returns the bowl on use, I checked)
  • farming:bibimbap (2 variations, one veggie)
  • farming:paella
  • farming:onigiri
  • farming:mochi
  • farming:chili_bowl
  • ethereal:sushi_kappamaki
  • ethereal:sushi_nigiri
  • ethereal:sushi_tamago
  • ethereal:teriyaki_beef
  • creating a shelf (that one doesn't count)
temporary list for recipes affected by cucina_vegana:bowl_rice (checking whether each returns the glass bowl as it should) - cucina_vegana:asparagus_rice - cucina_vegana:vegan_sushi (2 variations) - cooking the rice (that returns the bowl on use, I checked) - farming:bibimbap (2 variations, one veggie) - farming:paella - farming:onigiri - farming:mochi - farming:chili_bowl - ethereal:sushi_kappamaki - ethereal:sushi_nigiri - ethereal:sushi_tamago - ethereal:teriyaki_beef - creating a shelf (that one doesn't count)
Styxcolor commented 2021-11-11 23:41:31 +01:00
Owner
Copy Link

temporary note
food_sugar items that return an empty vessels:glass_bottle

  • canned_food:honey_jar
  • cucina_vegana:dandelion_honey

vessels:drinking_glass

  • cucina_vegana:molasses
temporary note food_sugar items that return an empty vessels:glass_bottle - canned_food:honey_jar - cucina_vegana:dandelion_honey vessels:drinking_glass - cucina_vegana:molasses
Styxcolor commented 2021-11-12 00:42:03 +01:00
Owner
Copy Link

Finally, tested and ready:
commit c4ee5a74b19e53223499c3678e03da37de773287

Finally, tested and ready: commit c4ee5a74b19e53223499c3678e03da37de773287
Styxcolor added this to the 1.1.99 milestone 2021-11-12 00:42:37 +01:00
AliasAlreadyTaken was unassigned by Styxcolor 2021-11-12 00:42:41 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/possible close

Should be closed, but a second opinion is asked

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
kind/standalone

issues that don't depend on internal access and can be implemented as a stand-alone project

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/possible close
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
kind/standalone
Milestone
Clear milestone
No items
No Milestone
1.1.99
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Styxcolor
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#974
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?