Eraldemay reports: Attacking players with PvP dis ... #973

New Issue

yourland-report · 2021-10-30T07:13:51Z

yourland-report commented

2021-10-30 07:13:51 +00:00

Eraldemay reports a bug:

Attacking players with PvP disabled still causes knockback and they can be pushed off walls etc.

Player position:

{
	y = 28.5,
	x = 6163.8012695313,
	z = 5856.7001953125
}

Player look:

{
	y = -0.61221730709076,
	x = -0.026353802531958,
	z = 0.79025030136108
}

Player information:

{
	min_rtt = 0.30500000715256,
	max_rtt = 3.0339999198914,
	connection_uptime = 14301,
	max_jitter = 2.6870000362396,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.3129999935627,
	state = "Active",
	avg_jitter = 0.010000020265579,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 14840\", \"3d_armor:chestplate_crystal 1 14840\", \"shields:shield_crystal 1 14840\", \"3d_armor:boots_crystal 1 14840\", \"3d_armor:leggings_crystal 1 14840\", \"\"}",
		["petz:werewolf_vignette_id"] = "20",
		["petz:werewolf"] = "0",
		jointime = "1628925507",
		yl_commons_player_joined = "1635563749",
		["signslib:pos"] = "(6120,5,5693)",
		digged_nodes = "529448",
		xp = "363154",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		placed_nodes = "151627",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -6730, [\"x\"] = 6113, [\"z\"] = 5722}, [\"last_death_portal\"] = 1635474089}",
		yl_commons_thankyou = "34",
		["stamina:level"] = "10.875",
		punch_count = "13834",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "272544",
		crafted = "2193",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		played_time = "1606752",
		["petz:werewolf_clan_idx"] = "3",
		died = "37",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1628925507"
	}
}

Log identifier


[MOD] yl_report log identifier = xSZSjvP5KkdTHw3zMqWCeAAU17vDoP3q

Profiler save:

profile-20211030T091350.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=53257.5, max_lag=15.4696, clients={debian44, Nobody24, Lupercus, meatball, bluattire, Xonon, Syriacus, jakob, Service, katiebee, AliasAlreadyTaken, Bailiff, Diaeresis, Bond007, Eraldemay, Flippster, flux}

Teleport command:

/teleport xyz 6164 29 5857

Compass command:

/give_compass Construction xSZSjvP5KkdTHw3zMqWCeAAU17vDoP3q D2691E 6164 29 5857

Eraldemay reports a bug: > Attacking players with PvP disabled still causes knockback and they can be pushed off walls etc. Player position: ``` { y = 28.5, x = 6163.8012695313, z = 5856.7001953125 } ``` Player look: ``` { y = -0.61221730709076, x = -0.026353802531958, z = 0.79025030136108 } ``` Player information: ``` { min_rtt = 0.30500000715256, max_rtt = 3.0339999198914, connection_uptime = 14301, max_jitter = 2.6870000362396, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.3129999935627, state = "Active", avg_jitter = 0.010000020265579, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 14840\", \"3d_armor:chestplate_crystal 1 14840\", \"shields:shield_crystal 1 14840\", \"3d_armor:boots_crystal 1 14840\", \"3d_armor:leggings_crystal 1 14840\", \"\"}", ["petz:werewolf_vignette_id"] = "20", ["petz:werewolf"] = "0", jointime = "1628925507", yl_commons_player_joined = "1635563749", ["signslib:pos"] = "(6120,5,5693)", digged_nodes = "529448", xp = "363154", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", placed_nodes = "151627", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = -6730, [\"x\"] = 6113, [\"z\"] = 5722}, [\"last_death_portal\"] = 1635474089}", yl_commons_thankyou = "34", ["stamina:level"] = "10.875", punch_count = "13834", arenalib_infobox_arenaID = "0", inflicted_damage = "272544", crafted = "2193", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", played_time = "1606752", ["petz:werewolf_clan_idx"] = "3", died = "37", hud_state = "on", repellant = "0", yl_commons_player_created = "1628925507" } } ``` Log identifier ``` [MOD] yl_report log identifier = xSZSjvP5KkdTHw3zMqWCeAAU17vDoP3q ``` Profiler save: ``` profile-20211030T091350.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=53257.5, max_lag=15.4696, clients={debian44, Nobody24, Lupercus, meatball, bluattire, Xonon, Syriacus, jakob, Service, katiebee, AliasAlreadyTaken, Bailiff, Diaeresis, Bond007, Eraldemay, Flippster, flux} ``` Teleport command: ``` /teleport xyz 6164 29 5857 ``` Compass command: ``` /give_compass Construction xSZSjvP5KkdTHw3zMqWCeAAU17vDoP3q D2691E 6164 29 5857 ```

AliasAlreadyTaken was assigned by yourland-report

2021-10-30 07:13:51 +00:00

Styxcolor commented

2021-10-30 23:45:28 +00:00

This is a remarkable one...would that mean that you can "kill" a player by pushing them off a high enough wall circumventing the pvp disabled state? Man! Then there should be no pushback!

Styxcolor added the

1. kind/bug

label 2021-11-08 19:17:53 +00:00

flux referenced this issue

2022-04-20 17:58:24 +00:00

Bla reports: upie just killed me with the b ... #1801

flux commented

2022-04-20 18:03:21 +00:00

This should be fixed in pvpplus itself by adding the following code:

local old_calculate_knockback = minetest.calculate_knockback
function minetest.calculate_knockback(player, hitter, ...)
    if not pvpplus.is_pvp(player:get_player_name()) or not pvpplus.is_pvp(hitter:get_player_name()) then
        return 0
    end
    return old_calculate_knockback(player, hitter, ...)
end

This should be fixed in pvpplus itself by adding the following code: ```lua local old_calculate_knockback = minetest.calculate_knockback function minetest.calculate_knockback(player, hitter, ...) if not pvpplus.is_pvp(player:get_player_name()) or not pvpplus.is_pvp(hitter:get_player_name()) then return 0 end return old_calculate_knockback(player, hitter, ...) end ```

👍 1

flux commented

2022-05-03 20:04:27 +00:00

Upstream: https://github.com/MT-Eurythmia/pvpplus/pull/8

AliasAlreadyTaken added the

3. source/mod upstream

label 2022-05-03 20:21:59 +00:00

AliasAlreadyTaken commented

2022-05-03 20:30:20 +00:00

Since we cannot expect upstream to ever pull flux' PR, we added it to yl_commons as a temporary forever bugfix: e738fb58ac

Since we cannot expect upstream to ever pull flux' PR, we added it to yl_commons as a temporary forever bugfix: https://gitea.your-land.de/your-land/yl_commons/commit/e738fb58ac67aa9c7e07d463e9f6b17e3a8f6042

AliasAlreadyTaken closed this issue

2022-05-03 20:30:20 +00:00

AliasAlreadyTaken added the

5. result/fixed

label 2022-05-03 20:30:30 +00:00

AliasAlreadyTaken added this to the 1.1.110 milestone 2022-05-03 20:30:33 +00:00

flux commented

2022-05-14 16:47:09 +00:00

Upstream PR actually got pulled https://github.com/MT-Eurythmia/pvpplus/pull/8

👍 1

AliasAlreadyTaken referenced this issue

2023-12-14 09:48:38 +00:00