Machtrollo reports: The two kinds of palm tree pro ... #882

New Issue

yourland-report · 2021-09-04T17:50:52Z

yourland-report commented

2021-09-04 17:50:52 +00:00

Machtrollo reports a bug:

The two kinds of palm tree products (trunk, plank, sapling, fruit, ...) should stack together in inventory, or at least should have more discernable item icons.

Player position:

{
	y = -0.49899998307228,
	x = 2089.0671386719,
	z = 1115.4870605469
}

Player look:

{
	y = 0.9947207570076,
	x = -0.0025251188781112,
	z = 0.10258781164885
}

Player information:

{
	min_rtt = 0.016000000759959,
	max_rtt = 2.6489999294281,
	connection_uptime = 15288,
	max_jitter = 1.6360000371933,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.019999999552965,
	state = "Active",
	avg_jitter = 0.061000000685453,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_bronze 1 18640\", \"shields:shield_bronze 1 18640\", \"3d_armor:chestplate_bronze 1 18640\", \"3d_armor:leggings_bronze 1 18640\", \"3d_armor:boots_crystal 1 4220\", \"\"}",
		played_time = "2432306",
		yl_commons_player_joined = "1630762620",
		["signslib:pos"] = "(2081,16,1120)",
		digged_nodes = "34873",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 7, [\"x\"] = 1276, [\"z\"] = 2326}, [\"last_death_portal\"] = 1628262529}",
		["stamina:level"] = "15",
		xp = "37286",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "3896",
		crafted = "15695",
		yl_commons_thankyou = "2",
		punch_count = "554",
		placed_nodes = "17462",
		died = "33",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1610685920"
	}
}

Log identifier


[MOD] yl_report log identifier = DpF264P9nz9MMKoCO53QSyx8YLEDUMNz

Profiler save:

profile-20210904T195052.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=421989, max_lag=3.57685, clients={lilou, LeniOwO, Tezzy, darealbang, BLADE, Bishiro, Boot, phillip, Tzatxli, jakob, flux, Machtrollo, Helel, Ernesto, Burnhard, Torri, hbreturns, Bailiff, Service, AliasAlreadyTaken}

Teleport command:

/teleport xyz 2089 0 1115

Compass command:

/give_compass Construction DpF264P9nz9MMKoCO53QSyx8YLEDUMNz D2691E 2089 0 1115

Machtrollo reports a bug: > The two kinds of palm tree products (trunk, plank, sapling, fruit, ...) should stack together in inventory, or at least should have more discernable item icons. Player position: ``` { y = -0.49899998307228, x = 2089.0671386719, z = 1115.4870605469 } ``` Player look: ``` { y = 0.9947207570076, x = -0.0025251188781112, z = 0.10258781164885 } ``` Player information: ``` { min_rtt = 0.016000000759959, max_rtt = 2.6489999294281, connection_uptime = 15288, max_jitter = 1.6360000371933, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.019999999552965, state = "Active", avg_jitter = 0.061000000685453, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_bronze 1 18640\", \"shields:shield_bronze 1 18640\", \"3d_armor:chestplate_bronze 1 18640\", \"3d_armor:leggings_bronze 1 18640\", \"3d_armor:boots_crystal 1 4220\", \"\"}", played_time = "2432306", yl_commons_player_joined = "1630762620", ["signslib:pos"] = "(2081,16,1120)", digged_nodes = "34873", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 7, [\"x\"] = 1276, [\"z\"] = 2326}, [\"last_death_portal\"] = 1628262529}", ["stamina:level"] = "15", xp = "37286", arenalib_infobox_arenaID = "0", inflicted_damage = "3896", crafted = "15695", yl_commons_thankyou = "2", punch_count = "554", placed_nodes = "17462", died = "33", hud_state = "on", repellant = "0", yl_commons_player_created = "1610685920" } } ``` Log identifier ``` [MOD] yl_report log identifier = DpF264P9nz9MMKoCO53QSyx8YLEDUMNz ``` Profiler save: ``` profile-20210904T195052.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=421989, max_lag=3.57685, clients={lilou, LeniOwO, Tezzy, darealbang, BLADE, Bishiro, Boot, phillip, Tzatxli, jakob, flux, Machtrollo, Helel, Ernesto, Burnhard, Torri, hbreturns, Bailiff, Service, AliasAlreadyTaken} ``` Teleport command: ``` /teleport xyz 2089 0 1115 ``` Compass command: ``` /give_compass Construction DpF264P9nz9MMKoCO53QSyx8YLEDUMNz D2691E 2089 0 1115 ```

AliasAlreadyTaken was assigned by yourland-report

2021-09-04 17:50:52 +00:00

Styxcolor added the

1. kind/enhancement

4. step/at work

labels 2021-10-31 00:01:58 +00:00

Styxcolor self-assigned this 2021-10-31 00:02:04 +00:00

Styxcolor commented

2021-10-31 00:02:34 +00:00

that falls right into my territory! Will fix/integrate the coconuts, just having to think through the balancing for a bit more.

Styxcolor added the

3. source/integration

label 2021-10-31 00:02:50 +00:00

Styxcolor referenced this issue

2021-10-31 09:49:02 +00:00

Lichberry reports: coconut pieces/flesh (German: ... #968

Styxcolor referenced this issue

2021-10-31 09:49:48 +00:00

Lichberry reports: addition to the previous bug r ... #969

Styxcolor commented

2021-11-05 09:59:13 +00:00

This is the state of things with our two coconut mods:

ethereal coconut can be put down into the world and split with a pickaxe, reappearing as four coconut slices in your inventory.
moretrees coconut can be placed in the world, too, but if treated with a pickaxe just
returns to the inventory as full coconut
ethereal coconut...also only has this recipe where you got four slices out of it
you can recollect four slices into a coconut again
or make coconut jam out of them.
moretrees coconut can be split with the farming:cutting_board or six types of axe (silver, mythril, steel, mese, diamond, bronze)
moretrees:raw_coconut is displayed as having no recipe but is obtained as byproduct of splitting a moretrees coconut for coconut milk
shouldn't coconut milk join the milk group just like soymilk?
Also we discovered a huge bug where splitting the moretrees coconut consumes any of your axes used with it
and sometimes (cases unclear as of yet) even your farming:cutting board

See here: #868

also, if you work with a stack of moretrees coconuts in one sitting (craft all) you sometimes only get a single or no coconut meat back in return

Next, I will check the code to know what's happening there and to give better recommendations on how to resolve the issues.

This is the state of things with our two coconut mods: - ethereal coconut can be put down into the world and split with a pickaxe, reappearing as four coconut slices in your inventory. - moretrees coconut can be placed in the world, too, but if treated with a pickaxe just returns to the inventory as full coconut - ethereal coconut...also only has this recipe where you got four slices out of it you can recollect four slices into a coconut again or make coconut jam out of them. - moretrees coconut can be split with the farming:cutting_board or six types of axe (silver, mythril, steel, mese, diamond, bronze) - moretrees:raw_coconut is displayed as having no recipe but is obtained as byproduct of splitting a moretrees coconut for coconut milk - shouldn't coconut milk join the milk group just like soymilk? - Also we discovered a huge bug where splitting the moretrees coconut consumes any of your axes used with it and sometimes (cases unclear as of yet) even your farming:cutting board See here: #868 also, if you work with a stack of moretrees coconuts in one sitting (craft all) you sometimes only get a single or no coconut meat back in return Next, I will check the code to know what's happening there and to give better recommendations on how to resolve the issues.

Styxcolor commented

2021-11-05 11:30:57 +00:00

The moretrees coconut can be found in moretrees\crafts.lua
The ethereal coconut can be found in ethereal\food.lua

The moretrees coconut can be found in moretrees\crafts.lua The ethereal coconut can be found in ethereal\food.lua

Styxcolor added the

4. step/help wanted

label 2021-11-05 11:33:13 +00:00

Styxcolor commented

2021-11-05 11:56:43 +00:00

Ah wait, also Machtrollo's original report states the palms produce similar looking but not stackable items! That's annoying for sure when they look equal but you can't stack any of the parts, not only the coconuts.

Styxcolor referenced this issue

2021-11-08 14:05:54 +00:00

Lichberry reports: addition to the previous bug r ... #969

Styxcolor referenced this issue

2021-11-08 19:24:49 +00:00

Lichberry reports: when making coconut milk, the ... #956

Styxcolor referenced this issue

2021-11-12 09:10:06 +00:00

Soy, tofu, soy milk #964

Styxcolor referenced this issue

2021-11-14 18:23:33 +00:00

Soy, tofu, soy milk #964

Styxcolor commented

2021-11-15 08:45:09 +00:00

discussed the possibility to alias one of the two palms away...but there is a real risk all the palms of this type can't spawn anymore and we only have half of the palms we should have ingame.

The less harsh path is the following then:

integrating the recipes
making one set of palm icons visually clearer from the other. They're not stackable even as a group, so make the visually different.

discussed the possibility to alias one of the two palms away...but there is a real risk all the palms of this type can't spawn anymore and we only have half of the palms we should have ingame. The less harsh path is the following then: - integrating the recipes - making one set of palm icons visually clearer from the other. They're not stackable even as a group, so make the visually different.

Styxcolor commented

2021-11-15 10:22:55 +00:00

Apparently I cannot adjust anything about moretrees:coconut remotely. Everything is entangled in modspecific loops and variables. I couldn't even smuggle in a recipe for ethereal:coconut_slice. Also there is a phantom second sort of moretrees coconut for which moretree's own recipes do not work. How. Why. I will ask Alias for permission to modify our version of the moretrees mod directly.

Also, maybe I can do a workaround where I can't create coconut slices for moretrees, but could use the raw coconut meat from moretrees for the same purpose as the coconut slices.

Apparently I cannot adjust anything about moretrees:coconut remotely. Everything is entangled in modspecific loops and variables. I couldn't even smuggle in a recipe for ethereal:coconut_slice. Also there is a phantom second sort of moretrees coconut for which moretree's own recipes do not work. How. Why. I will ask Alias for permission to modify our version of the moretrees mod directly. Also, maybe I can do a workaround where I can't create coconut slices for moretrees, but could use the raw coconut meat from moretrees for the same purpose as the coconut slices.

Styxcolor removed the

4. step/at work

label 2021-12-09 03:14:24 +00:00

Diaeresis commented

2022-05-14 17:13:54 +00:00

In lieu of complete unification, would it be possible to make the coconut milk recipe accept ethereal coconuts as well, or duplicate them for ethereal, as a workaround? I believe there is currently no way to produce it, otherwise. Or perhaps a simple recipe to convert between moretrees and ethereal coconuts.

EDIT:
Never mind, I had planted the wrong sapling, the milk can be produced fine.

In lieu of complete unification, would it be possible to make the coconut milk recipe accept ethereal coconuts as well, or duplicate them for ethereal, as a workaround? I believe there is currently no way to produce it, otherwise. Or perhaps a simple recipe to convert between moretrees and ethereal coconuts. EDIT: Never mind, I had planted the wrong sapling, the milk can be produced fine.

flux commented

2022-05-14 19:05:44 +00:00

My vote is to alias the ethereal palm wood to the moretrees wood, and to allow crafting ethereal coconuts into moretrees coconuts and vice versa.

👍 1

flux added

4. step/want approval

and removed

4. step/help wanted

labels 2022-05-14 19:06:06 +00:00

flux added this to the flux's TODO list project 2022-07-02 18:50:05 +00:00

flux removed the

4. step/want approval