Machtrollo reports: The two kinds of palm tree pro ... #882

Open
opened 5 months ago by yourland-report · 6 comments
Collaborator

Machtrollo reports a bug:

The two kinds of palm tree products (trunk, plank, sapling, fruit, ...) should stack together in inventory, or at least should have more discernable item icons.

Player position:

{
	y = -0.49899998307228,
	x = 2089.0671386719,
	z = 1115.4870605469
}

Player look:

{
	y = 0.9947207570076,
	x = -0.0025251188781112,
	z = 0.10258781164885
}

Player information:

{
	min_rtt = 0.016000000759959,
	max_rtt = 2.6489999294281,
	connection_uptime = 15288,
	max_jitter = 1.6360000371933,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.019999999552965,
	state = "Active",
	avg_jitter = 0.061000000685453,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_bronze 1 18640\", \"shields:shield_bronze 1 18640\", \"3d_armor:chestplate_bronze 1 18640\", \"3d_armor:leggings_bronze 1 18640\", \"3d_armor:boots_crystal 1 4220\", \"\"}",
		played_time = "2432306",
		yl_commons_player_joined = "1630762620",
		["signslib:pos"] = "(2081,16,1120)",
		digged_nodes = "34873",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 7, [\"x\"] = 1276, [\"z\"] = 2326}, [\"last_death_portal\"] = 1628262529}",
		["stamina:level"] = "15",
		xp = "37286",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "3896",
		crafted = "15695",
		yl_commons_thankyou = "2",
		punch_count = "554",
		placed_nodes = "17462",
		died = "33",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1610685920"
	}
}

Log identifier


[MOD] yl_report log identifier = DpF264P9nz9MMKoCO53QSyx8YLEDUMNz

Profiler save:

profile-20210904T195052.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=421989, max_lag=3.57685, clients={lilou, LeniOwO, Tezzy, darealbang, BLADE, Bishiro, Boot, phillip, Tzatxli, jakob, flux, Machtrollo, Helel, Ernesto, Burnhard, Torri, hbreturns, Bailiff, Service, AliasAlreadyTaken}

Teleport command:

/teleport xyz 2089 0 1115

Compass command:

/give_compass Construction DpF264P9nz9MMKoCO53QSyx8YLEDUMNz D2691E 2089 0 1115
Machtrollo reports a bug: > The two kinds of palm tree products (trunk, plank, sapling, fruit, ...) should stack together in inventory, or at least should have more discernable item icons. Player position: ``` { y = -0.49899998307228, x = 2089.0671386719, z = 1115.4870605469 } ``` Player look: ``` { y = 0.9947207570076, x = -0.0025251188781112, z = 0.10258781164885 } ``` Player information: ``` { min_rtt = 0.016000000759959, max_rtt = 2.6489999294281, connection_uptime = 15288, max_jitter = 1.6360000371933, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.019999999552965, state = "Active", avg_jitter = 0.061000000685453, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_bronze 1 18640\", \"shields:shield_bronze 1 18640\", \"3d_armor:chestplate_bronze 1 18640\", \"3d_armor:leggings_bronze 1 18640\", \"3d_armor:boots_crystal 1 4220\", \"\"}", played_time = "2432306", yl_commons_player_joined = "1630762620", ["signslib:pos"] = "(2081,16,1120)", digged_nodes = "34873", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 7, [\"x\"] = 1276, [\"z\"] = 2326}, [\"last_death_portal\"] = 1628262529}", ["stamina:level"] = "15", xp = "37286", arenalib_infobox_arenaID = "0", inflicted_damage = "3896", crafted = "15695", yl_commons_thankyou = "2", punch_count = "554", placed_nodes = "17462", died = "33", hud_state = "on", repellant = "0", yl_commons_player_created = "1610685920" } } ``` Log identifier ``` [MOD] yl_report log identifier = DpF264P9nz9MMKoCO53QSyx8YLEDUMNz ``` Profiler save: ``` profile-20210904T195052.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=421989, max_lag=3.57685, clients={lilou, LeniOwO, Tezzy, darealbang, BLADE, Bishiro, Boot, phillip, Tzatxli, jakob, flux, Machtrollo, Helel, Ernesto, Burnhard, Torri, hbreturns, Bailiff, Service, AliasAlreadyTaken} ``` Teleport command: ``` /teleport xyz 2089 0 1115 ``` Compass command: ``` /give_compass Construction DpF264P9nz9MMKoCO53QSyx8YLEDUMNz D2691E 2089 0 1115 ```
AliasAlreadyTaken was assigned by yourland-report 5 months ago
Styxcolor added the
kind/enhancement
step/at work
labels 3 months ago
Styxcolor self-assigned this 3 months ago
Collaborator

that falls right into my territory! Will fix/integrate the coconuts, just having to think through the balancing for a bit more.

that falls right into my territory! Will fix/integrate the coconuts, just having to think through the balancing for a bit more.
Styxcolor added the
source/integration
label 3 months ago
Collaborator

This is the state of things with our two coconut mods:

  • ethereal coconut can be put down into the world and split with a pickaxe, reappearing as four coconut slices in your inventory.

  • moretrees coconut can be placed in the world, too, but if treated with a pickaxe just
    returns to the inventory as full coconut

  • ethereal coconut...also only has this recipe where you got four slices out of it
    you can recollect four slices into a coconut again
    or make coconut jam out of them.

  • moretrees coconut can be split with the farming:cutting_board or six types of axe (silver, mythril, steel, mese, diamond, bronze)

  • moretrees:raw_coconut is displayed as having no recipe but is obtained as byproduct of splitting a moretrees coconut for coconut milk

  • shouldn't coconut milk join the milk group just like soymilk?

  • Also we discovered a huge bug where splitting the moretrees coconut consumes any of your axes used with it
    and sometimes (cases unclear as of yet) even your farming:cutting board

See here: #868

also, if you work with a stack of moretrees coconuts in one sitting (craft all) you sometimes only get a single or no coconut meat back in return

Next, I will check the code to know what's happening there and to give better recommendations on how to resolve the issues.

This is the state of things with our two coconut mods: - ethereal coconut can be put down into the world and split with a pickaxe, reappearing as four coconut slices in your inventory. - moretrees coconut can be placed in the world, too, but if treated with a pickaxe just returns to the inventory as full coconut - ethereal coconut...also only has this recipe where you got four slices out of it you can recollect four slices into a coconut again or make coconut jam out of them. - moretrees coconut can be split with the farming:cutting_board or six types of axe (silver, mythril, steel, mese, diamond, bronze) - moretrees:raw_coconut is displayed as having no recipe but is obtained as byproduct of splitting a moretrees coconut for coconut milk - shouldn't coconut milk join the milk group just like soymilk? - Also we discovered a huge bug where splitting the moretrees coconut consumes any of your axes used with it and sometimes (cases unclear as of yet) even your farming:cutting board See here: #868 also, if you work with a stack of moretrees coconuts in one sitting (craft all) you sometimes only get a single or no coconut meat back in return Next, I will check the code to know what's happening there and to give better recommendations on how to resolve the issues.
Collaborator

The moretrees coconut can be found in moretrees\crafts.lua
The ethereal coconut can be found in ethereal\food.lua

The moretrees coconut can be found in moretrees\crafts.lua The ethereal coconut can be found in ethereal\food.lua
Styxcolor added the
step/help wanted
label 3 months ago
Collaborator

Ah wait, also Machtrollo's original report states the palms produce similar looking but not stackable items! That's annoying for sure when they look equal but you can't stack any of the parts, not only the coconuts.

Ah wait, also Machtrollo's original report states the palms produce similar looking but not stackable items! That's annoying for sure when they look equal but you can't stack any of the parts, not only the coconuts.
Collaborator

discussed the possibility to alias one of the two palms away...but there is a real risk all the palms of this type can't spawn anymore and we only have half of the palms we should have ingame.

The less harsh path is the following then:

  • integrating the recipes
  • making one set of palm icons visually clearer from the other. They're not stackable even as a group, so make the visually different.
discussed the possibility to alias one of the two palms away...but there is a real risk all the palms of this type can't spawn anymore and we only have half of the palms we should have ingame. The less harsh path is the following then: - integrating the recipes - making one set of palm icons visually clearer from the other. They're not stackable even as a group, so make the visually different.
Collaborator

Apparently I cannot adjust anything about moretrees:coconut remotely. Everything is entangled in modspecific loops and variables. I couldn't even smuggle in a recipe for ethereal:coconut_slice. Also there is a phantom second sort of moretrees coconut for which moretree's own recipes do not work. How. Why. I will ask Alias for permission to modify our version of the moretrees mod directly.

Also, maybe I can do a workaround where I can't create coconut slices for moretrees, but could use the raw coconut meat from moretrees for the same purpose as the coconut slices.

Apparently I cannot adjust anything about moretrees:coconut remotely. Everything is entangled in modspecific loops and variables. I couldn't even smuggle in a recipe for ethereal:coconut_slice. Also there is a phantom second sort of moretrees coconut for which moretree's own recipes do not work. How. Why. I will ask Alias for permission to modify our version of the moretrees mod directly. Also, maybe I can do a workaround where I can't create coconut slices for moretrees, but could use the raw coconut meat from moretrees for the same purpose as the coconut slices.
Styxcolor removed the
step/at work
label 2 months ago
Sign in to join this conversation.
Loading…
There is no content yet.