your-land/bugtracker
your-land/bugtracker
41
22
Issues 3.6k Projects 4 Wiki

tour reports: we seem to run an outdated version of core.serialize ... #8483

New Issue
Open
opened 2025-04-30 02:01:53 +02:00 by yourland-report · 6 comments
yourland-report commented 2025-04-30 02:01:53 +02:00
Member
Copy Link

tour reports a bug:

we seem to run an outdated version of core.serialize

Player position:

{
	z = 1504.8000488281,
	x = 1931.9641113281,
	y = 50.5
}

Player look:

{
	z = 0.36521476507187,
	x = 0.057713568210602,
	y = -0.92913258075714
}

Player information:

{
	minor = 11,
	avg_rtt = 0.01799999922514,
	state = "Active",
	formspec_version = 8,
	max_rtt = 1.3869999647141,
	protocol_version = 46,
	ip_version = 6,
	min_rtt = 0.016000000759959,
	min_jitter = 0,
	max_jitter = 1.3639999628067,
	avg_jitter = 0,
	connection_uptime = 21199,
	serialization_version = 29,
	patch = 0,
	lang_code = "de",
	version_string = "5.11.0",
	major = 5
}

Player meta:

{
	fields = {
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_commons_player_joined = "1745950123",
		xp = "764096",
		["yl_statuseffects:builders_flight:particles_disabled"] = "1",
		jointime = "1625997613",
		played_time = "7135187",
		["ocean_build.last_warning"] = "1.66143e+09",
		placed_nodes = "372883",
		["hud_manager:choppy:waypoint_enabled"] = "y",
		crafted = "97576",
		digged_nodes = "771568",
		died = "212",
		punch_count = "142262",
		["stamina:level"] = "19",
		["ocean_build.ocean_built"] = "11",
		yl_commons_player_created = "1625997613",
		hud_state = "on",
		["stamina:exhaustion"] = "54",
		repellant = "0",
		inflicted_damage = "2841860",
		yl_commons_thankyou = "210",
		["signslib:pos"] = "(6645,11,2997)",
		bitten = "0",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 16872\", \"3d_armor:boots_crystal 1 28400\", \"3d_armor:leggings_rainbow 1 25832\", \"shields:shield_rainbow 1 42304\", \"3d_armor:chestplate_rainbow 1 25832\", \"\"}",
		["hud_manager:yl_snowball:hud__enabled"] = "n",
		yl_church = "return {[\"last_heal\"] = 1674245165, [\"last_death\"] = {[\"z\"] = 958, [\"x\"] = 2137, [\"y\"] = 10}, [\"last_death_portal\"] = 1730926823}",
		arenalib_infobox_arenaID = "0",
		hotbar_size = "24"
	}
}

Log identifier


[MOD] yl_report log identifier = go7N2UNEbwFdI2GWl6yZ2f6JamKHqrsO

Profiler save:

profile-20250430T020153.json_prettyEE

Status:

# Server: version: 5.11.0-yl-lt | game: Minetest Game | uptime: 7d 3h 28min 18s | max lag: 0.468s | clients (16/52): adbshell, AliasAlreadyTaken, Bailiff, Crazylad, DragonWrangler1, JeCel, Leia_og, nakama-ta, oreo1, pink_mothra, Scarletta, selknirW, Service, StarBurst, tour, whosit

Teleport command:

/teleport xyz 1932 51 1505

Compass command:

/give_compass Construction go7N2UNEbwFdI2GWl6yZ2f6JamKHqrsO D2691E 1932 51 1505
tour reports a bug: > we seem to run an outdated version of core.serialize Player position: ``` { z = 1504.8000488281, x = 1931.9641113281, y = 50.5 } ``` Player look: ``` { z = 0.36521476507187, x = 0.057713568210602, y = -0.92913258075714 } ``` Player information: ``` { minor = 11, avg_rtt = 0.01799999922514, state = "Active", formspec_version = 8, max_rtt = 1.3869999647141, protocol_version = 46, ip_version = 6, min_rtt = 0.016000000759959, min_jitter = 0, max_jitter = 1.3639999628067, avg_jitter = 0, connection_uptime = 21199, serialization_version = 29, patch = 0, lang_code = "de", version_string = "5.11.0", major = 5 } ``` Player meta: ``` { fields = { ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_commons_player_joined = "1745950123", xp = "764096", ["yl_statuseffects:builders_flight:particles_disabled"] = "1", jointime = "1625997613", played_time = "7135187", ["ocean_build.last_warning"] = "1.66143e+09", placed_nodes = "372883", ["hud_manager:choppy:waypoint_enabled"] = "y", crafted = "97576", digged_nodes = "771568", died = "212", punch_count = "142262", ["stamina:level"] = "19", ["ocean_build.ocean_built"] = "11", yl_commons_player_created = "1625997613", hud_state = "on", ["stamina:exhaustion"] = "54", repellant = "0", inflicted_damage = "2841860", yl_commons_thankyou = "210", ["signslib:pos"] = "(6645,11,2997)", bitten = "0", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 16872\", \"3d_armor:boots_crystal 1 28400\", \"3d_armor:leggings_rainbow 1 25832\", \"shields:shield_rainbow 1 42304\", \"3d_armor:chestplate_rainbow 1 25832\", \"\"}", ["hud_manager:yl_snowball:hud__enabled"] = "n", yl_church = "return {[\"last_heal\"] = 1674245165, [\"last_death\"] = {[\"z\"] = 958, [\"x\"] = 2137, [\"y\"] = 10}, [\"last_death_portal\"] = 1730926823}", arenalib_infobox_arenaID = "0", hotbar_size = "24" } } ``` Log identifier ``` [MOD] yl_report log identifier = go7N2UNEbwFdI2GWl6yZ2f6JamKHqrsO ``` Profiler save: ``` profile-20250430T020153.json_prettyEE ``` Status: ``` # Server: version: 5.11.0-yl-lt | game: Minetest Game | uptime: 7d 3h 28min 18s | max lag: 0.468s | clients (16/52): adbshell, AliasAlreadyTaken, Bailiff, Crazylad, DragonWrangler1, JeCel, Leia_og, nakama-ta, oreo1, pink_mothra, Scarletta, selknirW, Service, StarBurst, tour, whosit ``` Teleport command: ``` /teleport xyz 1932 51 1505 ``` Compass command: ``` /give_compass Construction go7N2UNEbwFdI2GWl6yZ2f6JamKHqrsO D2691E 1932 51 1505 ```
AliasAlreadyTaken was assigned by yourland-report 2025-04-30 02:01:53 +02:00
whosit added the
1. kind/bug
 label 2025-04-30 02:44:35 +02:00
whosit commented 2025-04-30 02:45:46 +02:00
Member
Copy Link

As tour investigated, this version has some pretty serious issues (one of them caused my luac to malfunction).
Very nice detective work, I was clueless :)

As tour investigated, this version has some pretty serious issues (one of them caused my luac to malfunction). Very nice detective work, I was clueless :)
tour commented 2025-04-30 03:44:40 +02:00
Member
Copy Link

introduced in e12eb9728b, probably bc. of #44

Serializer got an update in the meantime: https://github.com/luanti-org/luanti/pull/11427

This causes multiple problems:

the easiest solution would be to remove that strange override, but serializing userdata would crash again: /eval core.serialize(me)

On the other hand it seems like mobs_redo was the only mod having troubles with that and they implemented counter measures long time ago (68b25c9d08/api.lua (L2780))

We should definitely remove the buggy override. I'm also convinced that mods fixed themselves and try no longer to serialize userdata.

introduced in https://gitea.your-land.de/your-land/yl_commons/commit/e12eb9728b1167f00230a7262626ae6d08269b96, probably bc. of #44 Serializer got an update in the meantime: https://github.com/luanti-org/luanti/pull/11427 This causes multiple problems: - https://github.com/luanti-org/luanti/issues/11899 - https://github.com/luanti-org/luanti/issues/8719 (breaking whosit's luacontroller) - luacontroller serializer abuse the easiest solution would be to remove that strange override, but serializing userdata would crash again: `/eval core.serialize(me)` On the other hand it seems like mobs_redo was the only mod having troubles with that and they implemented counter measures long time ago (https://gitea.your-land.de/your-land/mobs_redo/src/commit/68b25c9d0853b6483fbb1dd58c8ca771898fe084/api.lua#L2780) We should definitely remove the buggy override. I'm also convinced that mods fixed themselves and try no longer to serialize userdata.
tour added this to the Next milestone 2025-04-30 03:45:02 +02:00
tour added the
2. prio/elevated
 label 2025-04-30 03:46:12 +02:00
tour commented 2025-04-30 23:12:56 +02:00
Member
Copy Link

2bcf3efc5d

https://gitea.your-land.de/your-land/yl_commons/commit/2bcf3efc5d2054d5a006ad040be4df38ef9d2838
tour added the
4. step/ready to QA test
 label 2025-04-30 23:13:06 +02:00
whosit commented 2025-05-01 00:50:00 +02:00
Member
Copy Link

We spent some time on test just visiting places and spawning random mobs - didn't notice any issues so far.

We spent some time on test just visiting places and spawning random mobs - didn't notice any issues so far.
whosit modified the milestone from Next to 1.1.128 2025-05-02 16:56:04 +02:00
whosit commented 2025-05-03 01:58:28 +02:00
Member
Copy Link

Got this in my test world:

AsyncErr: Lua: Runtime error from mod '' in callback luaentity_Step(): "Runtime error from mod '' in callback on_dieplayer(): .../builtin/common/serialize.lua:33: unsupported type: userdata
stack traceback:
	[C]: in function 'error'
	.../builtin/common/serialize.lua:33: in function 'count_values'
	.../builtin/common/serialize.lua:29: in function 'count_values'
	.../builtin/common/serialize.lua:36: in function 'count_objects'
	.../builtin/common/serialize.lua:69: in function 'serialize'
	.../builtin/common/serialize.lua:195: in function 'serialize'
	.../xp_redo/builtin.lua:113: in function <.../xp_redo/builtin.lua:74>
	.../builtin/common/register.lua:26: in function <.../builtin/common/register.lua:12>
	[C]: in function 'punch'
	.../mobs_redo/api.lua:2359: in function 'do_states'
	.../mobs_redo/api.lua:3165: in function <...mobs_redo/api.lua:3061>"
stack traceback:
	[C]: in function 'punch'
	.../mobs_redo/api.lua:2359: in function 'do_states'
	.../mobs_redo/api.lua:3165: in function <.../mobs_redo/api.lua:3061>

It's logging code:
285d9ed136/builtin.lua (L113)

Got this in my test world: ```cpp AsyncErr: Lua: Runtime error from mod '' in callback luaentity_Step(): "Runtime error from mod '' in callback on_dieplayer(): .../builtin/common/serialize.lua:33: unsupported type: userdata stack traceback: [C]: in function 'error' .../builtin/common/serialize.lua:33: in function 'count_values' .../builtin/common/serialize.lua:29: in function 'count_values' .../builtin/common/serialize.lua:36: in function 'count_objects' .../builtin/common/serialize.lua:69: in function 'serialize' .../builtin/common/serialize.lua:195: in function 'serialize' .../xp_redo/builtin.lua:113: in function <.../xp_redo/builtin.lua:74> .../builtin/common/register.lua:26: in function <.../builtin/common/register.lua:12> [C]: in function 'punch' .../mobs_redo/api.lua:2359: in function 'do_states' .../mobs_redo/api.lua:3165: in function <...mobs_redo/api.lua:3061>" stack traceback: [C]: in function 'punch' .../mobs_redo/api.lua:2359: in function 'do_states' .../mobs_redo/api.lua:3165: in function <.../mobs_redo/api.lua:3061> ``` It's logging code: https://gitea.your-land.de/your-land/xp_redo/src/commit/285d9ed13659d91dbb6b9733c609833734f072a6/builtin.lua#L113
👀 1
whosit added the
4. step/QA NOK
 label 2025-05-03 02:01:28 +02:00
whosit removed the
4. step/QA NOK
 label 2025-05-03 02:09:02 +02:00
whosit commented 2025-05-03 02:09:57 +02:00
Member
Copy Link

I just swapped serialize to dump 754ab385ec

I guess we should try grepping for more sus usages of serialize.

I just swapped `serialize` to `dump` https://gitea.your-land.de/your-land/xp_redo/commit/754ab385ecdebfafa5b860e490eb7ed271e32fb8 I guess we should try grepping for more sus usages of serialize.
👍 1
AliasAlreadyTaken added the
4. step/QA main
 label 2025-05-07 23:37:00 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/possible close

Should be closed, but a second opinion is asked

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
kind/standalone

issues that don't depend on internal access and can be implemented as a stand-alone project

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/possible close
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
kind/standalone
Milestone
Clear milestone
No items
No Milestone
1.1.128
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#8483
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?