tour reports: can't plant sunflower seeds ... #789

New Issue

yourland-report · 2021-08-02T08:35:45Z

yourland-report commented

2021-08-02 08:35:45 +00:00

tour reports a bug:

can't plant sunflower seeds

Player position:

{
	y = 10.5,
	x = 6894.3940429688,
	z = 3035.9440917969
}

Player look:

{
	y = -0.88039457798004,
	x = 0.46457225084305,
	z = -0.095278732478619
}

Player information:

{
	min_rtt = 0.025000000372529,
	max_rtt = 5.451000213623,
	connection_uptime = 5029,
	max_jitter = 4.6909999847412,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "de",
	version_string = "5.4.1",
	avg_rtt = 0.059999998658895,
	state = "Active",
	avg_jitter = 0.032999999821186,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 1600\", \"3d_armor:chestplate_crystal 1 1600\", \"rainbow_ore:rainbow_ore_leggings 1 640\", \"rainbow_ore:rainbow_ore_helmet 1 640\", \"rainbow_ore:rainbow_ore_shield 1 640\", \"\"}",
		yl_commons_thankyou = "2",
		jointime = "1625997613",
		yl_commons_player_joined = "1627888350",
		["signslib:pos"] = "(6734,-259,3070)",
		digged_nodes = "61677",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -1824, [\"x\"] = 7562, [\"z\"] = 3180}, [\"last_death_portal\"] = 1627034987}",
		["stamina:level"] = "17.025",
		punch_count = "10078",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "181950",
		crafted = "13864",
		xp = "50596",
		died = "37",
		played_time = "295974",
		placed_nodes = "12256",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1625997613"
	}
}

Log identifier


[MOD] yl_report log identifier = pbgWPXauMVq449BnSfWFEzihMPZc4pYC

Profiler save:

profile-20210802T103545.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=5540.4, max_lag=2.58221, clients={tasnemzak, upie, Segmentation_Fault, tour, Apocralypse, AliasAlreadyTaken, White_Feather, Bailiff, Service}

Teleport command:

/teleport xyz 6894 11 3036

Compass command:

/give_compass Construction pbgWPXauMVq449BnSfWFEzihMPZc4pYC D2691E 6894 11 3036

tour reports a bug: > can't plant sunflower seeds Player position: ``` { y = 10.5, x = 6894.3940429688, z = 3035.9440917969 } ``` Player look: ``` { y = -0.88039457798004, x = 0.46457225084305, z = -0.095278732478619 } ``` Player information: ``` { min_rtt = 0.025000000372529, max_rtt = 5.451000213623, connection_uptime = 5029, max_jitter = 4.6909999847412, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "de", version_string = "5.4.1", avg_rtt = 0.059999998658895, state = "Active", avg_jitter = 0.032999999821186, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 1600\", \"3d_armor:chestplate_crystal 1 1600\", \"rainbow_ore:rainbow_ore_leggings 1 640\", \"rainbow_ore:rainbow_ore_helmet 1 640\", \"rainbow_ore:rainbow_ore_shield 1 640\", \"\"}", yl_commons_thankyou = "2", jointime = "1625997613", yl_commons_player_joined = "1627888350", ["signslib:pos"] = "(6734,-259,3070)", digged_nodes = "61677", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = -1824, [\"x\"] = 7562, [\"z\"] = 3180}, [\"last_death_portal\"] = 1627034987}", ["stamina:level"] = "17.025", punch_count = "10078", arenalib_infobox_arenaID = "0", inflicted_damage = "181950", crafted = "13864", xp = "50596", died = "37", played_time = "295974", placed_nodes = "12256", hud_state = "on", repellant = "0", yl_commons_player_created = "1625997613" } } ``` Log identifier ``` [MOD] yl_report log identifier = pbgWPXauMVq449BnSfWFEzihMPZc4pYC ``` Profiler save: ``` profile-20210802T103545.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=5540.4, max_lag=2.58221, clients={tasnemzak, upie, Segmentation_Fault, tour, Apocralypse, AliasAlreadyTaken, White_Feather, Bailiff, Service} ``` Teleport command: ``` /teleport xyz 6894 11 3036 ``` Compass command: ``` /give_compass Construction pbgWPXauMVq449BnSfWFEzihMPZc4pYC D2691E 6894 11 3036 ```

AliasAlreadyTaken was assigned by yourland-report

2021-08-02 08:35:45 +00:00

Styxcolor added the

3. source/integration

label 2021-10-31 00:19:35 +00:00

Styxcolor self-assigned this 2021-10-31 00:20:17 +00:00

Styxcolor commented

2021-10-31 00:21:05 +00:00

Sounds like they had the "wrong" type of the two seeds with them. I stumbled across integration problems with the sunflower seeds too, didn't even get to the farming aspect. Will do my best to fix that.

Styxcolor commented

2021-11-06 19:57:07 +00:00

Tested it, farming:seed_sunflower works, farming:sunflower_seeds_toasted does not work but I wasn't expecting it to (but still checked)
cucina_vegana:sunflower_seeds is the one that currently cannot be planted, at least not on tilled ground. I tried on untilled one, just to check, and did not have success either.

Tested it, farming:seed_sunflower works, farming:sunflower_seeds_toasted does not work but I wasn't expecting it to (but still checked) cucina_vegana:sunflower_seeds is the one that currently cannot be planted, at least not on tilled ground. I tried on untilled one, just to check, and did not have success either.

Styxcolor added the

4. step/at work

label 2021-11-08 20:20:00 +00:00

Styxcolor referenced this issue

2021-11-16 14:03:54 +00:00

Sunflower bread, sunflower flour, sunflowers #966

Styxcolor added

1. kind/bug

and removed

3. source/integration

labels 2021-11-16 14:04:11 +00:00

tour commented

2021-12-30 19:08:42 +00:00

It's true, this bug refers to cucina_vegana. When I opend this issue, farming had no sunflowers, so no confusion.

tour commented

2021-12-30 19:13:38 +00:00

I tried to look in the code myself (I'm beginner, so no guarantee I understood everything correctly...):

cucina_vegana:sunflower_seeds are registerd as craftitems here: 8da0c37dda/items.lua (L228)
I don't know why they added it to groop:seed. (In my eyes, it needs to be removed from there to avoid further confusions). "normal" cucina_vegana seeds are registerd with a different syntax: "cucina_vegana:_seed" (without s)
In the same file, the cucina_vegana:sunflower are registerd as craftitems.

On YL we have farming redo, so these two file handle the sunflowers: https://github.com/acmgit/cucina_vegana/blob/master/sunflower_redo.lua and https://github.com/acmgit/cucina_vegana/blob/master/sunflower.lua

The plant registration is skipped (we got flowers:sunflower from plantlife modpack: https://github.com/mt-mods/plantlife_modpack/blob/master/pl_sunflowers/init.lua). There they are registered as a node, not as a plant.

So cucina_vegana can't grow sunflowers itself. The cucina_vegana:sunflower is never used after the registration since the plantlife-sunflife sunflower replace it. The name cucina_vegana:sunflower_seeds confused me (For me, all seeds are plantable). Additionally they should not be in group:seed (in my eyes, maybe you see it different).

I tried to look in the code myself (I'm beginner, so no guarantee I understood everything correctly...): cucina_vegana:sunflower_seeds are registerd as craftitems here: https://github.com/acmgit/cucina_vegana/blob/8da0c37dda2bc5ec26a5d6f107954ec7c789838a/items.lua#L228 I don't know why they added it to groop:seed. (In my eyes, it needs to be removed from there to avoid further confusions). "normal" cucina_vegana seeds are registerd with a different syntax: "cucina_vegana:<plantname>_seed" (without s) In the same file, the cucina_vegana:sunflower are registerd as craftitems. On YL we have farming redo, so these two file handle the sunflowers: https://github.com/acmgit/cucina_vegana/blob/master/sunflower_redo.lua and https://github.com/acmgit/cucina_vegana/blob/master/sunflower.lua The plant registration is skipped (we got flowers:sunflower from plantlife modpack: https://github.com/mt-mods/plantlife_modpack/blob/master/pl_sunflowers/init.lua). There they are registered as a node, not as a plant. So cucina_vegana can't grow sunflowers itself. The cucina_vegana:sunflower is never used after the registration since the plantlife-sunflife sunflower replace it. The name cucina_vegana:sunflower_seeds confused me (For me, all seeds are plantable). Additionally they should not be in group:seed (in my eyes, maybe you see it different).

Styxcolor commented

2021-12-30 22:15:54 +00:00

hey, thanks for the input, tour!

flux referenced this issue

2022-04-18 15:40:45 +00:00

JeCel reports: We have two different sunflowe ... #1788

flux referenced this issue

2022-06-05 04:30:18 +00:00

Freebie reports: Cucina sunflower could not be ... #2033

flux removed the

4. step/at work

label 2022-07-28 19:08:43 +00:00

flux referenced this issue

2022-08-20 15:57:31 +00:00

flux reports: sunflowers are a right mess ... #2490

flux commented

2022-10-05 02:57:43 +00:00

fixed in 9911469fe8

fixed in https://gitea.your-land.de/your-land/yl_commons/commit/9911469fe8a19274d61b64b5dbb24af1d26cf39d

flux added the

4. step/ready to QA test

label 2022-10-05 02:58:01 +00:00

flux added this to the flux's TODO list project 2022-10-05 02:58:04 +00:00

Styxcolor was unassigned by flux

2022-10-05 02:58:10 +00:00

flux self-assigned this 2022-10-05 02:58:10 +00:00

AliasAlreadyTaken added this to the 1.1.116 milestone 2022-10-11 19:17:27 +00:00

daydream commented

2022-10-26 02:03:51 +00:00

The only plantable sunflower is the farming mod one and it's working fine and has nice looking seeds. This fix has nasty looking "metal" seeds for a problem that doesn't exist. IDK what was going on a year ago, but this sunflower is fine how it is. People like it. They don't like the default 2D flat one but that was never plantable. Maybe that is what Tour meant? that it wasn't like "growable"? You just plunk it down. Whos knows but this fix is not needed and the new texture for the seeds is just not nice.

flux commented

2022-10-26 02:27:23 +00:00

This fix has nasty looking "metal" seeds

changing the texture is trivial, i chose the higher-resolution one. currently the sunflower seeds from farming contribute the item, and i just copied the texture from cucina_vegana if it's available. changing this is trivial if we want to, i don't have a strong opinion.

for a problem that doesn't exist.

having semi-distinct variations of the same logical thing, which have distinct rules, is a problem.

They don't like the default 2D flat one but that was never plantable.

the goal here is to make there be a single sunflower crop, and a single sunflower "flower", and make those both craft into the same seeds. the cucina vegana crops are not very attractive IMO, but i certainly dithered over which seed variant i wanted to use.

the new texture for the seeds is just not nice.

lets ask a few other people. i don't really like either texture, so if no-one responds, we can use the textures from farming.

> This fix has nasty looking "metal" seeds changing the texture is trivial, i chose the higher-resolution one. currently the sunflower seeds from farming contribute the item, and i just copied the texture from cucina_vegana if it's available. changing this is trivial if we want to, i don't have a strong opinion. > for a problem that doesn't exist. having semi-distinct variations of the same logical thing, which have distinct rules, is a problem. > They don't like the default 2D flat one but that was never plantable. the goal here is to make there be a single sunflower crop, and a single sunflower "flower", and make those both craft into the same seeds. the cucina vegana crops are not very attractive IMO, but i certainly dithered over which seed variant i wanted to use. > the new texture for the seeds is just not nice. lets ask a few other people. i don't really like either texture, so if no-one responds, we can use the textures from farming.

AliasAlreadyTaken commented

2022-10-26 02:57:47 +00:00

Opinion:

Pro farming sunflower seeds texture.

Pro unification of sunflowers.

Opinion: Pro farming sunflower seeds texture. Pro unification of sunflowers.

flux commented

2022-10-26 03:07:22 +00:00

Pro farming sunflower seeds texture.

done in 51abf46059

i said it was trivial, i was not lying :)

> Pro farming sunflower seeds texture. done in https://gitea.your-land.de/your-land/yl_commons/commit/51abf46059f1ac012a49582be949f205201ac7d7 i said it was trivial, i was not lying :)

flux commented

2022-10-26 03:12:08 +00:00

hm though now, i notice that we have 2 sunflower seed breads, but they are not easily comparable.

neither has a great recipe
cv has raw and baked varieties
farming looks way better

hm though now, i notice that we have 2 sunflower seed breads, but they are not easily comparable. * neither has a great recipe * cv has raw and baked varieties * farming looks way better

flux commented

2022-10-26 03:29:25 +00:00

created a new issue about the conquest of bread: #2919

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2022-11-13 16:04:40 +00:00

flux removed this from the flux's TODO list project 2022-11-13 16:04:43 +00:00

AliasAlreadyTaken was unassigned by flux

2022-11-13 16:04:46 +00:00

flux removed their assignment 2022-11-13 16:04:46 +00:00