tour reports: can't plant sunflower seeds ... #789
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
source/testserver
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#789
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
tour reports a bug:
Player position:
Player look:
Player information:
Player meta:
Log identifier
Profiler save:
Status:
Teleport command:
Compass command:
Sounds like they had the "wrong" type of the two seeds with them. I stumbled across integration problems with the sunflower seeds too, didn't even get to the farming aspect. Will do my best to fix that.
Tested it, farming:seed_sunflower works, farming:sunflower_seeds_toasted does not work but I wasn't expecting it to (but still checked)
cucina_vegana:sunflower_seeds is the one that currently cannot be planted, at least not on tilled ground. I tried on untilled one, just to check, and did not have success either.
It's true, this bug refers to cucina_vegana. When I opend this issue, farming had no sunflowers, so no confusion.
I tried to look in the code myself (I'm beginner, so no guarantee I understood everything correctly...):
cucina_vegana:sunflower_seeds are registerd as craftitems here:
8da0c37dda/items.lua (L228)
I don't know why they added it to groop:seed. (In my eyes, it needs to be removed from there to avoid further confusions). "normal" cucina_vegana seeds are registerd with a different syntax: "cucina_vegana:_seed" (without s)
In the same file, the cucina_vegana:sunflower are registerd as craftitems.
On YL we have farming redo, so these two file handle the sunflowers: https://github.com/acmgit/cucina_vegana/blob/master/sunflower_redo.lua and https://github.com/acmgit/cucina_vegana/blob/master/sunflower.lua
The plant registration is skipped (we got flowers:sunflower from plantlife modpack: https://github.com/mt-mods/plantlife_modpack/blob/master/pl_sunflowers/init.lua). There they are registered as a node, not as a plant.
So cucina_vegana can't grow sunflowers itself. The cucina_vegana:sunflower is never used after the registration since the plantlife-sunflife sunflower replace it. The name cucina_vegana:sunflower_seeds confused me (For me, all seeds are plantable). Additionally they should not be in group:seed (in my eyes, maybe you see it different).
hey, thanks for the input, tour!
fixed in
9911469fe8
The only plantable sunflower is the farming mod one and it's working fine and has nice looking seeds. This fix has nasty looking "metal" seeds for a problem that doesn't exist. IDK what was going on a year ago, but this sunflower is fine how it is. People like it. They don't like the default 2D flat one but that was never plantable. Maybe that is what Tour meant? that it wasn't like "growable"? You just plunk it down. Whos knows but this fix is not needed and the new texture for the seeds is just not nice.
changing the texture is trivial, i chose the higher-resolution one. currently the sunflower seeds from farming contribute the item, and i just copied the texture from cucina_vegana if it's available. changing this is trivial if we want to, i don't have a strong opinion.
having semi-distinct variations of the same logical thing, which have distinct rules, is a problem.
the goal here is to make there be a single sunflower crop, and a single sunflower "flower", and make those both craft into the same seeds. the cucina vegana crops are not very attractive IMO, but i certainly dithered over which seed variant i wanted to use.
lets ask a few other people. i don't really like either texture, so if no-one responds, we can use the textures from farming.
Opinion:
Pro farming sunflower seeds texture.
Pro unification of sunflowers.
done in
51abf46059
i said it was trivial, i was not lying :)
hm though now, i notice that we have 2 sunflower seed breads, but they are not easily comparable.
created a new issue about the conquest of bread: #2919
this is live