flux reports: sunflowers are a right mess ... #2490

Closed
opened 2022-08-20 03:11:26 +00:00 by yourland-report · 6 comments

flux reports a bug:

sunflowers are a right mess

Player position:

{
	z = 530.58801269531,
	x = 1278.4530029297,
	y = 11.954999923706
}

Player look:

{
	z = 0.95452570915222,
	x = -0.12939627468586,
	y = -0.26858359575272
}

Player information:

{
	state = "Active",
	ip_version = 6,
	min_rtt = 0.16200000047684,
	max_rtt = 4.191999912262,
	avg_rtt = 0.19699999690056,
	lang_code = "",
	max_jitter = 4.0149998664856,
	avg_jitter = 0.039000004529953,
	connection_uptime = 2307,
	serialization_version = 29,
	patch = 0,
	major = 5,
	minor = 6,
	formspec_version = 6,
	version_string = "5.6.0",
	protocol_version = 40,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "94",
		partychat = "party",
		yl_church = "return {[\"last_death_portal\"] = 1660095612, [\"last_death\"] = {[\"y\"] = 15, [\"z\"] = 1874, [\"x\"] = 2417}, [\"last_heal\"] = 1615504208}",
		died = "68",
		["stamina:level"] = "11",
		placed_nodes = "353368",
		["petz:werewolf"] = "1",
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 820\", \"3d_armor:leggings_nether 1 1840\", \"3d_armor:helmet_nether 1 920\", \"nether_mobs:dragon_shield 1 920\", \"3d_armor:chestplate_nether 1 1840\", \"\"}",
		["petz:lycanthropy"] = "1",
		bitten = "0",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		hud_state = "on",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf_vignette_id"] = "20",
		played_time = "22038886",
		xp = "1285293",
		punch_count = "92148",
		yl_commons_player_created = "1615351173",
		["petz:werewolf_clan_idx"] = "1",
		yl_commons_thankyou = "146",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		yl_commons_player_joined = "1660962804",
		jointime = "1615351173",
		digged_nodes = "1093965",
		repellant = "0",
		["signslib:pos"] = "(1273,69,540)",
		crafted = "39554",
		inflicted_damage = "1539542"
	}
}

Log identifier


[MOD] yl_report log identifier = cOHZMnNn5iBsbg6bYf8uI450LkbiBH2J

Profiler save:

profile-20220820T031126.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 1d 2h 58s | max lag: 1.55s | clients: dragon014, Woodman1234, evil123, Lupercus, Oakenshield, Therottenpotato, flux, the_chosen_one, mrminer, GrimPixel, Bailiff, Service, AliasAlreadyTaken, Sokomine, Antimatter_76

Teleport command:

/teleport xyz 1278 12 531

Compass command:

/give_compass Construction cOHZMnNn5iBsbg6bYf8uI450LkbiBH2J D2691E 1278 12 531
flux reports a bug: > sunflowers are a right mess Player position: ``` { z = 530.58801269531, x = 1278.4530029297, y = 11.954999923706 } ``` Player look: ``` { z = 0.95452570915222, x = -0.12939627468586, y = -0.26858359575272 } ``` Player information: ``` { state = "Active", ip_version = 6, min_rtt = 0.16200000047684, max_rtt = 4.191999912262, avg_rtt = 0.19699999690056, lang_code = "", max_jitter = 4.0149998664856, avg_jitter = 0.039000004529953, connection_uptime = 2307, serialization_version = 29, patch = 0, major = 5, minor = 6, formspec_version = 6, version_string = "5.6.0", protocol_version = 40, min_jitter = 0 } ``` Player meta: ``` { fields = { ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "94", partychat = "party", yl_church = "return {[\"last_death_portal\"] = 1660095612, [\"last_death\"] = {[\"y\"] = 15, [\"z\"] = 1874, [\"x\"] = 2417}, [\"last_heal\"] = 1615504208}", died = "68", ["stamina:level"] = "11", placed_nodes = "353368", ["petz:werewolf"] = "1", ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 820\", \"3d_armor:leggings_nether 1 1840\", \"3d_armor:helmet_nether 1 920\", \"nether_mobs:dragon_shield 1 920\", \"3d_armor:chestplate_nether 1 1840\", \"\"}", ["petz:lycanthropy"] = "1", bitten = "0", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", hud_state = "on", arenalib_infobox_arenaID = "0", ["petz:werewolf_vignette_id"] = "20", played_time = "22038886", xp = "1285293", punch_count = "92148", yl_commons_player_created = "1615351173", ["petz:werewolf_clan_idx"] = "1", yl_commons_thankyou = "146", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", yl_commons_player_joined = "1660962804", jointime = "1615351173", digged_nodes = "1093965", repellant = "0", ["signslib:pos"] = "(1273,69,540)", crafted = "39554", inflicted_damage = "1539542" } } ``` Log identifier ``` [MOD] yl_report log identifier = cOHZMnNn5iBsbg6bYf8uI450LkbiBH2J ``` Profiler save: ``` profile-20220820T031126.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 1d 2h 58s | max lag: 1.55s | clients: dragon014, Woodman1234, evil123, Lupercus, Oakenshield, Therottenpotato, flux, the_chosen_one, mrminer, GrimPixel, Bailiff, Service, AliasAlreadyTaken, Sokomine, Antimatter_76 ``` Teleport command: ``` /teleport xyz 1278 12 531 ``` Compass command: ``` /give_compass Construction cOHZMnNn5iBsbg6bYf8uI450LkbiBH2J D2691E 1278 12 531 ```
AliasAlreadyTaken was assigned by yourland-report 2022-08-20 03:11:26 +00:00
AliasAlreadyTaken added the
3. source/integration
label 2022-08-20 05:28:12 +00:00
Member

Styxcolor tried to clean these up at some point, but then farming released yet another sunflower, and cucina_vegana released some code to disable CV sunflowers if farming sunflowers were present, and the result is chaos.

related issues:

  • #789 can't plant sunflower seeds (from flowers mod)
  • #966 sunflower bread, sunflower flour, sunflowers
  • #1788 we have 2 different sunflower seeds
Styxcolor tried to clean these up at some point, but then `farming` released *yet another* sunflower, and `cucina_vegana` released some code to disable CV sunflowers if farming sunflowers were present, and the result is chaos. related issues: * [ ] #789 can't plant sunflower seeds (from flowers mod) * [ ] #966 sunflower bread, sunflower flour, sunflowers * [ ] #1788 we have 2 different sunflower seeds
Member

my preferred solution to this is mentioned in #1121, but i'll make it explicit here:

  • we should get rid of redundant crops (e.g. only 1 tomato from farming_redo or cucina_vegana)
  • we should get rid of "redundant seeds" - where the seed item is conceptually the same thing as the crop (e.g. rice "seeds" from cucina_vegana)

sunflower flowers should continue to exist, but they should craft into the seeds from either farming or CV.

my preferred solution to this is mentioned in #1121, but i'll make it explicit here: * we should get rid of redundant crops (e.g. only 1 tomato from `farming_redo` *or* `cucina_vegana`) * we should get rid of "redundant seeds" - where the seed item is conceptually the same thing as the crop (e.g. rice "seeds" from `cucina_vegana`) sunflower *flowers* should continue to exist, but they should craft into the seeds from either `farming` or CV.
flux added the
4. step/want approval
label 2022-08-20 16:26:11 +00:00
flux added this to the flux's TODO list project 2022-08-20 16:26:15 +00:00
flux self-assigned this 2022-08-20 16:26:18 +00:00

Additionally we should ask the makers of cucina vegana and farming_redo work together somehow.

Additionally we should ask the makers of cucina vegana and farming_redo work together somehow.
AliasAlreadyTaken added the
4. step/approved
label 2022-08-20 20:57:51 +00:00
Member

Additionally we should ask the makers of cucina vegana and farming_redo work together somehow.

what do you mean "work together"? cucina_vegana uses some API stuff provided by farming_redo. fixing crafting recipes is done by changing them to use groups, and we've mostly got that under control now, i think.

> Additionally we should ask the makers of cucina vegana and farming_redo work together somehow. what do you mean "work together"? `cucina_vegana` uses some API stuff provided by `farming_redo`. fixing crafting recipes is done by changing them to use groups, and we've mostly got that under control now, i think.
flux removed the
4. step/want approval
label 2022-08-21 17:20:35 +00:00
flux added
4. step/ready to QA test
and removed
4. step/approved
labels 2022-10-05 02:56:34 +00:00
Member

fixed in 9911469fe8

fixed in https://gitea.your-land.de/your-land/yl_commons/commit/9911469fe8a19274d61b64b5dbb24af1d26cf39d
AliasAlreadyTaken added this to the 1.1.116 milestone 2022-10-11 19:17:45 +00:00
flux added the
1. kind/enhancement
label 2022-11-05 17:15:08 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2022-11-13 22:17:56 +00:00
flux removed this from the flux's TODO list project 2022-11-13 22:17:58 +00:00
AliasAlreadyTaken was unassigned by flux 2022-11-13 22:18:00 +00:00
flux removed their assignment 2022-11-13 22:18:00 +00:00
Member

this is live

this is live
flux closed this issue 2022-11-13 22:18:07 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2490
No description provided.