whosit reports: add a new button to the crafti ... #7523

New Issue

yourland-report · 2024-10-17T18:31:53+02:00

yourland-report commented

2024-10-17 18:31:53 +02:00

whosit reports a bug:

add a new button to the crafting grid that will arrage 5 blocks to convert materials

Player position:

{
	x = -1940.6320800781,
	y = 45.5,
	z = 3707.4011230469
}

Player look:

{
	x = 0.84446781873703,
	y = -0.36227536201477,
	z = -0.39450046420097
}

Player information:

{
	min_rtt = 0.039000000804663,
	min_jitter = 0,
	max_jitter = 0.48800000548363,
	avg_jitter = 0,
	connection_uptime = 8728,
	serialization_version = 29,
	patch = 1,
	state = "Active",
	minor = 9,
	major = 5,
	version_string = "5.9.1",
	lang_code = "",
	formspec_version = 7,
	max_rtt = 0.53299999237061,
	avg_rtt = 0.041000001132488,
	protocol_version = 43,
	ip_version = 6
}

Player meta:

{
	fields = {
		repellant = "0",
		hud_state = "on",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		bitten = "0",
		yl_church = "return {[\"last_death_portal\"] = 1729176379, [\"last_heal\"] = 1708284048, [\"last_death\"] = {[\"x\"] = -1938, [\"y\"] = 48, [\"z\"] = 3715}}",
		played_time = "9665340",
		["petz:werewolf_clan_idx"] = "3",
		placed_nodes = "103951",
		died = "795",
		crafted = "94258",
		yl_commons_player_created = "1615221933",
		yl_commons_player_joined = "1729173989",
		["signslib:pos"] = "(-116,45,22542)",
		["stamina:level"] = "20",
		arenalib_infobox_arenaID = "0",
		xp_redo_hud_color = "0x0000ff",
		hotbar_size = "16",
		partychat = "party",
		punch_count = "41461",
		["3d_armor_inventory"] = "return {\"shields:shield_crystal 1 22409\", \"3d_armor:chestplate_crystal 1 22075\", \"3d_armor:boots_crystal 1 20935\", \"3d_armor:leggings_crystal 1 22125\", \"3d_armor:helmet_crystal 1 27000\", \"\"}",
		yl_commons_thankyou = "332",
		["petz:lycanthropy"] = "1",
		["petz:werewolf"] = "0",
		xp = "213369",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		inflicted_damage = "640732",
		jointime = "1615221933",
		["stamina:exhaustion"] = "117.5",
		lagometer = "1",
		["petz:werewolf_vignette_id"] = "20",
		digged_nodes = "368029",
		partypvp = "true"
	}
}

Log identifier


[MOD] yl_report log identifier = jIBl7sIaByoOHDP1uSsP2saxXY8FdY8j

Profiler save:

profile-20241017T163153.json_prettyEE

Status:

# Server: version: 5.8.0-yl-debug | game: Minetest Game | uptime: 4d 10h 8min 53s | max lag: 1.29s | clients (17/52): ait0r7, AjC2014, AliasAlreadyTaken, Boot, DannyVimaranes, daydream, DragonWrangler1, FeOH, flux, Keya, laira, Murmel, papadegianlp, Parrish, RPiManiac, Service, whosit

Teleport command:

/teleport xyz -1941 46 3707

Compass command:

/give_compass Construction jIBl7sIaByoOHDP1uSsP2saxXY8FdY8j D2691E -1941 46 3707

whosit reports a bug: > add a new button to the crafting grid that will arrage 5 blocks to convert materials Player position: ``` { x = -1940.6320800781, y = 45.5, z = 3707.4011230469 } ``` Player look: ``` { x = 0.84446781873703, y = -0.36227536201477, z = -0.39450046420097 } ``` Player information: ``` { min_rtt = 0.039000000804663, min_jitter = 0, max_jitter = 0.48800000548363, avg_jitter = 0, connection_uptime = 8728, serialization_version = 29, patch = 1, state = "Active", minor = 9, major = 5, version_string = "5.9.1", lang_code = "", formspec_version = 7, max_rtt = 0.53299999237061, avg_rtt = 0.041000001132488, protocol_version = 43, ip_version = 6 } ``` Player meta: ``` { fields = { repellant = "0", hud_state = "on", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", bitten = "0", yl_church = "return {[\"last_death_portal\"] = 1729176379, [\"last_heal\"] = 1708284048, [\"last_death\"] = {[\"x\"] = -1938, [\"y\"] = 48, [\"z\"] = 3715}}", played_time = "9665340", ["petz:werewolf_clan_idx"] = "3", placed_nodes = "103951", died = "795", crafted = "94258", yl_commons_player_created = "1615221933", yl_commons_player_joined = "1729173989", ["signslib:pos"] = "(-116,45,22542)", ["stamina:level"] = "20", arenalib_infobox_arenaID = "0", xp_redo_hud_color = "0x0000ff", hotbar_size = "16", partychat = "party", punch_count = "41461", ["3d_armor_inventory"] = "return {\"shields:shield_crystal 1 22409\", \"3d_armor:chestplate_crystal 1 22075\", \"3d_armor:boots_crystal 1 20935\", \"3d_armor:leggings_crystal 1 22125\", \"3d_armor:helmet_crystal 1 27000\", \"\"}", yl_commons_thankyou = "332", ["petz:lycanthropy"] = "1", ["petz:werewolf"] = "0", xp = "213369", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", inflicted_damage = "640732", jointime = "1615221933", ["stamina:exhaustion"] = "117.5", lagometer = "1", ["petz:werewolf_vignette_id"] = "20", digged_nodes = "368029", partypvp = "true" } } ``` Log identifier ``` [MOD] yl_report log identifier = jIBl7sIaByoOHDP1uSsP2saxXY8FdY8j ``` Profiler save: ``` profile-20241017T163153.json_prettyEE ``` Status: ``` # Server: version: 5.8.0-yl-debug | game: Minetest Game | uptime: 4d 10h 8min 53s | max lag: 1.29s | clients (17/52): ait0r7, AjC2014, AliasAlreadyTaken, Boot, DannyVimaranes, daydream, DragonWrangler1, FeOH, flux, Keya, laira, Murmel, papadegianlp, Parrish, RPiManiac, Service, whosit ``` Teleport command: ``` /teleport xyz -1941 46 3707 ``` Compass command: ``` /give_compass Construction jIBl7sIaByoOHDP1uSsP2saxXY8FdY8j D2691E -1941 46 3707 ```

AliasAlreadyTaken was assigned by yourland-report

2024-10-17 18:31:53 +02:00

whosit commented

2024-10-17 18:32:11 +02:00

There's an empty space for it (this is just a mockup screenshot):

There's an empty space for it (this is just a mockup screenshot): ![crafting_button.png](/attachments/9f605447-11c8-43cd-b41d-6f7f0bc6b760)

crafting_button.png

110 KiB

👍 1

whosit added the

1. kind/enhancement

label 2024-10-17 18:42:51 +02:00

Mat214 commented

2024-10-20 00:55:14 +02:00

That should be one line of code and the icon:

append { ico = "pattern_10.png", pattern = { 1, 2, 3, 4, 5 } }, in unified_inventory_plus/init.lua to craft_patterns.

Put the texture in textures

edit
I added the texture.

That should be one line of code and the icon: append `{ ico = "pattern_10.png", pattern = { 1, 2, 3, 4, 5 } },` in `unified_inventory_plus/init.lua` to `craft_patterns`. Put the texture in textures *edit* I added the texture.

pattern_10.png

103 B

👍 1

Mat214 commented

2024-10-20 14:09:56 +02:00

Are we on upstream? I could try to upstream the patch, but don't mind if I don't have to...

whosit commented

2024-10-20 16:53:48 +02:00

Our stable branch is just following upstream: https://github.com/bousket/unified_inventory_plus.git
Would be better if this button gets there...
Do other servers have such recipes?

Our stable branch is just following upstream: https://github.com/bousket/unified_inventory_plus.git Would be better if this button gets there... Do other servers have such recipes?

AliasAlreadyTaken commented

2024-10-29 04:54:18 +01:00

Do other servers have such recipes?

I doubt this recipe distribution is unique to YL, other servers might profit as well. Is this combination the most often used after the other ones?

Are we on upstream? I could try to upstream the patch, but don't mind if I don't have to...

We follow upstream, if they don't want to have it, we can think of adding it ourselves.

> Do other servers have such recipes? I doubt this recipe distribution is unique to YL, other servers might profit as well. Is this combination the most often used after the other ones? > Are we on upstream? I could try to upstream the patch, but don't mind if I don't have to... We follow upstream, if they don't want to have it, we can think of adding it ourselves.

AliasAlreadyTaken added the

3. source/mod upstream

label 2024-10-29 04:54:28 +01:00

Mat214 commented

2025-03-26 21:42:28 +01:00

I sent a PR to upstream.

edit If nothing happens for some time, you can also just pull my tree.

I sent a [PR ](https://github.com/mt-mods/unified_inventory_plus/pull/28) to upstream. *edit* If nothing happens for some time, you can also just pull [my tree](https://github.com/Mat21436/unified_inventory_plus).

👍 2

Niklp commented

2025-03-30 22:02:10 +02:00

Merged.
836ebf5a17

Merged. https://github.com/mt-mods/unified_inventory_plus/commit/836ebf5a172e752d5f17865874f5b04d60da3319

🎉 2

AliasAlreadyTaken added the

4. step/ready to QA test

label 2025-03-30 22:43:44 +02:00

AliasAlreadyTaken added this to the 1.1.128 milestone 2025-03-30 22:43:50 +02:00

AliasAlreadyTaken added the

4. step/QA OK