Service reports: remove_staff removes the privs ... #7354

New Issue

yourland-report · 2024-08-26T22:43:59+02:00

yourland-report commented

2024-08-26 22:43:59 +02:00

Service reports a bug:

remove_staff removes the privs of the caller instead of the target

Player position:

{
	z = -3493.3481445313,
	x = -1211.5379638672,
	y = 47.5
}

Player look:

{
	z = 0.7994824051857,
	x = 0.38064870238304,
	y = -0.46468749642372
}

Player information:

{
	serialization_version = 29,
	avg_rtt = 0.016000000759959,
	lang_code = "de",
	protocol_version = 43,
	state = "Active",
	major = 5,
	minor = 10,
	version_string = "5.10.0-yl-debug-56123b2fb",
	patch = 0,
	max_rtt = 1.7450000047684,
	min_jitter = 0,
	ip_version = 6,
	min_rtt = 0.014999999664724,
	formspec_version = 7,
	max_jitter = 1.4730000495911,
	avg_jitter = 0,
	connection_uptime = 46583
}

Player meta:

{
	fields = {
		["petz:lycanthropy"] = "0",
		punch_count = "2021",
		szutil_watch = "return {}",
		inflicted_damage = "1076938",
		lagometer = "1",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = -2009, [\"x\"] = -983, [\"y\"] = 19}, [\"last_death_portal\"] = 1672529932, [\"last_heal\"] = 1676219630}",
		["ethereal:fly_timer"] = "-99",
		bitten = "0",
		ui_waypoints = "{\"data\":[{\"active\":false,\"name\":\"Waypoint 1\",\"world_pos\":{\"x\":2002.0,\"y\":8.0,\"z\":1154.0}}],\"selected\":1.0}",
		["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"sneak_glitch\"] = false, [\"sneak\"] = true, [\"jump\"] = 1, [\"gravity\"] = 1, [\"new_move\"] = true}",
		["arena_lib_editor.players_number"] = "0",
		["arena_lib_editor.team_ID"] = "0",
		["petz:werewolf_vignette_id"] = "19",
		["stamina:level"] = "0",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf_clan_idx"] = "2",
		["ocean_build.last_warning"] = "1695708624",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		xp = "0",
		["3d_armor_inventory"] = "return {\"3d_armor:boots_quickrun\", \"\", \"\", \"\", \"\", \"\"}",
		played_time = "97460137",
		digged_nodes = "22682",
		placed_nodes = "25912",
		died = "119",
		crafted = "145",
		repellant = "0",
		yl_commons_player_created = "1610342909",
		yl_commons_player_joined = "1724658475",
		["signslib:pos"] = "(2010,16,1150)",
		hud_state = "on",
		["stamina:exhaustion"] = "34",
		yl_commons_thankyou = "45",
		["arena_lib_editor.spawner_ID"] = "0",
		yl_audio_state = "off",
		["petz:werewolf"] = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = c6JohJe8pYHmnJqfZyz8fojI4bLLlgcG

Profiler save:

profile-20240826T204359.json_prettyEE

Status:

# Server: version: 5.8.0-yl-debug | game: Minetest Game | uptime: 3d 7h 8min 58s | max lag: 0.727s | clients (17/52): AliasAlreadyTaken, AspireMint, Bailiff, Bingo, Boot, daydream, Ecklair, fanticwar, Fisherman, flux, LadyPixels, MineWorlds, poppyasdan, Service, TafferBell, toddie, try_114

Teleport command:

/teleport xyz -1212 48 -3493

Compass command:

/give_compass Construction c6JohJe8pYHmnJqfZyz8fojI4bLLlgcG D2691E -1212 48 -3493

Service reports a bug: > remove_staff removes the privs of the caller instead of the target Player position: ``` { z = -3493.3481445313, x = -1211.5379638672, y = 47.5 } ``` Player look: ``` { z = 0.7994824051857, x = 0.38064870238304, y = -0.46468749642372 } ``` Player information: ``` { serialization_version = 29, avg_rtt = 0.016000000759959, lang_code = "de", protocol_version = 43, state = "Active", major = 5, minor = 10, version_string = "5.10.0-yl-debug-56123b2fb", patch = 0, max_rtt = 1.7450000047684, min_jitter = 0, ip_version = 6, min_rtt = 0.014999999664724, formspec_version = 7, max_jitter = 1.4730000495911, avg_jitter = 0, connection_uptime = 46583 } ``` Player meta: ``` { fields = { ["petz:lycanthropy"] = "0", punch_count = "2021", szutil_watch = "return {}", inflicted_damage = "1076938", lagometer = "1", yl_church = "return {[\"last_death\"] = {[\"z\"] = -2009, [\"x\"] = -983, [\"y\"] = 19}, [\"last_death_portal\"] = 1672529932, [\"last_heal\"] = 1676219630}", ["ethereal:fly_timer"] = "-99", bitten = "0", ui_waypoints = "{\"data\":[{\"active\":false,\"name\":\"Waypoint 1\",\"world_pos\":{\"x\":2002.0,\"y\":8.0,\"z\":1154.0}}],\"selected\":1.0}", ["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"sneak_glitch\"] = false, [\"sneak\"] = true, [\"jump\"] = 1, [\"gravity\"] = 1, [\"new_move\"] = true}", ["arena_lib_editor.players_number"] = "0", ["arena_lib_editor.team_ID"] = "0", ["petz:werewolf_vignette_id"] = "19", ["stamina:level"] = "0", arenalib_infobox_arenaID = "0", ["petz:werewolf_clan_idx"] = "2", ["ocean_build.last_warning"] = "1695708624", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", xp = "0", ["3d_armor_inventory"] = "return {\"3d_armor:boots_quickrun\", \"\", \"\", \"\", \"\", \"\"}", played_time = "97460137", digged_nodes = "22682", placed_nodes = "25912", died = "119", crafted = "145", repellant = "0", yl_commons_player_created = "1610342909", yl_commons_player_joined = "1724658475", ["signslib:pos"] = "(2010,16,1150)", hud_state = "on", ["stamina:exhaustion"] = "34", yl_commons_thankyou = "45", ["arena_lib_editor.spawner_ID"] = "0", yl_audio_state = "off", ["petz:werewolf"] = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = c6JohJe8pYHmnJqfZyz8fojI4bLLlgcG ``` Profiler save: ``` profile-20240826T204359.json_prettyEE ``` Status: ``` # Server: version: 5.8.0-yl-debug | game: Minetest Game | uptime: 3d 7h 8min 58s | max lag: 0.727s | clients (17/52): AliasAlreadyTaken, AspireMint, Bailiff, Bingo, Boot, daydream, Ecklair, fanticwar, Fisherman, flux, LadyPixels, MineWorlds, poppyasdan, Service, TafferBell, toddie, try_114 ``` Teleport command: ``` /teleport xyz -1212 48 -3493 ``` Compass command: ``` /give_compass Construction c6JohJe8pYHmnJqfZyz8fojI4bLLlgcG D2691E -1212 48 -3493 ```

AliasAlreadyTaken was assigned by yourland-report

2024-08-26 22:43:59 +02:00

AliasAlreadyTaken added the

1. kind/bug

label 2024-08-28 04:14:50 +02:00

AliasAlreadyTaken added this to the Alias@work project 2024-08-28 04:14:53 +02:00

AliasAlreadyTaken referenced this issue from a commit

2024-11-12 01:27:57 +01:00

your-land/bugtracker#7354 Removes priv-giving and revoking for addstaff and removestaff. Use /grant instead

AliasAlreadyTaken commented

2024-11-12 01:28:46 +01:00

This part never worked. We'll use two separate mechanics: privs and list. /grant and /revoke is for privs, /addstaff and /removestaff is for the list.

AliasAlreadyTaken added the

4. step/ready to QA test

label 2024-11-12 01:28:52 +01:00

AliasAlreadyTaken added this to the 1.1.126 milestone 2024-11-12 01:28:55 +01:00

AliasAlreadyTaken referenced this issue

2024-11-21 16:24:31 +01:00

1.1.126 #7579

whosit commented

2024-11-21 17:37:15 +01:00

/addstaff and /removestaff only change the list, OK.

`/addstaff` and `/removestaff` only change the list, OK.

whosit added the