tour reports: addition to #719: when I type ... #720

New Issue

yourland-report · 2021-07-17T09:55:42Z

yourland-report commented

2021-07-17 09:55:42 +00:00

tour reports a bug:

addition to #719: when I type home while falling, I always die at home position (6900, 11,5, 3026)

Player position:

{
	y = 11.5,
	x = 6900,
	z = 3026
}

Player look:

{
	y = -0.85985225439072,
	x = -0.079514481127262,
	z = 0.50431299209595
}

Player information:

{
	min_rtt = 0.026000000536442,
	max_rtt = 14.524000167847,
	connection_uptime = 5303,
	max_jitter = 13.406999588013,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "de",
	version_string = "5.4.1",
	avg_rtt = 0.027000000700355,
	state = "Active",
	avg_jitter = 0.0010000001639128,
	min_jitter = 0,
	address = "::ffff:87.177.72.143"
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		played_time = "95569",
		jointime = "1625997613",
		yl_commons_player_joined = "1626510455",
		["signslib:pos"] = "(7069,28,2774)",
		digged_nodes = "18364",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 12, [\"x\"] = 6900, [\"z\"] = 3026}, [\"last_death_portal\"] = 1626466191}",
		["stamina:level"] = "18",
		xp = "14852",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "12146",
		crafted = "7228",
		punch_count = "1329",
		placed_nodes = "5530",
		died = "19",
		repellant = "0",
		yl_commons_player_created = "1625997613"
	}
}

Log identifier


[MOD] yl_report log identifier = HdBSWhbe37rGQBxZxB5YlHJiUrN3nYxN

Profiler save:

profile-20210717T115542.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=129861, max_lag=3.39355, clients={Apocralypse, anime_girl, rujal, Emelie, Julia, amelie, DatOneFox, abhinav, Boot, tour, I_Am_A_Programmer, Arabella, Runy, ufoshnik, Sirina, wishingirl, AliasAlreadyTaken, Bailiff, LordY, Service, Torri}

tour reports a bug: > addition to #719: when I type home while falling, I always die at home position (6900, 11,5, 3026) Player position: ``` { y = 11.5, x = 6900, z = 3026 } ``` Player look: ``` { y = -0.85985225439072, x = -0.079514481127262, z = 0.50431299209595 } ``` Player information: ``` { min_rtt = 0.026000000536442, max_rtt = 14.524000167847, connection_uptime = 5303, max_jitter = 13.406999588013, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "de", version_string = "5.4.1", avg_rtt = 0.027000000700355, state = "Active", avg_jitter = 0.0010000001639128, min_jitter = 0, address = "::ffff:87.177.72.143" } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", played_time = "95569", jointime = "1625997613", yl_commons_player_joined = "1626510455", ["signslib:pos"] = "(7069,28,2774)", digged_nodes = "18364", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 12, [\"x\"] = 6900, [\"z\"] = 3026}, [\"last_death_portal\"] = 1626466191}", ["stamina:level"] = "18", xp = "14852", arenalib_infobox_arenaID = "0", inflicted_damage = "12146", crafted = "7228", punch_count = "1329", placed_nodes = "5530", died = "19", repellant = "0", yl_commons_player_created = "1625997613" } } ``` Log identifier ``` [MOD] yl_report log identifier = HdBSWhbe37rGQBxZxB5YlHJiUrN3nYxN ``` Profiler save: ``` profile-20210717T115542.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=129861, max_lag=3.39355, clients={Apocralypse, anime_girl, rujal, Emelie, Julia, amelie, DatOneFox, abhinav, Boot, tour, I_Am_A_Programmer, Arabella, Runy, ufoshnik, Sirina, wishingirl, AliasAlreadyTaken, Bailiff, LordY, Service, Torri} ```

AliasAlreadyTaken was assigned by yourland-report

2021-07-17 09:55:42 +00:00

AliasAlreadyTaken commented

2021-08-12 13:01:51 +00:00

Can reproduce. Looks like your /home point kills you, if your jumphole is close to it.

I'd blame it on lag.

Can reproduce. Looks like your /home point kills you, if your jumphole is close to it. I'd blame it on lag.

AliasAlreadyTaken added the

1. kind/bug

4. step/help wanted

labels 2021-08-12 13:02:11 +00:00

AliasAlreadyTaken commented

2021-08-12 13:02:41 +00:00

Maybe we should make it that people lose all movement when they send /home

AliasAlreadyTaken commented

2021-08-12 13:03:44 +00:00

Whole issue reads:

When I jump in my mine (6908, 3022) and type in /home while falling, I always die at home position (6900, 11,5, 3026)

Closes #719

Whole issue reads: > When I jump in my mine (6908, 3022) and type in /home while falling, I always die at home position (6900, 11,5, 3026) Closes #719

AliasAlreadyTaken referenced this issue

2021-08-12 13:03:56 +00:00

tour reports: when I jump in my mine (6908, ... #719

flux referenced this issue

2022-01-05 01:20:26 +00:00

lazerbeak12345 reports: If you are falling at max spee ... #1217

flux referenced this issue

2022-01-05 01:21:21 +00:00

Andrew reports: AkhilKumar died in the Linn Ho ... #822

flux referenced this issue

2022-01-06 00:56:54 +00:00

lazerbeak12345 reports: If you are falling at max velo ... #1275

AliasAlreadyTaken commented

2022-01-06 03:10:49 +00:00

Is there any usecase where someone would want to retain their speed and vector when doing /home or /spawn? Couldn't find any.

Fixed.

#720 Set player velocity to 0 during spawn teleport:

yl_commons 6d03a38562

#720 Set player velocity to 0 during home teleport:

yl_commons 26d56294b4

Is there any usecase where someone would want to retain their speed and vector when doing /home or /spawn? Couldn't find any. Fixed. #720 Set player velocity to 0 during spawn teleport: yl_commons https://gitea.your-land.de/your-land/yl_commons/commit/6d03a385624fb4d9aa6472661caf612b197269e6 #720 Set player velocity to 0 during home teleport: yl_commons https://gitea.your-land.de/your-land/yl_commons/commit/26d56294b4462a03f8537f40788b5542ac96707e

AliasAlreadyTaken closed this issue

2022-01-06 03:10:49 +00:00

AliasAlreadyTaken added this to the 1.1.105 milestone 2022-01-06 03:10:55 +00:00

AliasAlreadyTaken added

5. result/fixed

and removed

4. step/help wanted

labels 2022-01-06 03:11:02 +00:00

AliasAlreadyTaken referenced this issue

2022-01-06 03:12:16 +00:00

Andrew reports: AkhilKumar died in the Linn Ho ... #822

flux commented

2022-01-06 04:15:32 +00:00

Is there any usecase where someone would want to retain their speed and vector when doing /home or /spawn? Couldn't find any.

yes. but i'd consider anything like that to be cheating, so no need to support it.

i can't think of anything specific, but i feel like such use might come into existence purely by accident. i can't think of any reason for there to be a mechanic that randomly kills you only because lag. and i'm not entirely convinced this effect is due to lag, it's a really old issue with minecraft. older than the following bug, but i can't find anything more relevant:

https://github.com/minetest/minetest/issues/9738

> Is there any usecase where someone would want to retain their speed and vector when doing /home or /spawn? Couldn't find any. yes. but i'd consider anything like that to be cheating, so no need to support it. i can't think of anything specific, but i feel like such use might come into existence purely by accident. i can't think of any reason for there to be a mechanic that randomly kills you only because lag. and i'm not entirely convinced this effect is due to lag, it's a really old issue with minecraft. older than the following bug, but i can't find anything more relevant: https://github.com/minetest/minetest/issues/9738

flux referenced this issue

2022-01-08 17:06:23 +00:00

debiankaios reports: if you fall down and do /h som ... #1286

AliasAlreadyTaken referenced this issue

2022-01-11 09:46:51 +00:00

debiankaios reports: if you fall down and do /h som ... #1286

flux referenced this issue

2022-04-07 20:01:32 +00:00

debiankaios reports: i typed /spawn jumped down and ... #1442

flux referenced this issue

2022-10-08 17:01:53 +00:00

icser reports: i died when i did /h when fall ... #2827

flux referenced this issue

2022-10-08 17:05:02 +00:00

debiankaios reports: i died near office without a r ... #1912

flux referenced this issue

2022-10-08 17:08:58 +00:00

debiankaios reports: i typed /spawn jumped down and ... #1442

flux commented

2022-10-08 17:37:28 +00:00

re-opening as the fix apparently does not solve the issue in all cases. will look into this more.

flux reopened this issue

2022-10-08 17:37:29 +00:00

flux referenced this issue

2022-10-08 17:37:45 +00:00

icser reports: i died when i did /h when fall ... #2827

flux added

4. step/question

2. prio/elevated

and removed

5. result/fixed

labels 2022-10-08 17:38:23 +00:00

flux removed this from the 1.1.105 milestone 2022-10-08 17:38:36 +00:00

flux added this to the flux's TODO list project 2022-10-08 17:38:39 +00:00

AliasAlreadyTaken was unassigned by flux

2022-10-08 17:38:44 +00:00

flux self-assigned this 2022-10-08 17:38:44 +00:00

flux commented

2022-10-08 20:14:52 +00:00

current behavior:

no lag, seems to always work fine
1s lag per step, usually works fine, but sometimes
- i'll get the "bones breaking" noise, but not take any damage
- i will teleport way above the target position and then fall from there and die?

trying to implement a "safe teleport"

current behavior: * no lag, seems to always work fine * 1s lag per step, *usually* works fine, but sometimes * i'll get the "bones breaking" noise, but not take any damage * i will teleport *way above* the target position and then fall from there and die? trying to implement a "safe teleport"

flux commented

2022-10-08 20:23:29 +00:00

no, that's not quite right. if my velocity is high enough, even w/ 0 lag, sometimes i'll appear at the target pos w/ immense upward velocity...

no, that's not quite right. if my velocity is high enough, even w/ 0 lag, sometimes i'll appear at the target pos w/ *immense* upward velocity...

flux commented

2022-10-08 21:53:12 +00:00

created something that seems to be reliable, finally.

4cd022c1ba

basically, it marks a teleporting player as invulnerable to fall damage for a period of time after they teleport. this is reset after:

the first fall damage they would have taken
after at least 4 server steps, each taking at least as long as max_rtt and max_lag.

this can be exploited slightly, but not easily or consistently.

created something that *seems* to be reliable, finally. https://gitea.your-land.de/your-land/yl_commons/commit/4cd022c1ba4051554653f87d14f4488ba736f7ca basically, it marks a teleporting player as invulnerable to fall damage for a period of time after they teleport. this is reset after: * the first fall damage they would have taken * after at least 4 server steps, each taking at least as long as max_rtt and max_lag. this *can* be exploited slightly, but not easily or consistently.

flux added

4. step/ready to QA test

and removed

4. step/question

labels 2022-10-08 21:53:30 +00:00

AliasAlreadyTaken was assigned by flux

2022-10-08 21:53:35 +00:00

flux commented

2022-11-13 16:02:29 +00:00

this is live

flux closed this issue

2022-11-13 16:02:29 +00:00