your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

rewired_X reports: i just phased through cottages ... #6565

New Issue
Open
opened 2024-03-24 23:58:34 +00:00 by yourland-report · 5 comments
yourland-report commented 2024-03-24 23:58:34 +00:00
Member
Copy Link

rewired_X reports a bug:

i just phased through cottages:fence_corner while holding shift ... and no im not on cow magic

Player position:

{
	y = -172.49899291992,
	z = 394.75201416016,
	x = 3139.1608886719
}

Player look:

{
	y = -0.39201602339745,
	z = 0.0065823532640934,
	x = 0.91993486881256
}

Player information:

{
	formspec_version = 7,
	ip_version = 6,
	min_rtt = 0.12800000607967,
	avg_rtt = 0.12999999523163,
	min_jitter = 0,
	max_jitter = 2.6789999008179,
	avg_jitter = 0,
	connection_uptime = 4267,
	serialization_version = 29,
	patch = 0,
	state = "Active",
	minor = 8,
	lang_code = "",
	protocol_version = 42,
	version_string = "5.8.0",
	max_rtt = 2.8090000152588,
	major = 5
}

Player meta:

{
	fields = {
		arenalib_watchID = "0",
		hud_state = "on",
		["ocean_build.forbidden"] = "true",
		yl_commons_player_joined = "1711320479",
		["signslib:pos"] = "(4203,53,1086)",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 14480\", \"shields:shield_rainbow 1 20208\", \"3d_armor:leggings_crystal 1 14480\", \"3d_armor:boots_crystal 1 14480\", \"3d_armor:chestplate_crystal 1 14480\", \"\"}",
		yl_church = "return {[\"last_death_portal\"] = 1710707338, [\"last_death\"] = {[\"y\"] = 84, [\"z\"] = 551, [\"x\"] = 3235}, [\"last_heal\"] = 1690328119}",
		["stamina:poisoned"] = "no",
		jointime = "1659200153",
		["stamina:exhaustion"] = "55.5",
		yl_commons_player_created = "1659200153",
		bitten = "0",
		xp_redo_hud_color = "0xE03fd8",
		digged_nodes = "367896",
		placed_nodes = "80574",
		died = "930",
		crafted = "138740",
		xp = "270256",
		yl_commons_thankyou = "75",
		punch_count = "196452",
		["stamina:level"] = "10",
		inflicted_damage = "4148732",
		repellant = "0",
		played_time = "7495987",
		["ocean_build.last_warning"] = "1.67388e+09",
		arenalib_infobox_arenaID = "0",
		["ocean_build.ocean_built"] = "12",
		partychat = "party"
	}
}

Log identifier


[MOD] yl_report log identifier = 5U1YXrUa2ltpbXpyP0CBWy0QRWApmXcj

Profiler save:

profile-20240324T235834.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 9h 35min 15s | max lag: 0.921s | clients (21/52): AliasAlreadyTaken, AspireMint, Bailiff, Boot, Cashia, cycle, DannyVimaranes, Diaeresis, flux, Gaeridall, Harlequin, LockePickens, MineWorlds, nakama-ta, pifo, Rattrap, rewired_X, Service, Sokomine, VK, weishilindon

Teleport command:

/teleport xyz 3139 -172 395

Compass command:

/give_compass Construction 5U1YXrUa2ltpbXpyP0CBWy0QRWApmXcj D2691E 3139 -172 395
rewired_X reports a bug: > i just phased through cottages:fence_corner while holding shift ... and no im not on cow magic Player position: ``` { y = -172.49899291992, z = 394.75201416016, x = 3139.1608886719 } ``` Player look: ``` { y = -0.39201602339745, z = 0.0065823532640934, x = 0.91993486881256 } ``` Player information: ``` { formspec_version = 7, ip_version = 6, min_rtt = 0.12800000607967, avg_rtt = 0.12999999523163, min_jitter = 0, max_jitter = 2.6789999008179, avg_jitter = 0, connection_uptime = 4267, serialization_version = 29, patch = 0, state = "Active", minor = 8, lang_code = "", protocol_version = 42, version_string = "5.8.0", max_rtt = 2.8090000152588, major = 5 } ``` Player meta: ``` { fields = { arenalib_watchID = "0", hud_state = "on", ["ocean_build.forbidden"] = "true", yl_commons_player_joined = "1711320479", ["signslib:pos"] = "(4203,53,1086)", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 14480\", \"shields:shield_rainbow 1 20208\", \"3d_armor:leggings_crystal 1 14480\", \"3d_armor:boots_crystal 1 14480\", \"3d_armor:chestplate_crystal 1 14480\", \"\"}", yl_church = "return {[\"last_death_portal\"] = 1710707338, [\"last_death\"] = {[\"y\"] = 84, [\"z\"] = 551, [\"x\"] = 3235}, [\"last_heal\"] = 1690328119}", ["stamina:poisoned"] = "no", jointime = "1659200153", ["stamina:exhaustion"] = "55.5", yl_commons_player_created = "1659200153", bitten = "0", xp_redo_hud_color = "0xE03fd8", digged_nodes = "367896", placed_nodes = "80574", died = "930", crafted = "138740", xp = "270256", yl_commons_thankyou = "75", punch_count = "196452", ["stamina:level"] = "10", inflicted_damage = "4148732", repellant = "0", played_time = "7495987", ["ocean_build.last_warning"] = "1.67388e+09", arenalib_infobox_arenaID = "0", ["ocean_build.ocean_built"] = "12", partychat = "party" } } ``` Log identifier ``` [MOD] yl_report log identifier = 5U1YXrUa2ltpbXpyP0CBWy0QRWApmXcj ``` Profiler save: ``` profile-20240324T235834.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 9h 35min 15s | max lag: 0.921s | clients (21/52): AliasAlreadyTaken, AspireMint, Bailiff, Boot, Cashia, cycle, DannyVimaranes, Diaeresis, flux, Gaeridall, Harlequin, LockePickens, MineWorlds, nakama-ta, pifo, Rattrap, rewired_X, Service, Sokomine, VK, weishilindon ``` Teleport command: ``` /teleport xyz 3139 -172 395 ``` Compass command: ``` /give_compass Construction 5U1YXrUa2ltpbXpyP0CBWy0QRWApmXcj D2691E 3139 -172 395 ```
AliasAlreadyTaken was assigned by yourland-report 2024-03-24 23:58:34 +00:00
AliasAlreadyTaken added the
1. kind/bug
 label 2024-03-25 02:17:36 +00:00
flux commented 2024-03-26 20:22:31 +00:00
Member
Copy Link

this appears to be the same basic issue as #4590. currently, anything thinner than 1/16th of a node can exhibit this behavior if you "sneak" while "inside" of it. the cottages fences appear to be 1/25th of a node wide, so they are susceptible to this. i'd rather not create another engine issue - instead this should be fixed by making the collision boxes thicker.

this appears to be the same basic issue as #4590. currently, anything thinner than 1/16th of a node can exhibit this behavior if you "sneak" while "inside" of it. the cottages fences appear to be 1/25th of a node wide, so they are susceptible to this. i'd rather not create another engine issue - instead this should be fixed by making the collision boxes thicker.
flux added the
3. source/mod upstream
 label 2024-03-26 20:22:41 +00:00
flux commented 2024-03-26 20:24:14 +00:00
Member
Copy Link

cottages isn't really maintained anymore, i suppose i could fix this in integration.

cottages isn't really maintained anymore, i suppose i could fix this in integration.
flux added the
3. source/client
 label 2024-03-26 20:25:13 +00:00
flux commented 2024-03-26 20:52:10 +00:00
Member
Copy Link

an audit showed that only the cottages fences and some chess pieces are too thin:

local thin = 1/16

local function is_box_too_thin(box)
	local xwidth = box[4] - box[1]
	local zwidth = box[6] - box[3]
	return (xwidth > 0 and xwidth < thin) and (zwidth > 0 and zwidth < thin)
end

local function is_boxes_too_thin(boxes)
	for i = 1, #boxes do
		if is_box_too_thin(boxes[i]) then
			return true
		end
	end
	return false
end

local function is_too_thin(box_or_boxes)
	if futil.is_box(box_or_boxes) then
		return is_box_too_thin(box_or_boxes)
	elseif futil.is_boxes(box_or_boxes) then
		return is_boxes_too_thin(box_or_boxes)
	end
end

local function is_nodebox_too_thin(nodebox)
	if not nodebox then
		return false
	elseif nodebox.type == "regular" then
		return false
	elseif nodebox.type == "fixed" or nodebox.type == "leveled" then
		return is_too_thin(nodebox.fixed)
	elseif nodebox.type == "wallmounted" then
		return is_too_thin(nodebox.wall_top) or is_too_thin(nodebox.wall_bottom) or is_too_thin(nodebox.wall_side)
	elseif nodebox.type == "connected" then
		return is_too_thin(nodebox.fixed) or
			is_too_thin(nodebox.connect_top) or
			is_too_thin(nodebox.connect_bottom) or
			is_too_thin(nodebox.connect_front) or
			is_too_thin(nodebox.connect_left) or
			is_too_thin(nodebox.connect_back) or
			is_too_thin(nodebox.connect_right) or
			is_too_thin(nodebox.disconnected_top) or
			is_too_thin(nodebox.disconnected_bottom) or
			is_too_thin(nodebox.disconnected_front) or
			is_too_thin(nodebox.disconnected_left) or
			is_too_thin(nodebox.disconnected_back) or
			is_too_thin(nodebox.disconnected_right) or
			is_too_thin(nodebox.disconnected) or
			is_too_thin(nodebox.disconnected_sides)
	end
end

for name, def in futil.table.pairs_by_key(minetest.registered_nodes) do
	if is_nodebox_too_thin(def.node_box) or is_nodebox_too_thin(def.collision_box) then
		print(name)
	end
end

image

an audit showed that only the cottages fences and some chess pieces are too thin: ```lua local thin = 1/16 local function is_box_too_thin(box) local xwidth = box[4] - box[1] local zwidth = box[6] - box[3] return (xwidth > 0 and xwidth < thin) and (zwidth > 0 and zwidth < thin) end local function is_boxes_too_thin(boxes) for i = 1, #boxes do if is_box_too_thin(boxes[i]) then return true end end return false end local function is_too_thin(box_or_boxes) if futil.is_box(box_or_boxes) then return is_box_too_thin(box_or_boxes) elseif futil.is_boxes(box_or_boxes) then return is_boxes_too_thin(box_or_boxes) end end local function is_nodebox_too_thin(nodebox) if not nodebox then return false elseif nodebox.type == "regular" then return false elseif nodebox.type == "fixed" or nodebox.type == "leveled" then return is_too_thin(nodebox.fixed) elseif nodebox.type == "wallmounted" then return is_too_thin(nodebox.wall_top) or is_too_thin(nodebox.wall_bottom) or is_too_thin(nodebox.wall_side) elseif nodebox.type == "connected" then return is_too_thin(nodebox.fixed) or is_too_thin(nodebox.connect_top) or is_too_thin(nodebox.connect_bottom) or is_too_thin(nodebox.connect_front) or is_too_thin(nodebox.connect_left) or is_too_thin(nodebox.connect_back) or is_too_thin(nodebox.connect_right) or is_too_thin(nodebox.disconnected_top) or is_too_thin(nodebox.disconnected_bottom) or is_too_thin(nodebox.disconnected_front) or is_too_thin(nodebox.disconnected_left) or is_too_thin(nodebox.disconnected_back) or is_too_thin(nodebox.disconnected_right) or is_too_thin(nodebox.disconnected) or is_too_thin(nodebox.disconnected_sides) end end for name, def in futil.table.pairs_by_key(minetest.registered_nodes) do if is_nodebox_too_thin(def.node_box) or is_nodebox_too_thin(def.collision_box) then print(name) end end ``` ![image](/attachments/d2800c87-9e4d-4e3b-9a93-30dab7576e9e)
image.png
11 KiB
flux added the
4. step/ready to QA test
 label 2024-03-26 21:06:47 +00:00
flux commented 2024-03-26 21:08:14 +00:00
Member
Copy Link

implemented 8c880026fb

implemented https://gitea.your-land.de/your-land/yl_commons/commit/8c880026fb2f3661a3cb4c6857968a8333231b98
flux commented 2024-03-26 21:09:38 +00:00
Member
Copy Link

i don't think the chess pieces are actually a problem, they've just got some thin decorative bits like e.g. the knight's "ears".

i don't think the chess pieces are actually a problem, they've just got some thin decorative bits like e.g. the knight's "ears".
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6565
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?