LeetPeet reports: when I type "/h", it sends me ... #6559

New Issue

yourland-report · 2024-03-24T13:59:19Z

yourland-report commented

2024-03-24 13:59:19 +00:00

LeetPeet reports a bug:

when I type "/h", it sends me to this spot, but when I type "/h" again, it sends me two blocks South. Could it be because of the door nearby? I have spoken with Alias about the issue.

Player position:

{
	x = -26048,
	y = 2.5,
	z = -21456
}

Player look:

{
	x = 0.86224985122681,
	y = -0.092196799814701,
	z = -0.49802103638649
}

Player information:

{
	max_jitter = 0.70999997854233,
	avg_jitter = 0.020999997854233,
	serialization_version = 29,
	max_rtt = 0.81999999284744,
	version_string = "5.8.0",
	minor = 8,
	protocol_version = 42,
	state = "Active",
	patch = 0,
	formspec_version = 7,
	connection_uptime = 402,
	major = 5,
	ip_version = 6,
	lang_code = "",
	min_rtt = 0.10000000149012,
	avg_rtt = 0.14900000393391,
	min_jitter = 0
}

Player meta:

{
	fields = {
		xp = "4374767",
		["signslib:pos"] = "(-26038,2,-21469)",
		bitten = "0",
		["stamina:exhaustion"] = "42",
		arenalib_infobox_arenaID = "0",
		yl_commons_player_created = "1609243939",
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_crystal 1 4650\", \"3d_armor:boots_crystal 1 1900\", \"shields:shield_crystal 1 4650\", \"3d_armor:leggings_crystal 1 4650\", \"petz:pumpkin_hood 1 9340\", \"\"}",
		hud_state = "on",
		["ocean_build.last_warning"] = "1.65343e+09",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		punch_count = "29492",
		repellant = "0",
		["stamina:level"] = "10",
		["stamina:poisoned"] = "no",
		yl_commons_thankyou = "74",
		inflicted_damage = "507386",
		crafted = "51865",
		yl_commons_player_joined = "1711288366",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		played_time = "9212550",
		digged_nodes = "4633228",
		placed_nodes = "714278",
		died = "324",
		partychat = "main",
		yl_church = "return {[\"last_death_portal\"] = 1711288515, [\"last_death\"] = {[\"x\"] = -26048, [\"y\"] = 2, [\"z\"] = -21483}, [\"last_heal\"] = 1630693112}"
	}
}

Log identifier


[MOD] yl_report log identifier = ZTNpTYnvf7csxxTemev7ueV6izntYUjd

Profiler save:

profile-20240324T135919.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1d 57min 4s | max lag: 1.55s | clients (23/52): AliasAlreadyTaken, AspireMint, Bailiff, Boot, dark_mike_78, ente202, flux, gianlp, hedwig, IRLIANBLITZ, Keya, LadyPixels, laira, LeetPeet, LockePickens, Murmel, nixOS, Noii, playor, pups, Service, Shismu, Tinkerbot

Teleport command:

/teleport xyz -26048 3 -21456

Compass command:

/give_compass Construction ZTNpTYnvf7csxxTemev7ueV6izntYUjd D2691E -26048 3 -21456

LeetPeet reports a bug: > when I type "/h", it sends me to this spot, but when I type "/h" again, it sends me two blocks South. Could it be because of the door nearby? I have spoken with Alias about the issue. Player position: ``` { x = -26048, y = 2.5, z = -21456 } ``` Player look: ``` { x = 0.86224985122681, y = -0.092196799814701, z = -0.49802103638649 } ``` Player information: ``` { max_jitter = 0.70999997854233, avg_jitter = 0.020999997854233, serialization_version = 29, max_rtt = 0.81999999284744, version_string = "5.8.0", minor = 8, protocol_version = 42, state = "Active", patch = 0, formspec_version = 7, connection_uptime = 402, major = 5, ip_version = 6, lang_code = "", min_rtt = 0.10000000149012, avg_rtt = 0.14900000393391, min_jitter = 0 } ``` Player meta: ``` { fields = { xp = "4374767", ["signslib:pos"] = "(-26038,2,-21469)", bitten = "0", ["stamina:exhaustion"] = "42", arenalib_infobox_arenaID = "0", yl_commons_player_created = "1609243939", ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_crystal 1 4650\", \"3d_armor:boots_crystal 1 1900\", \"shields:shield_crystal 1 4650\", \"3d_armor:leggings_crystal 1 4650\", \"petz:pumpkin_hood 1 9340\", \"\"}", hud_state = "on", ["ocean_build.last_warning"] = "1.65343e+09", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", punch_count = "29492", repellant = "0", ["stamina:level"] = "10", ["stamina:poisoned"] = "no", yl_commons_thankyou = "74", inflicted_damage = "507386", crafted = "51865", yl_commons_player_joined = "1711288366", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", played_time = "9212550", digged_nodes = "4633228", placed_nodes = "714278", died = "324", partychat = "main", yl_church = "return {[\"last_death_portal\"] = 1711288515, [\"last_death\"] = {[\"x\"] = -26048, [\"y\"] = 2, [\"z\"] = -21483}, [\"last_heal\"] = 1630693112}" } } ``` Log identifier ``` [MOD] yl_report log identifier = ZTNpTYnvf7csxxTemev7ueV6izntYUjd ``` Profiler save: ``` profile-20240324T135919.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1d 57min 4s | max lag: 1.55s | clients (23/52): AliasAlreadyTaken, AspireMint, Bailiff, Boot, dark_mike_78, ente202, flux, gianlp, hedwig, IRLIANBLITZ, Keya, LadyPixels, laira, LeetPeet, LockePickens, Murmel, nixOS, Noii, playor, pups, Service, Shismu, Tinkerbot ``` Teleport command: ``` /teleport xyz -26048 3 -21456 ``` Compass command: ``` /give_compass Construction ZTNpTYnvf7csxxTemev7ueV6izntYUjd D2691E -26048 3 -21456 ```

AliasAlreadyTaken was assigned by yourland-report

2024-03-24 13:59:19 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2024-03-24 23:22:37 +00:00

flux commented

2024-03-26 01:43:51 +00:00

Alias and i came up w/ the same solution at the same time - the code which prevents you from teleporting on top of another player also prevents you from teleporting to the same position you're already standing on.

probably /home should not be restricted this way. and whether or not we decide it should be, your own position shouldn't be a blocker on whether you can teleport to that same position again.

another issue is that these sorts of adjusted positions to teleports shouldn't ever put you through walls, which they apparently can currently.

Alias and i came up w/ the same solution at the same time - the code which prevents you from teleporting on top of another player also prevents you from teleporting to the same position you're already standing on. probably /home *should not* be restricted this way. and whether or not we decide it should be, your own position shouldn't be a blocker on whether you can teleport to that same position again. another issue is that these sorts of adjusted positions to teleports shouldn't ever put you through walls, which they apparently can currently.

flux added the

3. source/integration

2. prio/elevated

labels 2024-03-26 01:44:06 +00:00

flux added this to the flux's TODO list project 2024-03-26 01:44:17 +00:00

flux commented

2024-04-04 23:36:07 +00:00

made safe_teleport ignore the player's own position

38768d5b0d

made safe_teleport ignore the player's own position https://gitea.your-land.de/your-land/yl_commons/commit/38768d5b0d0b88dcdd957e5c0b177f5c6b878db1

flux added the

4. step/ready to QA test