Lucien_II reports: the last item in crafting tabl ... #6537

Open
opened 2024-03-20 21:22:49 +00:00 by yourland-report · 10 comments

Lucien_II reports a bug:

the last item in crafting table & autocrafter spits out the ingredients not the crafted item

Player position:

{
	y = -819.4990234375,
	z = -3141.5329589844,
	x = -1545.5989990234
}

Player look:

{
	y = -0.6360781788826,
	z = 0.17843072116375,
	x = 0.75071102380753
}

Player information:

{
	max_rtt = 1.4370000362396,
	ip_version = 6,
	min_rtt = 0.037999998778105,
	avg_rtt = 0.064999997615814,
	min_jitter = 0,
	max_jitter = 1.3940000534058,
	avg_jitter = 0.023999996483326,
	connection_uptime = 5201,
	serialization_version = 29,
	patch = 0,
	minor = 8,
	formspec_version = 7,
	protocol_version = 42,
	major = 5,
	lang_code = "",
	version_string = "5.8.0",
	state = "Active"
}

Player meta:

{
	fields = {
		["stamina:poisoned"] = "no",
		yl_commons_thankyou = "16",
		["stamina:exhaustion"] = "159.5",
		played_time = "3176022",
		digged_nodes = "1087109",
		placed_nodes = "230067",
		died = "203",
		crafted = "382828",
		yl_commons_player_created = "1637790663",
		yl_commons_player_joined = "1710964579",
		bitten = "0",
		arenalib_infobox_arenaID = "0",
		["signslib:pos"] = "(-4028,-989,-5465)",
		jointime = "1637790663",
		["petz:werewolf_clan_idx"] = "1",
		inflicted_damage = "858592",
		hud_state = "on",
		xp = "973604",
		punch_count = "44879",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		repellant = "0",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 15910\", \"3d_armor:leggings_crystal 1 15910\", \"shields:shield_rainbow 1 6176\", \"3d_armor:boots_crystal 1 15440\", \"3d_armor:chestplate_crystal 1 15440\", \"\"}",
		yl_church = "return {[\"last_death_portal\"] = 1710968269, [\"last_death\"] = {[\"y\"] = -816, [\"z\"] = -3144, [\"x\"] = -1549}, [\"last_heal\"] = 1654037245}",
		["petz:werewolf"] = "0",
		["stamina:level"] = "10",
		["petz:lycanthropy"] = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = 2e6dYvFtTk6Nhg5h8omcgBB6Fb8c8gi6

Profiler save:

profile-20240320T212249.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 4d 7h 1min 44s | max lag: 0.837s | clients (18/52): AliasAlreadyTaken, AspireMint, Bailiff, Crainiax, crankyape, flux, G9, Historia_reiss, LadyPixels, laira, Lucien, Lucien_II, MichaelVL, Minetest13, poppyasdan, ProMemm, randomm, Service

Teleport command:

/teleport xyz -1546 -819 -3142

Compass command:

/give_compass Construction 2e6dYvFtTk6Nhg5h8omcgBB6Fb8c8gi6 D2691E -1546 -819 -3142
Lucien_II reports a bug: > the last item in crafting table & autocrafter spits out the ingredients not the crafted item Player position: ``` { y = -819.4990234375, z = -3141.5329589844, x = -1545.5989990234 } ``` Player look: ``` { y = -0.6360781788826, z = 0.17843072116375, x = 0.75071102380753 } ``` Player information: ``` { max_rtt = 1.4370000362396, ip_version = 6, min_rtt = 0.037999998778105, avg_rtt = 0.064999997615814, min_jitter = 0, max_jitter = 1.3940000534058, avg_jitter = 0.023999996483326, connection_uptime = 5201, serialization_version = 29, patch = 0, minor = 8, formspec_version = 7, protocol_version = 42, major = 5, lang_code = "", version_string = "5.8.0", state = "Active" } ``` Player meta: ``` { fields = { ["stamina:poisoned"] = "no", yl_commons_thankyou = "16", ["stamina:exhaustion"] = "159.5", played_time = "3176022", digged_nodes = "1087109", placed_nodes = "230067", died = "203", crafted = "382828", yl_commons_player_created = "1637790663", yl_commons_player_joined = "1710964579", bitten = "0", arenalib_infobox_arenaID = "0", ["signslib:pos"] = "(-4028,-989,-5465)", jointime = "1637790663", ["petz:werewolf_clan_idx"] = "1", inflicted_damage = "858592", hud_state = "on", xp = "973604", punch_count = "44879", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", repellant = "0", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 15910\", \"3d_armor:leggings_crystal 1 15910\", \"shields:shield_rainbow 1 6176\", \"3d_armor:boots_crystal 1 15440\", \"3d_armor:chestplate_crystal 1 15440\", \"\"}", yl_church = "return {[\"last_death_portal\"] = 1710968269, [\"last_death\"] = {[\"y\"] = -816, [\"z\"] = -3144, [\"x\"] = -1549}, [\"last_heal\"] = 1654037245}", ["petz:werewolf"] = "0", ["stamina:level"] = "10", ["petz:lycanthropy"] = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = 2e6dYvFtTk6Nhg5h8omcgBB6Fb8c8gi6 ``` Profiler save: ``` profile-20240320T212249.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 4d 7h 1min 44s | max lag: 0.837s | clients (18/52): AliasAlreadyTaken, AspireMint, Bailiff, Crainiax, crankyape, flux, G9, Historia_reiss, LadyPixels, laira, Lucien, Lucien_II, MichaelVL, Minetest13, poppyasdan, ProMemm, randomm, Service ``` Teleport command: ``` /teleport xyz -1546 -819 -3142 ``` Compass command: ``` /give_compass Construction 2e6dYvFtTk6Nhg5h8omcgBB6Fb8c8gi6 D2691E -1546 -819 -3142 ```
AliasAlreadyTaken was assigned by yourland-report 2024-03-20 21:22:49 +00:00
flux added the
4. step/question
label 2024-03-21 05:24:32 +00:00
Member

sent a mail to the player:

what were you trying to craft, and with what recipe? 
sent a mail to the player: ``` what were you trying to craft, and with what recipe? ```
Member

reply:

The last one was black stone - two stone brick and one black dye in autocrafter. Also noticed it with picked carrots - three carrots and one glass in a crafting table but didn't think much of it. Both still had partial ingredients remaining. I think the autocrafter still have excess dye.
reply: ``` The last one was black stone - two stone brick and one black dye in autocrafter. Also noticed it with picked carrots - three carrots and one glass in a crafting table but didn't think much of it. Both still had partial ingredients remaining. I think the autocrafter still have excess dye. ```
Member

i can't replicate this

image

image

i can't replicate this ![image](/attachments/e82e44c1-22b1-4e4b-b1bb-fed24715775b) ![image](/attachments/9b05a6e9-ba73-4925-baab-51060040ef53)
flux added
1. kind/bug
4. step/needs confirmation
and removed
4. step/question
labels 2024-03-24 21:54:57 +00:00
Member

mmmm i just tried to destroy my test crafting table and then it spawned some input items into the output inventory? need to test this more, but i'm 85% asleep. it had nothing in the input or output before i did that. once i removed it, i could remove those.

mmmm i just tried to destroy my test crafting table and *then* it spawned some input items into the output inventory? need to test this more, but i'm 85% asleep. it had nothing in the input or output before i did that. once i removed it, i could remove those.
Member

oh, i bet i know what this is about! because the recipe is now a schema and not an inventory, anything in it is refunded into the outputs.

oh, i bet i know what this is about! because the recipe is now a schema and not an inventory, anything in it is refunded into the outputs.
flux added
1. kind/documentation
5. result/fixed
and removed
1. kind/bug
4. step/needs confirmation
labels 2024-03-30 19:26:34 +00:00
Member

ugh apparently there's a bug in the refund LBM, if put some stuff in the crafting grid and restart the server, they get refunded, even though no items were lost. it only happens once though.

ugh apparently there's a bug in the refund LBM, if put some stuff in the crafting grid and restart the server, they get refunded, even though no items were lost. it only happens once though.
Member

fixed that 812ecaa704

fixed that https://github.com/fluxionary/minetest-crafting_bench/commit/812ecaa7040dc5c5874c19d7409383277f01e17e
flux added
2. prio/critical
and removed
2. prio/elevated
labels 2024-03-30 19:42:09 +00:00
flux added this to the flux's TODO list project 2024-03-30 19:42:18 +00:00
flux self-assigned this 2024-03-30 19:42:23 +00:00
flux added this to the 1.1.124 milestone 2024-03-30 19:42:51 +00:00
Member

if there was to be anything we do in a 1.1.123.3 release, this should be in there. this bug allows duping of any item.

if there was to be anything we do in a 1.1.123.3 release, this should be in there. this bug allows duping of any item.
flux added the
4. step/ready to QA test
label 2024-04-03 22:35:55 +00:00

QA

Waht's the repro? I can neither reproduce with autocrafter nor crafting bench on main?

QA Waht's the repro? I can neither reproduce with autocrafter nor crafting bench on main?
AliasAlreadyTaken added the
4. step/question
label 2024-04-22 12:15:35 +00:00
AliasAlreadyTaken added
ugh/QA OK
and removed
4. step/question
labels 2024-04-26 22:25:09 +00:00

QA

Found the repro and it works now as expected, new workbenches don't refund items.

QA Found the repro and it works now as expected, new workbenches don't refund items.
Sign in to join this conversation.
No Milestone
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6537
No description provided.