AspireMint reports: Digging yl_commons:candle_thin ... #6423

New Issue

yourland-report · 2024-03-09T00:53:04Z

yourland-report commented

2024-03-09 00:53:04 +00:00

AspireMint reports a bug:

Digging yl_commons:candle_thin makes sound of leaves. Suggestion: use wool sound (or any other softer sound) and make digging time shorter (same as digging torch).

Player position:

{
	x = 1981.166015625,
	y = 17.5,
	z = 1173.1490478516
}

Player look:

{
	x = -0.085128508508205,
	y = -0.56049448251724,
	z = 0.82377129793167
}

Player information:

{
	max_rtt = 29.099000930786,
	protocol_version = 42,
	lang_code = "",
	version_string = "5.7.0",
	ip_version = 6,
	min_rtt = 0.024000000208616,
	avg_rtt = 0.026000000536442,
	min_jitter = 0,
	formspec_version = 6,
	avg_jitter = 0,
	connection_uptime = 32255,
	serialization_version = 29,
	patch = 0,
	state = "Active",
	max_jitter = 28.63399887085,
	minor = 7,
	major = 5
}

Player meta:

{
	fields = {
		digged_nodes = "2036529",
		placed_nodes = "399935",
		died = "386",
		crafted = "132639",
		yl_commons_player_joined = "1709913375",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 4551, [\"y\"] = 29802, [\"z\"] = 1539}, [\"last_heal\"] = 1708702962, [\"last_death_portal\"] = 1709670258}",
		arenalib_infobox_arenaID = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}",
		punch_count = "567929",
		["stamina:level"] = "8",
		yl_commons_thankyou = "298",
		xp = "2125629",
		["ocean_build.forbidden"] = "true",
		hud_state = "on",
		hotbar_size = "16",
		["petz:werewolf_clan_idx"] = "4",
		["petz:lycanthropy"] = "0",
		repellant = "0",
		["petz:werewolf"] = "0",
		["ocean_build.last_warning"] = "1.65674e+09",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 14320\", \"3d_armor:boots_crystal 1 14320\", \"3d_armor:leggings_nether 1 28640\", \"\", \"3d_armor:chestplate_nether 1 28640\", \"shields:shield_nether 1 28640\"}",
		["ocean_build.ocean_built"] = "12",
		["stamina:exhaustion"] = "143",
		yl_commons_player_created = "1619715757",
		bitten = "0",
		jointime = "1619715757",
		played_time = "7132008",
		["signslib:pos"] = "(2824,-191,326)",
		["stamina:poisoned"] = "no",
		partychat = "party",
		inflicted_damage = "12286830"
	}
}

Log identifier


[MOD] yl_report log identifier = 8F96NoC97R1E071pSmCVnOSGKigZhxNt

Profiler save:

profile-20240309T005303.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 5d 12h 19min 26s | max lag: 0.375s | clients (15/52): 123ert, AliasAlreadyTaken, AspireMint, Azelf, Bailiff, Bishiro, crankyape, daydream, flux, Injury, JinnyC, rewired_X, rheo, Service, tagtraum

Teleport command:

/teleport xyz 1981 18 1173

Compass command:

/give_compass Construction 8F96NoC97R1E071pSmCVnOSGKigZhxNt D2691E 1981 18 1173

AspireMint reports a bug: > Digging yl_commons:candle_thin makes sound of leaves. Suggestion: use wool sound (or any other softer sound) and make digging time shorter (same as digging torch). Player position: ``` { x = 1981.166015625, y = 17.5, z = 1173.1490478516 } ``` Player look: ``` { x = -0.085128508508205, y = -0.56049448251724, z = 0.82377129793167 } ``` Player information: ``` { max_rtt = 29.099000930786, protocol_version = 42, lang_code = "", version_string = "5.7.0", ip_version = 6, min_rtt = 0.024000000208616, avg_rtt = 0.026000000536442, min_jitter = 0, formspec_version = 6, avg_jitter = 0, connection_uptime = 32255, serialization_version = 29, patch = 0, state = "Active", max_jitter = 28.63399887085, minor = 7, major = 5 } ``` Player meta: ``` { fields = { digged_nodes = "2036529", placed_nodes = "399935", died = "386", crafted = "132639", yl_commons_player_joined = "1709913375", yl_church = "return {[\"last_death\"] = {[\"x\"] = 4551, [\"y\"] = 29802, [\"z\"] = 1539}, [\"last_heal\"] = 1708702962, [\"last_death_portal\"] = 1709670258}", arenalib_infobox_arenaID = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}", punch_count = "567929", ["stamina:level"] = "8", yl_commons_thankyou = "298", xp = "2125629", ["ocean_build.forbidden"] = "true", hud_state = "on", hotbar_size = "16", ["petz:werewolf_clan_idx"] = "4", ["petz:lycanthropy"] = "0", repellant = "0", ["petz:werewolf"] = "0", ["ocean_build.last_warning"] = "1.65674e+09", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 14320\", \"3d_armor:boots_crystal 1 14320\", \"3d_armor:leggings_nether 1 28640\", \"\", \"3d_armor:chestplate_nether 1 28640\", \"shields:shield_nether 1 28640\"}", ["ocean_build.ocean_built"] = "12", ["stamina:exhaustion"] = "143", yl_commons_player_created = "1619715757", bitten = "0", jointime = "1619715757", played_time = "7132008", ["signslib:pos"] = "(2824,-191,326)", ["stamina:poisoned"] = "no", partychat = "party", inflicted_damage = "12286830" } } ``` Log identifier ``` [MOD] yl_report log identifier = 8F96NoC97R1E071pSmCVnOSGKigZhxNt ``` Profiler save: ``` profile-20240309T005303.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 5d 12h 19min 26s | max lag: 0.375s | clients (15/52): 123ert, AliasAlreadyTaken, AspireMint, Azelf, Bailiff, Bishiro, crankyape, daydream, flux, Injury, JinnyC, rewired_X, rheo, Service, tagtraum ``` Teleport command: ``` /teleport xyz 1981 18 1173 ``` Compass command: ``` /give_compass Construction 8F96NoC97R1E071pSmCVnOSGKigZhxNt D2691E 1981 18 1173 ```

👍 1

AliasAlreadyTaken was assigned by yourland-report

2024-03-09 00:53:04 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2024-03-09 00:55:14 +00:00

flux referenced this issue from a commit

2024-03-10 00:10:38 +00:00

your-land/bugtracker#6423 more appropriate sounds for yl lights

flux added the

4. step/ready to QA test

label 2024-03-10 00:10:57 +00:00

flux commented

2024-03-10 00:11:11 +00:00

added more appropriate sounds: fae95258f6

added more appropriate sounds: https://gitea.your-land.de/your-land/yl_commons/commit/fae95258f6291b6b960974ac98e26563f86f9061

AliasAlreadyTaken added this to the 1.1.123 milestone 2024-03-10 12:05:39 +00:00

whosit commented

2024-03-11 20:00:20 +00:00

Metal things make metal sounds 👌
But yl_commons:candle_thin still makes default_dig_snappy.ogg (leafy) sound because it's in snappy group and default sounds don't add dig sound which is not the same as dug sound:

function default.node_sound_defaults(table)
	table = table or {}
	table.footstep = table.footstep or
			{name = "", gain = 1.0}
	table.dug = table.dug or
			{name = "default_dug_node", gain = 0.25}
	table.place = table.place or
			{name = "default_place_node_hard", gain = 1.0}
	return table
end

This took me embarrassingly long to figure out..

Metal things make metal sounds 👌 But `yl_commons:candle_thin` still makes `default_dig_snappy.ogg` (leafy) sound because it's in `snappy` group and default sounds don't add `dig` sound which is not the same as `dug` sound: ```lua function default.node_sound_defaults(table) table = table or {} table.footstep = table.footstep or {name = "", gain = 1.0} table.dug = table.dug or {name = "default_dug_node", gain = 0.25} table.place = table.place or {name = "default_place_node_hard", gain = 1.0} return table end ``` This took me embarrassingly long to figure out..

flux referenced this issue from a commit

2024-03-11 21:59:35 +00:00

your-land/bugtracker#6423 actually fix candle breaking sounds

flux commented

2024-03-11 22:00:56 +00:00

This took me embarrassingly long to figure out..

sorry you had to do that, i clearly didn't test this. i just copied what wool was doing and assumed it would work.

fixed the candle dig sounds (though they now take slightly longer to dig) 36fdc526cb

> This took me embarrassingly long to figure out.. sorry you had to do that, i clearly didn't test this. i just copied what wool was doing and assumed it would work. fixed the candle dig sounds (though they now take slightly longer to dig) https://gitea.your-land.de/your-land/yl_commons/commit/36fdc526cbce0d4684eae5860f0cfde048bcc2c2

AliasAlreadyTaken added the

ugh/QA OK

label 2024-03-12 00:13:04 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2024-03-29 22:52:33 +00:00

AliasAlreadyTaken was unassigned by flux

2024-03-29 22:52:35 +00:00

flux commented

2024-03-29 22:52:55 +00:00