whosit reports: water_life textures cause client stuttering/freezing #6418

Closed
opened 2024-03-08 17:54:16 +00:00 by yourland-report · 10 comments

whosit reports a bug:

water_life textures cause client stuttering when generating wielditems for croc_bag and crocleather because textures are 1080x1080px

croc bag, croc leather

Player position:

{
	x = 79.904998779297,
	y = 1021.5009765625,
	z = 22472.58203125
}

Player look:

{
	x = 0.99930787086487,
	y = -0.036469291895628,
	z = -0.0073253009468317
}

Player information:

{
	formspec_version = 7,
	lang_code = "ru",
	protocol_version = 43,
	max_rtt = 4.1989998817444,
	ip_version = 6,
	min_rtt = 0.039000000804663,
	avg_rtt = 0.041999999433756,
	min_jitter = 0,
	max_jitter = 3.5549998283386,
	avg_jitter = 0.0010000020265579,
	connection_uptime = 4605,
	serialization_version = 29,
	patch = 0,
	state = "Active",
	major = 5,
	version_string = "5.8.0-debug",
	minor = 8
}

Player meta:

{
	fields = {
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 41, [\"y\"] = 12, [\"z\"] = 22486}, [\"last_heal\"] = 1709652151, [\"last_death_portal\"] = 1709916594}",
		xp = "0",
		xp_redo_hud_color = "0x0000ff",
		partychat = "party",
		["petz:pre_werewolf_animation"] = "return {[\"animation\"] = \"stand\", [\"textures\"] = {\"blank.png\", \"character.warrior_m1.png\", \"3d_armor_trans.png^3d_armor_boots_crystal.png^shields_shield_crystal.png^3d_armor_leggings_crystal.png^3d_armor_helmet_crystal.png^3d_armor_chestplate_crystal.png\", \"default_dirt.png\"}, [\"model\"] = \"skinsdb_3d_armor_character_5.b3d\", [\"animation_speed\"] = 30}",
		repellant = "0",
		["petz:werewolf_clan_idx"] = "3",
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 6740\", \"shields:shield_crystal 1 6715\", \"3d_armor:leggings_crystal 1 6715\", \"3d_armor:helmet_crystal 1 6715\", \"3d_armor:chestplate_crystal 1 6715\", \"\"}",
		yl_commons_player_created = "1615221933",
		yl_commons_player_joined = "1709915871",
		["signslib:pos"] = "(2183,22,1163)",
		["petz:werewolf_vignette_id"] = "20",
		hud_state = "on",
		played_time = "8731875",
		digged_nodes = "345423",
		punch_count = "41130",
		died = "790",
		crafted = "83765",
		["stamina:level"] = "12",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["stamina:poisoned"] = "no",
		lagometer = "1",
		["stamina:exhaustion"] = "72.5",
		arenalib_infobox_arenaID = "0",
		jointime = "1615221933",
		inflicted_damage = "634102",
		yl_commons_thankyou = "261",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		placed_nodes = "100050",
		["petz:werewolf"] = "1"
	}
}

Log identifier


[MOD] yl_report log identifier = TDsQcb0j7ApckY0GXZA9zgpbC4Snb7c3

Profiler save:

profile-20240308T175416.json_prettyEE

Status:

# Server: version: 5.8.0-yl-test | game: Minetest Game | uptime: 1d 3min 46s | max lag: 0.162s | clients (2/52): whosit, whostand

Teleport command:

/teleport xyz 80 1022 22473

Compass command:

/give_compass Construction TDsQcb0j7ApckY0GXZA9zgpbC4Snb7c3 D2691E 80 1022 22473
whosit reports a bug: > water_life textures cause client stuttering when generating wielditems for croc_bag and crocleather because textures are 1080x1080px croc bag, croc leather Player position: ``` { x = 79.904998779297, y = 1021.5009765625, z = 22472.58203125 } ``` Player look: ``` { x = 0.99930787086487, y = -0.036469291895628, z = -0.0073253009468317 } ``` Player information: ``` { formspec_version = 7, lang_code = "ru", protocol_version = 43, max_rtt = 4.1989998817444, ip_version = 6, min_rtt = 0.039000000804663, avg_rtt = 0.041999999433756, min_jitter = 0, max_jitter = 3.5549998283386, avg_jitter = 0.0010000020265579, connection_uptime = 4605, serialization_version = 29, patch = 0, state = "Active", major = 5, version_string = "5.8.0-debug", minor = 8 } ``` Player meta: ``` { fields = { ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"x\"] = 41, [\"y\"] = 12, [\"z\"] = 22486}, [\"last_heal\"] = 1709652151, [\"last_death_portal\"] = 1709916594}", xp = "0", xp_redo_hud_color = "0x0000ff", partychat = "party", ["petz:pre_werewolf_animation"] = "return {[\"animation\"] = \"stand\", [\"textures\"] = {\"blank.png\", \"character.warrior_m1.png\", \"3d_armor_trans.png^3d_armor_boots_crystal.png^shields_shield_crystal.png^3d_armor_leggings_crystal.png^3d_armor_helmet_crystal.png^3d_armor_chestplate_crystal.png\", \"default_dirt.png\"}, [\"model\"] = \"skinsdb_3d_armor_character_5.b3d\", [\"animation_speed\"] = 30}", repellant = "0", ["petz:werewolf_clan_idx"] = "3", ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 6740\", \"shields:shield_crystal 1 6715\", \"3d_armor:leggings_crystal 1 6715\", \"3d_armor:helmet_crystal 1 6715\", \"3d_armor:chestplate_crystal 1 6715\", \"\"}", yl_commons_player_created = "1615221933", yl_commons_player_joined = "1709915871", ["signslib:pos"] = "(2183,22,1163)", ["petz:werewolf_vignette_id"] = "20", hud_state = "on", played_time = "8731875", digged_nodes = "345423", punch_count = "41130", died = "790", crafted = "83765", ["stamina:level"] = "12", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["stamina:poisoned"] = "no", lagometer = "1", ["stamina:exhaustion"] = "72.5", arenalib_infobox_arenaID = "0", jointime = "1615221933", inflicted_damage = "634102", yl_commons_thankyou = "261", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", placed_nodes = "100050", ["petz:werewolf"] = "1" } } ``` Log identifier ``` [MOD] yl_report log identifier = TDsQcb0j7ApckY0GXZA9zgpbC4Snb7c3 ``` Profiler save: ``` profile-20240308T175416.json_prettyEE ``` Status: ``` # Server: version: 5.8.0-yl-test | game: Minetest Game | uptime: 1d 3min 46s | max lag: 0.162s | clients (2/52): whosit, whostand ``` Teleport command: ``` /teleport xyz 80 1022 22473 ``` Compass command: ``` /give_compass Construction TDsQcb0j7ApckY0GXZA9zgpbC4Snb7c3 D2691E 80 1022 22473 ```
AliasAlreadyTaken was assigned by yourland-report 2024-03-08 17:54:16 +00:00
Member

do
/teleport xyz 80 1022 22473
on the test server and slowly walk East, and watch your client freeze.

To test on smaller scale, just put croc items in an itemframe and punch it.

do `/teleport xyz 80 1022 22473` on the test server and slowly walk East, and watch your client freeze. To test on smaller scale, just put croc items in an itemframe and punch it.
whosit changed title from whosit reports: water_life textures causes cli ... to whosit reports: water_life textures cause client stuttering/freezing 2024-03-08 17:56:38 +00:00
Member

And thanks to AspireMint for pointing this problem out and helping narrow it down.

And thanks to AspireMint for pointing this problem out and helping narrow it down.
flux added the
3. source/art
label 2024-03-09 04:38:32 +00:00
Member

i've been playing around w/ cropping and downscaling the huge water_life textures, and i'll add those to yl_texturepack soon.

however, these aren't the only huge textures - i intend on reporting back on that later, and also replacing them in yl_texturepack.

i've been playing around w/ cropping and downscaling the huge water_life textures, and i'll add those to yl_texturepack soon. however, these aren't the only huge textures - i intend on reporting back on that later, and also replacing them in yl_texturepack.
flux added the
1. kind/balancing
4. step/at work
labels 2024-03-09 04:41:13 +00:00
flux added this to the flux's TODO list project 2024-03-09 04:41:16 +00:00
flux self-assigned this 2024-03-09 04:41:22 +00:00
Member

oh right, i forgot about this lovely feature of the extruded wieldimage drawtype, which is part of why they're so expensive to draw:

image

note this is a scaled-down 64x64 texture

oh right, i forgot about this lovely feature of the extruded wieldimage drawtype, which is part of why they're so expensive to draw: ![image](/attachments/c0b469c0-3694-435a-b597-ddca490095e4) note this is a scaled-down 64x64 texture
131 KiB
Member

downsized a number of water_life images: 88ef2c7df7

downsized a number of water_life images: https://gitea.your-land.de/your-land/yl_texturepack/commit/88ef2c7df7356f5a9ed8d971580b7a172823a7a5
Member

It's not even drawing, there's some code that generates that mesh... and uploads it to GPU?
Somehow on a laptop without dedicated GPU this stutter is barely noticeable, but on PC with a dedicated AMD GPU just dropping this croc causes 0.2s freeze...

It's not even drawing, there's some code that generates that mesh... and uploads it to GPU? Somehow on a laptop without dedicated GPU this stutter is barely noticeable, but on PC with a dedicated AMD GPU just dropping this croc causes 0.2s freeze...
Member

other "large" image files, which aren't screenshots or otherwise not displayed in-game, and are not part of a HUD:

  • digistuff/textures/digistuff_eeprom_top.png (512, 512)
  • digistuff/textures/digistuff_gpu_top.png (512, 512)
  • digistuff/textures/digistuff_ioexp_top.png (512, 512)
  • digistuff/textures/digistuff_nic_top.png (512, 512)
  • digistuff/textures/digistuff_ram_top.png (512, 512)
  • digistuff/textures/digistuff_timer_top.png (512, 512)
  • mesecons/mesecons_luacontroller/textures/jeija_luacontroller_LED_A.png (512, 512)
  • mesecons/mesecons_luacontroller/textures/jeija_luacontroller_LED_B.png (512, 512)
  • mesecons/mesecons_luacontroller/textures/jeija_luacontroller_LED_C.png (512, 512)
  • mesecons/mesecons_luacontroller/textures/jeija_luacontroller_LED_D.png (512, 512)
  • mesecons/mesecons_luacontroller/textures/jeija_luacontroller_burnt_top.png (512, 512)
  • mesecons/mesecons_luacontroller/textures/jeija_luacontroller_top.png (512, 512)
  • mesecons_debug/textures/penalty_controller_top.png (512, 512)
  • meseportals/textures/meseportal_controller.png (384, 384)
  • meseportals/textures/meseportal_controller_unlinked.png (384, 384)
  • meseportals/textures/meseportal_vortex.png (192, 2304)
  • scorpion/textures/scorpion_armor.png (512, 512)
  • scorpion/textures/scorpion_green.png (512, 512)
  • scorpion/textures/scorpion_pet.png (512, 512)
  • scorpion/textures/scorpion_red.png (512, 512)
  • scorpion/textures/scorpion_tan.png (512, 512)
  • snowball/textures/snowball.png (400, 400)
  • windmill/textures/windmill.png (80, 1280)
  • windmill/textures/windmill_3blade_ccw.png (160, 3200)
  • windmill/textures/windmill_3blade_cw.png (160, 3200)
  • windmill/textures/windmill_farm_ccw.png (160, 3200)
  • windmill/textures/windmill_farm_cw.png (160, 3200)
  • windmill/textures/windmill_reverse.png (80, 1280)
  • windmill/textures/windmill_wooden_ccw.png (160, 2560)
  • windmill/textures/windmill_wooden_ccw_with_sails.png (160, 2560)
  • windmill/textures/windmill_wooden_cw.png (160, 2560)
  • windmill/textures/windmill_wooden_cw_with_sails.png (160, 2560)
  • yl_exhibition/textures/yl_exhibition_2021_05_23_aliasschnitzel.png (548, 537)
  • yl_exhibition/textures/yl_exhibition_2021_08_08_sword.png (567, 568)
  • yl_fireplace/textures/yl_fireplace_fireplace.png (1024, 1024)
  • yl_fireplace/textures/yl_fireplace_fireplace_active.png (1024, 1024)
  • yl_livemapping/textures/yl_aqualonia.png (512, 512)
  • yl_livemapping/textures/yl_arvangurvanmod.png (512, 512)
  • yl_livemapping/textures/yl_livemapping_ne.png (384, 384)
  • yl_livemapping/textures/yl_livemapping_ne_points.png (384, 384)
  • yl_livemapping/textures/yl_livemapping_nw.png (384, 384)
  • yl_livemapping/textures/yl_livemapping_nw_points.png (384, 384)
  • yl_livemapping/textures/yl_livemapping_se.png (384, 384)
  • yl_livemapping/textures/yl_livemapping_se_points.png (384, 384)
  • yl_livemapping/textures/yl_livemapping_sw.png (384, 384)
  • yl_livemapping/textures/yl_livemapping_sw_points.png (384, 384)
  • yl_livemapping/textures/yl_maravillosa_cc.png (272, 256)
  • yl_livemapping/textures/yl_maravillosa_nc.png (272, 256)
  • yl_livemapping/textures/yl_maravillosa_sc.png (272, 256)
  • yl_livemapping/textures/yl_maravillose.png (672, 656)
  • yl_livemapping/textures/yl_sanctuary.png (512, 512)
  • yl_livemapping/textures/yl_venezia_large.png (768, 768)
  • yl_nether_mobs/textures/dmobs_rat.png (512, 512)
  • yl_nether_mobs/textures/dmobs_skeleton.png (512, 512)

i'm not sure any of these are really super important. the mesecons/digistuff textures look terrible when scaled down any. the livemapping stuff probably will never go into an item frame. i don't think the other things can be shown as a wielditem either, but i'm not sure about everything.

other "large" image files, which aren't screenshots or otherwise not displayed in-game, and are not part of a HUD: * digistuff/textures/digistuff_eeprom_top.png (512, 512) * digistuff/textures/digistuff_gpu_top.png (512, 512) * digistuff/textures/digistuff_ioexp_top.png (512, 512) * digistuff/textures/digistuff_nic_top.png (512, 512) * digistuff/textures/digistuff_ram_top.png (512, 512) * digistuff/textures/digistuff_timer_top.png (512, 512) * mesecons/mesecons_luacontroller/textures/jeija_luacontroller_LED_A.png (512, 512) * mesecons/mesecons_luacontroller/textures/jeija_luacontroller_LED_B.png (512, 512) * mesecons/mesecons_luacontroller/textures/jeija_luacontroller_LED_C.png (512, 512) * mesecons/mesecons_luacontroller/textures/jeija_luacontroller_LED_D.png (512, 512) * mesecons/mesecons_luacontroller/textures/jeija_luacontroller_burnt_top.png (512, 512) * mesecons/mesecons_luacontroller/textures/jeija_luacontroller_top.png (512, 512) * mesecons_debug/textures/penalty_controller_top.png (512, 512) * meseportals/textures/meseportal_controller.png (384, 384) * meseportals/textures/meseportal_controller_unlinked.png (384, 384) * meseportals/textures/meseportal_vortex.png (192, 2304) * scorpion/textures/scorpion_armor.png (512, 512) * scorpion/textures/scorpion_green.png (512, 512) * scorpion/textures/scorpion_pet.png (512, 512) * scorpion/textures/scorpion_red.png (512, 512) * scorpion/textures/scorpion_tan.png (512, 512) * snowball/textures/snowball.png (400, 400) * windmill/textures/windmill.png (80, 1280) * windmill/textures/windmill_3blade_ccw.png (160, 3200) * windmill/textures/windmill_3blade_cw.png (160, 3200) * windmill/textures/windmill_farm_ccw.png (160, 3200) * windmill/textures/windmill_farm_cw.png (160, 3200) * windmill/textures/windmill_reverse.png (80, 1280) * windmill/textures/windmill_wooden_ccw.png (160, 2560) * windmill/textures/windmill_wooden_ccw_with_sails.png (160, 2560) * windmill/textures/windmill_wooden_cw.png (160, 2560) * windmill/textures/windmill_wooden_cw_with_sails.png (160, 2560) * yl_exhibition/textures/yl_exhibition_2021_05_23_aliasschnitzel.png (548, 537) * yl_exhibition/textures/yl_exhibition_2021_08_08_sword.png (567, 568) * yl_fireplace/textures/yl_fireplace_fireplace.png (1024, 1024) * yl_fireplace/textures/yl_fireplace_fireplace_active.png (1024, 1024) * yl_livemapping/textures/yl_aqualonia.png (512, 512) * yl_livemapping/textures/yl_arvangurvanmod.png (512, 512) * yl_livemapping/textures/yl_livemapping_ne.png (384, 384) * yl_livemapping/textures/yl_livemapping_ne_points.png (384, 384) * yl_livemapping/textures/yl_livemapping_nw.png (384, 384) * yl_livemapping/textures/yl_livemapping_nw_points.png (384, 384) * yl_livemapping/textures/yl_livemapping_se.png (384, 384) * yl_livemapping/textures/yl_livemapping_se_points.png (384, 384) * yl_livemapping/textures/yl_livemapping_sw.png (384, 384) * yl_livemapping/textures/yl_livemapping_sw_points.png (384, 384) * yl_livemapping/textures/yl_maravillosa_cc.png (272, 256) * yl_livemapping/textures/yl_maravillosa_nc.png (272, 256) * yl_livemapping/textures/yl_maravillosa_sc.png (272, 256) * yl_livemapping/textures/yl_maravillose.png (672, 656) * yl_livemapping/textures/yl_sanctuary.png (512, 512) * yl_livemapping/textures/yl_venezia_large.png (768, 768) * yl_nether_mobs/textures/dmobs_rat.png (512, 512) * yl_nether_mobs/textures/dmobs_skeleton.png (512, 512) i'm not sure any of these are really super important. the mesecons/digistuff textures look terrible when scaled down any. the livemapping stuff probably will never go into an item frame. i don't think the other things can be shown as a wielditem either, but i'm not sure about everything.
flux added
4. step/ready to QA test
and removed
4. step/at work
labels 2024-03-12 00:25:15 +00:00
Member

marking as ready to QA test, unless someone else can point to specific other textures we need to downsize. my audit hasn't come up w/ anything yet.

marking as ready to QA test, unless someone else can point to specific other textures we need to downsize. my audit hasn't come up w/ anything yet.

QA

Looks good :)

QA Looks good :)
AliasAlreadyTaken added the
ugh/QA OK
label 2024-03-12 00:32:45 +00:00
AliasAlreadyTaken added this to the 1.1.123 milestone 2024-03-12 00:32:46 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2024-03-28 23:04:50 +00:00
flux removed this from the flux's TODO list project 2024-03-28 23:04:54 +00:00
AliasAlreadyTaken was unassigned by flux 2024-03-28 23:04:56 +00:00
flux removed their assignment 2024-03-28 23:04:56 +00:00
Member

live

live
flux closed this issue 2024-03-28 23:05:03 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6418
No description provided.