daydream reports: could have sworn I've rhotated ... #6377

New Issue

yourland-report · 2024-02-29T07:18:40Z

yourland-report commented

2024-02-29 07:18:40 +00:00

daydream reports a bug:

could have sworn I've rhotated wool hundreds if not thousands of times... now I can't tho? Well full node anyways - why can we rhotate all slab sizes but not full node?

Player position:

{
	y = 13.531000137329,
	z = -9819.103515625,
	x = -7060.265625
}

Player look:

{
	y = -0.77813351154327,
	z = -0.043704554438591,
	x = 0.62657654285431
}

Player information:

{
	minor = 8,
	state = "Active",
	min_rtt = 0.15199999511242,
	lang_code = "",
	protocol_version = 42,
	ip_version = 6,
	major = 5,
	avg_rtt = 0.16500000655651,
	min_jitter = 0,
	max_jitter = 2.6870000362396,
	avg_jitter = 0.00099998712539673,
	connection_uptime = 12596,
	serialization_version = 29,
	patch = 0,
	formspec_version = 7,
	version_string = "5.8.0",
	max_rtt = 2.8659999370575
}

Player meta:

{
	fields = {
		digged_nodes = "2788192",
		placed_nodes = "491402",
		died = "353",
		crafted = "221290",
		jointime = "1650064821",
		["petz:lycanthropy"] = "0",
		partychat = "party",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "4.5",
		yl_commons_thankyou = "830",
		["petz:werewolf_clan_idx"] = "1",
		hud_state = "on",
		punch_count = "526632",
		inflicted_damage = "9175360",
		["ocean_build.last_warning"] = "1.65235e+09",
		["ocean_build.ocean_built"] = "8",
		["3d_armor_inventory"] = "return {\"petz:prince_crown\", \"shields:shield_rainbow\", \"petz:silk_dress_coat\", \"3d_armor:leggings_nether\", \"nether_mobs:dragon_boots\", \"\"}",
		["signslib:pos"] = "(-7061,13,-9809)",
		xp = "2907721",
		xp_redo_hud_color = "0xFFC001",
		arenalib_infobox_arenaID = "0",
		yl_church = "return {[\"last_heal\"] = 1673944229, [\"last_death\"] = {[\"y\"] = -30878, [\"z\"] = 1361, [\"x\"] = 1877}, [\"last_death_portal\"] = 1707988941}",
		hotbar_size = "16",
		repellant = "0",
		["petz:werewolf"] = "0",
		yl_commons_player_created = "1650064821",
		yl_commons_player_joined = "1709178543",
		["hud_manager:spawnit:hud_enabled"] = "n",
		bitten = "0",
		["petz:werewolf_vignette_id"] = "19",
		["stamina:level"] = "20",
		played_time = "37750948"
	}
}

Log identifier


[MOD] yl_report log identifier = WND831nHWio6zSI6IqUlfTHju7zKhfkg

Profiler save:

profile-20240229T071840.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 16h 56min 7s | max lag: 0.421s | clients (10/52): aeon, Bailiff, daydream, DezS4125, Hecate, jackofthebean000, JinnyC, Murmel, qBA, TimurHami

Teleport command:

/teleport xyz -7060 14 -9819

Compass command:

/give_compass Construction WND831nHWio6zSI6IqUlfTHju7zKhfkg D2691E -7060 14 -9819

daydream reports a bug: > could have sworn I've rhotated wool hundreds if not thousands of times... now I can't tho? Well full node anyways - why can we rhotate all slab sizes but not full node? Player position: ``` { y = 13.531000137329, z = -9819.103515625, x = -7060.265625 } ``` Player look: ``` { y = -0.77813351154327, z = -0.043704554438591, x = 0.62657654285431 } ``` Player information: ``` { minor = 8, state = "Active", min_rtt = 0.15199999511242, lang_code = "", protocol_version = 42, ip_version = 6, major = 5, avg_rtt = 0.16500000655651, min_jitter = 0, max_jitter = 2.6870000362396, avg_jitter = 0.00099998712539673, connection_uptime = 12596, serialization_version = 29, patch = 0, formspec_version = 7, version_string = "5.8.0", max_rtt = 2.8659999370575 } ``` Player meta: ``` { fields = { digged_nodes = "2788192", placed_nodes = "491402", died = "353", crafted = "221290", jointime = "1650064821", ["petz:lycanthropy"] = "0", partychat = "party", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", ["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "4.5", yl_commons_thankyou = "830", ["petz:werewolf_clan_idx"] = "1", hud_state = "on", punch_count = "526632", inflicted_damage = "9175360", ["ocean_build.last_warning"] = "1.65235e+09", ["ocean_build.ocean_built"] = "8", ["3d_armor_inventory"] = "return {\"petz:prince_crown\", \"shields:shield_rainbow\", \"petz:silk_dress_coat\", \"3d_armor:leggings_nether\", \"nether_mobs:dragon_boots\", \"\"}", ["signslib:pos"] = "(-7061,13,-9809)", xp = "2907721", xp_redo_hud_color = "0xFFC001", arenalib_infobox_arenaID = "0", yl_church = "return {[\"last_heal\"] = 1673944229, [\"last_death\"] = {[\"y\"] = -30878, [\"z\"] = 1361, [\"x\"] = 1877}, [\"last_death_portal\"] = 1707988941}", hotbar_size = "16", repellant = "0", ["petz:werewolf"] = "0", yl_commons_player_created = "1650064821", yl_commons_player_joined = "1709178543", ["hud_manager:spawnit:hud_enabled"] = "n", bitten = "0", ["petz:werewolf_vignette_id"] = "19", ["stamina:level"] = "20", played_time = "37750948" } } ``` Log identifier ``` [MOD] yl_report log identifier = WND831nHWio6zSI6IqUlfTHju7zKhfkg ``` Profiler save: ``` profile-20240229T071840.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 16h 56min 7s | max lag: 0.421s | clients (10/52): aeon, Bailiff, daydream, DezS4125, Hecate, jackofthebean000, JinnyC, Murmel, qBA, TimurHami ``` Teleport command: ``` /teleport xyz -7060 14 -9819 ``` Compass command: ``` /give_compass Construction WND831nHWio6zSI6IqUlfTHju7zKhfkg D2691E -7060 14 -9819 ```

AliasAlreadyTaken was assigned by yourland-report

2024-02-29 07:18:40 +00:00

AliasAlreadyTaken added the

1. kind/documentation

label 2024-02-29 14:03:14 +00:00

AliasAlreadyTaken commented

2024-02-29 14:04:54 +00:00

I believe wool blocks were never "rotatable", for no good reason. We could make them rotatable, but they're in default.

Wool can be cut in the saw, all of those can be rotated, so there's no real good reason not to make full wool blocks rotatable as well, so the tiling fits a rotated cut block

I believe wool blocks were never "rotatable", for no good reason. We could make them rotatable, but they're in default. Wool can be cut in the saw, all of those can be rotated, so there's no real good reason not to make full wool blocks rotatable as well, so the tiling fits a rotated cut block

👍 1

AliasAlreadyTaken added the

1. kind/enhancement

label 2024-02-29 14:05:50 +00:00

lumberJack commented

2024-03-02 14:25:03 +00:00

I can write up a patch for this. Are you looking to fork wool or override the item in a patch mod somewhere? I can make the PR if you point me where you want it, or whatever is preferred. Thanks!

flux referenced this issue from a commit

2024-03-07 23:23:04 +00:00

your-land/bugtracker#6377 allow rotating wool

flux commented

2024-03-07 23:24:04 +00:00

thanks for the offer, @lumberJack, though i've already got a system in place for adding rotation to various nodes so this just takes me a minute. if you're looking for other simple but useful things to do, check out the "good first issue" label

implemented here: 51456bec27

thanks for the offer, @lumberJack, though i've already got a system in place for adding rotation to various nodes so this just takes me a minute. if you're looking for other simple but useful things to do, check out the ["good first issue" label](https://gitea.your-land.de/your-land/bugtracker/issues?q=&type=all&sort=&state=open&labels=103&milestone=0&project=0&assignee=0&poster=0) implemented here: https://gitea.your-land.de/your-land/yl_commons/commit/51456bec2754e098dd336bd757072b7d50553795

👍 2

flux added the

4. step/ready to QA test

label 2024-03-07 23:25:37 +00:00

AliasAlreadyTaken added this to the 1.1.123 milestone 2024-03-09 00:27:44 +00:00

AliasAlreadyTaken commented

2024-03-10 07:17:20 +00:00

QA

The normal wool is now rotatable.

The only wool that is not is vanilla wool by petz, but since that one has a different style, I'd OK this issue regardless

QA The normal wool is now rotatable. The only wool that is not is vanilla wool by petz, but since that one has a different style, I'd OK this issue regardless

AliasAlreadyTaken added the

ugh/QA OK

label 2024-03-10 07:17:24 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2024-03-28 23:02:23 +00:00

AliasAlreadyTaken was unassigned by flux

2024-03-28 23:02:59 +00:00

flux commented

2024-03-28 23:03:04 +00:00