AspireMint reports: https://content.minetest.net/p ... #6352

New Issue

yourland-report · 2024-02-26T00:45:52Z

yourland-report commented

2024-02-26 00:45:52 +00:00

AspireMint reports a bug:

https://content.minetest.net/packages/Krunegan/confetti/

Player position:

{
	z = 1181,
	x = 2022,
	y = 16
}

Player look:

{
	z = 0.99821293354034,
	x = 0.025790935382247,
	y = -0.05390453338623
}

Player information:

{
	minor = 7,
	state = "Active",
	major = 5,
	max_rtt = 13.619000434875,
	min_rtt = 0.025000000372529,
	avg_rtt = 0.027000000700355,
	min_jitter = 0,
	max_jitter = 12.978000640869,
	avg_jitter = 0,
	connection_uptime = 18187,
	serialization_version = 29,
	patch = 0,
	version_string = "5.7.0",
	protocol_version = 42,
	ip_version = 6,
	formspec_version = 6,
	lang_code = ""
}

Player meta:

{
	fields = {
		["petz:lycanthropy"] = "0",
		digged_nodes = "2023886",
		yl_church = "return {[\"last_death_portal\"] = 1708715300, [\"last_heal\"] = 1708702962, [\"last_death\"] = {[\"y\"] = -164, [\"z\"] = 215, [\"x\"] = 2922}}",
		punch_count = "551042",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "11917842",
		["stamina:level"] = "20",
		["ocean_build.last_warning"] = "1.65674e+09",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		["stamina:poisoned"] = "no",
		hud_state = "on",
		["stamina:exhaustion"] = "24.5",
		yl_commons_thankyou = "288",
		placed_nodes = "395491",
		yl_commons_player_joined = "1708890209",
		partychat = "party",
		xp = "2116547",
		["petz:werewolf_clan_idx"] = "4",
		repellant = "0",
		jointime = "1619715757",
		bitten = "0",
		["petz:werewolf"] = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}",
		played_time = "6849645",
		yl_commons_player_created = "1619715757",
		["signslib:pos"] = "(-54,5,22529)",
		died = "383",
		crafted = "126674",
		["3d_armor_inventory"] = "return {\"shields:shield_nether 1 40\", \"3d_armor:boots_crystal 1 20\", \"3d_armor:leggings_nether 1 40\", \"3d_armor:chestplate_nether 1 40\", \"3d_armor:helmet_nether 1 20\", \"\"}"
	}
}

Log identifier


[MOD] yl_report log identifier = uOgXgGciAEa1xHw6OUvkJsSOAbnW7yqV

Profiler save:

profile-20240226T004552.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1d 5h 37min 1s | max lag: 0.879s | clients (21/52): AliasAlreadyTaken, Aliza, AspireMint, Azelf, Bailiff, betzi, Chache, DanteLives, daydream, Empempires, flux, Historia_reiss, jackofthebean000, JeCel, Jennison, LeetPeet, lumberJack, MineWorlds, poppyasdan, Service, tagtraum

Teleport command:

/teleport xyz 2022 16 1181

Compass command:

/give_compass Construction uOgXgGciAEa1xHw6OUvkJsSOAbnW7yqV D2691E 2022 16 1181

AspireMint reports a bug: > https://content.minetest.net/packages/Krunegan/confetti/ Player position: ``` { z = 1181, x = 2022, y = 16 } ``` Player look: ``` { z = 0.99821293354034, x = 0.025790935382247, y = -0.05390453338623 } ``` Player information: ``` { minor = 7, state = "Active", major = 5, max_rtt = 13.619000434875, min_rtt = 0.025000000372529, avg_rtt = 0.027000000700355, min_jitter = 0, max_jitter = 12.978000640869, avg_jitter = 0, connection_uptime = 18187, serialization_version = 29, patch = 0, version_string = "5.7.0", protocol_version = 42, ip_version = 6, formspec_version = 6, lang_code = "" } ``` Player meta: ``` { fields = { ["petz:lycanthropy"] = "0", digged_nodes = "2023886", yl_church = "return {[\"last_death_portal\"] = 1708715300, [\"last_heal\"] = 1708702962, [\"last_death\"] = {[\"y\"] = -164, [\"z\"] = 215, [\"x\"] = 2922}}", punch_count = "551042", arenalib_infobox_arenaID = "0", inflicted_damage = "11917842", ["stamina:level"] = "20", ["ocean_build.last_warning"] = "1.65674e+09", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", ["stamina:poisoned"] = "no", hud_state = "on", ["stamina:exhaustion"] = "24.5", yl_commons_thankyou = "288", placed_nodes = "395491", yl_commons_player_joined = "1708890209", partychat = "party", xp = "2116547", ["petz:werewolf_clan_idx"] = "4", repellant = "0", jointime = "1619715757", bitten = "0", ["petz:werewolf"] = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}", played_time = "6849645", yl_commons_player_created = "1619715757", ["signslib:pos"] = "(-54,5,22529)", died = "383", crafted = "126674", ["3d_armor_inventory"] = "return {\"shields:shield_nether 1 40\", \"3d_armor:boots_crystal 1 20\", \"3d_armor:leggings_nether 1 40\", \"3d_armor:chestplate_nether 1 40\", \"3d_armor:helmet_nether 1 20\", \"\"}" } } ``` Log identifier ``` [MOD] yl_report log identifier = uOgXgGciAEa1xHw6OUvkJsSOAbnW7yqV ``` Profiler save: ``` profile-20240226T004552.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1d 5h 37min 1s | max lag: 0.879s | clients (21/52): AliasAlreadyTaken, Aliza, AspireMint, Azelf, Bailiff, betzi, Chache, DanteLives, daydream, Empempires, flux, Historia_reiss, jackofthebean000, JeCel, Jennison, LeetPeet, lumberJack, MineWorlds, poppyasdan, Service, tagtraum ``` Teleport command: ``` /teleport xyz 2022 16 1181 ``` Compass command: ``` /give_compass Construction uOgXgGciAEa1xHw6OUvkJsSOAbnW7yqV D2691E 2022 16 1181 ```

👍 1

AliasAlreadyTaken was assigned by yourland-report

2024-02-26 00:45:52 +00:00

whosit commented

2024-02-26 01:14:09 +00:00

Adds 110 individual particles instead of using particle generator:
4fd16f2d41/init.lua (L65)
if updated to use generators, then could be nice...

Adds 110 individual particles instead of using particle generator: https://github.com/Krunegan/confetti/blob/4fd16f2d416f715b790ac73146c84339541018f3/init.lua#L65 if updated to use generators, then could be nice...

👍 1

AliasAlreadyTaken added the

1. kind/enhancement

label 2024-02-26 01:54:17 +00:00

flux commented

2024-02-26 04:42:45 +00:00

if updated to use generators, then could be nice...

the benefit would be using vastly fewer network packets, right?

> if updated to use generators, then could be nice... the benefit would be using vastly fewer network packets, right?

whosit commented

2024-02-26 06:52:03 +00:00

the benefit would be using vastly fewer network packets, right?

Yes :)
Just to have the numbers: it would send 110 separate packets, each 172 bytes, per one use... Now imagine people crafting loads of them and starting spamming like we do with fireworks. One add_particlespawner() call can use only 2 packets and 663 bytes to generate same amount of particles or many more...

Also, server has to do less work (in theory at least) - because it does distance checking, serialization, queuing for each call, etc...

> the benefit would be using vastly fewer network packets, right? Yes :) Just to have the numbers: it would send 110 separate packets, each 172 bytes, per one use... Now imagine people crafting loads of them and starting spamming like we do with fireworks. One `add_particlespawner()` call can use only 2 packets and 663 bytes to generate same amount of particles or many more... Also, server has to do less work (in theory at least) - because it does distance checking, serialization, queuing for each call, etc...

AliasAlreadyTaken commented

2024-02-26 10:16:58 +00:00

If this is an easy fix, let's do it and PR upstream :) I'll put the mod on the testserver.

whosit commented

2024-02-27 20:06:26 +00:00

My version is here: https://github.com/yl-whosit/confetti

also made a PR upstream: https://github.com/Krunegan/confetti/pull/2

My version is here: https://github.com/yl-whosit/confetti also made a PR upstream: https://github.com/Krunegan/confetti/pull/2

🎉 2

AliasAlreadyTaken added this to the 1.1.123 milestone 2024-02-27 21:21:08 +00:00

AliasAlreadyTaken commented

2024-02-29 15:23:55 +00:00

Since the mod maintainer appears not to be terribly active, let's add the mod, fix the issue in the yl_stable branch and remove the fix once upstreams pulls it.

AliasAlreadyTaken referenced this issue from a commit

2024-03-03 22:34:14 +00:00

your-land/bugtracker#6352 Add confetti

AliasAlreadyTaken added the

4. step/ready to QA test

ugh/QA OK

labels 2024-03-03 22:36:23 +00:00

whosit commented

2024-03-27 15:21:58 +00:00

Upstream PR got merged:
https://github.com/Krunegan/confetti/pull/2

Upstream PR got merged: https://github.com/Krunegan/confetti/pull/2

flux added