Chache reports: Regarding rotation, YL_livemap ... #6347
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#6347
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Chache reports a bug:
Player position:
Player look:
Player information:
Player meta:
Log identifier
Profiler save:
Status:
Teleport command:
Compass command:
Maps have
I guess that's just how they are?
Not sure what are the benefits though.
would have to set
paramtype2 = "facedir"
. is there a reason why it's currently "wallmounted"?Yes, there is a very good cause: Because this was pretty much my very first mod. Apparently wallmounted was the first value that worked approximately the way I wanted. That's how it became the chosen one(tm). Means: If we can change it to fix this issue without requiring a migration, let's do.
i think it would require a migration, which could be handled by a very simple run-once LBM. i'll test it out and see.
Making a mesh shouldn't be too hard though...
Aren't meshes the most expensive drawtype? Or does that depend on the mesh?
I have no idea, but nodeboxes also work:
i'm already working on this. i'm still banging my head on the logic to correctly orient the map when it's placed, though.
You mean, convert param2?
They seem to orient on placement ok with my definition (but always vertical)
And to convert rotations here's this:
https://github.com/minetest/minetest/blob/master/doc/lua_api.md#item-handling
the nodebox i'm using is
using this, i can get away with only specifying one texture (no need for dirt around the edges). the map appears to "float" above the wall a little bit, but that's what they do currently.
i'm also putting the map orthogonal to the "y axis", so that rotating it with the screwdriver works sanely.
I think having some material for the backing (maybe wood? cloth? paper? anything...) would look better than floating map...
I see... but I always expect weirdness from screwdriver and just use rhotator, which works fine here.
no-one has ever been able to convince me that the rhotator is a suitable replacement for the screwdriver. if you're standing in one place,or only some faces of the node are visible, there's just no way to achieve certain results.
i think i agree, but no-one has requested such a feature, and someone might complain, because people complain about every minor change...
They might have a legit usecase we haven't thought of, but We are making changes. your-land/bugtracker#3039
If you'll excuse the short off-topic:
Using only the rotating feature of the Rhotator it's not possible, but combining that with the "push closest edge" feature, all 24 combinations of a single node's position+orientation should be achievable even if there's only one face visible.
Does not work for nodes that don't have an edge you can push in some orientations. I don't think you can orient this thin map box with it's back to you (if only one face is accessible)
finally got around to finishing this:
4eb6fdc656
currently the maps do not have "side" textures as in whosit's implementation. if alias approves, i could add one.
i also haven't fully tested the conversion orientations, but it's working for the main map in haven.
Ready for QA? :D
yes
Maravillosa maps got flipped
/teleport xyz 39 4 22463
better hope a certain soko won't mind the maps being hung by a single nail on each piece
Sounds like QA:NOK?
yes i'm gonna have to recheck the LBM. ugh. that's tedious.
QA
PdS maps as well
that means the LBM wasn't even run....
testing locally, it works correctly in all directions:
and it looks fine on the test server to me currently, and has
param2=17
:possibly lag and the LBM just hadn't run yet?
I noticed those after spending lots of time there trying to figure out it's the tiny croc causing client stutter...
But server has been restarted since then, so I have no idea honestly.
PdS map is still broken though... but it has
param2=5
, so that means the LBM also hasn't run there yet either? but it's not running while i'm sitting there looking....visited a number of other cities, and the maps were broken in all of them.
maybe try removing
yl_livemapping:convert_to_facedir~24623515;
(or whatever number you get) from$worldpath/env_meta.txt
? i have no idea why the LBM might not be running.Maybe the LBM did run - twice and more? It cannot know the "correct" orientation, right?
it only modifies the param2 value if it's 0, 1, 2, 3, 4, or 5, and none of the resulting values are any of those, so it can be run repeatedly and still produce the same results. it's just luck that it worked out like that.
QA
No way. proverb of my grandfather: "Wenn mans richtig macht, dann funktionierts auch."
More or less: "If you do it right, it works."
live