Azelf reports: opening this aspen wood fence ... #6323

New Issue

yourland-report · 2024-02-21T00:16:11Z

yourland-report commented

2024-02-21 00:16:11 +00:00

Azelf reports a bug:

opening this aspen wood fence gate at the public mine gives the protection message (and doing enough times would eventually damage players)

Player position:

{
	x = 2167.8930664063,
	y = 14.5,
	z = 1292.2940673828
}

Player look:

{
	x = 0.0063619990833104,
	y = -0.17158521711826,
	z = -0.98514872789383
}

Player information:

{
	min_rtt = 0.17200000584126,
	avg_rtt = 0.17499999701977,
	min_jitter = 0,
	max_jitter = 2.7920000553131,
	avg_jitter = 0.0010000020265579,
	connection_uptime = 973,
	serialization_version = 29,
	patch = 0,
	lang_code = "",
	max_rtt = 2.9660000801086,
	protocol_version = 42,
	state = "Active",
	formspec_version = 7,
	version_string = "5.8.0",
	minor = 8,
	major = 5,
	ip_version = 6
}

Player meta:

{
	fields = {
		died = "124",
		["signslib:pos"] = "(6707,3,11032)",
		yl_church = "return {[\"last_death_portal\"] = 1708313463, [\"last_heal\"] = 1707543932, [\"last_death\"] = {[\"x\"] = -1046, [\"y\"] = 138, [\"z\"] = 4618}}",
		yl_commons_player_created = "1659363683",
		yl_commons_player_joined = "1708473616",
		repellant = "0",
		xp = "1272194",
		arenalib_infobox_arenaID = "0",
		crafted = "726505",
		inflicted_damage = "5457348",
		hud_state = "on",
		["3d_armor_inventory"] = "return {\"3d_armor:leggings_rainbow 1 18664\", \"nether_mobs:dragon_boots 1 580\", \"shields:shield_rainbow 1 18664\", \"3d_armor:helmet_rainbow 1 18664\", \"3d_armor:chestplate_rainbow 1 18664\", \"\"}",
		punch_count = "257497",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		placed_nodes = "407705",
		partychat = "party",
		jointime = "1659363683",
		bitten = "0",
		["ocean_build.last_warning"] = "1.67602e+09",
		["stamina:level"] = "18",
		["ocean_build.ocean_built"] = "11",
		yl_commons_thankyou = "105",
		["stamina:poisoned"] = "no",
		played_time = "6493389",
		digged_nodes = "930253",
		["stamina:exhaustion"] = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = hGZOFxCMHofeZ59lwiTmnOVdVFYIv0hR

Profiler save:

profile-20240221T001611.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 4d 2h 56min 29s | max lag: 0.644s | clients (16/52): AliasAlreadyTaken, Aliza, Azelf, Bailiff, crankyape, Crazylad, flux, Hecate, JinnyC, L-Dog, LadYeauty, MineWorlds, miron88, poppyasdan, Service, tres

Teleport command:

/teleport xyz 2168 15 1292

Compass command:

/give_compass Construction hGZOFxCMHofeZ59lwiTmnOVdVFYIv0hR D2691E 2168 15 1292

Azelf reports a bug: > opening this aspen wood fence gate at the public mine gives the protection message (and doing enough times would eventually damage players) Player position: ``` { x = 2167.8930664063, y = 14.5, z = 1292.2940673828 } ``` Player look: ``` { x = 0.0063619990833104, y = -0.17158521711826, z = -0.98514872789383 } ``` Player information: ``` { min_rtt = 0.17200000584126, avg_rtt = 0.17499999701977, min_jitter = 0, max_jitter = 2.7920000553131, avg_jitter = 0.0010000020265579, connection_uptime = 973, serialization_version = 29, patch = 0, lang_code = "", max_rtt = 2.9660000801086, protocol_version = 42, state = "Active", formspec_version = 7, version_string = "5.8.0", minor = 8, major = 5, ip_version = 6 } ``` Player meta: ``` { fields = { died = "124", ["signslib:pos"] = "(6707,3,11032)", yl_church = "return {[\"last_death_portal\"] = 1708313463, [\"last_heal\"] = 1707543932, [\"last_death\"] = {[\"x\"] = -1046, [\"y\"] = 138, [\"z\"] = 4618}}", yl_commons_player_created = "1659363683", yl_commons_player_joined = "1708473616", repellant = "0", xp = "1272194", arenalib_infobox_arenaID = "0", crafted = "726505", inflicted_damage = "5457348", hud_state = "on", ["3d_armor_inventory"] = "return {\"3d_armor:leggings_rainbow 1 18664\", \"nether_mobs:dragon_boots 1 580\", \"shields:shield_rainbow 1 18664\", \"3d_armor:helmet_rainbow 1 18664\", \"3d_armor:chestplate_rainbow 1 18664\", \"\"}", punch_count = "257497", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", placed_nodes = "407705", partychat = "party", jointime = "1659363683", bitten = "0", ["ocean_build.last_warning"] = "1.67602e+09", ["stamina:level"] = "18", ["ocean_build.ocean_built"] = "11", yl_commons_thankyou = "105", ["stamina:poisoned"] = "no", played_time = "6493389", digged_nodes = "930253", ["stamina:exhaustion"] = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = hGZOFxCMHofeZ59lwiTmnOVdVFYIv0hR ``` Profiler save: ``` profile-20240221T001611.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 4d 2h 56min 29s | max lag: 0.644s | clients (16/52): AliasAlreadyTaken, Aliza, Azelf, Bailiff, crankyape, Crazylad, flux, Hecate, JinnyC, L-Dog, LadYeauty, MineWorlds, miron88, poppyasdan, Service, tres ``` Teleport command: ``` /teleport xyz 2168 15 1292 ``` Compass command: ``` /give_compass Construction hGZOFxCMHofeZ59lwiTmnOVdVFYIv0hR D2691E 2168 15 1292 ```

AliasAlreadyTaken was assigned by yourland-report

2024-02-21 00:16:11 +00:00

flux added the

3. source/integration

1. kind/bug

labels 2024-02-21 05:12:27 +00:00

flux commented

2024-02-21 05:14:05 +00:00

i haven't confirmed this, but it'd be a bug if you can open the gate but still get pinged for a protection violation.

flux added the

4. step/needs confirmation

label 2024-02-21 05:14:14 +00:00

whosit commented

2024-02-23 10:32:38 +00:00

confirmed...

![image](/attachments/0abc69b4-e908-42b4-b5b3-96c8a4bb8cc6) confirmed...

image.png

157 KiB

whosit removed the

4. step/needs confirmation

label 2024-02-23 10:33:05 +00:00

flux commented

2024-02-23 20:14:57 +00:00

the protection violation seems to be in code introduced by the leads mod. need to report it upstream but i'm about to go out the door.

flux added the

3. source/mod upstream

label 2024-02-23 20:15:13 +00:00

flux commented

2024-02-23 23:56:12 +00:00

huh. it's apparently not just leads itself, something deeper...

huh. it's apparently *not* just leads itself, something deeper...

flux commented

2024-02-24 00:04:24 +00:00

on my local YL server:

on YL main:

as i can't reproduce this locally, i can't really debug what's going on here. what version of leads is installed on the server?

on my local YL server: ![image](/attachments/fa7e381b-0518-4c19-b4b5-1ab361d666d3) on YL main: ![image](/attachments/7c23a286-e1c4-4a88-9825-f73f446694bc) as i can't reproduce this locally, i can't really debug what's going on here. what version of leads is installed on the server?

image.png

32 KiB

image.png

33 KiB

flux added the

4. step/help wanted

label 2024-02-24 00:05:19 +00:00

whosit commented

2024-02-24 03:30:31 +00:00

I noticed that on test server I don't get protection violation when I open same gate.

Also, leads just do this:

local old_is_protected = minetest.is_protected;
function minetest.is_protected(pos, name)
    if leads.interaction_blockers[name] then
        return true;
    end;
    return old_is_protected(pos, name);
end;

and both on test and on main leads.interaction_blockers table is empty.

I noticed that on test server I don't get protection violation when I open same gate. Also, leads just do this: ```lua local old_is_protected = minetest.is_protected; function minetest.is_protected(pos, name) if leads.interaction_blockers[name] then return true; end; return old_is_protected(pos, name); end; ``` and both on test and on main `leads.interaction_blockers` table is empty.

flux commented

2024-02-24 04:18:46 +00:00

i should have mentioned, the debug data i was dumping was for the on_rightclick callback of the fence. i have no idea how that's getting set, leads doesn't do it on its own, and the implicated function isn't publicly accesible, at least w/ the current version of leads.

flux commented

2024-02-24 05:04:32 +00:00

minetest.is_protected

that function isn't immediately relevant. minetest.record_protection_violation is. i've been testing things by registering an alert with minetest.register_on_protection_violation, but the debugging data for the gate's on_rightclick behavior is what's super sus, but unexplainable. i feel like there's some cascading sequence of integration mechanics that's causing this, but i don't see where to start looking.

> `minetest.is_protected` that function isn't immediately relevant. `minetest.record_protection_violation` is. i've been testing things by registering an alert with `minetest.register_on_protection_violation`, but the debugging data for the gate's `on_rightclick` behavior is what's super sus, but unexplainable. i feel like there's some cascading sequence of integration mechanics that's causing this, but i don't see where to start looking.

whosit commented

2024-02-24 05:21:19 +00:00

Also it's weird that the gate still does get open...
And just right-clicking fences also pings you...

Also it's weird that the gate still does get open... And just right-clicking fences also pings you...

whosit commented

2024-02-24 05:52:07 +00:00

Ok, it's just this:
3fad55a571/api.lua (L238-L248)

which is called from here:
3fad55a571/internal.lua (L43)

how it should actually handle doors though?

Ok, it's just this: https://gitea.your-land.de/your-land/leads/src/commit/3fad55a57195e082128a2bc0754c32e1e67ffc71/api.lua#L238-L248 which is called from here: https://gitea.your-land.de/your-land/leads/src/commit/3fad55a57195e082128a2bc0754c32e1e67ffc71/internal.lua#L43 how it should actually handle doors though?

whosit commented

2024-02-24 06:06:53 +00:00

So, is_knottable() somehow got broken on main, but not on test?

![image](/attachments/c3454d1f-766d-47d7-bd6f-0ad127eb96f2) So, [is_knottable()](https://gitea.your-land.de/your-land/leads/src/commit/3fad55a57195e082128a2bc0754c32e1e67ffc71/api.lua#L169) somehow got broken on main, but not on test?

изображение.png

100 KiB

flux commented

2024-02-24 17:11:19 +00:00

@AliasAlreadyTaken what version of leads is installed on the server?

AliasAlreadyTaken commented

2024-02-24 17:21:49 +00:00

This one: 89322baf5c

Leads was switched out with new upstream, they finally decided to put it on git. 1.1.122 has the trashcan one, 1.1.123 (thus the testserver and every new checkout) will have the new upstream

This one: https://gitea.your-land.de/your-land-trashcan/leads/commit/89322baf5c6c6a564bdc7454b0f5dd31b6812deb Leads was switched out with new upstream, they finally decided to put it on git. 1.1.122 has the trashcan one, 1.1.123 (thus the testserver and every new checkout) will have the new upstream

flux commented

2024-02-24 17:31:33 +00:00

This one: 89322baf5c

Leads was switched out with new upstream, they finally decided to put it on git. 1.1.122 has the trashcan one, 1.1.123 (thus the testserver and every new checkout) will have the new upstream

alright, that makes sense, seems this will be fixed with 1.1.123 already then. marking as QA/OK

> This one: https://gitea.your-land.de/your-land-trashcan/leads/commit/89322baf5c6c6a564bdc7454b0f5dd31b6812deb > > Leads was switched out with new upstream, they finally decided to put it on git. 1.1.122 has the trashcan one, 1.1.123 (thus the testserver and every new checkout) will have the new upstream alright, that makes sense, seems this will be fixed with 1.1.123 already then. marking as QA/OK

flux added

4. step/ready to QA test

ugh/QA OK

and removed

4. step/help wanted

labels 2024-02-24 17:31:46 +00:00

AliasAlreadyTaken added this to the 1.1.123 milestone 2024-02-24 19:28:03 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2024-03-28 22:43:14 +00:00