Chache reports: Make right-clicking on (invisi ... #6319

New Issue

yourland-report · 2024-02-19T22:12:10Z

yourland-report commented

2024-02-19 22:12:10 +00:00

Chache reports a bug:

Make right-clicking on (invisible) item frames have priority over the behaviour of 1) node replacer, 2) rhotator and other various screwdrivers, and 3) the chisel, so that they can be placed inside item frames

Player position:

{
	x = 2926.8811035156,
	y = 15.5,
	z = -2747.3000488281
}

Player look:

{
	x = 0.98136115074158,
	y = -0.029666244983673,
	z = 0.1898687928915
}

Player information:

{
	major = 5,
	minor = 8,
	ip_version = 6,
	min_rtt = 0.029999999329448,
	avg_rtt = 0.16500000655651,
	lang_code = "es",
	max_jitter = 5.3790001869202,
	avg_jitter = 0.1330000013113,
	connection_uptime = 754,
	serialization_version = 29,
	patch = 0,
	max_rtt = 5.4140000343323,
	protocol_version = 42,
	state = "Active",
	formspec_version = 7,
	version_string = "5.8.0",
	min_jitter = 0
}

Player meta:

{
	fields = {
		died = "13",
		crafted = "281432",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 2, [\"z\"] = -2696, [\"x\"] = 2862}, [\"last_heal\"] = 1653594577, [\"last_death_portal\"] = 1682897352}",
		yl_commons_player_created = "1645471717",
		yl_commons_player_joined = "1708379992",
		arenalib_infobox_arenaID = "0",
		repellant = "0",
		xp = "1565323",
		xp_redo_hud_color = "0xFFFF00",
		["stamina:level"] = "14",
		punch_count = "53281",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 29920\", \"\", \"3d_armor:chestplate_crystal 1 29900\", \"shields:shield_rainbow 1 12008\", \"3d_armor:leggings_crystal 1 29900\", \"3d_armor:boots_crystal 1 30000\"}",
		hud_state = "on",
		partychat = "party",
		["stamina:exhaustion"] = "86.5",
		["signslib:pos"] = "(2927,13,-2745)",
		inflicted_damage = "1661018",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		jointime = "1645471717",
		bitten = "0",
		["ocean_build.last_warning"] = "1.65606e+09",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		yl_commons_thankyou = "457",
		["stamina:poisoned"] = "no",
		played_time = "13211866",
		digged_nodes = "1256510",
		placed_nodes = "634645"
	}
}

Log identifier


[MOD] yl_report log identifier = tFAFKY4x617IevkxPUf5jysk3F1KTIga

Profiler save:

profile-20240219T221210.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3d 21min 18s | max lag: 1.68s | clients (21/52): AliasAlreadyTaken, Aliza, Bailiff, betzi, Boot, Chache, crankyape, flux, ivpri, Justice, LadyPixels, LeetPeet, lumberJack, Lupercus, MagicStag, Marat1ch, MineWorlds, poppyasdan, Service, Sokomine, visibleObject2

Teleport command:

/teleport xyz 2927 16 -2747

Compass command:

/give_compass Construction tFAFKY4x617IevkxPUf5jysk3F1KTIga D2691E 2927 16 -2747

Chache reports a bug: > Make right-clicking on (invisible) item frames have priority over the behaviour of 1) node replacer, 2) rhotator and other various screwdrivers, and 3) the chisel, so that they can be placed inside item frames Player position: ``` { x = 2926.8811035156, y = 15.5, z = -2747.3000488281 } ``` Player look: ``` { x = 0.98136115074158, y = -0.029666244983673, z = 0.1898687928915 } ``` Player information: ``` { major = 5, minor = 8, ip_version = 6, min_rtt = 0.029999999329448, avg_rtt = 0.16500000655651, lang_code = "es", max_jitter = 5.3790001869202, avg_jitter = 0.1330000013113, connection_uptime = 754, serialization_version = 29, patch = 0, max_rtt = 5.4140000343323, protocol_version = 42, state = "Active", formspec_version = 7, version_string = "5.8.0", min_jitter = 0 } ``` Player meta: ``` { fields = { died = "13", crafted = "281432", yl_church = "return {[\"last_death\"] = {[\"y\"] = 2, [\"z\"] = -2696, [\"x\"] = 2862}, [\"last_heal\"] = 1653594577, [\"last_death_portal\"] = 1682897352}", yl_commons_player_created = "1645471717", yl_commons_player_joined = "1708379992", arenalib_infobox_arenaID = "0", repellant = "0", xp = "1565323", xp_redo_hud_color = "0xFFFF00", ["stamina:level"] = "14", punch_count = "53281", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 29920\", \"\", \"3d_armor:chestplate_crystal 1 29900\", \"shields:shield_rainbow 1 12008\", \"3d_armor:leggings_crystal 1 29900\", \"3d_armor:boots_crystal 1 30000\"}", hud_state = "on", partychat = "party", ["stamina:exhaustion"] = "86.5", ["signslib:pos"] = "(2927,13,-2745)", inflicted_damage = "1661018", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", jointime = "1645471717", bitten = "0", ["ocean_build.last_warning"] = "1.65606e+09", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", yl_commons_thankyou = "457", ["stamina:poisoned"] = "no", played_time = "13211866", digged_nodes = "1256510", placed_nodes = "634645" } } ``` Log identifier ``` [MOD] yl_report log identifier = tFAFKY4x617IevkxPUf5jysk3F1KTIga ``` Profiler save: ``` profile-20240219T221210.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3d 21min 18s | max lag: 1.68s | clients (21/52): AliasAlreadyTaken, Aliza, Bailiff, betzi, Boot, Chache, crankyape, flux, ivpri, Justice, LadyPixels, LeetPeet, lumberJack, Lupercus, MagicStag, Marat1ch, MineWorlds, poppyasdan, Service, Sokomine, visibleObject2 ``` Teleport command: ``` /teleport xyz 2927 16 -2747 ``` Compass command: ``` /give_compass Construction tFAFKY4x617IevkxPUf5jysk3F1KTIga D2691E 2927 16 -2747 ```

AliasAlreadyTaken was assigned by yourland-report

2024-02-19 22:12:10 +00:00

Chache commented

2024-02-19 23:53:53 +00:00

And the pedestal too.

flux added the

1. kind/enhancement

3. source/integration

labels 2024-02-20 00:24:00 +00:00

flux commented

2024-02-20 00:31:39 +00:00

the chisel and rhotator - certainly. for the replacer and screwdriver, that conflicts with the intentional use of the tools on those. we might be able to do it with a modifier key though.

flux referenced this issue from a commit

2024-02-20 00:59:31 +00:00

your-land/bugtracker#6319 allow putting some more tools in itemframes

flux commented

2024-02-20 01:01:27 +00:00

11429be05f

you can now add the chisel to the itemframe, and you can add the rhotators and the replacer by placing while holding AUX1 (i forget what that's bound to by default). the screwdriver already can be inserted while holding AUX1.

https://gitea.your-land.de/your-land/yl_commons/commit/11429be05fe850b1c86dc2eecbc28b9e9d9d3f87 you can now add the chisel to the itemframe, and you can add the rhotators and the replacer by placing while holding AUX1 (i forget what that's bound to by default). the screwdriver already can be inserted while holding AUX1.

👍 1

flux added the

4. step/ready to QA test

label 2024-02-20 01:01:36 +00:00

Chache commented

2024-02-20 10:09:35 +00:00

Aux1 is the key for running, "e" by default.

AliasAlreadyTaken added this to the 1.1.123 milestone 2024-02-20 14:23:00 +00:00

whosit added the

ugh/QA OK

label 2024-02-25 21:59:27 +00:00

whosit commented

2024-02-25 22:01:44 +00:00

also still works it seems X)

![image](/attachments/b34b87b7-131b-4e4d-8515-7fbc5790e90a) also still works it seems X)

image.png

17 KiB

whosit commented

2024-02-25 22:06:25 +00:00

Hmm.... actually, I can't copy itemframe's rotation with shift-right-click using rhotator:screwdriver_multi

Hmm.... actually, I can't copy itemframe's rotation with shift-right-click using `rhotator:screwdriver_multi`

whosit added

ugh/QA NOK

and removed

ugh/QA OK

labels 2024-02-25 22:07:30 +00:00

flux commented

2024-02-26 04:17:59 +00:00

Hmm.... actually, I can't copy itemframe's rotation with shift-right-click using rhotator:screwdriver_multi

vote to approve this change and deal with this conflict in a later issue.

> Hmm.... actually, I can't copy itemframe's rotation with shift-right-click using rhotator:screwdriver_multi vote to approve this change and deal with this conflict in a later issue.

whosit referenced this issue from a commit

2024-02-26 09:33:49 +00:00

your-land/bugtracker#6319 fixup rhotator_multi

whosit commented

2024-02-26 09:34:34 +00:00

1b31b755ec
looks like this was just a typo?
I locally it works now.

https://gitea.your-land.de/your-land/yl_commons/commit/1b31b755ec56e02da28438694537e4dd0fb75f9e looks like this was just a typo? I locally it works now.

👍 1

whosit added

ugh/QA OK

and removed

ugh/QA NOK

labels 2024-02-26 09:34:47 +00:00

flux commented

2024-03-02 22:57:21 +00:00

looks like this was just a typo?

i think it was intentional but i don't remember why.

> looks like this was just a typo? i think it was intentional but i don't remember why.

whosit commented

2024-03-03 06:10:30 +00:00

check_on_place_targets() could take modifier table arg that allows to run special code only when some of them are not pressed, like {'aux1'=true, 'sneak'=false}...

`check_on_place_targets()` could take modifier table arg that allows to run special code only when some of them are not pressed, like `{'aux1'=true, 'sneak'=false}`...

👍 1

flux commented

2024-03-08 00:13:19 +00:00

check_on_place_targets() could take modifier table arg that allows to run special code only when some of them are not pressed, like {'aux1'=true, 'sneak'=false}...

did that now: 0fd1306ec6

did you have a proposal for using that in this issue though?

> `check_on_place_targets()` could take modifier table arg that allows to run special code only when some of them are not pressed, like `{'aux1'=true, 'sneak'=false}`... did that now: https://gitea.your-land.de/your-land/yl_commons/commit/0fd1306ec6eb677d9e225e61c1b8f0a60fd68271 did you have a proposal for using that in this issue though?

whosit commented

2024-03-08 10:04:40 +00:00

did you have a proposal for using that in this issue though?

In relation to this issue: no... At least stuff seems to work.
I just thought initially that this kind of conflict was the problem...

> did you have a proposal for using that in this issue though? In relation to this issue: no... At least stuff seems to work. I just thought initially that this kind of conflict was the problem...

AliasAlreadyTaken was unassigned by flux

2024-03-28 22:38:49 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2024-03-28 22:38:55 +00:00

flux commented

2024-03-28 22:39:03 +00:00

live

flux closed this issue

2024-03-28 22:39:03 +00:00