JustShapesAndBeats reports: if you dont have ocean builder ... #6252

New Issue

yourland-report · 2024-02-06T20:00:35Z

yourland-report commented

2024-02-06 20:00:35 +00:00

JustShapesAndBeats reports a bug:

if you dont have ocean builder, placing a falling block while building above an ocean still places the block, making it duplicated

Player position:

{
	x = 12013.94921875,
	y = 1.5,
	z = 6673.9897460938
}

Player look:

{
	x = -0.59643071889877,
	y = -0.78897684812546,
	z = -0.14760062098503
}

Player information:

{
	state = "Active",
	ip_version = 6,
	avg_jitter = 0.0010000020265579,
	serialization_version = 29,
	patch = 0,
	avg_rtt = 0.12700000405312,
	min_rtt = 0.11599999666214,
	protocol_version = 42,
	max_jitter = 0.59900003671646,
	max_rtt = 0.73000001907349,
	lang_code = "",
	formspec_version = 6,
	minor = 7,
	major = 5,
	connection_uptime = 875,
	min_jitter = 0,
	version_string = "5.7.0"
}

Player meta:

{
	fields = {
		yl_commons_player_created = "1606696121",
		yl_commons_player_joined = "1707248785",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_mithril 1 4440\", \"3d_armor:leggings_mithril 1 10440\", \"shields:shield_diamond 1 28000\", \"3d_armor:boots_crystal 1 14100\", \"3d_armor:chestplate_mithril 1 10440\", \"\"}",
		inflicted_damage = "24654",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		hud_state = "on",
		placed_nodes = "12932",
		arenalib_infobox_arenaID = "0",
		["ocean_build.forbidden"] = "true",
		xp = "48222",
		punch_count = "1294",
		bitten = "0",
		["ocean_build.ocean_built"] = "12",
		played_time = "179320",
		repellant = "0",
		["stamina:level"] = "13",
		["stamina:exhaustion"] = "59.5",
		["stamina:poisoned"] = "no",
		yl_commons_thankyou = "5",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1966, [\"z\"] = 1164}}",
		["signslib:pos"] = "(11998,6,6619)",
		xp_redo_hud_color = "0xB373FB",
		digged_nodes = "49296",
		["ocean_build.last_warning"] = "1707249566",
		died = "4",
		crafted = "49647"
	}
}

Log identifier


[MOD] yl_report log identifier = Z33M5Ze78aTb9NmEqyaX3MocllRLXrlq

Profiler save:

profile-20240206T200035.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 23h 10min 59s | max lag: 0.788s | clients (26/52): AliasAlreadyTaken, Apocralypse, Bailiff, Benicio, betzi, Bishiro, Boot, canelle__crossing11, daydream, DragonWrangler1, flux, JustShapesAndBeats, leo6, Lucy1, LucyUnicorn_Queen, lumberJack, Marat1ch, Minetest13, Murmel, Noii, poppyasdan, Service, tagtraum, Wace4, whosit, Xiximon

Teleport command:

/teleport xyz 12014 2 6674

Compass command:

/give_compass Construction Z33M5Ze78aTb9NmEqyaX3MocllRLXrlq D2691E 12014 2 6674

JustShapesAndBeats reports a bug: > if you dont have ocean builder, placing a falling block while building above an ocean still places the block, making it duplicated Player position: ``` { x = 12013.94921875, y = 1.5, z = 6673.9897460938 } ``` Player look: ``` { x = -0.59643071889877, y = -0.78897684812546, z = -0.14760062098503 } ``` Player information: ``` { state = "Active", ip_version = 6, avg_jitter = 0.0010000020265579, serialization_version = 29, patch = 0, avg_rtt = 0.12700000405312, min_rtt = 0.11599999666214, protocol_version = 42, max_jitter = 0.59900003671646, max_rtt = 0.73000001907349, lang_code = "", formspec_version = 6, minor = 7, major = 5, connection_uptime = 875, min_jitter = 0, version_string = "5.7.0" } ``` Player meta: ``` { fields = { yl_commons_player_created = "1606696121", yl_commons_player_joined = "1707248785", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_mithril 1 4440\", \"3d_armor:leggings_mithril 1 10440\", \"shields:shield_diamond 1 28000\", \"3d_armor:boots_crystal 1 14100\", \"3d_armor:chestplate_mithril 1 10440\", \"\"}", inflicted_damage = "24654", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", hud_state = "on", placed_nodes = "12932", arenalib_infobox_arenaID = "0", ["ocean_build.forbidden"] = "true", xp = "48222", punch_count = "1294", bitten = "0", ["ocean_build.ocean_built"] = "12", played_time = "179320", repellant = "0", ["stamina:level"] = "13", ["stamina:exhaustion"] = "59.5", ["stamina:poisoned"] = "no", yl_commons_thankyou = "5", yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1966, [\"z\"] = 1164}}", ["signslib:pos"] = "(11998,6,6619)", xp_redo_hud_color = "0xB373FB", digged_nodes = "49296", ["ocean_build.last_warning"] = "1707249566", died = "4", crafted = "49647" } } ``` Log identifier ``` [MOD] yl_report log identifier = Z33M5Ze78aTb9NmEqyaX3MocllRLXrlq ``` Profiler save: ``` profile-20240206T200035.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 23h 10min 59s | max lag: 0.788s | clients (26/52): AliasAlreadyTaken, Apocralypse, Bailiff, Benicio, betzi, Bishiro, Boot, canelle__crossing11, daydream, DragonWrangler1, flux, JustShapesAndBeats, leo6, Lucy1, LucyUnicorn_Queen, lumberJack, Marat1ch, Minetest13, Murmel, Noii, poppyasdan, Service, tagtraum, Wace4, whosit, Xiximon ``` Teleport command: ``` /teleport xyz 12014 2 6674 ``` Compass command: ``` /give_compass Construction Z33M5Ze78aTb9NmEqyaX3MocllRLXrlq D2691E 12014 2 6674 ```

AliasAlreadyTaken was assigned by yourland-report

2024-02-06 20:00:35 +00:00

flux added the

1. kind/bug

3. source/integration

labels 2024-02-06 20:12:16 +00:00

flux commented

2024-02-06 20:13:33 +00:00

so this allows duplication of falling nodes? fortunately i think most of those are not valuable...

flux referenced this issue from a commit

2024-02-06 21:28:58 +00:00

your-land/bugtracker#6252 remove falling node entities that're placed by another on_placenode callback

flux commented

2024-02-06 21:29:22 +00:00

fixed, more or less: 49353c18eb

fixed, more or less: https://gitea.your-land.de/your-land/yl_commons/commit/49353c18ebe02dcc566365a491609abb5153fbf2

flux added the

4. step/ready to QA test

label 2024-02-06 21:29:33 +00:00

AliasAlreadyTaken added this to the 1.1.123 milestone 2024-02-07 16:09:37 +00:00

AliasAlreadyTaken added the

ugh/QA NOK

label 2024-02-16 08:30:34 +00:00

AliasAlreadyTaken commented

2024-02-16 08:31:53 +00:00

QA

I still can place default:sand on the ocean and they will fall. Funny sidenote: If I now place them normally, without having them fall, then they do get placed.

QA I still can place default:sand on the ocean and they will fall. Funny sidenote: If I now place them normally, without having them fall, then they do get placed.

flux commented

2024-02-17 17:24:23 +00:00

QA

I still can place default:sand on the ocean and they will fall. Funny sidenote: If I now place them normally, without having them fall, then they do get placed.

this happens when you're getting the "You may not build on the ocean!" message?

> QA > > > I still can place default:sand on the ocean and they will fall. Funny sidenote: If I now place them normally, without having them fall, then they do get placed. this happens when you're getting the "You may not build on the ocean!" message?

AliasAlreadyTaken commented

2024-03-07 18:24:56 +00:00

QA

"If I now place them normally, without having them fall, then they do get placed."

Yes, because that's how ocean_builder works. Lolol, I fooled myself again.

OK

QA "If I now place them normally, without having them fall, then they do get placed." Yes, because that's how ocean_builder works. Lolol, I fooled myself again. OK

AliasAlreadyTaken added

ugh/QA OK

and removed

ugh/QA NOK

labels 2024-03-07 18:25:03 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2024-03-28 22:08:16 +00:00

AliasAlreadyTaken was unassigned by flux

2024-03-28 22:08:19 +00:00