crash when loading a worldedit schematic with unknown nodes #6199

Open
opened 2024-02-03 19:20:44 +00:00 by flux · 4 comments
Member

from your-land/log_yl_main#114

2024-02-03 06:30:16: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'worldedit_commands' in callback on_chat_message(): Unknown node: ethereal:coral5_rooted
2024-02-03 06:30:16: ERROR[Main]: stack traceback:
2024-02-03 06:30:16: ERROR[Main]: 	[C]: in function '__index'
2024-02-03 06:30:16: ERROR[Main]: 	.../mt/5.7.0/Minetest_live/bin/../builtin/common/item_s.lua:229: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/common/item_s.lua:228>
2024-02-03 06:30:16: ERROR[Main]: 	[C]: in function 'add_node'
2024-02-03 06:30:16: ERROR[Main]: 	...n/../mods/Minetest-WorldEdit/worldedit/serialization.lua:257: in function 'deserialize'
2024-02-03 06:30:16: ERROR[Main]: 	...n/../mods/Minetest-WorldEdit/worldedit_commands/init.lua:1514: in function 'func'
2024-02-03 06:30:16: ERROR[Main]: 	...n/../mods/Minetest-WorldEdit/worldedit_commands/init.lua:57: in function 'func'
2024-02-03 06:30:16: ERROR[Main]: 	...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function 'func'
2024-02-03 06:30:16: ERROR[Main]: 	/home/mt/5.7.0/Minetest_live/bin/../builtin/game/chat.lua:79: in function </home/mt/5.7.0/Minetest_live/bin/../builtin/game/chat.lua:52>
2024-02-03 06:30:16: ERROR[Main]: 	.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432>

note that this is a known issue that we've mentioned before, but which doesn't have it's own issue #1981 (comment)

upstream issue: https://github.com/Uberi/Minetest-WorldEdit/issues/210

i'm not sure what a "rooted" variant of ethereal coral is. did it exist in the past and get removed? the word "rooted" isn't in the ethereal source code at all.

from https://gitea.your-land.de/your-land/log_yl_main/issues/114 ``` 2024-02-03 06:30:16: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'worldedit_commands' in callback on_chat_message(): Unknown node: ethereal:coral5_rooted 2024-02-03 06:30:16: ERROR[Main]: stack traceback: 2024-02-03 06:30:16: ERROR[Main]: [C]: in function '__index' 2024-02-03 06:30:16: ERROR[Main]: .../mt/5.7.0/Minetest_live/bin/../builtin/common/item_s.lua:229: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/common/item_s.lua:228> 2024-02-03 06:30:16: ERROR[Main]: [C]: in function 'add_node' 2024-02-03 06:30:16: ERROR[Main]: ...n/../mods/Minetest-WorldEdit/worldedit/serialization.lua:257: in function 'deserialize' 2024-02-03 06:30:16: ERROR[Main]: ...n/../mods/Minetest-WorldEdit/worldedit_commands/init.lua:1514: in function 'func' 2024-02-03 06:30:16: ERROR[Main]: ...n/../mods/Minetest-WorldEdit/worldedit_commands/init.lua:57: in function 'func' 2024-02-03 06:30:16: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function 'func' 2024-02-03 06:30:16: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/chat.lua:79: in function </home/mt/5.7.0/Minetest_live/bin/../builtin/game/chat.lua:52> 2024-02-03 06:30:16: ERROR[Main]: .../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432> ``` note that this is a known issue that we've mentioned before, but which doesn't have it's own issue https://gitea.your-land.de/your-land/bugtracker/issues/1981#issuecomment-23569 upstream issue: https://github.com/Uberi/Minetest-WorldEdit/issues/210 i'm not sure what a "rooted" variant of ethereal coral is. did it exist in the past and get removed? the word "rooted" isn't in the ethereal source code at all.
flux added the
1. kind/bug
3. source/mod upstream
labels 2024-02-03 19:20:44 +00:00
Member

Test has a newer version of ethereal than main, here is the rooted coral:
1e67afe05e/sealife.lua (L199)

(schematics were used to copy nodes from test to main)

Test has a newer version of ethereal than main, here is the rooted coral: https://gitea.your-land.de/your-land/ethereal/src/commit/1e67afe05e6911bc00150df95874fe69cf4a111b/sealife.lua#L199 (schematics were used to copy nodes from test to main)
Author
Member

Test has a newer version of ethereal than main, here is the rooted coral:
1e67afe05e/sealife.lua (L199)

(schematics were used to copy nodes from test to main)

oh, nice. plantlike rooted looks much better underwater.

> Test has a newer version of ethereal than main, here is the rooted coral: > https://gitea.your-land.de/your-land/ethereal/src/commit/1e67afe05e6911bc00150df95874fe69cf4a111b/sealife.lua#L199 > > (schematics were used to copy nodes from test to main) oh, nice. plantlike rooted looks much better underwater.

There's even a PR that fixes the issue, but wasn't pulled in yet: https://github.com/Uberi/Minetest-WorldEdit/pull/238

There are many other PRs and issues open

There's even a PR that fixes the issue, but wasn't pulled in yet: https://github.com/Uberi/Minetest-WorldEdit/pull/238 There are many other PRs and issues open
2024-02-15 10:42:46: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'digistuff' in callback on_chat_message(): Unknown node: yl_dice:dice
2024-02-15 10:42:46: ERROR[Main]: stack traceback:
2024-02-15 10:42:46: ERROR[Main]: 	[C]: in function '__index'
2024-02-15 10:42:46: ERROR[Main]: 	.../mt/5.7.0/Minetest_live/bin/../builtin/common/item_s.lua:229: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/common/item_s.lua:228>
2024-02-15 10:42:46: ERROR[Main]: 	[C]: in function 'add_node'
2024-02-15 10:42:46: ERROR[Main]: 	...n/../mods/Minetest-WorldEdit/worldedit/serialization.lua:257: in function 'deserialize'
2024-02-15 10:42:46: ERROR[Main]: 	...n/../mods/Minetest-WorldEdit/worldedit_commands/init.lua:1514: in function 'func'
2024-02-15 10:42:46: ERROR[Main]: 	...n/../mods/Minetest-WorldEdit/worldedit_commands/init.lua:57: in function 'func'
2024-02-15 10:42:46: ERROR[Main]: 	...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function 'func'
2024-02-15 10:42:46: ERROR[Main]: 	/home/mt/5.7.0/Minetest_live/bin/../builtin/game/chat.lua:79: in function </home/mt/5.7.0/Minetest_live/bin/../builtin/game/chat.lua:52>
2024-02-15 10:42:46: ERROR[Main]: 	.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432>
``` 2024-02-15 10:42:46: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'digistuff' in callback on_chat_message(): Unknown node: yl_dice:dice 2024-02-15 10:42:46: ERROR[Main]: stack traceback: 2024-02-15 10:42:46: ERROR[Main]: [C]: in function '__index' 2024-02-15 10:42:46: ERROR[Main]: .../mt/5.7.0/Minetest_live/bin/../builtin/common/item_s.lua:229: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/common/item_s.lua:228> 2024-02-15 10:42:46: ERROR[Main]: [C]: in function 'add_node' 2024-02-15 10:42:46: ERROR[Main]: ...n/../mods/Minetest-WorldEdit/worldedit/serialization.lua:257: in function 'deserialize' 2024-02-15 10:42:46: ERROR[Main]: ...n/../mods/Minetest-WorldEdit/worldedit_commands/init.lua:1514: in function 'func' 2024-02-15 10:42:46: ERROR[Main]: ...n/../mods/Minetest-WorldEdit/worldedit_commands/init.lua:57: in function 'func' 2024-02-15 10:42:46: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function 'func' 2024-02-15 10:42:46: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/chat.lua:79: in function </home/mt/5.7.0/Minetest_live/bin/../builtin/game/chat.lua:52> 2024-02-15 10:42:46: ERROR[Main]: .../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432> ```
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6199
No description provided.