flux reports: put 1 ethereal:glostone in a t ... #1981

Open
opened 2022-05-25 15:44:35 +00:00 by yourland-report · 17 comments

flux reports a bug:

put 1 ethereal:glostone in a table saw. remove 2 slabs. somehow, 6 "microblocks" remain, when there should be 0? remove another slab, which should cost 4 microblocks. now, none remain? what?

Player position:

{
	y = 47.5,
	x = 1281.8000488281,
	z = 613.81298828125
}

Player look:

{
	y = -0.62714773416519,
	x = -0.77839690446854,
	z = 0.027998292818666
}

Player information:

{
	min_rtt = 0.16599999368191,
	max_rtt = 2.2909998893738,
	connection_uptime = 1793,
	max_jitter = 2.1109998226166,
	minor = 6,
	major = 5,
	ip_version = 6,
	formspec_version = 5,
	patch = 0,
	protocol_version = 40,
	serialization_version = 29,
	lang_code = "",
	version_string = "5.6.0-dev-d208be276-dirty",
	avg_rtt = 0.17700000107288,
	state = "Active",
	avg_jitter = 0.011999994516373,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 7180\", \"3d_armor:leggings_nether 1 14360\", \"nether_mobs:dragon_shield 1 7180\", \"3d_armor:chestplate_nether 1 14360\", \"3d_armor:helmet_nether 1 7180\", \"\"}",
		["petz:werewolf_vignette_id"] = "5",
		yl_commons_thankyou = "116",
		jointime = "1615351173",
		yl_commons_player_joined = "1653491700",
		["stamina:exhaustion"] = "128",
		["signslib:pos"] = "(-45,6,22488)",
		digged_nodes = "1045774",
		["petz:werewolf_clan_idx"] = "1",
		punch_count = "78040",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		["stamina:poisoned"] = "no",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -3071, [\"x\"] = 2916, [\"z\"] = 1670}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1649877393}",
		placed_nodes = "345769",
		["stamina:level"] = "19",
		xp = "1246018",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "1254180",
		crafted = "35379",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:werewolf"] = "1",
		played_time = "16028245",
		died = "62",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1615351173"
	}
}

Log identifier


[MOD] yl_report log identifier = uri5Cify0h28RIRNol4PVcsKpOjAze7J

Profiler save:

profile-20220525T174434.json_prettyEE

Status:

# Server: version: 5.5.0-yl | game: Minetest Game | uptime: 4d 1h 1min 4s | max lag: 6.08s | clients: Lucien, nia, kape, Bla, flux, Alex1977, kein_ahnung, Dragoni_is_bored, shanish2, Giuseppe, CodeIter, phillip, Boot, Bishiro, pitman, JeCel, rohit, celestial, Bailiff, Service, AliasAlreadyTaken, tour

Teleport command:

/teleport xyz 1282 48 614

Compass command:

/give_compass Construction uri5Cify0h28RIRNol4PVcsKpOjAze7J D2691E 1282 48 614
flux reports a bug: > put 1 ethereal:glostone in a table saw. remove 2 slabs. somehow, 6 "microblocks" remain, when there should be 0? remove another slab, which should cost 4 microblocks. now, none remain? what? Player position: ``` { y = 47.5, x = 1281.8000488281, z = 613.81298828125 } ``` Player look: ``` { y = -0.62714773416519, x = -0.77839690446854, z = 0.027998292818666 } ``` Player information: ``` { min_rtt = 0.16599999368191, max_rtt = 2.2909998893738, connection_uptime = 1793, max_jitter = 2.1109998226166, minor = 6, major = 5, ip_version = 6, formspec_version = 5, patch = 0, protocol_version = 40, serialization_version = 29, lang_code = "", version_string = "5.6.0-dev-d208be276-dirty", avg_rtt = 0.17700000107288, state = "Active", avg_jitter = 0.011999994516373, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 7180\", \"3d_armor:leggings_nether 1 14360\", \"nether_mobs:dragon_shield 1 7180\", \"3d_armor:chestplate_nether 1 14360\", \"3d_armor:helmet_nether 1 7180\", \"\"}", ["petz:werewolf_vignette_id"] = "5", yl_commons_thankyou = "116", jointime = "1615351173", yl_commons_player_joined = "1653491700", ["stamina:exhaustion"] = "128", ["signslib:pos"] = "(-45,6,22488)", digged_nodes = "1045774", ["petz:werewolf_clan_idx"] = "1", punch_count = "78040", bitten = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", ["stamina:poisoned"] = "no", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = -3071, [\"x\"] = 2916, [\"z\"] = 1670}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1649877393}", placed_nodes = "345769", ["stamina:level"] = "19", xp = "1246018", arenalib_infobox_arenaID = "0", inflicted_damage = "1254180", crafted = "35379", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:werewolf"] = "1", played_time = "16028245", died = "62", hud_state = "on", repellant = "0", yl_commons_player_created = "1615351173" } } ``` Log identifier ``` [MOD] yl_report log identifier = uri5Cify0h28RIRNol4PVcsKpOjAze7J ``` Profiler save: ``` profile-20220525T174434.json_prettyEE ``` Status: ``` # Server: version: 5.5.0-yl | game: Minetest Game | uptime: 4d 1h 1min 4s | max lag: 6.08s | clients: Lucien, nia, kape, Bla, flux, Alex1977, kein_ahnung, Dragoni_is_bored, shanish2, Giuseppe, CodeIter, phillip, Boot, Bishiro, pitman, JeCel, rohit, celestial, Bailiff, Service, AliasAlreadyTaken, tour ``` Teleport command: ``` /teleport xyz 1282 48 614 ``` Compass command: ``` /give_compass Construction uri5Cify0h28RIRNol4PVcsKpOjAze7J D2691E 1282 48 614 ```
AliasAlreadyTaken was assigned by yourland-report 2022-05-25 15:44:35 +00:00
AliasAlreadyTaken added the
1. kind/bug
label 2022-05-25 16:06:55 +00:00
Member
Upstream issue: https://github.com/minetest-mods/moreblocks/issues/190
flux added the
3. source/mod upstream
label 2022-05-25 17:22:12 +00:00
AliasAlreadyTaken was unassigned by flux 2022-05-25 17:51:03 +00:00
flux self-assigned this 2022-05-25 17:51:03 +00:00
Member

I'll try to get this fixed soon, but I'm feeling terrible today, so probably not today.

I'll try to get this fixed soon, but I'm feeling terrible today, so probably not today.
Member

This might devolve into me rewriting moreblocks so as to fix all the major longstanding bugs.

This might devolve into me rewriting moreblocks so as to fix all the major longstanding bugs.
flux added the
2. prio/critical
label 2022-05-26 04:53:30 +00:00
Member

As this can currently be used to create infinite quantities of glostone with minimal effort, I'm upgrading the priority of this.

As this can currently be used to create infinite quantities of glostone with minimal effort, I'm upgrading the priority of this.
Member

I've started a massive cleanup (or partial rewrite) of moreblocks.

https://github.com/fluxionary/minetest-moreblocks/tree/bugfixes

I've started a massive cleanup (or partial rewrite) of `moreblocks`. https://github.com/fluxionary/minetest-moreblocks/tree/bugfixes
flux added the
4. step/at work
label 2022-06-12 01:16:11 +00:00
flux added
4. step/ready to QA test
and removed
4. step/at work
labels 2022-07-02 21:54:17 +00:00
flux added this to the flux's TODO list project 2022-07-02 21:54:20 +00:00
Member
will be fixed when https://github.com/minetest-mods/moreblocks/pull/191 is live

From the discussion in this PR, it seems a lot of people are interested, but it still needs a bit of testing?

I noticed I can't import stuff from the testserver to the main due to some nodenames being different?

From the discussion in this PR, it seems a lot of people are interested, but it still needs a bit of testing? I noticed I can't import stuff from the testserver to the main due to some nodenames being different?
Member

From the discussion in this PR, it seems a lot of people are interested, but it still needs a bit of testing?

i'm not sure anyone wants more testing, but the people in charge of accepting the PR are being very cautions because this is a huge change. i don't blame them. not all the interested parties may be aware of the plans for the mod. perhaps i should try to speed things up by talking about it again in #minetest on IRC.

I noticed I can't import stuff from the testserver to the main due to some nodenames being different?

correct, it changes (normalizes) the names of many of the shaped sub-blocks. if you want, i could try to write a "revert" mod if someone decides they want to go back to the old way. i'm not sure it's possible to that "perfectly" though.

> From the discussion in this PR, it seems a lot of people are interested, but it still needs a bit of testing? i'm not sure anyone wants more testing, but the people in charge of accepting the PR are being *very cautions* because this is a huge change. i don't blame them. not all the interested parties may be aware of the plans for the mod. perhaps i should try to speed things up by talking about it again in #minetest on IRC. > I noticed I can't import stuff from the testserver to the main due to some nodenames being different? correct, it changes (normalizes) the names of many of the shaped sub-blocks. if you want, i could try to write a "revert" mod if someone decides they want to go back to the old way. i'm not sure it's possible to that "perfectly" though.

It's very good they are cautious, the last thing we need is a fragmentation over blocks where the old ones don't stack with the new ones and cause a mess during import of old schematics. Currently, importing old schematics to a moreblocks rewrite server will crash it. This can hardly be blamed on the moreblocks rewrite though, its more a WE problem: Looks like during import they do not consider aliases.

What's the reasoning behind this normalization? To get out of the moreblocks namespace?

It's very good they are cautious, the last thing we need is a fragmentation over blocks where the old ones don't stack with the new ones and cause a mess during import of old schematics. Currently, importing old schematics to a moreblocks rewrite server will crash it. This can hardly be blamed on the moreblocks rewrite though, its more a WE problem: Looks like during import they do not consider aliases. What's the reasoning behind this normalization? To get out of the moreblocks namespace?
Member

What's the reasoning behind this normalization? To get out of the moreblocks namespace?

ah, there's multiple normalizations.

yes, the "mod" portion of the itemstring of microblocks is now always the same as the original node. this is because most of the time, the mod should be the one responsible for registering the microblocks, not moreblocks. it also helps to avoid conflicting nodes, which was something we had on blocky survival - there were two nodes called "stone_tile", both of which could be used with the saw, but only one set of microblocks.

i also changed the naming format of some of the shapes so that "panel", "slab", and "micro" names matched. e.g there was a "panel_%s_quarter" which became "panel_%s_4"

> What's the reasoning behind this normalization? To get out of the moreblocks namespace? ah, there's multiple normalizations. yes, the "mod" portion of the itemstring of microblocks is now always the same as the original node. this is because most of the time, the mod should be the one responsible for registering the microblocks, not moreblocks. it also helps to avoid conflicting nodes, which was something we had on blocky survival - there were two nodes called "stone_tile", both of which could be used with the saw, but only one set of microblocks. i also changed the naming format of some of the shapes so that "panel", "slab", and "micro" names matched. e.g there was a "panel_%s_quarter" which became "panel_%s_4"
Member

Currently, importing old schematics to a moreblocks rewrite server will crash it.

hm. that's not good. which "import" method are you talking about? //save and //load, or //mtschemcreate and //mtschemplace?

> Currently, importing old schematics to a moreblocks rewrite server will crash it. hm. that's not good. which "import" method are you talking about? `//save` and `//load`, or `//mtschemcreate` and `//mtschemplace`?
Member

@AliasAlreadyTaken i tried on a local test world. 1 of every variant of a gold block, and chests containing all the variants, and a circular saw w/ some stuff in it.

//load worked flawlessly. //mtschemplace worked as i expected (it doesn't handle node metadata including inventories). neither caused a crash.

@AliasAlreadyTaken i tried on a local test world. 1 of every variant of a gold block, and chests containing all the variants, and a circular saw w/ some stuff in it. `//load` worked flawlessly. `//mtschemplace` worked as i expected (it doesn't handle node metadata including inventories). neither caused a crash.

A building was created on the testserver with the new moreblocks enabled. This was saved as a WE schematic via //save and then imported to the main with //load. That crashed the server.

A building was created on the testserver with the new moreblocks enabled. This was saved as a WE schematic via `//save` and then imported to the main with `//load`. That crashed the server.
Member

ah, so the problem was going backwards. i'm curious why that crashed things, but it absolutely shouldn't work properly.

ah, so the problem was going *backwards*. i'm curious why that crashed things, but it absolutely shouldn't work properly.
Member

A building was created on the testserver with the new moreblocks enabled. This was saved as a WE schematic via //save and then imported to the main with //load. That crashed the server.

i created an issue upstream on worldedit: https://github.com/Uberi/Minetest-WorldEdit/issues/210

> A building was created on the testserver with the new moreblocks enabled. This was saved as a WE schematic via `//save` and then imported to the main with `//load`. That crashed the server. i created an issue upstream on worldedit: https://github.com/Uberi/Minetest-WorldEdit/issues/210
flux added
4. step/blocked
and removed
4. step/ready to QA test
labels 2022-10-25 23:51:47 +00:00
flux added
4. step/ready to QA test
and removed
4. step/blocked
labels 2023-02-20 01:38:38 +00:00
flux added this to the 1.1.118 milestone 2023-02-20 01:38:43 +00:00
AliasAlreadyTaken modified the milestone from 1.1.118 to 1.1.119 2023-04-14 06:55:16 +00:00
AliasAlreadyTaken modified the milestone from 1.1.119 to 1.1.120 2023-05-09 12:46:26 +00:00
AliasAlreadyTaken removed this from the 1.1.120 milestone 2023-08-28 14:00:51 +00:00
AliasAlreadyTaken added this to the moreblocks milestone 2023-12-06 16:54:16 +00:00

Restest moving "old" moreblocks schematics to "new" moreblocks before moreblocks milestone!

Restest moving "old" moreblocks schematics to "new" moreblocks before moreblocks milestone!
Member

Restest moving "old" moreblocks schematics to "new" moreblocks before moreblocks milestone!

is there anything you need me to do?

> Restest moving "old" moreblocks schematics to "new" moreblocks before moreblocks milestone! is there anything you need me to do?
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#1981
No description provided.