rheo reports: when the crafting bench has st ... #6146

New Issue

yourland-report · 2024-01-30T21:58:12Z

yourland-report commented

2024-01-30 21:58:12 +00:00

rheo reports a bug:

when the crafting bench has stacks w/ multiple items in the recipe grid, some of those items are moved to the output and not used in the recipe

Player position:

{
	x = -437.82797241211,
	y = 52.5,
	z = 21495.55859375
}

Player look:

{
	x = -0.65758472681046,
	y = -0.42467349767685,
	z = -0.62228184938431
}

Player information:

{
	protocol_version = 42,
	minor = 9,
	lang_code = "",
	min_rtt = 0.16799999773502,
	avg_rtt = 0.21400000154972,
	min_jitter = 0,
	max_jitter = 6.0269999504089,
	avg_jitter = 0.11299999058247,
	connection_uptime = 2845,
	serialization_version = 29,
	patch = 0,
	major = 5,
	version_string = "5.9.0-dev-454dd8576-dirty",
	state = "Active",
	ip_version = 6,
	max_rtt = 6.2290000915527,
	formspec_version = 7
}

Player meta:

{
	fields = {
		["petz:werewolf_vignette_id"] = "16",
		hotbar_size = "16",
		yl_commons_thankyou = "74",
		arenalib_infobox_arenaID = "0",
		jointime = "1644205752",
		["hud_manager:spawnit:hud_enabled"] = "y",
		["ocean_build.last_warning"] = "1.66814e+09",
		["ocean_build.ocean_built"] = "6",
		punch_count = "1279",
		hud_state = "off",
		inflicted_damage = "283762",
		["petz:werewolf"] = "0",
		["petz:lycanthropy"] = "0",
		["signslib:pos"] = "(20048,20012,19963)",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}",
		digged_nodes = "20437",
		played_time = "7829539",
		yl_commons_player_created = "1644205752",
		placed_nodes = "21068",
		died = "2",
		crafted = "2229",
		["stamina:poisoned"] = "no",
		["petz:old_override_table"] = "return {[\"sneak\"] = true, [\"speed\"] = 2, [\"new_move\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false}",
		["stamina:level"] = "0",
		xp = "0",
		["stamina:exhaustion"] = "110.5",
		bitten = "0",
		["3d_armor_inventory"] = "return {\"3d_armor:boots_quickrun\", \"\", \"\", \"\", \"\", \"\"}",
		["petz:werewolf_clan_idx"] = "2",
		yl_commons_player_joined = "1706649065",
		repellant = "0",
		["ethereal:fly_timer"] = "-99",
		partychat = "party",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}"
	}
}

Log identifier


[MOD] yl_report log identifier = qiOYGigI7XbTqxu1GJW7pSAqiM8yXZSl

Profiler save:

profile-20240130T215812.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 13d 10h 58min 44s | max lag: 1.24s | clients (25/52): _ble_, AliasAlreadyTaken, AspireMint, BLuOXide, Boot, crankyape, daydream, DragonWrangler1, flux, jackofthebean000, jim15, johanlegend, Kadax, kanAU, Keya, Marat1ch, Noii, OLIVER2017, poppyasdan, prowler, pups, rheo, Service, tagtraum, Xiximon

Teleport command:

/teleport xyz -438 53 21496

Compass command:

/give_compass Construction qiOYGigI7XbTqxu1GJW7pSAqiM8yXZSl D2691E -438 53 21496

rheo reports a bug: > when the crafting bench has stacks w/ multiple items in the recipe grid, some of those items are moved to the output and not used in the recipe Player position: ``` { x = -437.82797241211, y = 52.5, z = 21495.55859375 } ``` Player look: ``` { x = -0.65758472681046, y = -0.42467349767685, z = -0.62228184938431 } ``` Player information: ``` { protocol_version = 42, minor = 9, lang_code = "", min_rtt = 0.16799999773502, avg_rtt = 0.21400000154972, min_jitter = 0, max_jitter = 6.0269999504089, avg_jitter = 0.11299999058247, connection_uptime = 2845, serialization_version = 29, patch = 0, major = 5, version_string = "5.9.0-dev-454dd8576-dirty", state = "Active", ip_version = 6, max_rtt = 6.2290000915527, formspec_version = 7 } ``` Player meta: ``` { fields = { ["petz:werewolf_vignette_id"] = "16", hotbar_size = "16", yl_commons_thankyou = "74", arenalib_infobox_arenaID = "0", jointime = "1644205752", ["hud_manager:spawnit:hud_enabled"] = "y", ["ocean_build.last_warning"] = "1.66814e+09", ["ocean_build.ocean_built"] = "6", punch_count = "1279", hud_state = "off", inflicted_damage = "283762", ["petz:werewolf"] = "0", ["petz:lycanthropy"] = "0", ["signslib:pos"] = "(20048,20012,19963)", yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}", digged_nodes = "20437", played_time = "7829539", yl_commons_player_created = "1644205752", placed_nodes = "21068", died = "2", crafted = "2229", ["stamina:poisoned"] = "no", ["petz:old_override_table"] = "return {[\"sneak\"] = true, [\"speed\"] = 2, [\"new_move\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false}", ["stamina:level"] = "0", xp = "0", ["stamina:exhaustion"] = "110.5", bitten = "0", ["3d_armor_inventory"] = "return {\"3d_armor:boots_quickrun\", \"\", \"\", \"\", \"\", \"\"}", ["petz:werewolf_clan_idx"] = "2", yl_commons_player_joined = "1706649065", repellant = "0", ["ethereal:fly_timer"] = "-99", partychat = "party", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}" } } ``` Log identifier ``` [MOD] yl_report log identifier = qiOYGigI7XbTqxu1GJW7pSAqiM8yXZSl ``` Profiler save: ``` profile-20240130T215812.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 13d 10h 58min 44s | max lag: 1.24s | clients (25/52): _ble_, AliasAlreadyTaken, AspireMint, BLuOXide, Boot, crankyape, daydream, DragonWrangler1, flux, jackofthebean000, jim15, johanlegend, Kadax, kanAU, Keya, Marat1ch, Noii, OLIVER2017, poppyasdan, prowler, pups, rheo, Service, tagtraum, Xiximon ``` Teleport command: ``` /teleport xyz -438 53 21496 ``` Compass command: ``` /give_compass Construction qiOYGigI7XbTqxu1GJW7pSAqiM8yXZSl D2691E -438 53 21496 ```

AliasAlreadyTaken was assigned by yourland-report

2024-01-30 21:58:12 +00:00

flux added the

1. kind/bug

3. source/mod upstream

labels 2024-01-30 21:59:00 +00:00

flux commented

2024-01-30 21:59:48 +00:00

note how there's 2 cobble in the first stack, and cobble is then ending up in the output. material doesn't seem to be lost or created ex-nihilo.

credit to AspireMint for discovering this

![image](/attachments/d2f8aab0-8515-4db3-a101-42d602c875ba) note how there's 2 cobble in the first stack, and cobble is then ending up in the output. material doesn't seem to be lost or created ex-nihilo. credit to AspireMint for discovering this

image.png

37 KiB

flux commented

2024-01-30 22:09:30 +00:00

nevermind, you can dupe materials:

after putting 15 diamonds into the ingredients inventory:

nevermind, you can dupe materials: after putting 15 diamonds into the ingredients inventory: ![image](/attachments/707618f5-9195-4738-a255-da8ae22decfe)

image.png

16 KiB

flux added the

2. prio/critical

label 2024-01-30 22:09:39 +00:00

flux commented

2024-01-30 22:12:27 +00:00

put 90 rainbow into the ingredients side. result: free rainbow block

put 90 rainbow into the ingredients side. result: free rainbow block ![image](/attachments/083b035e-773b-4d01-86ef-0081ca0a10de)

image.png

19 KiB

flux added this to the flux's TODO list project 2024-01-30 22:13:14 +00:00

flux self-assigned this 2024-01-30 22:13:21 +00:00

flux added the

4. step/at work

label 2024-01-30 22:13:30 +00:00

flux commented

2024-01-31 00:02:43 +00:00

upstream issue https://github.com/minetest-mods/crafting_bench/issues/14

AliasAlreadyTaken added this to the 1.1.123 milestone 2024-01-31 04:01:14 +00:00

AliasAlreadyTaken commented

2024-01-31 04:07:13 +00:00

The insertion and taking is logged, the crafting is not.

So we do have a chance to catch dupers, but we should also add logging to the crafting process.

The autocrafter does it right

The insertion and taking is logged, the crafting is not. So we do have a chance to catch dupers, but we should also add logging to the crafting process. The autocrafter does it right

flux commented

2024-01-31 19:30:30 +00:00

i'm tempted to just hard-fork the crafting_bench. upstream has rejected my attempts to fix them mod twice before. my version already fixes this issue.

flux commented

2024-01-31 19:44:02 +00:00

The insertion and taking is logged, the crafting is not.

according to the code it just says "player moves stuff in workbench @ (x,y,z)" without saying what was moved.

> The insertion and taking is logged, the crafting is not. according to the code it just says "player moves stuff in workbench @ (x,y,z)" without saying what was moved.

Jammy commented

2024-01-31 23:00:44 +00:00

A possible temp solution would be to only allow one item to be placed in each grid.

flux commented

2024-01-31 23:59:48 +00:00

i did a hard fork instead of trying to deal with minetest-mods again. https://github.com/fluxionary/minetest-crafting_bench

flux added

4. step/ready to QA test

and removed

4. step/at work

labels 2024-02-01 00:00:11 +00:00

AliasAlreadyTaken commented

2024-02-01 05:48:09 +00:00

The hard fork is now on the testserver.

Jammy commented

2024-02-01 08:03:28 +00:00

My advice is to limit some of the bugs like this to admin-only until it is fixed. This prevents abusing.

👀 2

rewired_X commented

2024-02-02 00:22:53 +00:00

After testing:
I can't stack things in the recipe slots anymore, however now the workbench works closer to an autocrafter (as in, anything I put in recipe, it behaves as if it were in an autocrafter, putting it in doesn't actually make you place the item, but removing it just makes it vanish. that behavior.)

After testing: I can't stack things in the recipe slots anymore, however now the workbench works closer to an autocrafter (as in, anything I put in recipe, it behaves as if it were in an autocrafter, putting it in doesn't actually make you place the item, but removing it just makes it vanish. that behavior.)

flux commented

2024-02-02 05:13:00 +00:00

anything I put in recipe, it behaves as if it were in an autocrafter, putting it in doesn't actually make you place the item, but removing it just makes it vanish. that behavior.)

that's intentional. also, physical items that were previously put into the workbench's crafting grid will be refunded. my reasoning is that the previous behavior is nonsensical. the crafting grid in an autocrafter should be a schema and not an inventory.

> anything I put in recipe, it behaves as if it were in an autocrafter, putting it in doesn't actually make you place the item, but removing it just makes it vanish. that behavior.) that's intentional. also, physical items that were previously put into the workbench's crafting grid will be refunded. my reasoning is that the previous behavior is nonsensical. the crafting grid in an autocrafter should be a schema and not an inventory.

Jammy commented

2024-02-02 08:34:30 +00:00

Is this on main server now?