DragonWrangler1 reports: when I type /protect_this I ge ... #6004

New Issue

yourland-report · 2024-01-18T02:57:34Z

yourland-report commented

2024-01-18 02:57:34 +00:00

DragonWrangler1 reports a bug:

when I type /protect_this I get a message in chat saying "Area is too big." InfiniteMacroCosmos has the same problem

Player position:

{
	x = 30446.19921875,
	y = 14.5,
	z = -152.88499450684
}

Player look:

{
	x = -0.26756688952446,
	y = 0.26707017421722,
	z = -0.9257869720459
}

Player information:

{
	protocol_version = 42,
	ip_version = 6,
	avg_rtt = 0.23800000548363,
	min_jitter = 0,
	max_jitter = 1.9559999704361,
	minor = 9,
	connection_uptime = 3186,
	serialization_version = 29,
	patch = 0,
	lang_code = "",
	major = 5,
	version_string = "5.9.0-dev",
	state = "Active",
	formspec_version = 7,
	min_rtt = 0.14399999380112,
	max_rtt = 2.1040000915527,
	avg_jitter = 0.091000005602837
}

Player meta:

{
	fields = {
		["stamina:exhaustion"] = "115",
		hotbar_size = "32",
		yl_commons_thankyou = "308",
		["petz:werewolf_vignette_id"] = "5",
		xp_redo_hud_color = "0xa66000",
		arenalib_infobox_arenaID = "0",
		jointime = "1668874705",
		bitten = "0",
		["ocean_build.last_warning"] = "1692193690",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		punch_count = "140711",
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 17820\", \"3d_armor:chestplate_crystal 1 17820\", \"shields:shield_rainbow 1 7128\", \"3d_armor:helmet_nether 1 17820\", \"3d_armor:leggings_crystal 1 17820\", \"\"}",
		inflicted_damage = "2516126",
		["petz:werewolf"] = "0",
		["petz:lycanthropy"] = "0",
		yl_church = "return {[\"last_death_portal\"] = 1705528648, [\"last_heal\"] = 1696697785, [\"last_death\"] = {[\"x\"] = 29889, [\"y\"] = -5, [\"z\"] = -259}}",
		played_time = "5749020",
		yl_commons_player_created = "1668874705",
		yl_commons_player_joined = "1705543474",
		died = "1328",
		crafted = "192824",
		["petz:old_override_table"] = "return {[\"sneak_glitch\"] = false, [\"new_move\"] = true, [\"speed\"] = 2, [\"gravity\"] = 1, [\"jump\"] = 1.5, [\"sneak\"] = true}",
		hud_state = "on",
		xp = "507408",
		digged_nodes = "1133978",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		["petz:werewolf_clan_idx"] = "2",
		["signslib:pos"] = "(5465,69,-3320)",
		placed_nodes = "290025",
		["stamina:level"] = "5",
		repellant = "0",
		["stamina:poisoned"] = "no"
	}
}

Log identifier


[MOD] yl_report log identifier = YfvPK79JFF9ZyTqpr9F3yqQLMR7VL5D7

Profiler save:

profile-20240118T025734.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 9h 53min 59s | max lag: 0.514s | clients (17/52): Aliza, Bailiff, Brabenec, Calamity_Jones, daydream, DragonWrangler1, flux, Giuseppe, InfiniteMacroCosmos, JinnyC, ModTron, Penelopee, poppyasdan, RedStoner, rheo, Sofia28, taonza12

Teleport command:

/teleport xyz 30446 15 -153

Compass command:

/give_compass Construction YfvPK79JFF9ZyTqpr9F3yqQLMR7VL5D7 D2691E 30446 15 -153

DragonWrangler1 reports a bug: > when I type /protect_this I get a message in chat saying "Area is too big." InfiniteMacroCosmos has the same problem Player position: ``` { x = 30446.19921875, y = 14.5, z = -152.88499450684 } ``` Player look: ``` { x = -0.26756688952446, y = 0.26707017421722, z = -0.9257869720459 } ``` Player information: ``` { protocol_version = 42, ip_version = 6, avg_rtt = 0.23800000548363, min_jitter = 0, max_jitter = 1.9559999704361, minor = 9, connection_uptime = 3186, serialization_version = 29, patch = 0, lang_code = "", major = 5, version_string = "5.9.0-dev", state = "Active", formspec_version = 7, min_rtt = 0.14399999380112, max_rtt = 2.1040000915527, avg_jitter = 0.091000005602837 } ``` Player meta: ``` { fields = { ["stamina:exhaustion"] = "115", hotbar_size = "32", yl_commons_thankyou = "308", ["petz:werewolf_vignette_id"] = "5", xp_redo_hud_color = "0xa66000", arenalib_infobox_arenaID = "0", jointime = "1668874705", bitten = "0", ["ocean_build.last_warning"] = "1692193690", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", punch_count = "140711", ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 17820\", \"3d_armor:chestplate_crystal 1 17820\", \"shields:shield_rainbow 1 7128\", \"3d_armor:helmet_nether 1 17820\", \"3d_armor:leggings_crystal 1 17820\", \"\"}", inflicted_damage = "2516126", ["petz:werewolf"] = "0", ["petz:lycanthropy"] = "0", yl_church = "return {[\"last_death_portal\"] = 1705528648, [\"last_heal\"] = 1696697785, [\"last_death\"] = {[\"x\"] = 29889, [\"y\"] = -5, [\"z\"] = -259}}", played_time = "5749020", yl_commons_player_created = "1668874705", yl_commons_player_joined = "1705543474", died = "1328", crafted = "192824", ["petz:old_override_table"] = "return {[\"sneak_glitch\"] = false, [\"new_move\"] = true, [\"speed\"] = 2, [\"gravity\"] = 1, [\"jump\"] = 1.5, [\"sneak\"] = true}", hud_state = "on", xp = "507408", digged_nodes = "1133978", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", ["petz:werewolf_clan_idx"] = "2", ["signslib:pos"] = "(5465,69,-3320)", placed_nodes = "290025", ["stamina:level"] = "5", repellant = "0", ["stamina:poisoned"] = "no" } } ``` Log identifier ``` [MOD] yl_report log identifier = YfvPK79JFF9ZyTqpr9F3yqQLMR7VL5D7 ``` Profiler save: ``` profile-20240118T025734.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 9h 53min 59s | max lag: 0.514s | clients (17/52): Aliza, Bailiff, Brabenec, Calamity_Jones, daydream, DragonWrangler1, flux, Giuseppe, InfiniteMacroCosmos, JinnyC, ModTron, Penelopee, poppyasdan, RedStoner, rheo, Sofia28, taonza12 ``` Teleport command: ``` /teleport xyz 30446 15 -153 ``` Compass command: ``` /give_compass Construction YfvPK79JFF9ZyTqpr9F3yqQLMR7VL5D7 D2691E 30446 15 -153 ```

AliasAlreadyTaken was assigned by yourland-report

2024-01-18 02:57:34 +00:00

flux added the

1. kind/bug

2. prio/critical

labels 2024-01-18 04:11:59 +00:00

flux commented

2024-01-18 04:13:27 +00:00

this seems important, please poke me until this is fixed, or i negate that command.

whosit commented

2024-01-20 04:56:30 +00:00

#5129 (comment)
this seems to be related?

https://gitea.your-land.de/your-land/bugtracker/issues/5129#issuecomment-71355 this seems to be related?

AzelfYL referenced this issue

2024-01-20 09:45:10 +00:00

daydream reports: jukeri was trying to /protect_ ... #6021

~~whosit referenced this issue 2024-01-20 11:24:22 +00:00~~

daydream reports: jukeri was trying to /protect_ ... #6021

AliasAlreadyTaken commented

2024-01-20 16:03:30 +00:00

Cause was that I changed

areas.self_protection_max_size = 64, 128, 64
=> 
areas.self_protection_max_size = 65, 129, 65

due to your-land/bugtracker#5129

There is some wrong calculation at work

Cause was that I changed ``` areas.self_protection_max_size = 64, 128, 64 => areas.self_protection_max_size = 65, 129, 65 ``` due to your-land/bugtracker#5129 There is some wrong calculation at work

uhhh commented

2024-02-04 01:51:14 +00:00

is there a way to fix it???? uhhh

AliasAlreadyTaken commented

2024-02-04 17:45:29 +00:00

For the records, that's how we can fix it from a running server:

//lua areas.config.self_protection_max_size={x=64,y=128,z=64}

For the records, that's how we can fix it from a running server: `//lua areas.config.self_protection_max_size={x=64,y=128,z=64}`

flux commented

2024-02-04 19:28:28 +00:00

there's two off-by-one bugs here.

one is in upstream areas - it's not accounting for the fact that the intervals include both endpoints, and so lets players protect areas that are one node too wide.

the other is in yl_areas_addon math - it creates an area that's 1 node too wide if the max size of the dimension is even, but two nodes too wide if it's odd.

there's two off-by-one bugs here. one is in upstream areas - it's not accounting for the fact that the intervals include both endpoints, and so lets players protect areas that are one node too wide. the other is in yl_areas_addon math - it creates an area that's 1 node too wide if the max size of the dimension is even, but two nodes too wide if it's odd.

flux referenced this issue from a commit

2024-02-04 19:48:36 +00:00

your-land/bugtracker#6004 fix bounds when doing /protect_this

flux commented

2024-02-04 19:48:53 +00:00

upstream PR: https://github.com/minetest-mods/areas/pull/70

yl_areas_addon fix: 301061e19c

upstream PR: https://github.com/minetest-mods/areas/pull/70 yl_areas_addon fix: https://gitea.your-land.de/your-land/yl_areas_addon/commit/301061e19cd7faa6c91c5de5e26f622a7ff61c11

flux added the

4. step/ready to QA test

4. step/blocked

labels 2024-02-04 19:49:16 +00:00

flux commented

2024-02-04 19:51:11 +00:00

note: the fix to yl_areas_addon will resolve the problem, we don't actually need to wait for the areas fix to be accepted. we should also keep the max area size at (65, 129, 65) after this, because many such areas already exist.

👍 1

flux commented

2024-02-04 19:52:26 +00:00

noting that the problem originated with #5129

AzelfYL commented

2024-02-14 12:51:34 +00:00

Fixed? Dragonwrangler and myself don't have any more issues on main server

whosit commented

2024-02-14 15:15:42 +00:00

Fixed? Dragonwrangler and myself don't have any more issues on main server

It's fixed on the main by just running a command and won't be kept after a restart. A assume this is still open to make sure it's properly works after server restart too.

> Fixed? Dragonwrangler and myself don't have any more issues on main server It's fixed on the main by just running a command and won't be kept after a restart. A assume this is still open to make sure it's properly works after server restart too.

flux commented

2024-02-14 19:27:26 +00:00

the upstream PR got merged

AliasAlreadyTaken added this to the 1.1.123 milestone 2024-02-14 19:29:48 +00:00

AliasAlreadyTaken commented

2024-02-17 05:58:28 +00:00

QA

Works :)

QA Works :)

AliasAlreadyTaken added the

ugh/QA OK

label 2024-02-17 05:58:33 +00:00