your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

My specific portal causing lag when reset #5980

New Issue
Open
opened 2024-01-14 12:20:18 +00:00 by freg · 10 comments
freg commented 2024-01-14 12:20:18 +00:00
Copy Link

the portal at 17402, 26, -16370 has a chance to cause giant lag when reset

[resetting a portal = breaking the portal in the nether, then re-activating the overworld portal]

We couldn't reproduce this issue in the test server

the portal at 17402, 26, -16370 *has a chance* to cause giant lag when reset [resetting a portal = breaking the portal in the nether, then re-activating the overworld portal] We couldn't reproduce this issue in the test server
Boot commented 2024-01-14 12:38:04 +00:00
Member
Copy Link

Yes, you expected that yourself and announce a lag spike of 100 seconds in the chat. Then you just go through with it without regard for the other players and deliberately risk the crash of the server. If you are not sure what you are doing but know about the risk, then you don't just go through with it, but discuss it with the administration before.

Yes, you expected that yourself and announce a lag spike of 100 seconds in the chat. Then you just go through with it without regard for the other players and deliberately risk the crash of the server. If you are not sure what you are doing but know about the risk, then you don't just go through with it, but discuss it with the administration before.
👍 2
AliasAlreadyTaken added the
1. kind/bug
4. step/help wanted
3. source/unknown
 labels 2024-01-14 13:19:06 +00:00
whosit commented 2024-01-14 14:19:14 +00:00
Member
Copy Link

We couldn't reproduce

I think that exact portal was not tested? Or did you try again?

Backtrace: #5978
Some effects? #5979

Server freezing for a while happened before, and after this fix that problem seemed to disappear (Alias found this commit, but I could not find original issues about that):
155641499e
But, freezes didn't happen for 3 years, after this fix. And before fix it was happening pretty often, even Haven portal was permanently disabled for a while to prevent freezes...
So either freg is very unlucky with his spot, or this time it's caused by some other recent change.

> We couldn't reproduce I think that exact portal was not tested? Or did you try again? Backtrace: https://gitea.your-land.de/your-land/bugtracker/issues/5978 Some effects? https://gitea.your-land.de/your-land/bugtracker/issues/5979 Server freezing for a while happened before, and after this fix that problem seemed to disappear (Alias found this commit, but I could not find original issues about that): https://gitea.your-land.de/your-land/nether/commit/155641499e5cc833bf54f229dba0cc93858c1887 But, freezes didn't happen for 3 years, after this fix. And before fix it was happening pretty often, even Haven portal was permanently disabled for a while to prevent freezes... So either freg is very unlucky with his spot, or this time it's caused by some other recent change.
whosit commented 2024-01-14 14:32:33 +00:00
Member
Copy Link

17402, 26, -16370
I don't see nether portals at this pos on the test server, so looks like there were no attempts to repro this at exact same spot as on main.

`17402, 26, -16370` I don't see nether portals at this pos on the test server, so looks like there were no attempts to repro this at exact same spot as on main.
AliasAlreadyTaken commented 2024-01-14 14:55:58 +00:00
Owner
Copy Link

I'm taking a backup of main and will restore to testserver as soon as it's available, then we can hopefully reproduce the issue. If not, it may have to do with lag from other sources

I'm taking a backup of main and will restore to testserver as soon as it's available, then we can hopefully reproduce the issue. If not, it may have to do with lag from other sources
whosit commented 2024-01-14 15:15:28 +00:00
Member
Copy Link

I'm willing to bet it's portals - because of how many times it happened, and each time portal was reset.
I'm just saying it feels that something recent caused the portal problem to reappear.

I'm willing to bet it's portals - because of how many times it happened, and each time portal was reset. I'm just saying it feels that something recent caused the portal problem to reappear.
whosit commented 2024-01-14 15:40:09 +00:00
Member
Copy Link

I've placed fresh portal in same exact position on the test server and could trigger freezes up to 130 seconds pretty reliably by just entering portal, destroying the exit one, placing some blocks to mark the spot and teleporting back using /h to entrance portal to re-ignite it . Just repeat this until it starts freezing.

I've placed fresh portal in same exact position on the test server and could trigger freezes up to 130 seconds pretty reliably by just entering portal, destroying the exit one, placing some blocks to mark the spot and teleporting back using `/h` to entrance portal to re-ignite it . Just repeat this until it starts freezing.
freg commented 2024-01-14 16:14:30 +00:00
Author
Copy Link

Yes, you expected that yourself and announce a lag spike of 100 seconds in the chat. Then you just go through with it without regard for the other players and deliberately risk the crash of the server. If you are not sure what you are doing but know about the risk, then you don't just go through with it, but discuss it with the administration before.

The latest time i did this i actually asked
https://discord.com/channels/634941856719044629/710035074497642587/1196062498814709812
https://discord.com/channels/634941856719044629/710035074497642587/1196062781850533899

Someone said i could and nobody else said anything negative
https://discord.com/channels/634941856719044629/710035074497642587/1196063289440997528

But in my previous attempts i haven't asked, and i apologize for that

> Yes, you expected that yourself and announce a lag spike of 100 seconds in the chat. Then you just go through with it without regard for the other players and deliberately risk the crash of the server. If you are not sure what you are doing but know about the risk, then you don't just go through with it, but discuss it with the administration before. The latest time i did this i actually asked https://discord.com/channels/634941856719044629/710035074497642587/1196062498814709812 https://discord.com/channels/634941856719044629/710035074497642587/1196062781850533899 Someone said i could and nobody else said anything negative https://discord.com/channels/634941856719044629/710035074497642587/1196063289440997528 But in my previous attempts i haven't asked, and i apologize for that
freg commented 2024-01-14 16:14:50 +00:00
Author
Copy Link

17402, 26, -16370
I don't see nether portals at this pos on the test server, so looks like there were no attempts to repro this at exact same spot as on main.

we should've probably tried that too

> `17402, 26, -16370` > I don't see nether portals at this pos on the test server, so looks like there were no attempts to repro this at exact same spot as on main. we should've probably tried that too
whosit commented 2024-01-14 17:15:25 +00:00
Member
Copy Link

We have tried that spot, and after some number of attempts, freeze time started increasing. Last record was 1111 seconds, current one is still frozen as I'm writing this.
So don't do it on main - freezes will only get worse.

UPD: this freeze was for 1250 seconds...

Another guess is that it may be "retry next random spot" algorithm (if it's really how portals work) - the more there are broken portals, the longer the search will take.

We have tried that spot, and after some number of attempts, freeze time started increasing. Last record was 1111 seconds, current one is still frozen as I'm writing this. So don't do it on main - freezes will only get worse. UPD: this freeze was for 1250 seconds... Another guess is that it may be "retry next random spot" algorithm (if it's really how portals work) - the more there are broken portals, the longer the search will take.
rewired_X commented 2024-01-14 17:31:23 +00:00
Copy Link

maybe broken portals could be deleted somehow?

maybe broken portals could be deleted somehow?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5980
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?