your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

3d_armor/3d_armor/api.lua:723: attempt to index local 'inv' (a nil value) #5978

New Issue
Open
opened 2024-01-14 12:11:26 +00:00 by AliasAlreadyTaken · 4 comments
AliasAlreadyTaken commented 2024-01-14 12:11:26 +00:00
Owner
Copy Link
2024-01-14 12:10:27: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'petz' in callback environment_Step(): ....7.0/Minetest_live/bin/../mods/3d_armor/3d_armor/api.lua:723: attempt to index local 'inv' (a nil value)
2024-01-14 12:10:27: ERROR[Main]: stack traceback:
2024-01-14 12:10:27: ERROR[Main]: 	....7.0/Minetest_live/bin/../mods/3d_armor/3d_armor/api.lua:723: in function 'func'
2024-01-14 12:10:27: ERROR[Main]: 	...e/mt/5.7.0/Minetest_live/bin/../builtin/common/after.lua:27: in function <...e/mt/5.7.0/Minetest_live/bin/../builtin/common/after.lua:11>
2024-01-14 12:10:27: ERROR[Main]: 	.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432>
``` 2024-01-14 12:10:27: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'petz' in callback environment_Step(): ....7.0/Minetest_live/bin/../mods/3d_armor/3d_armor/api.lua:723: attempt to index local 'inv' (a nil value) 2024-01-14 12:10:27: ERROR[Main]: stack traceback: 2024-01-14 12:10:27: ERROR[Main]: ....7.0/Minetest_live/bin/../mods/3d_armor/3d_armor/api.lua:723: in function 'func' 2024-01-14 12:10:27: ERROR[Main]: ...e/mt/5.7.0/Minetest_live/bin/../builtin/common/after.lua:27: in function <...e/mt/5.7.0/Minetest_live/bin/../builtin/common/after.lua:11> 2024-01-14 12:10:27: ERROR[Main]: .../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432> ```
AliasAlreadyTaken added the
1. kind/bug
 label 2024-01-14 13:05:44 +00:00
AliasAlreadyTaken added the
2. prio/critical
 label 2024-01-14 13:18:32 +00:00
whosit commented 2024-01-14 13:58:50 +00:00
Member
Copy Link

ServerError: AsyncErr: Lua:
Alias says server was restarted manually.

`ServerError: AsyncErr: Lua:` Alias says server was restarted manually.
flux added the
4. step/ready to QA test
 label 2024-01-21 22:54:53 +00:00
flux commented 2024-01-21 22:59:35 +00:00
Member
Copy Link

whoops, forgot to note that i reported this upstream. it should be fixed now https://github.com/minetest-mods/3d_armor/issues/132

how to test:

local player_name = "Boris" -- or whoever
local player = minetest.get_player_by_name(player_name)
local armor = ItemStack("3d_armor:helmet_wood")
armor:equip(player, armor)
armor:unequip(player, armor)
minetest.disconnect_player(player_name)
whoops, forgot to note that i reported this upstream. it should be fixed now https://github.com/minetest-mods/3d_armor/issues/132 how to test: ```lua local player_name = "Boris" -- or whoever local player = minetest.get_player_by_name(player_name) local armor = ItemStack("3d_armor:helmet_wood") armor:equip(player, armor) armor:unequip(player, armor) minetest.disconnect_player(player_name) ```
AliasAlreadyTaken added this to the 1.1.123 milestone 2024-02-26 12:37:55 +00:00
AliasAlreadyTaken added the
ugh/QA main
 label 2024-02-26 12:37:59 +00:00
AliasAlreadyTaken commented 2024-02-26 12:56:45 +00:00
Author
Owner
Copy Link

QA

Testing via to avoid global armor and local armor conflict

local player_name = "Boris" -- or whoever
local player = minetest.get_player_by_name(player_name)
local item = ItemStack("3d_armor:helmet_wood")
armor:equip(player, item)
armor:unequip(player, item)
minetest.disconnect_player(player_name)

At the end I get disconnected, but upon next login, I wear the helmet: OK

Running this in snippets results in a crash, but it appears only somewhat related to this issue: your-land/bugtracker#6358

QA Testing via to avoid global `armor` and local `armor` conflict ``` local player_name = "Boris" -- or whoever local player = minetest.get_player_by_name(player_name) local item = ItemStack("3d_armor:helmet_wood") armor:equip(player, item) armor:unequip(player, item) minetest.disconnect_player(player_name) ``` At the end I get disconnected, but upon next login, I wear the helmet: OK Running this in snippets results in a crash, but it appears only somewhat related to this issue: your-land/bugtracker#6358
flux commented 2024-03-29 22:38:37 +00:00
Member
Copy Link

the upstream fix isn't actually valid - it doesn't check whether the player is still connected.

the upstream fix isn't actually valid - it doesn't check whether the player is still connected.
👍 1
flux added
3. source/mod upstream
 and removed
4. step/ready to QA test
ugh/QA main
 labels 2024-03-29 22:38:59 +00:00
flux removed this from the 1.1.123 milestone 2024-03-29 22:39:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5978
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?