your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

minetest-spawnit/manage_ao_blocks.lua:140: attempt to index a nil value #5862

New Issue
Closed
opened 2023-12-29 11:49:26 +00:00 by AliasAlreadyTaken · 6 comments
AliasAlreadyTaken commented 2023-12-29 11:49:26 +00:00
Owner
Copy Link
2023-12-29 07:37:23: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'spawnit' in callback environment_Step(): ...t_live/bin/../mods/minetest-spawnit/manage_ao_blocks.lua:140: attempt to index a nil value
2023-12-29 07:37:23: ERROR[Main]: stack traceback:
2023-12-29 07:37:23: ERROR[Main]: 	...t_live/bin/../mods/minetest-spawnit/manage_ao_blocks.lua:140: in function 'is_moving_too_fast'
2023-12-29 07:37:23: ERROR[Main]: 	...t_live/bin/../mods/minetest-spawnit/manage_ao_blocks.lua:163: in function 'get_ao_block_hpos_set'
2023-12-29 07:37:23: ERROR[Main]: 	...t_live/bin/../mods/minetest-spawnit/manage_ao_blocks.lua:250: in function 'update_visibility'
2023-12-29 07:37:23: ERROR[Main]: 	...t_live/bin/../mods/minetest-spawnit/manage_ao_blocks.lua:344: in function 'func'
2023-12-29 07:37:23: ERROR[Main]: 	..._live/bin/../mods/minetest-futil/minetest/globalstep.lua:78: in function 'func'
2023-12-29 07:37:23: ERROR[Main]: 	...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:101>
2023-12-29 07:37:23: ERROR[Main]: 	.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432>
``` 2023-12-29 07:37:23: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'spawnit' in callback environment_Step(): ...t_live/bin/../mods/minetest-spawnit/manage_ao_blocks.lua:140: attempt to index a nil value 2023-12-29 07:37:23: ERROR[Main]: stack traceback: 2023-12-29 07:37:23: ERROR[Main]: ...t_live/bin/../mods/minetest-spawnit/manage_ao_blocks.lua:140: in function 'is_moving_too_fast' 2023-12-29 07:37:23: ERROR[Main]: ...t_live/bin/../mods/minetest-spawnit/manage_ao_blocks.lua:163: in function 'get_ao_block_hpos_set' 2023-12-29 07:37:23: ERROR[Main]: ...t_live/bin/../mods/minetest-spawnit/manage_ao_blocks.lua:250: in function 'update_visibility' 2023-12-29 07:37:23: ERROR[Main]: ...t_live/bin/../mods/minetest-spawnit/manage_ao_blocks.lua:344: in function 'func' 2023-12-29 07:37:23: ERROR[Main]: ..._live/bin/../mods/minetest-futil/minetest/globalstep.lua:78: in function 'func' 2023-12-29 07:37:23: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:101> 2023-12-29 07:37:23: ERROR[Main]: .../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432> ```
AliasAlreadyTaken added the
1. kind/bug
2. prio/critical
 labels 2023-12-29 11:49:35 +00:00
AzelfYL commented 2023-12-29 13:53:15 +00:00
Copy Link

I assume this was what crashed the server previously?

I assume this was what crashed the server previously?
👍 1
flux added this to the flux's TODO list project 2023-12-29 18:24:15 +00:00
flux self-assigned this 2023-12-29 18:24:20 +00:00
flux added the
4. step/at work
 label 2023-12-29 18:24:27 +00:00
flux commented 2023-12-29 18:34:09 +00:00
Member
Copy Link

apparently minetest.get_connected_players() can return disconnected players? or at least players without velocity? anyway, added some checks to make sure nothing crashes:

b4a3f9caef

apparently `minetest.get_connected_players()` can return disconnected players? or at least players without velocity? anyway, added some checks to make sure nothing crashes: https://github.com/fluxionary/minetest-spawnit/commit/b4a3f9caef1ad241c746e689cc8b13f3f53d0c47
flux added
4. step/ready to QA test
 and removed
4. step/at work
 labels 2023-12-29 18:34:21 +00:00
AliasAlreadyTaken commented 2023-12-29 21:10:52 +00:00
Author
Owner
Copy Link

apparently minetest.get_connected_players() can return disconnected players?

If that's the case, then minetest.get_connected_players() will crash in many many other occasions as well, because hardly anyone checks for existence when one gets a list of player objects this way

> apparently `minetest.get_connected_players()` can return disconnected players? If that's the case, then `minetest.get_connected_players()` will crash in many many other occasions as well, because hardly anyone checks for existence when one gets a list of player objects this way
AliasAlreadyTaken added this to the 1.1.123 milestone 2023-12-29 21:11:03 +00:00
AliasAlreadyTaken commented 2024-01-28 13:14:27 +00:00
Author
Owner
Copy Link

QA

Could that have been a pipeworks fake player again?

I can't reproduce the issue, we'll have to wait for it to happen again.

QA Could that have been a pipeworks fake player again? I can't reproduce the issue, we'll have to wait for it to happen again.
AliasAlreadyTaken added the
ugh/QA main
 label 2024-01-28 13:14:32 +00:00
flux commented 2024-01-29 22:41:28 +00:00
Member
Copy Link

Could that have been a pipeworks fake player again?

minetest.get_connected_players() won't ever return pipeworks fake players, this had to have been a once-connected player that somehow hadn't been properly been removed from the list.

> Could that have been a pipeworks fake player again? `minetest.get_connected_players()` won't ever return pipeworks fake players, this had to have been a once-connected player that somehow hadn't been properly been removed from the list.
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2024-03-29 21:35:50 +00:00
flux removed this from the flux's TODO list project 2024-03-29 21:35:53 +00:00
flux removed their assignment 2024-03-29 21:35:55 +00:00
flux commented 2024-03-29 21:36:47 +00:00
Member
Copy Link

presuming this is fixed

presuming this is fixed
flux closed this issue 2024-03-29 21:36:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.123
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5862
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?